Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Francois Romieu
Date: Monday, March 23, 2009 - 3:42 pm

Karsten Wiese <fzu@wemgehoertderstaat.de> :
[...]

Ok, it starts to make some sense.

Does the patch below make a difference ?

diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 4b7cb38..b5a7358 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -2011,8 +2011,6 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		}
 	}
 
-	pci_set_master(pdev);
-
 	/* ioremap MMIO region */
 	ioaddr = ioremap(pci_resource_start(pdev, region), R8169_REGS_SIZE);
 	if (!ioaddr) {
@@ -2039,6 +2037,8 @@ rtl8169_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
 		msleep_interruptible(1);
 	}
 
+	pci_set_master(pdev);
+
 	/* Identify chip attached to board */
 	rtl8169_get_mac_version(tp, ioaddr);
 
-- 
Ueimor

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Tue Mar 17, 12:34 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Tue Mar 17, 3:06 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Tue Mar 17, 6:56 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Tue Mar 17, 11:40 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Wed Mar 18, 4:59 am)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Wed Mar 18, 3:36 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), David Miller, (Wed Mar 18, 11:35 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Thu Mar 19, 3:58 am)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Thu Mar 19, 3:23 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Thu Mar 19, 6:40 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Sun Mar 22, 2:16 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Sun Mar 22, 4:53 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Mon Mar 23, 3:42 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Mon Mar 23, 5:38 pm)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Karsten Wiese, (Tue Mar 24, 6:54 am)
Re: [PATCH] r8169: Fix irq masking in rtl8169_interrupt(), Francois Romieu, (Tue Mar 24, 1:18 pm)