Hi David,
The patch looks fine, but (minor nit) the subject line should read
"smsc95xx" instead of "sms95xx".
Acked-by: Steve Glendinning <steve.glendinning@smsc.com>
--
Steve Glendinning
SMSC GmbH
m: +44 777 933 9124
e: steve.glendinning@smsc.com
David Brownell <david-b@pacbell.net> wrote on 21/03/2009 09:20:29:
quoted text > On Friday 20 March 2009, Stephen Hemminger wrote:
> > Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> cc driver maintainer
>
>
> > --- a/drivers/net/usb/smsc95xx.c 2009-03-20 12:11:35.646901516 -0700
> > +++ b/drivers/net/usb/smsc95xx.c 2009-03-20 12:16:51.582901740 -0700
> > @@ -1008,6 +1008,18 @@ static int smsc95xx_reset(struct usbnet
> > return 0;
> > }
> >
> > +static const struct net_device_ops smsc95xx_netdev_ops = {
> > + .ndo_open = usbnet_open,
> > + .ndo_stop = usbnet_stop,
> > + .ndo_start_xmit = usbnet_start_xmit,
> > + .ndo_tx_timeout = usbnet_tx_timeout,
> > + .ndo_change_mtu = usbnet_change_mtu,
> > + .ndo_set_mac_address = eth_mac_addr,
> > + .ndo_validate_addr = eth_validate_addr,
> > + .ndo_do_ioctl = smsc95xx_ioctl,
> > + .ndo_set_multicast_list = smsc95xx_set_multicast,
> > +};
> > +
> > static int smsc95xx_bind(struct usbnet *dev, struct usb_interface
*intf)
quoted text > > {
> > struct smsc95xx_priv *pdata = NULL;
> > @@ -1038,9 +1050,8 @@ static int smsc95xx_bind(struct usbnet *
> > /* Init all registers */
> > ret = smsc95xx_reset(dev);
> >
> > - dev->net->do_ioctl = smsc95xx_ioctl;
> > + dev->net->netdev_ops = &smsc95xx_netdev_ops;
> > dev->net->ethtool_ops = &smsc95xx_ethtool_ops;
> > - dev->net->set_multicast_list = smsc95xx_set_multicast;
> > dev->net->flags |= IFF_MULTICAST;
> > dev->net->hard_header_len += SMSC95XX_TX_OVERHEAD;
> > return 0;
> >
> > --
> >
> >
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
