login
Search
| From | Subject | Date |
|---|---|---|
| Jeff Kirsher | [net-next PATCH 1/2] e1000e: fix unmap bug
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
This is in reference to https://bugzilla.redhat.com/show_bug.cgi?id=484494
Also addresses issue show in kerneloops
The e1000e transmit code was calling pci_unmap_page on dma handles that it
might have called pci_map_single on.
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000e/netdev.c | 62 ...
| Mar 2, 4:49 pm 2009 |
| Jeff Kirsher | [net-next PATCH 2/2] e1000: fix unmap bug
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
This is in reference to the issue shown in kerneloops (search e1000 unmap)
The e1000 transmit code was calling pci_unmap_page on dma handles that it
might have called pci_map_single on.
Same bug as e1000e
Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
Acked-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/e1000/e1000_main.c | 51 ...
| Mar 2, 4:49 pm 2009 |
| Jeff Kirsher | [net-next PATCH v2] igb: remove skb_orphan calls
From: Alexander Duyck <alexander.h.duyck@intel.com>
Remove skb_orphan call from igb driver as it can cause multiple issues due
to the fact that it is calling the desctructor and removing the skb from
the socket prior to transmission.
The call was added to improve performance but did so by allowing the skb to
be removed from the socket which gave the socket more window space to
transmit. The performance gain is not worth the extra problems that this
kind of workaround can introduce as this ...
| Mar 2, 4:44 pm 2009 |
| Vlad Yasevich | [PATCH net-next 0/5] sctp: Bug fixes
Hi David
This is a set of bug fixes and cleanups for SCTP for the net-next tree.
Please apply.
Thanks
-vlad
--
| Mar 2, 12:46 pm 2009 |
| Vlad Yasevich | [PATCH net-next 2/5] sctp: remove dup code in net/sctp/s ...
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Remove dup check of "if (optlen < sizeof(int))".
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
net/sctp/socket.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/net/sctp/socket.c b/net/sctp/socket.c
index dea864f..4bc558c 100644
--- a/net/sctp/socket.c
+++ b/net/sctp/socket.c
@@ -3069,9 +3069,6 @@ static int sctp_setsockopt_maxburst(struct sock *sk,
...
| Mar 2, 12:46 pm 2009 |
| Vlad Yasevich | [PATCH net-next 4/5] sctp: use time_before or time_after ...
From: Wei Yongjun <yjwei@cn.fujitsu.com>
The functions time_before or time_after are more robust
for comparing jiffies against other values.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
net/sctp/outqueue.c | 3 ++-
net/sctp/transport.c | 7 ++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
index bc411c8..a367d15 100644
--- a/net/sctp/outqueue.c
+++ ...
| Mar 2, 12:46 pm 2009 |
| Vlad Yasevich | [PATCH net-next 5/5] sctp: Fix broken RTO-doubling for d ...
Commit faee47cdbfe8d74a1573c2f81ea6dbb08d735be6
(sctp: Fix the RTO-doubling on idle-link heartbeats)
broke the RTO doubling for data retransmits. If the
heartbeat was sent before the data T3-rtx time, the
the RTO will not double upon the T3-rtx expiration.
Distingish between the operations by passing an argument
to the function.
Additionally, Wei Youngjun pointed out that our treatment
of requested HEARTBEATS and timer HEARTBEATS is the same
wrt resetting congestion window. That needs to be ...
| Mar 2, 12:46 pm 2009 |
| Vlad Yasevich | [PATCH net-next 3/5] sctp: fix the length check in sctp_ ...
From: Wei Yongjun <yjwei@cn.fujitsu.com>
The code in sctp_getsockopt_maxburst() doesn't allow len to be larger
then struct sctp_assoc_value, which is a common case where app writers
just pass down the sizeof(buf) or something similar.
This patch fix the problem.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
net/sctp/socket.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sctp/socket.c ...
| Mar 2, 12:46 pm 2009 |
| Vlad Yasevich | [PATCH net-next 1/5] sctp: Add some missing types for de ...
From: Wei Yongjun <yjwei@cn.fujitsu.com>
This patch add the type name "AUTH" and primitive type name
"PRIMITIVE_ASCONF" for debug message.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
net/sctp/debug.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/net/sctp/debug.c b/net/sctp/debug.c
index 67715f4..7ff548a 100644
--- a/net/sctp/debug.c
+++ b/net/sctp/debug.c
@@ -86,6 +86,9 @@ const char ...
| Mar 2, 12:46 pm 2009 |
| Ron Mercer | [net-next PATCH 2/3] qlge: Add support for device ID 8000.
This device has more firmware support for link management, setting
TX and RX maximum frame sizes.
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge.h | 37 +++++++++++++++++++++++-
drivers/net/qlge/qlge_main.c | 64 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 100 insertions(+), 1 deletions(-)
diff --git a/drivers/net/qlge/qlge.h b/drivers/net/qlge/qlge.h
index 7bf18c6..5f60ec4 100644
--- a/drivers/net/qlge/qlge.h
+++ ...
| Mar 2, 11:07 am 2009 |
| Ron Mercer | [net-next PATCH 1/3] qlge: Add support for firmware mail ...
This interface will be used for setting things like maximum
frame size, setting WOL, and ACKing changes requested by the FCOE
function.
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge_mpi.c | 222 ++++++++++++++++++++++++++++++++++++++++++-
1 files changed, 218 insertions(+), 4 deletions(-)
diff --git a/drivers/net/qlge/qlge_mpi.c b/drivers/net/qlge/qlge_mpi.c
index a4b810d..11102be 100644
--- a/drivers/net/qlge/qlge_mpi.c
+++ b/drivers/net/qlge/qlge_mpi.c
@@ ...
| Mar 2, 11:07 am 2009 |
| Ron Mercer | [net-next PATCH 3/3] qlge: Add support for getting/setti ...
This patch adds functionality to get and set port parameters.
Currently it is used to set maximum TX/RX frame sizes. This process is
also capable of setting:
1) Pause type: Standard or Priority based.
2) Loop back mode.
3) Enable Jumbo frame mode (included here...)
Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
---
drivers/net/qlge/qlge.h | 6 +
drivers/net/qlge/qlge_main.c | 14 +++-
drivers/net/qlge/qlge_mpi.c | 209 ++++++++++++++++++++++++++++++++++++++++++
3 files ...
| Mar 2, 11:07 am 2009 |
| Ron Mercer | [net-next PATCH 0/3] Add Device ID 8000.
Hi Dave,
Attached are 3 patches that add Device ID 8000 and some supporting
functionality that is required by this ID.
Regards,
Ron Mercer
--
| Mar 2, 11:07 am 2009 |
| Eilon Greenstein | [PATCH 17/18] bnx2x: Register dump
Subject: [PATCH 17/18] bnx2x: Register dump
Adding "ethtool -d" support. Due to the complexity of the FW and HW, there are a
lot of different regions in the chip - to keep the code as clean as possible,
the ranges were put in an H file. Some areas cannot be read if the driver is
running - so by default, the driver will not access those areas - but any
programmer facing a problem will be able to easily manipulate the driver to
extract full dump. The full dump can also be used with kernel dump ...
| Mar 2, 11:01 am 2009 |
| Eilon Greenstein | [PATCH 16/18] bnx2x: Debug prints
Subject: [PATCH 16/18] bnx2x: Debug prints
Add the FP index to relevant debug prints and simply beautify some others
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 38 +++++++++++++++++++-------------------
1 files changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index bb9d539..e5952c5 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -216,7 +216,7 @@ void ...
| Mar 2, 11:01 am 2009 |
| Eilon Greenstein | [PATCH 18/18] bnx2x: Version update
Subject: [PATCH 18/18] bnx2x: Version update
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 09d802a..00a78e8 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -55,8 +55,8 @@
#include "bnx2x_init.h"
#include "bnx2x_dump.h"
-#define DRV_MODULE_VERSION "1.48.102"
-#define ...
| Mar 2, 11:01 am 2009 |
| Eilon Greenstein | [PATCH 15/18] bnx2x: Whitespace
Subject: [PATCH 15/18] bnx2x: Whitespace
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_init.h | 4 ++--
drivers/net/bnx2x_main.c | 1 +
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h
index 5362d5a..39ba293 100644
--- a/drivers/net/bnx2x_init.h
+++ b/drivers/net/bnx2x_init.h
@@ -186,8 +186,8 @@ static void bnx2x_init_fill(struct bnx2x *bp, u32 addr, int fill, u32 len)
static void ...
| Mar 2, 11:01 am 2009 |
| Eilon Greenstein | [PATCH 14/18] bnx2x: Loopback support at external PHY
Subject: [PATCH 14/18] bnx2x: Loopback support at external PHY
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_link.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index 3812058..ed648ac 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -4624,13 +4624,13 @@ static u8 bnx2x_link_initialize(struct link_params ...
| Mar 2, 11:01 am 2009 |
| Eilon Greenstein | [PATCH 13/18] bnx2x: Display BCM8481 FW version
Subject: [PATCH 13/18] bnx2x: Display BCM8481 FW version
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_link.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index c72a964..3812058 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -4244,6 +4244,7 @@ u8 bnx2x_get_ext_phy_fw_version(struct link_params *params, u8 ...
| Mar 2, 11:00 am 2009 |
| Eilon Greenstein | [PATCH 12/18] bnx2x: BCM8705 has no microcode
Subject: [PATCH 12/18] bnx2x: BCM8705 has no microcode
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_link.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index 280f008..c72a964 100644
--- a/drivers/net/bnx2x_link.c
+++ b/drivers/net/bnx2x_link.c
@@ -3033,10 +3033,9 @@ static u8 bnx2x_ext_phy_init(struct link_params *params, ...
| Mar 2, 11:00 am 2009 |
| Eilon Greenstein | [PATCH 08/18] bnx2x: Using DMA engine
Subject: [PATCH 08/18] bnx2x: Using DMA engine
Using DMA engine (DMAE) to initialize large consecutive memories in the chip
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_init.h | 36 +++++++++++++++++---------------
drivers/net/bnx2x_main.c | 51 ++++++++++-----------------------------------
2 files changed, 31 insertions(+), 56 deletions(-)
diff --git a/drivers/net/bnx2x_init.h b/drivers/net/bnx2x_init.h
index 8af2757..5362d5a 100644
--- ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 11/18] bnx2x: Enable BCM8726 module transmitter
Subject: [PATCH 11/18] bnx2x: Enable BCM8726 module transmitter
When 8726 module detection option is disabled, module should be transmitting
regardless of invalid read from EEPROM
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_link.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c
index 35f3b5a..280f008 100644
--- ...
| Mar 2, 11:00 am 2009 |
| Eilon Greenstein | [PATCH 10/18] bnx2x: Supporting new BCM8726 FW
Subject: [PATCH 10/18] bnx2x: Supporting new BCM8726 FW
Microcode download requires write of another register and read from
"Limiting/LRM mode" register before setting
Signed-off-by: Yaniv Rosner <yanivr@broadcom.com>
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_link.c | 30 +++++++++++++++++++-----------
drivers/net/bnx2x_reg.h | 1 +
2 files changed, 20 insertions(+), 11 deletions(-)
diff --git a/drivers/net/bnx2x_link.c ...
| Mar 2, 11:00 am 2009 |
| Eilon Greenstein | [PATCH 05/18] bnx2x: Unlimited Tx interrupt work
Subject: [PATCH 05/18] bnx2x: Unlimited Tx interrupt work
The Tx interrupt is very short and there is no need to limit it to a budget
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 11 ++++-------
1 files changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index e4d54e1..a66536e 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -874,7 +874,7 @@ static inline u16 ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 09/18] bnx2x: Calling tx disable unconditionally
Subject: [PATCH 09/18] bnx2x: Calling tx disable unconditionally
On unload, the FW assumes that no packets will be sent after the driver sends
the FW stop command. To ensure that, the driver must always call
netif_tx_disable
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 3ef24b9..5397de1 100644
--- ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 07/18] bnx2x: Missing module parameter description
Subject: [PATCH 07/18] bnx2x: Missing module parameter description
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index e0851a7..46e2492 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -72,6 +72,7 @@ MODULE_VERSION(DRV_MODULE_VERSION);
static int multi_mode = 1;
module_param(multi_mode, int, ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 06/18] bnx2x: napi_poll budget check
Subject: [PATCH 06/18] bnx2x: napi_poll budget check
Check the napi_poll budget only when updating it. Also add a comment to explain
the rmb
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 22 ++++++++++++++++++----
1 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index a66536e..e0851a7 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -10068,14 +10068,27 @@ ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 04/18] bnx2x: Add rmb to read status block indice ...
Subject: [PATCH 04/18] bnx2x: Add rmb to read status block indices on load
Add rmb to read status block indices on load
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index fbd0f88..e4d54e1 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -5154,6 +5154,10 @@ static void bnx2x_nic_init(struct bnx2x *bp, ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 03/18] bnx2x: Reduce the likelihood of smb_mb
Subject: [PATCH 03/18] bnx2x: Reduce the likelihood of smb_mb
As the comment explains, this smb_mb is needed only if the queue is stopped
(which is unlikely) so the barrier can be moved to that location
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 5954bed..fbd0f88 100644
--- a/drivers/net/bnx2x_main.c
+++ ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 02/18] bnx2x: Misleading name
Subject: [PATCH 02/18] bnx2x: Misleading name
As noted by Ben Hutchings <bhutchings@solarflare.com>, these are the
capabilities offsets and not the ID itself
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_reg.h | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnx2x_reg.h b/drivers/net/bnx2x_reg.h
index 360a256..8de80cc 100644
--- a/drivers/net/bnx2x_reg.h
+++ b/drivers/net/bnx2x_reg.h
@@ -5410,7 +5410,7 @@
#define ...
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 00/18] bnx2x updates
Hi Dave,
Please consider applying these bnx2x enhancements to net-next.
Thanks,
Eilon
--
| Mar 2, 10:59 am 2009 |
| Eilon Greenstein | [PATCH 01/18] bnx2x: Remove redundant smb_mb on unload
Subject: [PATCH 01/18] bnx2x: Remove redundant smb_mb on unload
As noted by Ben Hutchings <bhutchings@solarflare.com>, these smb_mb are not
needed
Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
drivers/net/bnx2x_main.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 9427175..5954bed 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -7210,7 +7210,6 @@ static int ...
| Mar 2, 10:59 am 2009 |
| Vlad Yasevich | [PATCH 2/2] sctp: fix kernel panic with ERROR chunk cont ...
From: Wei Yongjun <yjwei@cn.fujitsu.com>
If ERROR chunk is received with too many error causes in ESTABLISHED
state, the kernel get panic.
This is because sctp limit the max length of cmds to 14, but while
ERROR chunk is received, one error cause will add around 2 cmds by
sctp_add_cmd_sf(). So many error causes will fill the limit of cmds
and panic.
This patch fixed the problem.
This bug can be test by SCTP Conformance Test Suite
<http://networktest.sourceforge.net/>.
Signed-off-by: ...
| Mar 2, 9:46 am 2009 |
| Vlad Yasevich | [PATCH 1/2] sctp: fix crash during module unload
An extra list_del() during the module load failure and unload
resulted in a crash with a list corruption. Now sctp can
be unloaded again.
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
---
net/sctp/protocol.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/net/sctp/protocol.c b/net/sctp/protocol.c
index b78e3be..4e66384 100644
--- a/net/sctp/protocol.c
+++ b/net/sctp/protocol.c
@@ -1322,9 +1322,8 @@ SCTP_STATIC __init int sctp_init(void)
out:
...
| Mar 2, 9:46 am 2009 |
| Vlad Yasevich | [PATCH 0/2] sctp: Crash fixes.
Hi David
There two patches fix crashes in the sctp module. The module-unload
one is actually a regression from as far back as 2.6.25.
The second one could be classified as a potential security issue.
Thanks
-vlad
--
| Mar 2, 9:46 am 2009 |
| David Miller | [GIT]: Networking
1) TCP retransmit accounting fix from Ilpo.
2) netconsole over devices configured with VLANs can crash,
fix from Herbert Xu.
3) DRR scheduler crashes when TCA_OPTIONS are not specified.
Fix from Jarek P.
4) VETH carrier detection fix from Eric Bierderman.
5) Several small driver fixes all over.
6) IPV6 fix with time-wait sockets when namespaces are enabled,
from Pavel Emelyanov.
7) Fix hp-plus build, again, from Randy Dunlap.
Please pull, thanks a lot!
The following ...
| Mar 1, 10:40 pm 2009 |
| David Miller | Re: zaurus: add usb id for motomagx phones
Applied, thanks.
--
| Mar 1, 9:48 pm 2009 |
| Lennart Sorensen | Re: Vlan interface nuisance
Yes. What vlan number is vlan0 talking to on ethX?
Not that eth0 ever told you much useful, but at least eth0.0005 told
you something. I guess vconfig chose the name anyhow before, so no
reason to not continue to let user space take care of what to name it.
--
Len Sorensen
--
| Mar 2, 12:36 pm 2009 |
| Jarek Poplawski | Re: Vlan interface nuisance
On Mon, Mar 02, 2009 at 09:23:15PM +0200, Denys Fedoryschenko wrote:
Happily there is a choice. On the other hand, I guess the main question
here is if it's OK to use different defaults depending on a config tool.
Jarek P.
--
| Mar 2, 1:24 pm 2009 |
| Stephen Hemminger | Vlan interface nuisance
Why is interface created through netlink named 'vlan0' and
interface created through old vconfig called 'ethX.YY'.
Seems like the interface should be consistent.
--
| Mar 1, 9:47 pm 2009 |
| Herbert Xu | Re: Vlan interface nuisance
I don't see the point of this. The new interface is available
through ip(8) only, vconfig remains unchanged. So the user is
completely aware that the name may change as he's using a new
command.
In any case, ip(8) allows you to set the name to whatever you
want at creation time. So for those nostalgics you can still
use ethX.Y through ip.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: ...
| Mar 1, 11:50 pm 2009 |
| David Miller | Re: Vlan interface nuisance
From: Stephen Hemminger <shemminger@vyatta.com>
I think the netlink scheme is saner, and the idea is to
transition people over to that.
We can't change what vconfig uses, so what Patrick decided
to do is pretty sane if you ask me.
--
| Mar 1, 9:57 pm 2009 |
| Jarek Poplawski | Re: Vlan interface nuisance
Just for the record, I don't agree with calling "this" argument silly
just like it was with "that" argument. Actually, I think they are
both so "right" that I've changed my mind and think it's great each
tool does it differently...
Jarek P.
--
| Mar 2, 3:30 pm 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
Indeed. The kernel also sends notifications, so iproute could print
the generated name if none was specified.
--
| Mar 2, 2:45 am 2009 |
| Jarek Poplawski | Re: Vlan interface nuisance
Even if you have only one ethX?
Jarek P.
--
| Mar 2, 11:51 am 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
The binding is displayed when listing interfaces. This hole
argument is silly, if you want a particular name, just specify
it. The current naming schemes are entirely based on information
that you have to specify anyways.
--
| Mar 2, 2:49 pm 2009 |
| Lennart Sorensen | Re: Vlan interface nuisance
That does seem silly.
ethX.YYYY told you which physical interface and which vlan number it was.
vlan0 tells you nothing useful.
--
Len Sorensen
--
| Mar 2, 10:20 am 2009 |
| Ben Greear | Re: Vlan interface nuisance
Yes...the old way would tell you the vlan-id regardless of how
many NICs you have, which is useful information for anyone
actually trying to configure two boxes to talk to each other,
or (god forbid), debug someone else's config.
It's true you can specify the vlan-name on creation using 'ip',
which is what I do, so I'm not going to argue Stephen's change
either way..but I do like device names that give more info...
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc ...
| Mar 2, 11:56 am 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
Finally someone realizes it :) As stated before, there is room
for improvement, but please no selectable naming schemes when
userspace is ulitimatively responsible anyways :)
--
| Mar 2, 2:54 pm 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
Admittedly, this part of the rtnl_link interface could be improved.
The names are allocated centrally when unspecified, which imposes
this fixed naming scheme. A simple callback to choose a better
name than just incrementally counting up interfaces types would
allow to at least choose a default name of ethX.xyz or something
similar. I refuse to introduce the selectable naming schemes to
this interface though, this can easily be done in userspace.
--
| Mar 2, 2:52 pm 2009 |
| Stephen Hemminger | Re: Vlan interface nuisance
Yes but their is no indication as to which interface was just created.
--
| Mar 2, 12:15 am 2009 |
| Stephen Hemminger | Re: Vlan interface nuisance
On Mon, 02 Mar 2009 22:49:18 +0100
I overlooked the obvious:
ip li add link eth1 name eth1.44 type vlan id 44
Setting the name overrides.
--
| Mar 2, 2:51 pm 2009 |
| Stephen Hemminger | Re: Vlan interface nuisance
On Sun, 01 Mar 2009 20:57:02 -0800 (PST)
This is missing:
------------------------------------------------------------------
Subject: vlan: names should be consistent
Vlan's created via netlink should be the same as vlan's created
via older interface. This patches changes is to be consistent.
One could argue this is an API change (it changes behaviour of netlink
interface), but I argue this was a design bug when the netlink interface
to VLAN was added.
Signed-off-by: Stephen Hemminger ...
| Mar 1, 10:05 pm 2009 |
| Jarek Poplawski | Re: Vlan interface nuisance
OK, you're right! More info is better. ...How about changing this
silly "eth" thing to something really useful like BSDs do?!
Jarek P.
--
| Mar 2, 1:07 pm 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
I'm not sure whether I'm supposed to understand this, so I'm going
to respond with something useful unrelated to naming user resources
that every virtual device author should know (and that seems to be
not well known):
Every virtual device bound to a different device should set the
dev->iflink field to the ifindex of the device bound to. This
makes every device related netlink message include this relation.
If the binding is already known at device-creation time and
relevant for the virtuals ...
| Mar 2, 4:35 pm 2009 |
| Patrick McHardy | Re: Vlan interface nuisance
Indeed, it was intentional not to have these IMO useless naming
schemes when you can simply supply the name of your choice when
creating the interface.
--
| Mar 2, 2:44 am 2009 |
| David Miller | Re: Vlan interface nuisance
From: Stephen Hemminger <shemminger@vyatta.com>
You can just say you don't think the behavior is
intentional.... :-/
--
| Mar 1, 10:28 pm 2009 |
| Denys Fedoryschenko | Re: Vlan interface nuisance
I guess for Linux it should be ethN.Y.
vlanN is Cisco and other switches behaviour, since they establish vlanN
interfaces and bridge all vlan with numbers there. In best case they do
remapping on receive.
So on linux similar alternative of cisco interface vlan100 will be:
ip link add link eth0 type vlan id 100
ip link add link eth1 type vlan id 100
brctl addbr vlan100
brctl addif vlan100 eth0.100
brctl addif vlan100 eth1.100
But on first two steps it creates for me vlan0 and vlan1, ...
| Mar 2, 12:23 pm 2009 |
| Herbert Xu | Re: Vlan interface nuisance
You should be able to set the name at creation time.
The default is only used if you didn't specify an explicit name.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Mar 2, 12:39 am 2009 |
| David Miller | Re: Vlan interface nuisance
From: Patrick McHardy <kaber@trash.net>
I considered this issue closed 6 emails ago.
I don't know why Stephen keeps persisting. :-)
--
| Mar 2, 2:57 am 2009 |
| Jarek Poplawski | Re: Vlan interface nuisance
To make it clear: I don't say vlan0 is better; but IMHO it doesn't
have to be silly or nothing useful either.
Jarek P.
--
| Mar 2, 12:06 pm 2009 |
| Waskiewicz Jr, Peter P | Re: [PATCH]: ixgbe: Fix some compiler warnings.
Thanks Dave. We removed the code that used pap since it was used only for
silicon validation, but we forgot to pull the variable.
Thanks for cleaning these up!
Cheers,
-PJ Waskiewicz
--
| Mar 1, 11:40 pm 2009 |
| David Miller | [PATCH]: ixgbe: Fix some compiler warnings.
[ Commited to net-next-2.6 ]
'pap' is never used in ixgbe_dcb_hw_config_82599()
and 'eec' in ixgbe_acquire_eeptom() is only used when
status == 0 but GCC has some trouble seeing that.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/ixgbe/ixgbe_common.c | 2 +-
drivers/net/ixgbe/ixgbe_dcb_82599.c | 2 --
2 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_common.c b/drivers/net/ixgbe/ixgbe_common.c
index 26ee8a0..245db0e ...
| Mar 1, 9:33 pm 2009 |
| Andrew Morton | Re: some tc commands fail on 2.6.29-rc6-git5, works on 2 ...
(cc netdev)
--
| Mar 1, 5:57 pm 2009 |
| Jarek Poplawski | Re: some tc commands fail on 2.6.29-rc6-git5, works on 2 ...
Hi,
I've just repeated your commands (with eth0) on the current Linus' tree
and it works OK. Check your .config and "modules_install" again, and if
no result send gzipped .config and show "lsmod" and "tc -V" output after
these commands above.
Cheers,
Jarek P.
--
| Mar 2, 11:44 am 2009 |
| Herbert Xu | Re: [PATCH] tcp: '< 0' test on unsigned
Either cnt needs to be promoted, or you need to limit len to INT_MAX.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Mar 1, 9:30 pm 2009 |
| Roel Kluin | Re: [PATCH] tcp: '< 0' test on unsigned
like this then?
------------------------------>8-------------8<---------------------------------
promote 'cnt' to size_t, to match 'len'.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/net/ipv4/tcp_probe.c b/net/ipv4/tcp_probe.c
index 25524d4..59f5b5e 100644
--- a/net/ipv4/tcp_probe.c
+++ b/net/ipv4/tcp_probe.c
@@ -165,9 +165,10 @@ static int tcpprobe_sprint(char *tbuf, int n)
static ssize_t tcpprobe_read(struct file *file, char __user *buf,
size_t len, loff_t ...
| Mar 2, 5:24 am 2009 |
| David Miller | Re: [PATCH] tcp: '< 0' test on unsigned
From: Herbert Xu <herbert@gondor.apana.org.au>
Right, since the positive range of 'size_t' can exceed that of 'int'
--
| Mar 1, 9:36 pm 2009 |
| Hantzis Fotis | Re: PATCH tcp_init_wl / tcp_update_wl argument cleanup
Sorry for not complying with the guidelines on the previous submission.
I am resending the patch properly this time:
Signed-off-by: Hantzis Fotis <xantzis@ceid.upatras.gr>
---
diff -uprN -X linux-2.6.28-vanilla/Documentation/dontdiff linux-2.6.28-vanilla/include/net/tcp.h linux-2.6.28-devel/include/net/tcp.h
--- linux-2.6.28-vanilla/include/net/tcp.h 2009-03-02 18:50:45.000000000 +0200
+++ linux-2.6.28-devel/include/net/tcp.h 2009-03-02 19:11:19.000000000 +0200
@@ -829,12 +829,12 @@ static ...
| Mar 2, 10:57 am 2009 |
| David Miller | Re: PATCH tcp_init_wl / tcp_update_wl argument cleanup
From: "ithilgore.ryu.L@gmail.com" <ithilgore.ryu.l@gmail.com>
Please read linux/Documentation/SubmittingPatches
In particular, your submission:
1) Lacked a proper "Signed-off-by" line and please do fix
the proper name assosciated with your email address if
you don't mind.
2) Did not root your patch properly.
Thanks.
--
| Mar 2, 4:14 am 2009 |
| Inaky Perez-Gonzalez | Re: [PATCH] wimax: replace uses of __constant_{endian}
This is a conflict fix -- yours (the original) is still in the tree, (way)
before this series.
However, some of the code merged in with my fixes conflicted with your
edits, so only those are changed to reflect the new code (hence the
"Edited" line).
Hope this clarifies
--
Inaky
--
| Mar 1, 5:07 pm 2009 |
| David Miller | Re: [PATCH] WiMAX-next for 2.6.30
From: Inaky Perez-Gonzalez <inaky@linux.intel.com>
All applied to net-next-2.6, thanks!
--
| Mar 2, 4:12 am 2009 |
| David Miller | Re: [PATCH net-next 17/17] tcp: get rid of two unnecessa ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:03 am 2009 |
| David Miller | Re: [PATCH net-next 10/17] tcp: drop unnecessary local v ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:02 am 2009 |
| David Miller | Re: [PATCH net-next 11/17] htcp: merge icsk_ca_state compare
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:02 am 2009 |
| David Miller | Re: [PATCH net-next 05/17] tcp: Don't clear hints when t ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 16/17] tcp: in sendmsg/pages open co ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:03 am 2009 |
| David Miller | Re: [PATCH net-next 02/17] tcp: don't backtrack to sacked skbs
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 03/17] tcp: fix lost_cnt_hint miscounts
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 09/17] tcp: cleanup ca_state mess in ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:02 am 2009 |
| David Miller | Re: [PATCH net-next 04/17] tcp: deferring in middle of q ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
I can't believe this check was missing :-)
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 15/17] tcp: kill pointless if () in ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
I skipped this for the same reason I skipped patch #14.
This could be there to avoid dirtying that part of
the structure when it isn't necessary.
--
| Mar 2, 4:03 am 2009 |
| David Miller | Re: [PATCH net-next 14/17] tcp: remove pointless .dsack code
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
I skipped this one.
These tests could be there to avoid dirtying a cacheline
when unnecessary. And so unless we can prove the condition
always hits and we always do the write, we should keep
the tests there.
--
| Mar 2, 4:03 am 2009 |
| David Miller | Re: [PATCH net-next 08/17] tcp: separate timeout marking ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:02 am 2009 |
| Ilpo Järvinen | Re: [PATCH net-next 14/17] tcp: remove pointless .dsack code
On Mon, 2 Mar 2009, David Miller wrote:
> From: "Ilpo J
| Mar 2, 4:54 am 2009 |
| David Miller | Re: [PATCH net-next 06/17] tcp: fix corner case issue in ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 12/17] tcp: add helper for AI algorithm
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied, nice work.
--
| Mar 2, 4:02 am 2009 |
| David Miller | Re: [PATCH net-next 13/17] tcp: kill eff_sacks "cache", ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:02 am 2009 |
| David Miller | Re: [PATCH net-next 07/17] tcp: remove redundant code fr ...
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Applied.
--
| Mar 2, 4:01 am 2009 |
| David Miller | Re: [PATCH net-next 14/17] tcp: remove pointless .dsack code
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
That sounds like a good commit log entry for when you resubmit
this patch :-)
--
| Mar 2, 4:57 am 2009 |
| David Miller | Re: [PATCH 1/2] dccp: Minimise header option overhead in ...
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied.
--
| Mar 2, 4:08 am 2009 |
| David Miller | Re: [PATCH 2/2] dccp: Do not let initial option overhead ...
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Applied.
--
| Mar 2, 4:08 am 2009 |
| David Miller | Re: [PATCH 7/9] sfc: Delete unused efx_blinker::led_num field
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 6/9] sfc: Add support for QT2025C PHY
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 1/9] sfc: SFT9001: Include non-breaking cable ...
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 2/9] sfc: Fix test for MDIO read failure
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 5/9] sfc: Fix reporting of PHY id
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 9/9] sfc: Add support for SFN4112F SFP+ refer ...
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 8/9] sfc: Clean up LED control
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 4/9] sfc: Remove "XFP" from log messages that ...
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH 3/9] sfc: SFT9001/SFN4111T: Check PHY boot st ...
From: Ben Hutchings <bhutchings@solarflare.com>
Applied.
--
| Mar 2, 4:26 am 2009 |
| David Miller | Re: [PATCH -next] skbuff.h: fix timestamps kernel-doc
From: Randy Dunlap <randy.dunlap@oracle.com>
Applied, thanks Randy.
--
| Mar 2, 4:16 am 2009 |
| David Miller | Re: [PATCH] r8169: read MAC address from EEPROM on init ...
From: Francois Romieu <romieu@fr.zoreil.com>
Done, thanks everyone.
--
| Mar 1, 9:35 pm 2009 |
| Herbert Xu | Re: WARNING: at net/core/dev.c:1505 skb_gso_segment+0x6e ...
Please try to reproduce this under 2.6.28-rcX where it'll print more
details about what went wrong. I'd suspect that something went
amiss with the features computation on the bonding device.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Mar 1, 9:15 pm 2009 |
| Chris Stromsoe | Re: WARNING: at net/core/dev.c:1505 skb_gso_segment+0x6e ...
I am not seeing the warnings with 2.6.28.7 on the same hardware. Did you
want me to try with one of the 2.6..28-rcX kernels, or was that a typo for
2.6.29-rcX ?
-Chris
--
| Mar 2, 1:32 pm 2009 |
| Stephen Hemminger | Re: [PATCH] iptables: new strict host model match
On Mon, 2 Mar 2009 14:42:33 +0100 (CET)
That doesn't work when system already has an ARP entry and link goes down.
--
| Mar 2, 11:53 am 2009 |
| Patrick McHardy | Re: [PATCH] iptables: new strict host model match
I think it would make sense to define the differences in behaviour
that are expected when acting according to the strict host model.
It very unlikely that all of this can be achieved with iptables,
and if what can be done is still useful, the limitations should be
known.
--
| Mar 2, 3:12 pm 2009 |
| Patrick McHardy | Re: [PATCH] iptables: new strict host model match
I'm not sure this is correct, I think it will only allow communication
with truely on-link addresses, meaning it won't accept routed packets
going to the interface address. Generally I don't think this can be
fully done in iptables since you'd still have to deal with ARP etc.
An IPv4 sysctl might be more appropriate.
Just for the IPv4 packets, I'm wondering if the intended result could
be achieved using the addrtype match. Something like:
-m addrtype --limit-iface-in --dst-type ...
| Mar 2, 4:02 am 2009 |
| Jesper Dangaard Brouer | Re: [PATCH] iptables: new strict host model match
Is this no almost the same as:
inet_addr_onlink() will call
-> inet_ifa_match(ip_hdr(skb)->daddr, ifa)
arp_ignore = 1
-> inet_confirm_addr(in_dev, 0, tip, RT_SCOPE_HOST)
-> inet_ifa_match(tip, ifa)
Hilsen
Jesper Brouer
--
-------------------------------------------------------------------
MSc. Master of Computer Science
Dept. of Computer Science, University of Copenhagen
Author of ...
| Mar 2, 6:42 am 2009 |
| Denys Fedoryschenko | Re: [PATCH] iptables: new strict host model match
I guess if some "smart guy" will set static association in his ARP table, he
can ignore this rule and "hack the host" over another ip, which sits on
internal interface for example.
--
| Mar 2, 6:46 am 2009 |
| David Miller | Re: [PATCH] usbnet: make usbnet_get_link() fall back to ...
From: Bjørn Mork <bjorn@mork.no>
Applied, thanks.
--
| Mar 1, 9:45 pm 2009 |
| David Dillow | Re: [PATCH v2] typhoon: Use request_firmware()
Do you want to revert, or do you a patch to fix it? Revert will be
quicker as I have to dig out hardware to test...
--
| Mar 1, 8:16 pm 2009 |
| David Miller | Re: [PATCH v2] typhoon: Use request_firmware()
From: David Dillow <dave@thedillows.org>
Give me a fix so I don't have to revert.
--
| Mar 1, 9:11 pm 2009 |
| David Miller | Re: [PATCH v2] typhoon: Use request_firmware()
From: David Miller <davem@davemloft.net>
Nevermind, I checked in a fix myself.
I cared enough to fix this, maybe one of you will care enough
to test it.
typhoon: Need non-vmalloc memory to DMA firmware to the card.
request_firmware() gives vmalloc'd memory, which is not suitable
for pci_map_single() and friends.
Use a kmalloc()'d copy of the firmware for this DMA operation.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/typhoon.c | 27 ...
| Mar 1, 9:29 pm 2009 |
| Ben Hutchings | Re: [PATCH v2] typhoon: Use request_firmware()
Sorry about that - I looked for a maintainer but there was no listing
for "typhoon" in MAINTAINERS nor any recent change to the driver that
was not part of a general API change. Email addresses in source files
tend to be outdated, so I didn't look for them. I see now that you have
an entry under "3CR990" in MAINTAINERS, but that isn't the driver name.
You could well be right.
Ben.
--=20
Ben Hutchings
In a hierarchy, every employee tends to rise to his level of incompetence.
| Mar 1, 6:02 pm 2009 |
| David Miller | Re: [PATCH v2] typhoon: Use request_firmware()
From: David Dillow <dave@thedillows.org>
Good catch, I've checked in the following fix:
typhoon: Add missing firmware copy.
Noticed by David Dillow.
Signed-off-by: David S. Miller <davem@davemloft.net>
---
drivers/net/typhoon.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c
index ec2541c..9bba787 100644
--- a/drivers/net/typhoon.c
+++ b/drivers/net/typhoon.c
@@ -1377,6 +1377,7 @@ typhoon_request_firmware(struct ...
| Mar 2, 2:53 am 2009 |
| David Miller | Re: [PATCH v2] typhoon: Use request_firmware()
From: Ben Hutchings <ben@decadent.org.uk>
He is definitely right, this cannot work.
--
| Mar 1, 6:44 pm 2009 |
| David Dillow | Re: [PATCH v2] typhoon: Use request_firmware()
Like I said, I will be happy to test as soon as I can dig the hardware
You never copied the image into the kmalloc'd memory, so you upload
garbage.
Fix that and I think it will be OK.
--
| Mar 2, 12:56 am 2009 |
| David Miller | Re: [PATCH 1/2] veth: Fix carrier detect
From: ebiederm@xmission.com (Eric W. Biederman)
Applied.
--
| Mar 1, 9:44 pm 2009 |
| David Miller | Re: [PATCH] cdc_ether: add usb id for Ericsson F3507g
From: Bjørn Mork <bjorn@mork.no>
Applied, thanks.
--
| Mar 1, 9:44 pm 2009 |
| Patrick McHardy | Re: IPv4/IPv6 sysctl unregistration deadlock
We should be able to avoid the restart looping in most cases,
we only need to do this while unregistration is in progress.
--
| Mar 2, 4:07 am 2009 |
| David Miller | Re: IPv4/IPv6 sysctl unregistration deadlock
From: Patrick McHardy <kaber@trash.net>
Could you give that "not actually in-progress" detection a shot?
I don't like the spinning either.
--
| Mar 2, 3:47 pm 2009 |
| Ben Greear | Re: IPv4/IPv6 sysctl unregistration deadlock
With both of Stephen's patches included in the latest -rc6 source,
I re-ran the test and it seems to be working (I added printks so
that I would know the new code was being exercised)
I had 2000 or so mac-vlans configured, with 10 of them being
re-configured concurrently, while also deleting groups of 20-100
mac-vlans in my test. This was locking up reliably before,
and now it seems to be working fine.
Here's the kernel log showing the ERESTARTSYS in action. I don't
have an easy way to ...
| Mar 2, 3:11 pm 2009 |
| Patrick McHardy | Re: IPv4/IPv6 sysctl unregistration deadlock
This looks like its working fine. Despite the non-desirable active
spinning, this seems like the best fix (actually much simpler than
I expected to be possible) at this time. If we just could avoid
the spinning when unnecessary, it would be perfect :)
--
| Mar 2, 3:20 pm 2009 |
| Patrick McHardy | Re: IPv4/IPv6 sysctl unregistration deadlock
I tried this morning, the problem is that its always the sysctl
handler which will run into the deadlock first, but there is no
reliable indication to avoid it other than that the RTNL is
already held. The problem is that the sysctl interface puts the
process holding the RTNL to sleep and allows a process requiring
it to run. Any different synchronization attempt will have the
same problem, it seems you simply can't hold any locks while
unregistering sysctls.
--
| Mar 2, 4:03 pm 2009 |
| Patrick McHardy | Re: IPv4/IPv6 sysctl unregistration deadlock
It doesn't seem to work. The idea was something like this:
static int addrconf_fixup_forwarding(struct ctl_table *table, int *p,
int old)
{
struct inet6_dev *idev;
struct net *net;
net = (struct net *)table->extra2;
if (p == &net->ipv6.devconf_dflt->forwarding)
return 0;
/* Unregistration in progress */
idev = table->extra1;
if (idev->cnf.sysctl == NULL)
return -ERESTARTSYS;
rtnl_lock();
...
but the process might have entered this function while the rtnl
is ...
| Mar 2, 4:21 am 2009 |
| Gary Thomas | Re: Marvell 88E609x switch?
Yes, although I think it will need some work in the future
(I've set it to 1000Mb connection, you said you used 100Mb, etc)
Question: I'm testing this by trying a ping out of my box.
Linux replies by sending an ARP packet out, and the destination
replies with an ARP packet in. I can see from the ethtool stats
that the reply packets get into lan1.1 (the physical port I'm
using), but I don't see them get moved through the CPU port.
My understanding is that this should work via the VLAN map?
I ...
| Mar 2, 8:14 am 2009 |
| Jesper Dangaard Brouer | Re: Marvell 88E609x switch?
Looking through my old code I found this comment, which indicate that
you should take care of PPU (Phy Polling Unit) state... I had to support
both the 6095 and 6097 chip.
Cite code:
/*** Setup PHY's ***/
/*
Accessing the PHY devices is special. Direct access to a PHY
device requires that the PPU (Phy Polling Unit) has been
disabled. The 6097 series support indirect access through SMI
registers (GLOBAL_DEV2 registers 0x18 and 0x19).
Disabling the PPU _here_ is not ...
| Mar 2, 3:14 am 2009 |
| Jesper Dangaard Brouer | Re: Marvell 88E609x switch?
Ups, I see (from the thread) that you have already done/tried this...
--
Med venlig hilsen / Best regards
Jesper Brouer
ComX Networks A/S
Linux Network developer
Cand. Scient Datalog / MSc.
Author of http://adsl-optimizer.dk
LinkedIn: http://www.linkedin.com/in/brouer
--
| Mar 2, 4:05 am 2009 |
| Jesper Dangaard Brouer | Re: Marvell 88E609x switch?
Well, thats a break through :-) If I understand you correctly, the
destination host actually receives the ARP packet and responds with a
packet.
That should means that the outgoing DSA tagging is working. Although I'm
I think that the "VLAN map/table" has gotten a wrong name as it does not
really determine the VLANs, it only says who can talk to whom. The switch
does support a real vlan setup, but its deactivated in Lennerts driver, as
I guess he wants Linux to handle the ...
| Mar 2, 3:05 pm 2009 |
| Gary Thomas | Re: Marvell 88E609x switch?
I agree that the simple mode Lennert's code uses is not VLAN on
I didn't look at the 6097 yet, but I have scoured the 6095 and 6131
data sheets and I can't see what's wrong. The differences between
these two parts are extremely minor - basically the number of ports
No VLAN tagging (by Linux), just normal IPv4 packets. Here's what I did:
root@ppc_target:~ ifconfig eth0
eth0 Link encap:Ethernet HWaddr 00:1D:11:81:00:00
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
...
| Mar 2, 3:32 pm 2009 |
| Gary Thomas | Re: Marvell 88E609x switch?
I also just noticed that the ESA registers (Global 1,2,3)
aren't set at all. I'm pretty sure that the way I'm using
the switch in my bootloader this doesn't matter as all packets
have a fixed routing and the ESA recognition happens at the
actual ethernet device.
Is this going to cause problems with the VLAN (+DSA) based
routing?
--
------------------------------------------------------------
Gary Thomas | Consulting for the
MLB Associates | Embedded ...
| Mar 2, 8:22 am 2009 |
| Jesper Dangaard Brouer | Re: Marvell 88E609x switch?
For external ports I had to enabled the PPU to allow the external PHYs
to negotiate.
Also, on external PHYs ports 8 and 9, I write 0x0403 not 0x0003 (to
register 0x1, PCS Control Register). Which also enables inband
On the CPU port I force link-up and force speed+duplex setting. I only
got 100Mbit/s to the CPU port...
/* CPU Port 10: Force 100Mbit Full-Duplex */
REG_WRITE( 0x1A , 0x01 , 0x003D );
You should write 0x003E ... see attached patch
--
Med venlig hilsen / Best ...
| Mar 2, 3:56 am 2009 |
| Kyle McMartin | Re: oops / null deref in __inet6_check_established(), ke ...
Any thoughts? This is a pretty serious issue... Granted we should
probably just turn CONFIG_NET_NS off entirely, since it's
underdocumented and should be explicitly labelled as experimental
instead of just depending on it...
regards, Kyle
--
| Mar 1, 10:09 pm 2009 |
| Kyle McMartin | Re: oops / null deref in __inet6_check_established(), ke ...
Thanks for resolving this. Apologies I was too ignorant to see the patch
from Pavel. :/
regards, Kyle
--
| Mar 2, 10:18 am 2009 |
| David Miller | Re: oops / null deref in __inet6_check_established(), ke ...
From: Kyle McMartin <kyle@infradead.org>
Pavel already submitted a fix for this and it's in my net-2.6
tree and therefore will be sent to Linus soon.
And thanks so much for your amazing patience.
commit 3f53a38131a4e7a053c0aa060aba0411242fb6b9
Author: Pavel Emelyanov <xemul@openvz.org>
Date: Thu Feb 26 03:35:13 2009 -0800
ipv6: don't use tw net when accounting for recycled tw
We already have a valid net in that place, but this is not just a
cleanup - the tw pointer ...
| Mar 1, 10:33 pm 2009 |
| David Miller | Re: oops / null deref in __inet6_check_established(), ke ...
From: Kyle McMartin <kyle@infradead.org>
It's in my queue, I just haven't gotten to it yet.
Serious issue or not you have to be patient.
--
| Mar 1, 10:28 pm 2009 |
| Patrick McHardy | Re: [PATCH] iptables: lock free counters
Great, thanks :)
--
| Mar 2, 2:56 pm 2009 |
| Patrick McHardy | Re: [PATCH] iptables: lock free counters
Is this fixed by your RCU quiescent state fix?
--
| Mar 2, 3:55 am 2009 |
| Stephen Hemminger | Re: [PATCH] iptables: lock free counters
On Mon, 02 Mar 2009 22:56:39 +0100
I wonder if the RCU quiescent fix should go in 2.6.29 because it
fixes other issues like route changing RCU latency under Dos attack.
--
| Mar 2, 3:02 pm 2009 |
| Eric Dumazet | Re: [PATCH] iptables: lock free counters
Yes it is :)
--
| Mar 2, 10:47 am 2009 |
| Paul E. McKenney | Re: [PATCH] iptables: lock free counters
I agree.
Thanx, Paul
--
| Mar 2, 3:17 pm 2009 |
| Patrick McHardy | Re: [PATCH] iptables: lock free counters
From what I can tell, it should.
--
| Mar 2, 3:07 pm 2009 |
| Eric Dumazet | Re: [PATCH] iptables: lock free counters
Yes probably, and on stable versions too, since this problem is quite old...
--
| Mar 2, 3:27 pm 2009 |
| Pantelis Koukousoulas | Re: [PATCH] b44: Disable device on shutdown (Resend)
It seems there is no way to prevent the gmail web client from horribly
mangling a patch :(
From now on I guess I 'll just put up a tree in gitorious and send pull
requests.
The first time these 2 patches were sent by Michael and they were
not corrupted.
Thanks for applying and sorry for the trouble (it is the last time I
get it wrong, I promise :)
Pantelis
--
| Mar 2, 8:43 am 2009 |
| David Miller | Re: [PATCH net-next] jme: Advance version number after p ...
From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
Applied, but missing a signoff, please don't forget it
next time.
--
| Mar 2, 2:55 am 2009 |
| Guo-Fu Tseng | [PATCH net-next] jme: Advance version number after previ ...
Advance version number after previous changes.
Sorry for not come along with previous patch series.
diff --git a/drivers/net/jme.h b/drivers/net/jme.h
index e321c67..0996a06 100644
--- a/drivers/net/jme.h
+++ b/drivers/net/jme.h
@@ -25,7 +25,7 @@
#define __JME_H_INCLUDED__
#define DRV_NAME "jme"
-#define DRV_VERSION "1.0.3"
+#define DRV_VERSION "1.0.4"
#define PFX DRV_NAME ": "
#define PCI_DEVICE_ID_JMICRON_JMC250 0x0250
--
| Mar 2, 1:39 am 2009 |
| previous day | today | next day |
|---|---|---|
| March 1, 2009 | March 2, 2009 | March 3, 2009 |
