[PATCH 09/18] bnx2x: Calling tx disable unconditionally

Previous thread: [PATCH 07/18] bnx2x: Missing module parameter description by Eilon Greenstein on Monday, March 2, 2009 - 10:59 am. (1 message)

Next thread: [PATCH 05/18] bnx2x: Unlimited Tx interrupt work by Eilon Greenstein on Monday, March 2, 2009 - 10:59 am. (1 message)
From: Eilon Greenstein
Date: Monday, March 2, 2009 - 10:59 am

Subject: [PATCH 09/18] bnx2x: Calling tx disable unconditionally

On unload, the FW assumes that no packets will be sent after the driver sends
the FW stop command. To ensure that, the driver must always call
netif_tx_disable

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
---
 drivers/net/bnx2x_main.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/bnx2x_main.c b/drivers/net/bnx2x_main.c
index 3ef24b9..5397de1 100644
--- a/drivers/net/bnx2x_main.c
+++ b/drivers/net/bnx2x_main.c
@@ -6573,10 +6573,8 @@ static void bnx2x_netif_stop(struct bnx2x *bp, int disable_hw)
 {
 	bnx2x_int_disable_sync(bp, disable_hw);
 	bnx2x_napi_disable(bp);
-	if (netif_running(bp->dev)) {
-		netif_tx_disable(bp->dev);
-		bp->dev->trans_start = jiffies;	/* prevent tx timeout */
-	}
+	netif_tx_disable(bp->dev);
+	bp->dev->trans_start = jiffies;	/* prevent tx timeout */
 }
 
 /*
-- 
1.5.4.3




--

Previous thread: [PATCH 07/18] bnx2x: Missing module parameter description by Eilon Greenstein on Monday, March 2, 2009 - 10:59 am. (1 message)

Next thread: [PATCH 05/18] bnx2x: Unlimited Tx interrupt work by Eilon Greenstein on Monday, March 2, 2009 - 10:59 am. (1 message)