Home » Mailing list archives » linux-netdev » 2009 » March » 19

Re: [PATCH] ipv6: fix display of local and remote sit endpoints

Previous thread: [GIT]: Networking by David Miller on Monday, March 9, 2009 - 5:29 am. (4 messages)

Next thread: Kernel Oops in UDP w/ ARM architecture by Ron Yorgason on Monday, March 9, 2009 - 8:52 am. (8 messages)
[view original message]
From: Jan Engelhardt
Subject: Re: iproute2 and regressing "ipv6: convert tunnels to net_device_ops"
Date: Monday, March 9, 2009 - 7:46 am

(Cc'ed netdev ml)

--


[ message continues ]
[view original message]
From: Rafael J. Wysocki
Subject: Re: iproute2 and regressing "ipv6: convert tunnels to net_device_ops"
Date: Saturday, March 14, 2009 - 11:34 am

Thanks,
Rafael
--


[ message continues ]
[view original message]
From: Bjørn Mork
Subject: [PATCH] ipv6: fix display of local and remote sit endpoints
Date: Monday, March 16, 2009 - 6:47 am

ipv6: fix display of local and remote sit endpoints

This fixes the regressions cause by
commit 1326c3d5a4b792a2b15877feb7fb691f8945d203
(v2.6.28-rc6-461-g23a12b1) broke the display of local and remote
addresses of an SIT tunnel in iproute2.

nt->parms is used by ipip6_tunnel_init() and therefore need to be
initialized first.

Tracked as http://bugzilla.kernel.org/show_bug.cgi?id=12868

Reported-by: Jan Engelhardt <jengelh@medozas.de>
Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 net/ipv6/sit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c
index d3467e5..5cee2bc 100644
--- a/net/ipv6/sit.c
+++ b/net/ipv6/sit.c
@@ -188,9 +188,9 @@ static struct ip_tunnel * ipip6_tunnel_locate(struct net *net,
 	}
 
 	nt = netdev_priv(dev);
-	ipip6_tunnel_init(dev);
 
 	nt->parms = *parms;
+	ipip6_tunnel_init(dev);
 
 	if (parms->i_flags & SIT_ISATAP)
 		dev->priv_flags |= IFF_ISATAP;
-- 
1.5.6.5

--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] ipv6: fix display of local and remote sit endpoints
Date: Wednesday, March 18, 2009 - 6:57 pm

From: Bjørn Mork <bjorn@mork.no>

Applied, thanks.
--


[ message continues ]
Previous thread: [GIT]: Networking by David Miller on Monday, March 9, 2009 - 5:29 am. (4 messages)

Next thread: Kernel Oops in UDP w/ ARM architecture by Ron Yorgason on Monday, March 9, 2009 - 8:52 am. (8 messages)