Home » Mailing list archives » linux-netdev » 2009 » March » 17

[PATCH 12/30] solos: Fix under-allocation of skb size for get/set parameters

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Woodhouse
Subject: [PATCH 12/30] solos: Fix under-allocation of skb size for get/set parameters
Date: Tuesday, March 17, 2009 - 2:29 pm

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
---
 drivers/atm/solos-pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/atm/solos-pci.c b/drivers/atm/solos-pci.c
index 2978699..2dca5ff 100644
--- a/drivers/atm/solos-pci.c
+++ b/drivers/atm/solos-pci.c
@@ -159,7 +159,7 @@ static ssize_t solos_param_show(struct device *dev, struct device_attribute *att
 
 	buflen = strlen(attr->attr.name) + 10;
 
-	skb = alloc_skb(buflen, GFP_KERNEL);
+	skb = alloc_skb(sizeof(*header) + buflen, GFP_KERNEL);
 	if (!skb) {
 		dev_warn(&card->dev->dev, "Failed to allocate sk_buff in solos_param_show()\n");
 		return -ENOMEM;
@@ -215,7 +215,7 @@ static ssize_t solos_param_store(struct device *dev, struct device_attribute *at
 
 	buflen = strlen(attr->attr.name) + 11 + count;
 
-	skb = alloc_skb(buflen, GFP_KERNEL);
+	skb = alloc_skb(sizeof(*header) + buflen, GFP_KERNEL);
 	if (!skb) {
 		dev_warn(&card->dev->dev, "Failed to allocate sk_buff in solos_param_store()\n");
 		return -ENOMEM;
-- 
1.6.0.6


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GIT *] Solos PCI ADSL card update, David Woodhouse, (Tue Mar 17, 10:19 am)
Re: [GIT *] Solos PCI ADSL card update, David Miller, (Tue Mar 17, 12:23 pm)
Re: [GIT *] Solos PCI ADSL card update, Stephen Hemminger, (Tue Mar 17, 1:41 pm)
[PATCH 01/30] solos: Fix length header in FPGA transfers, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 02/30] solos: Slight debugging improvements, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 03/30] solos: FPGA and firmware update support., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 04/30] solos: Clean up firmware loading code, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 05/30] solos: Kill global 'opens' count., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 06/30] solos: Handle attribute show/store in kernel ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 07/30] solos: Add initial list of parameters, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 08/30] solos: Handle new line status change packets ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 09/30] solos: Kill existing connections on link dow ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 10/30] solos: Reject non-AAL5 connections.... for now, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 11/30] solos: Add SNR and Attn to status packet, fi ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 12/30] solos: Fix under-allocation of skb size for ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 13/30] solos: Remove parameter group from sysfs on ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 14/30] solos: First attempt at DMA support, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 15/30] solos: Tidy up DMA handling a little. Still ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 16/30] solos: Tidy up tx_mask handling for ports wh ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 17/30] solos: Remove unused loopback debug stuff, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 18/30] solos: Remove IRQF_DISABLED, don't frob IRQ ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 19/30] solos: Remove superfluous wait_queue_head_t ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 21/30] solos: Clean up handling of card-&gt;tx_mask a ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 20/30] solos: Fix various bugs in status packet han ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 22/30] solos: Remove debugging, commented-out test code, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 23/30] solos: Add 'reset' module parameter to reset ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 24/30] solos: Tidy up status interrupt handling, co ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 25/30] solos: Don't clear config registers at startup, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 26/30] solos: Set RX empty flag at startup only for ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 27/30] solos: Swap upstream/downstream rates in sta ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 28/30] solos: Reset device on unload, free pending skbs, David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 30/30] solos: Disable DMA until we have an FPGA upd ..., David Woodhouse, (Tue Mar 17, 2:29 pm)
[PATCH 29/30] solos: Automatically determine number of ports, David Woodhouse, (Tue Mar 17, 2:29 pm)
Re: [GIT *] Solos PCI ADSL card update, David Woodhouse, (Tue Mar 17, 2:33 pm)
Re: [GIT *] Solos PCI ADSL card update, David Woodhouse, (Tue Mar 17, 2:36 pm)
Re: [PATCH 06/30] solos: Handle attribute show/store in ke ..., Stephen Hemminger, (Tue Mar 17, 3:44 pm)
Re: [PATCH 06/30] solos: Handle attribute show/store in ke ..., David Woodhouse, (Tue Mar 17, 3:49 pm)
Re: [PATCH 06/30] solos: Handle attribute show/store in ke ..., David Miller, (Sat Mar 21, 1:22 pm)