Re: [Bugme-new] [Bug 12886] New: skge wake on lan

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rafael J. Wysocki
Date: Tuesday, March 17, 2009 - 2:23 pm

On Tuesday 17 March 2009, Tomi Orava wrote:

Hmm.


I wonder what it shows if that commit is not reverted (in fact it is necessary
on some other systems for things to work correctly).

Also, please check if the appended patch helps (of course, without reverting
the commit).

---
 drivers/net/skge.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Index: linux-2.6/drivers/net/skge.c
===================================================================
--- linux-2.6.orig/drivers/net/skge.c
+++ linux-2.6/drivers/net/skge.c
@@ -3856,8 +3856,9 @@ static struct net_device *skge_devinit(s
 	skge->speed = -1;
 	skge->advertising = skge_supported_modes(hw);
 
-	if (device_may_wakeup(&hw->pdev->dev))
-		skge->wol = wol_supported(hw) & WAKE_MAGIC;
+	skge->wol = wol_supported(hw) & WAKE_MAGIC;
+	if (skge->wol && device_can_wakeup(&hw->pdev->dev))
+		device_set_wakeup_enable(&hw->pdev->dev, true);
 
 	hw->dev[port] = dev;
 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Andrew Morton, (Mon Mar 16, 8:04 pm)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Rafael J. Wysocki, (Tue Mar 17, 3:01 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Tomi Orava, (Tue Mar 17, 3:15 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Rafael J. Wysocki, (Tue Mar 17, 2:23 pm)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Tomi Orava, (Wed Mar 18, 12:32 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Rafael J. Wysocki, (Wed Mar 18, 8:14 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Tomi Orava, (Thu Mar 19, 6:03 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Tomi Orava, (Thu Mar 19, 9:23 am)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Rafael J. Wysocki, (Thu Mar 19, 1:59 pm)
Re: [Bugme-new] [Bug 12886] New: skge wake on lan, Tomi Orava, (Thu Mar 19, 8:59 pm)