Re: [net-2.6 PATCH 3/10] Neterion: New driver: Kconfig and Makefile

Previous thread: [net-2.6 PATCH 10/10] Neterion: New driver: Driver Version by Ramkrishna Vepa on Saturday, March 14, 2009 - 1:22 am. (1 message)

Next thread: [net-2.6 PATCH 6/10] Neterion: New driver: Hardware init & configuration by Ramkrishna Vepa on Saturday, March 14, 2009 - 1:21 am. (7 messages)
From: Ramkrishna Vepa
Date: Saturday, March 14, 2009 - 1:20 am

- Kconfig and Makefile related changes for vxge driver.

Signed-off-by: Sivakumar Subramani <sivakumar.subramani@neterion.com>
Signed-off-by: Rastapur Santosh <santosh.rastapur@neterion.com>
Signed-off-by: Ramkrishna Vepa <ram.vepa@neterion.com>
---
diff -urpN patch_2/drivers/net/Kconfig patch_3/drivers/net/Kconfig
--- patch_2/drivers/net/Kconfig	2009-03-12 11:23:32.000000000 -0700
+++ patch_3/drivers/net/Kconfig	2009-03-12 11:33:06.000000000 -0700
@@ -2531,6 +2531,24 @@ config S2IO
 	  More specific information on configuring the driver is in 
 	  <file:Documentation/networking/s2io.txt>.

+config VXGE
+	tristate "Neterion X3100 Series 10GbE PCIe Server Adapter"
+	depends on PCI
+	select INET_LRO
+	---help---
+	  This driver supports Neterion Inc's X3100 Series 10 GbE PCIe
+	  I/O Virtualized Server Adapter.
+	  More specific information on configuring the driver is in
+	  <file:Documentation/networking/vxge.txt>.
+
+config VXGE_DEBUG_TRACE_ALL
+	bool "Enabling All Debug trace statments in driver"
+	default n
+	depends on VXGE
+	---help---
+	  Say Y here if you want to enabling all the debug trace statements in
+	  driver. By  default only few debug trace statements are enabled.
+
 config MYRI10GE
 	tristate "Myricom Myri-10G Ethernet support"
 	depends on PCI && INET
diff -urpN patch_2/drivers/net/Makefile patch_3/drivers/net/Makefile
--- patch_2/drivers/net/Makefile	2009-03-12 11:23:32.000000000 -0700
+++ patch_3/drivers/net/Makefile	2009-03-12 11:33:55.000000000 -0700
@@ -219,6 +219,7 @@ obj-$(CONFIG_R8169) += r8169.o
 obj-$(CONFIG_AMD8111_ETH) += amd8111e.o
 obj-$(CONFIG_IBMVETH) += ibmveth.o
 obj-$(CONFIG_S2IO) += s2io.o
+obj-$(CONFIG_VXGE) += vxge/
 obj-$(CONFIG_MYRI10GE) += myri10ge/
 obj-$(CONFIG_SMC91X) += smc91x.o
 obj-$(CONFIG_SMC911X) += smc911x.o
diff -urpN patch_2/drivers/net/vxge/Makefile patch_3/drivers/net/vxge/Makefile
--- patch_2/drivers/net/vxge/Makefile	1969-12-31 16:00:00.000000000 -0800
+++ patch_3/drivers/net/vxge/Makefile	2009-03-12 ...
From: Bill Fink
Date: Saturday, March 14, 2009 - 10:40 am

To prevent certain build failures, when you "select INET_LRO" you also
need to add a depends on INET, so the above "depends on PCI" needs to
be changed to:

	depends on PCI && INET

						-Bill
--

From: Bill Fink
Date: Saturday, March 14, 2009 - 11:08 am

And I believe LRO has been deprecated in favor of GRO.

						-Bill
--

From: David Miller
Date: Saturday, March 14, 2009 - 11:44 am

From: Bill Fink <billfink@mindspring.com>

That's correct.

We should not add any new users of LRO.
--

From: Ben Hutchings
Date: Sunday, March 15, 2009 - 12:09 pm

[...]

These should really come last in the series so they don't refer to
nonexistent files.  This may not matter for a new driver as Dave can
squash them together into one patch.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
--

From: Ramkrishna Vepa
Date: Sunday, March 15, 2009 - 3:42 pm

Ben,

Thanks for the comments. We will address them when we resubmit the
patches in the next day or so.

--

Previous thread: [net-2.6 PATCH 10/10] Neterion: New driver: Driver Version by Ramkrishna Vepa on Saturday, March 14, 2009 - 1:22 am. (1 message)

Next thread: [net-2.6 PATCH 6/10] Neterion: New driver: Hardware init & configuration by Ramkrishna Vepa on Saturday, March 14, 2009 - 1:21 am. (7 messages)