linux-netdev mailing list

FromSubjectsort iconDate
feldmaus
Re: no IPv6 Routers present
First of all thank you for your answer, first i post my specifications if my system works well: /etc/network/interfaces: ######################################################################## auto lo iface lo inet loopback allow-hotplug eth0 iface eth0 inet dhcp iface dsl-provider inet ppp pre-up /sbin/ifconfig eth0 up -arp 0 # line maintained by pppoeconf provider dsl-provider ######################################################################## $route ...
Mar 12, 4:32 pm 2009
Markus Feldmann
Re: no IPv6 Routers present
Forgt to write my specifications: debian lenny with kernel 2.6.28.7 Regards Markus --
Mar 12, 2:41 pm 2009
Markus Feldmann
no IPv6 Routers present
Hi All, i am working on a combined Firewall, means 2 Firewalls on one Personal Computer. The first firewall is for my <ppp0> and the second firewall is for <eth0> if i connect through my Server to the internet. However, if i plug off and plug in my network cable, to change the connection from <eth0> to <ppp0>, the connection to internet fails. From <ppp0> to <eth0> works, but than i can not switch back because of a unkown connection error. <dmesg> prints out: no IPv6 Router ...
Mar 12, 2:05 pm 2009
Vlad Yasevich
Re: no IPv6 Routers present
This is just an information message when it's trying to It didn't switch to IPv6 in the first place. There is not switch. The two work side-by-side. You can do this now in 2.6.29-rcXXX, but not before. Also, my bet is that something other then IPv6 is wrong here. You need to give more information about your interface configurations, routes, and any firewall rules. --
Mar 12, 4:17 pm 2009
Arthur Jones
[PATCH] igb: allow tx of pre-formatted vlan tagged packets
When the 82575 is fed 802.1q packets, it chokes with an error of the form: igb 0000:08:00.1: partial checksum but proto=81 As the logic there was not smart enough to look into the vlan header to pick out the encapsulated protocol. There are times when we'd like to send these packets out without having to configure a vlan on the interface. Here we check for the vlan tag and allow the packet to go out with the correct hardware checksum. Thanks to Kand Ly <kand@riverbed.com> for ...
Mar 12, 1:27 pm 2009
Stephen Hemminger
Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
On Thu, 12 Mar 2009 13:27:24 -0700 That code in current igb driver (net-next-2.6) tree no longer has Don't use __constant_htons() here, macro is smart enough to know when --
Mar 12, 1:51 pm 2009
Alexander Duyck
Re: [net-next PATCH] igb: allow tx of pre-formatted vlan ...
I have added a few comments inline. This should probably reference skb_mac_header(skb) instead of data in Thanks, Alex --
Mar 12, 3:30 pm 2009
Arthur Jones
Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
Hi Stephen, ... The patch from linux-2.6 applies to net-next-2.6 with just a minor context fixup. I think the issue still exists in net-next-2.6, I'm compiling and testing now... Arthur --
Mar 12, 2:25 pm 2009
Stephen Hemminger
Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
On Thu, 12 Mar 2009 14:00:57 -0700 Actually, it is there just a little furthur down than I was looking --
Mar 12, 2:22 pm 2009
Arthur Jones
[net-next PATCH] igb: allow tx of pre-formatted vlan tag ...
When the 82575 is fed 802.1q packets, it chokes with an error of the form: igb 0000:08:00.1: partial checksum but proto=81 As the logic there was not smart enough to look into the vlan header to pick out the encapsulated protocol. There are times when we'd like to send these packets out without having to configure a vlan on the interface. Here we check for the vlan tag and allow the packet to go out with the correct hardware checksum. Thanks to Kand Ly <kand@riverbed.com> for ...
Mar 12, 2:33 pm 2009
Arthur Jones
Re: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
Hi Stephen, ... Ok, thanks, I'll test that one... Arthur --
Mar 12, 2:00 pm 2009
Markus Feldmann
how to access this mailing list netdev
Hi All, i am not sure whether this mail will pass this mailing list ? Is this Mailing List <netdev> accessable over gmane ? Or another Side with a Treeview ? Regards Markus --
Mar 12, 1:32 pm 2009
Ben Hutchings
Re: how to access this mailing list netdev
Yes, it's called gmane.linux.network there. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. --
Mar 12, 1:40 pm 2009
Andrew Morton
Re: [Bugme-new] [Bug 12860] New: SO_RCVBUF and SO_SNDBUF ...
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Thu, 12 Mar 2009 10:23:52 -0700 (PDT) --
Mar 12, 1:13 pm 2009
Vlad Yasevich
[PATCH net-next 0/4] sctp: clean-ups and fixes
Hi David This a small set of fixes in sctp: 1) clean up and simplify sctp listening code. 2) fix ASCONF indication in INIT-ACK. 3) send FORWARD TSN chunks only when peer supports the extension. 4) include Adaptation Indication parameter only when user set it. Thanks -vlad --
Mar 12, 12:49 pm 2009
Vlad Yasevich
[PATCH net-next 3/4] sctp: fix to send FORWARD-TSN chunk ...
From: Wei Yongjun <yjwei@cn.fujitsu.com> RFC3758 Section 3.3.1. Sending Forward-TSN-Supported param in INIT Note that if the endpoint chooses NOT to include the parameter, then at no time during the life of the association can it send or process a FORWARD TSN. If peer does not support PR-SCTP capable, don't send FORWARD-TSN chunk to peer. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- net/sctp/outqueue.c | 3 ...
Mar 12, 12:49 pm 2009
Vlad Yasevich
[PATCH net-next 2/4] sctp: fix to indicate ASCONF suppor ...
From: Wei Yongjun <yjwei@cn.fujitsu.com> This patch fix to indicate ASCONF support in INIT-ACK only if peer has such capable. This patch also fix to calc the chunk size if peer has no FWD-TSN capable. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- net/sctp/sm_make_chunk.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index b40e95f..9484f33 ...
Mar 12, 12:49 pm 2009
Vlad Yasevich
[PATCH net-next 1/4] sctp: simplify sctp listening code
sctp_inet_listen() call is split between UDP and TCP style. Looking at the code, the two functions are almost the same and can be merged into a single helper. This also fixes a bug that was fixed in the UDP function, but missed in the TCP function. Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com> --- net/sctp/socket.c | 152 +++++++++++++++++----------------------------------- 1 files changed, 50 insertions(+), 102 deletions(-) diff --git a/net/sctp/socket.c ...
Mar 12, 12:49 pm 2009
Vlad Yasevich
[PATCH net-next 4/4] sctp: add Adaptation Layer Indicati ...
From: malc <mlashley@gmail.com> RFC5061 states: Each adaptation layer that is defined that wishes to use this parameter MUST specify an adaptation code point in an appropriate RFC defining its use and meaning. If the user has not set one - assume they don't want to sent the param with a zero Adaptation Code Point. Rationale - Currently the IANA defines zero as reserved - and 1 as the only valid value - so we consider zero to be unset - to save adding a boolean to ...
Mar 12, 12:49 pm 2009
Michal Schmidt
Re: [PATCH] 8139cp: allow to set mac address on running device
On Thu, 12 Mar 2009 17:27:31 +0100 You're writing to the card, so using *_to_cpu looks suspicious. Michal --
Mar 12, 10:11 am 2009
Jiri Pirko
[PATCH] 8139cp: allow to set mac address on running device
So far there was not a chance to set a mac address on running 8139cp device. This is for example needed when you want to use this NIC as a bonding slave in bonding device in mode balance-alb. This simple patch allows it. Jirka Signed-off-by: Jiri Pirko <jpirko@redhat.com> drivers/net/8139cp.c | 24 +++++++++++++++++++++++- 1 files changed, 23 insertions(+), 1 deletions(-) diff --git a/drivers/net/8139cp.c b/drivers/net/8139cp.c index 4e19ae3..13b708a 100644 --- ...
Mar 12, 9:27 am 2009
Jiri Pirko
Re: [PATCH] 8139cp: allow to set mac address on running device
Well, I'm using the same approach as it is already done in function cp_init_hw(). Quote: /* Restore our idea of the MAC address. */ cpw32_f (MAC0 + 0, le32_to_cpu (*(__le32 *) (dev->dev_addr + 0))); cpw32_f (MAC0 + 4, le32_to_cpu (*(__le32 *) (dev->dev_addr + 4))); --
Mar 12, 10:46 am 2009
Paul Moore
[RFC PATCH v1 0/3] Fix a problem with incoming TCP conne ...
The patches below have more information on the problem but the issue is that we are not correctly labeling incoming TCP connection sockets at present. Due to a variety of things all coming together we've gotten a bit lucky in that the majority of labeled TCP connections are labeled correctly now but this won't hold for long as some of the new features added recently will break this "happy coincidence" for some configurations. For the folks on netdev, you probably only care about the relocation ...
Mar 12, 9:22 am 2009
Paul Moore
[RFC PATCH v1 3/3] netlabel: Label incoming TCP connecti ...
This patch labels incoming TCP connections correctly in a manner very similar to SELinux using the security_inet_conn_request() to label the request_sock. --- include/net/netlabel.h | 5 ++++ net/netlabel/netlabel_kapi.c | 13 +++++++++++ security/smack/smack_lsm.c | 51 ++++++++++++++++++++++++++++++++---------- 3 files changed, 57 insertions(+), 12 deletions(-) diff --git a/include/net/netlabel.h b/include/net/netlabel.h index bdb10e5..60ebbc1 100644 --- ...
Mar 12, 9:23 am 2009
Paul Moore
[RFC PATCH v1 1/3] lsm: Relocate the IPv4 security_inet_ ...
The current placement of the security_inet_conn_request() hooks do not allow individual LSMs to override the IP options of the connection's request_sock. This is a problem as both SELinux and Smack have the ability to use labeled networking protocols which make use of IP options to carry security attributes and the inability to set the IP options at the start of the TCP handshake is problematic. This patch moves the IPv4 security_inet_conn_request() hooks past the code where the request_sock's ...
Mar 12, 9:22 am 2009
Paul Moore
[RFC PATCH v1 2/3] netlabel: Label incoming TCP connecti ...
The current NetLabel/SELinux behavior for incoming TCP connections works but only through a series of happy coincidences that rely on the limited nature of standard CIPSO (only able to convey MLS attributes) and the write equality imposed by the SELinux MLS constraints. The problem is that network sockets created as the result of an incoming TCP connection were not on-the-wire labeled based on the security attributes of the parent socket but rather based on the wire label of the remote peer. The ...
Mar 12, 9:23 am 2009
Jan-Bernd Themann
[PATCH net-next-2.6] ehea: fix circular locking problem
This patch fixes the circular locking problem by changing the locking strategy concerning the logging of firmware handles. Signed-off-by: Jan-Bernd Themann <themann@de.ibm.com> --- drivers/net/ehea/ehea.h | 2 +- drivers/net/ehea/ehea_main.c | 56 ++++++++++++++++++++++------------------- 2 files changed, 31 insertions(+), 27 deletions(-) diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h index 029631c..6e317ca 100644 --- a/drivers/net/ehea/ehea.h +++ ...
Mar 12, 8:20 am 2009
Rémi Denis-Courmont
Re: Trouble getting a stable miredo relay
Hello, This is symptomatic of an overflow in the route/neighbor caches of the kernel. Please try to increase the size (a lot) manually via sysctl. I don't know Miredo holds a paradoxical situation whereby it (in userland) can easily handle millions of peers, but the kernel starts failing at 1024 of them. See also http://kerneltrap.org/mailarchive/linux-netdev/2008/8/31/3146914/thread and http://kerneltrap.org/mailarchive/linux-netdev/2008/8/31/3147634/thread You don't need much ...
Mar 12, 7:24 am 2009
Compaq Promo
claims of
Your email ID has been awarded £950,000,00 GBP in our COMPAQ AWARD, Reply to the email above in your in subjuect with your information Email:jerry.smith100@btinternet.com Name:.................... Country:................. Sex:..................... Age/Tell Number:............ Addres:................... --
Mar 12, 4:50 am 2009
Leila Mar 12, 4:07 am 2009
Varun Chandramohan
[IPROUTE2][PATCH 2/2] Enable Type Labels For "ip monitor all"
This patch adds prefix lables for "ip monitor all" command to simplfy understanding of the output. Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com> --- ip/ipmonitor.c | 16 ++++++++++++++++ 1 files changed, 16 insertions(+), 0 deletions(-) diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c index a74730e..baf25a8 100644 --- a/ip/ipmonitor.c +++ b/ip/ipmonitor.c @@ -25,6 +25,7 @@ #include "ip_common.h" static void usage(void) __attribute__((noreturn)); +int prefix_banner; ...
Mar 12, 1:12 am 2009
Varun Chandramohan
[IPROUTE2][PATCH 1/2] Add Monitor Support For Neigh Table
This patch adds exclusive support to enable monitoring neighbour table entries in ip command. Signed-off-by: Varun Chandramohan <varunc@linux.vnet.ibm.com> --- ip/ipmonitor.c | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c index df0fd91..a74730e 100644 --- a/ip/ipmonitor.c +++ b/ip/ipmonitor.c @@ -102,6 +102,7 @@ int do_ipmonitor(int argc, char **argv) int laddr=0; int lroute=0; int lprefix=0; + int lneigh=0; ...
Mar 12, 1:12 am 2009
David Miller
Re: [PATCH] Make virtio_net support carrier detection
From: Pantelis Koukousoulas <pktoss@gmail.com> Yes, absolutely. --
Mar 12, 6:03 am 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
It doesn't ignore it, it just doesn't enable it by default, like it does for those that do report carrier. But the user experience is that on real hardware you just boot a livecd and see your network "just working" (and the familiar icon with the 2 computers indicating that), while under e.g., KVM/virtio you get non-working network / an icon with a red X and you have to figure out to left click on it and select eth0 to get things to work. Some newer versions of NetworkManager seem to assume ...
Mar 12, 12:44 am 2009
Rusty Russell
Re: [PATCH] Make virtio_net support carrier detection
So, NetworkManager ignores the device because it doesn't support carrier detection? That seems weird, but I have nothing against this patch in general. Thanks, --
Mar 12, 12:29 am 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
This looks like an independent problem imho, one of kernel<->userspace API. The current 'defacto' way of finding out if detection is supported or not (ethtool) seems to give the needed information even if somewhat ugly. The issue discussed here as I understand it is whether virtio should or should not support carrier status reporting. IMHO it should, since it is useful functionality and doesn't cost much. Dan, What is your opinion on that? Pantelis --
Mar 12, 5:47 am 2009
Dan Williams
Re: [PATCH] Make virtio_net support carrier detection
(to be 100% clear, I believe that Pantelis' patch to add minimal ethtool support is *correct*, and it will fix the issue with NetworkManager) Dan --
Mar 12, 6:55 am 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
So, you agree that my patch that does exactly that is correct ? Pantelis --
Mar 12, 5:58 am 2009
David Miller
Re: [PATCH] Make virtio_net support carrier detection
From: Pantelis Koukousoulas <pktoss@gmail.com> I think Dan is right. If the driver doesn't provide an explicit carrier, there is no way to know for sure that it is on of off. If NetworkManager decides that this means on, and it's really off, that isn't so nice. And lots of very old drivers in the tree don't have a link indication handler, so this is a very real issue. Not adding a link state handler to virtio_net for pompous reasons like some theoretical "clean design" claim is idiotic, ...
Mar 12, 5:52 am 2009
Rusty Russell
Re: [PATCH] Make virtio_net support carrier detection
No, that's absolutely sane behavior, the previous was buggy. If a network doesn't support carrier, you shouldn't look for it. Since they've fixed this in Network Manager, I'm not tempted to lie about it in the driver (though the distributions might choose to). Rusty. --
Mar 12, 2:16 am 2009
Dan Williams
Re: [PATCH] Make virtio_net support carrier detection
Checking up more this morning in NetworkManager, here's the current behavior with 0.7.x. If the device doesn't support carrier detection (determined by checking for ethtool or MII ioctl support), NetworkManager will *not* listen for netlink carrier events. These are triggered by netif_carrier_on()/netif_carrier_off(), which even drivers that don't support carrier detection will still sometimes send. However, NetworkManager will assume carrier=on, because NM is designed such that if the ...
Mar 12, 6:41 am 2009
Dan Williams
Re: [PATCH] Make virtio_net support carrier detection
The problem is that there's no "my carrier detection is accurate" flag for drivers. Drivers that don't support carrier detection (say, my Belkin PCMCIA NE2k card) always report "carrier on", but of course don't support carrier detection. So when NetworkManager looks at the device and sees "hey, there's a carrier!" it will activate it, because a carrier means the cable is plugged in or the PHY *thinks* a cable is plugged in. So NetworkManager checks whether the device supports ethtool ...
Mar 12, 4:43 am 2009
Rusty Russell
Re: [PATCH] Make virtio_net support carrier detection
Actually, I've changed my mind. Unlike a device which *has* a carrier which we can't detect, there's no virtio_net "device" which can turn off link (not kvm/qemu, not lguest) without the pending VIRTIO_NET_S_LINK feature. Here's the patch for Dave's tree; the q. is do we want to put Pantelis' patch in 2.6.29 and stable? Rusty. Subject: virtio_net: set carrier on by default. Impact: fix carrier detection, older NetworkManager This is actually two fixes: 1) If the virtio_net device ...
Mar 12, 4:47 pm 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
Great, because the point I was arguing about was exactly what you wrote on the previous mail :) Thanks, Pantelis --
Mar 12, 6:10 am 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
On Thu, Mar 12, 2009 at 12:23 PM, Pantelis Koukousoulas After reading this one more time, it doesn't make much sense, so let me try to explain my point of view more clearly: For the wired case, carrier status == "is cable connected?" (NetworkManager is asking that) So, * virtio saying "Hey, I have no idea if cable is connected or not. I have no way to know that". (aka carrier detect not supported) I think this is closer to lying than: * "Hey, I know that the cable is connected". == ...
Mar 12, 4:05 am 2009
Pantelis Koukousoulas
Re: [PATCH] Make virtio_net support carrier detection
Ok, if "lying" is reporting that the driver supports carrier detection, this looks like an innocent lie :). Because the carrier *is* on, this is the truth and you could just as well claim that the virtual hardware supports detection as that it doesn't :) (Plus there is no technical reason why virtio_net cannot report carrier status, the only argument against it is saving 2 lines of code) IMHO, if someone has such an ancient card whose hardware cannot report carrier status (even my ne2k isa ...
Mar 12, 3:23 am 2009
Stephen Hemminger
Re: [PATCH] Make virtio_net support carrier detection
On Fri, 13 Mar 2009 10:17:11 +1030 Yes, need that feature, it is really useful for testing. It is about the only reason I hold onto using VMware. --
Mar 12, 4:55 pm 2009
Rusty Russell
Re: [PATCH] Make virtio_net support carrier detection
We really don't know if there's a carrier: virtio_net doesn't support it (yet). Dan said we can't return "don't know", but he's wrong: you get -EOPNOTSUPP from ETHTOOL_GLINK. That surely gives userspace the best "If". We've discussed adding a virtio_net feature to indicate link status, which implies that it's *not* always on. Rusty. --
Mar 12, 2:39 pm 2009
Harvey Harrison
Re: [PROBLEM]: potential unaligned memory access in driv ...
Doubtful, this patch should be a no-op, any alignment problems that existed before will still be there. Harvey --
Mar 12, 4:51 pm 2009
Andrew Morton
Re: [PROBLEM]: potential unaligned memory access in driv ...
(cc linux-usb and netdev) (it's drivers/usb/gadget/rndis.c) Maybe the below fixed this? afacit it is queued for 2.6.30 in the net-next tree: commit 35c26c2cf6a6a2d1c48add732d8ba002bd90784c Author: Harvey Harrison <harvey.harrison@gmail.com> AuthorDate: Sat Feb 14 22:56:56 2009 -0800 Commit: David S. Miller <davem@davemloft.net> CommitDate: Sat Feb 14 22:56:56 2009 -0800 rndis: remove private wrapper of __constant_cpu_to_le32 Use cpu_to_le32 directly as it ...
Mar 11, 11:51 pm 2009
Dave Jones
Re: VIA velocity skb leak.
On Thu, Mar 12, 2009 at 05:45:57AM +0100, Eric Dumazet wrote: > > @@ -1845,10 +1846,11 @@ static void velocity_free_tx_buf(struct velocity_info *vptr, struct velocity_td_ > > if (tdinfo->skb_dma) { > > > > + pktlen = (skb->len > ETH_ZLEN ? : ETH_ZLEN); > > I personally find better to use max(skb->len, ETH_ZLEN) macro, but YMMV ;) > > It actually can avoid you a bug ;) I prefer that too, but it makes a warning. drivers/net/via-velocity.c:2093: warning: comparison of ...
Mar 11, 9:56 pm 2009
David Miller
Re: VIA velocity skb leak.
velocity_xmit() needs to set 'pktlen = skb->len;' after, not before, the skb_padto() call. --
Mar 11, 9:17 pm 2009
Eric Dumazet
Re: VIA velocity skb leak.
I personally find better to use max(skb->len, ETH_ZLEN) macro, but YMMV ;) It actually can avoid you a bug ;) --
Mar 11, 9:45 pm 2009
David Miller
Re: VIA velocity skb leak.
From: David Miller <davem@davemloft.net> Actually that won't work since, as you suggest, skb->len isn't updated by skb_padto(). So the transmit needs something like: pktlen = (skb->len > ETH_ZLEN ? : ETH_ZLEN); velocity_free_tx_buf() needs to make the same calculation instead of just plain skb->len This bug probably exists in every other driver using skb_padto() :-) --
Mar 11, 9:20 pm 2009
Dave Jones
Re: VIA velocity skb leak.
On Wed, Mar 11, 2009 at 09:20:09PM -0700, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Wed, 11 Mar 2009 21:17:06 -0700 (PDT) > > > > > velocity_xmit() needs to set 'pktlen = skb->len;' after, > > not before, the skb_padto() call. > > Actually that won't work since, as you suggest, skb->len > isn't updated by skb_padto(). > > So the transmit needs something like: > > pktlen = (skb->len > ETH_ZLEN ? : ETH_ZLEN); > > velocity_free_tx_buf() ...
Mar 11, 9:39 pm 2009
Eric Dumazet
Re: VIA velocity skb leak.
or use max_t(unsigned, skb->len, ETH_ZLEN) --
Mar 11, 10:14 pm 2009
Dave Jones
VIA velocity skb leak.
I think I've found a bug in the via-velocity driver, but I'm not sure how to fix it. We've been carrying some debug patches in the Fedora kernel that dwmw2 wrote, which do some sanity checks on dma allocations. Velocity triggered this trace.. [ 324.777540] ------------[ cut here ]------------ [ 324.777559] WARNING: at lib/dma-debug.c:470 check_unmap+0x196/0x3e4() (Not tainted) [ 324.777575] Hardware name: [ 324.777591] via-velocity 0000:00:0e.0: DMA-API: device driver frees DMA memory ...
Mar 11, 9:13 pm 2009
Paul Menage
Re: [PATCH] cls_cgroup: remove unneeded cgroup_lock
There's no guarantee that the group isn't dead, so we could be writing into a value that's never going to be used again, but I guess that's not really a big deal. --
Mar 11, 7:41 pm 2009
Li Zefan
[PATCH] cls_cgroup: remove unneeded cgroup_lock
We can remove this lock here, since we are in cgroup write handler and thus the cgrp is guaranteed to be valid, and no lock is needed when writing a u32 variable. Signed-off-by: Li Zefan <lizf@cn.fujitsuc.com> --- net/sched/cls_cgroup.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/net/sched/cls_cgroup.c b/net/sched/cls_cgroup.c index 91a3db4..1ab4542 100644 --- a/net/sched/cls_cgroup.c +++ b/net/sched/cls_cgroup.c @@ -62,13 +62,7 @@ static u64 ...
Mar 11, 6:47 pm 2009
Jarek Poplawski
Re: DRR example, how to replace SFQ
Generally looks OK, but examples from cls_flow changelog could be followed: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=e5dfb8... Jarek P. --
Mar 12, 12:25 am 2009
Denys Fedoryschenko
DRR example, how to replace SFQ
If i understand right, it must look like this to simulate SFQ This example with just 2 "queues". tc qdisc add dev eth0.100 root handle 1: htb tc class add dev eth0.100 parent 1: classid 1:1 htb rate 15Kbit ceil 15Kbit tc qdisc add dev eth0.100 parent 1:1 handle 2: drr tc class add dev eth0.100 parent 2: classid 2:1 drr quantum 1600 tc class add dev eth0.100 parent 2: classid 2:2 drr quantum 1600 tc qdisc add dev eth0.100 parent 2:1 handle 10: bfifo 9000 tc qdisc add dev eth0.100 ...
Mar 11, 5:01 pm 2009
Steffen Klassert
Re: 3c59x: shared interrupt problem
Your pictures show just a message at shutdown. Are there any other unusual messages from the 3c59x driver in your logs? In particular I'm interested in "transmit timed out" messages. --
Mar 12, 7:39 am 2009
Gerhard Pircher
Re: 3c59x: shared interrupt problem
Unfortunately no. But I had disabled debugging in the driver until now, as it slows down the network transfer considerably. I'll rerun the test with debugging enabled. I'm going to retry 'git bisect' next week. Maybe I find a way to compile a bootable image for older kernel versions. Thanks! Gerhard -- Nur bis 16.03.! DSL-Komplettanschluss inkl. WLAN-Modem für nur 17,95 ¿/mtl. + 1 Monat gratis!* http://dsl.gmx.de/?ac=OM.AD.PD003K11308T4569a --
Mar 12, 8:12 am 2009
Daniel Lezcano
Re: [RFC v2 5/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 2:15 am 2009
Daniel Lezcano
Re: [RFC v2 7/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 2:51 am 2009
Daniel Lezcano
Re: [RFC v2 6/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 2:49 am 2009
Daniel Lezcano
Re: [RFC v2 3/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 2:03 am 2009
Daniel Lezcano
Re: [RFC v2 2/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 1:54 am 2009
Daniel Lezcano
Re: [RFC v2 4/7] net: netfilter conntrack - add per-net ...
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 2:07 am 2009
Daniel Lezcano
Re: [RFC v2 1/7] net: sysctl_net - use net_eq to compare nets
Acked-by: Daniel Lezcano <daniel.lezcano@free.fr> --
Mar 12, 1:50 am 2009
Ilpo Järvinen
Re: [RFC] tcp: allow timestamps even if SYN packet has tsval=0
What about the fact that PAWS could bite us leaving us a hung connection if timestamp changes too much when we get the first ACK? Though I doubt you can get windows to run long enough for this to become a problem if they always start from zero... ;-) -- i. --
Mar 12, 12:26 am 2009
Ben Hutchings
Re: [RFC v2: Patch 1/3] net: hand off skb list to other ...
Yes, that's exactly what they do. This feature is sometimes called Receive-Side Scaling (RSS) which is Microsoft's name for it. Microsoft requires Windows drivers performing RSS to provide the hash value to the networking stack, so Linux drivers for the same hardware should be able The choice of TX queue can be based on the RX hash so that configuration Aggressive power-saving causes far greater latency than context- switching under Linux. I believe most 10G NICs have large RX FIFOs ...
Mar 12, 7:08 am 2009
Andi Kleen
Re: [RFC v2: Patch 1/3] net: hand off skb list to other ...
Interrupt binding is something popular for benchmarks, but most users don't (and shouldn't need to) care. Having it work well out of the box There's a Microsoft spec for a standard hash function that does this on NICs and all the serious ones support it these days. The hash is normally used to select a MSI-X target based on the input header. Point was that any solution shouldn't add more reordering. But when a RSS hash is used there is no reordering on stream basis. -Andi -- ...
Mar 12, 7:34 am 2009
Zhang, Yanmin
Re: [RFC v2: Patch 1/3] net: hand off skb list to other ...
There are 2 kinds of LLC sharing here. 1) RX/TX share the LLC; 2) All RX share the LLC of some cpus and TX share the LLC of other cpus. Item 1) is important, but sometimes item 2) is also important when the sending speed is very high and huge data is on flight which flushes cpu cache quickly. Yes, when the data isn't huge. My forwarding testing currently could reach at 270M bytes per Yes. My method still depends on MSI-X and multi-queue. One difference is I just need less than Sorry. I can't ...
Mar 12, 1:16 am 2009
Jamie Lokier
Re: [PATCH] dnet: Dave DNET ethernet controller driver
In other words, glibc doesn't work on some embedded targets even if I believe the party line on such things is "use udev". Of course, realistically you can't use udev on little embedded systems and you probably wouldn't use it inside initrd either. Oh well! That's a good point. If assigning the MAC to a particular device "eth0" is dubious - someone said because device names aren't guaranteed. Well, why is Another good point: There have been complaints, of a sort, that embedded ...
Mar 12, 12:25 pm 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver ( ...
From: Ilya Yanok <yanok@emcraft.com> Applied, but I had to add the following patch to fix warnings and actual errors on 64-bit. dnet: Fix warnings on 64-bit. Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/dnet.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/dnet.c b/drivers/net/dnet.c index 92c3bd3..4b96974 100644 --- a/drivers/net/dnet.c +++ b/drivers/net/dnet.c @@ -553,8 +553,8 @@ static int ...
Mar 11, 11:29 pm 2009
Jamie Lokier
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Yes. Patching your own initrd or your own modified Debian initrd is _also_ not in the official trees, so I can't see any reason why anybody would follow Dave's suggestion. Much more work, different private tree, same behaviour, probably more bloated, probably Debian's initrd doesn't work on nommu anyway. However there was some attempt to get a reference initrd build into the kernel. Did that go anywhere? It would actually be good to use that if it exists. -- Jamie --
Mar 12, 11:06 am 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver
From: Riku Voipio <riku.voipio@iki.fi> That's a perfectly fine solution as well. Anything that specifies a unique MAC address somewhere on the board is OK. It's this "generate a random MAC address every bootup" that I am totally against. A situation where there is no permanent MAC address stored anywhere. --
Mar 11, 5:44 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Random mac addresses, yuk! :-) I'd much rather have something that I can make "do the right thing" than something I can't. And as I said, what I've encountered many times is a reference board from some manufacturer where the following conditions are present: 1. The bootloader can pass a command line to the kernel and it is saved in non-volatile storage that can be changed from the bootloader 2. I can not modify the bootloader 3. I can modify the Linux kernel 4. The manufacturer ...
Mar 12, 3:41 am 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Size, size, size. The killer in the embedded world which rules out glibc. And have you tried to link glibc statically with something that uses gethostbyname lately? It is no longer possible since the introduction of all the introduction of the dynamic name lookup crap (ok, it's not really crap, I just feel like it's crap every time I try to link a networking application statically). But that's a bit off topic since I don't need name lookups just to mount a NFS file system. uclibc ...
Mar 12, 11:25 am 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
It might be possible to build glibc to always use hosts+DNS for name lookup, but since I almost always use uclibc on embedded systems I haven't really tried to do it. If I use glibc, it's on a NFS root and I'm not sure what is happening, but a statically linked uclibc binary that does TCP networking will work happily with one userspace but not another. It would seem to me that a statically linked binary should only depend on the kernel ABI and not on anything userspace (except the ...
Mar 12, 12:43 pm 2009
Michael Cashwell
Re: [PATCH] dnet: Dave DNET ethernet controller driver
I'm confused by this. If I'm NFS-booting the board then how do I get to those userland tools if I don't have a valid MAC address in place to do the root mount? -Mike --
Mar 12, 6:41 am 2009
Stephen Hemminger
Re: [PATCH] dnet: Dave DNET ethernet controller driver
On Wed, 11 Mar 2009 21:56:06 +0100 The problem is that usually users end up with all devices with the same address, unless there is some other procedure to hand out addresses during configuration. That is why the random_ether_addr is safer. --
Mar 11, 5:13 pm 2009
Dan Williams Mar 12, 11:39 am 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver
From: Michael Cashwell <mboards@prograde.net> Initial ramdisk. --
Mar 12, 7:05 am 2009
Russell King - ARM Linux Mar 12, 1:35 pm 2009
Neil Horman
Re: [PATCH] dnet: Dave DNET ethernet controller driver
You didn't read what I wrote very closely, I specifically said you have to dig or host to do name lookups, specifically because of the issues with getXbyY. When I said I built busybox in 800k (400k compressed), That was with glibc statically linked. End of story. You're making up problems here, its not that big a deal. I've not looked at the figures lately, but how much space does the dhcp client and nfs root code take up in the kernel these days? I imagine that what you save there by ...
Mar 12, 12:05 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
In theory, nothing. In practice, well, where do I find an example initrd that I can build on that has a DHCP client that hands over the NFS root information from the DHCP response to a tool that mounts the NFS root file system? So far I haven't seen anything like that and the infrastructure to build initrds (such as klibc) is still hard to find and use. Every time I've tried to build an initrd that can do DCHP+NFS root it has turned out to be too much trouble and I've had to drop it as ...
Mar 12, 9:25 am 2009
Sascha Hauer
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Great, but how does this help in setting the MAC address? This would just move this exact discussion to the dracut or whatever mailing list, but we would still be searching for a generic way to say eth0addr=00:01:02:03:04:05 and I bet the arguments stay the same. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ...
Mar 12, 12:04 pm 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver
From: Christer Weinigel <christer@weinigel.se> This is getting rediculious. If you can modify the kernel, you can have the kernel look in the non-volatile storage for the MAC address and export that information to the ethernet driver. Or, you can parse the command line in your platform specific code and program the MAC address into the chip. In fact there are many reasonable ways to solve the problem in your scenerio, and none of them require device driver command line option ...
Mar 12, 5:55 am 2009
Sascha Hauer
Re: [PATCH] dnet: Dave DNET ethernet controller driver
just checked: disabling CONFIG_IP_PNP and CONFIG_IP_PNP_DHCP saves me 4456 bytes of zImage size on an ARM/PXA build Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --
Mar 12, 12:14 pm 2009
Wolfgang Denk
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Dear Sascha Hauer, Well, PowerPC uses the device tree for such information. As far as I've been told work is underway to extend the device tree support for ARM, too. [And U-Boot supports the device tree, of course.] Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de Any sufficiently advanced ...
Mar 12, 1:14 pm 2009
Neil Horman
Re: [PATCH] dnet: Dave DNET ethernet controller driver
+1, the simple fact of the matter is that, when building networkable devices, the design requirements must include: 1) The ability to store unit-unique data, like MAC addresses, in persistent storage, in a manner that can be read at arbitrary times from the OS. 2) The abiltiy to access that data from the OS under all relevant operating conditions. You have (1) covered, in that the bootloader passes the MAC on the command line to the kernel which can then be read via /proc/cmdline ...
Mar 12, 7:26 am 2009
Jamie Lokier
Re: [PATCH] dnet: Dave DNET ethernet controller driver
About 4k apparently. See the difference from "400k compressed?". I must admit that a solution which makes the effective kernel size 800k larger (your figure) doesn't look like a good standard to me. If that was the "standard", I'd be tempted to add a MAC address driver hack to the kernel to save the space :-) -- Jamie --
Mar 12, 2:59 pm 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver
From: Christer Weinigel <christer@weinigel.se> Yep, and you can parse that and execute the appropriate ifconfig command from userspace in your initial ramdisk. --
Mar 12, 8:01 am 2009
Neil Horman
Re: [PATCH] dnet: Dave DNET ethernet controller driver
If you have an MTD driver ported, then it is available if you use an initramfs. If you don't have an initramfs, you can still use your kernel command line Then dont, if you are only guaranteed one interface, use the kernel command What exactly is so difficult about cpio-ing up an initramfs to do this work with sed and ifconfig? You make it sound like its an impossible barrier. Its really You've convinced yourself that theres no other way to do this. What exactly is your opposition to an ...
Mar 12, 8:12 am 2009
Neil Horman
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Well, for an example of an initrd, you can unpack just about any distribution initramfs that you like. If you want to use busybox, I'd personally recommend either Debian (I think they use busybox normally), or you're welcome to get a copy of the fedora kexec-tools package. I put a script called mkdumprd that generates initramfs files in there based on busybox for the purpose of capturing core dumps. As for the dhcp part of it, that depends on the dhcp client you decide to use. I use the udhcpc ...
Mar 12, 10:49 am 2009
Sascha Hauer
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Unfortunately it isn't this simple because network device names are not stable (i.e. eth0 can become eth1 when you plug another network card) Someone has already mentioned this and I think this is the real problem why we still don't have such a mechanism. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 ...
Mar 12, 7:34 am 2009
Mike (mwester)
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Can you share your scripts and tools for creating an initramfs so easily? I too run into this problem -- I've always used the kernel-provided mechanism to DHCP and do the nfs mount of the rootfs, but if the initramfs is the right way to do that, then I'll be happy to change. It always looked rather daunting to me, and a lot of extra effort compared to letting the kernel do the job, but if it really is so easy, then I'll be happy to change my practices. Thanks! Mike (mwester) --
Mar 12, 1:24 pm 2009
Jamie Lokier
Re: [PATCH] dnet: Dave DNET ethernet controller driver
The objection "we're not taking that because it should go in initrd" would go away. -- Jamie --
Mar 12, 12:15 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Yup. A week right now is a luxury I usually don't have right now. I shouldn't even be spending time writing this mail, but I'm eh, Actually, I'm quite happy about work so far. When worked on improving the Samsung S3C24A0 patches Sandeep Patil had made, I got approval from my boss to spend time on making them suitable for submission to the official kernel, so I was able to do a lot more than just "make things work now". But the last few months have been kind of hectic. ...
Mar 12, 12:29 pm 2009
David Miller
Re: [PATCH] dnet: Dave DNET ethernet controller driver
From: Christer Weinigel <christer@weinigel.se> Just about every single distribution has to build a initrd that has to be able to setup a network, and have the necessary infrastructure to access things over NFS in order to implement their installer. You can start with the debian installer, that's probably the easiest to hack on and extend. Or you can just continue to list excuses, that might be easier. --
Mar 12, 10:43 am 2009
Jamie Lokier
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Aren't you basically implying that the in-kernel DHCP client and NFS mounting should be removed from the kernel too? I'd agree with that; it's the trend. But it seems pretty harsh to say "you can do DHCP+NFS now, but if you want to set the MAC address too, then you have to reimplement DHCP+NFS a completely different way from scratch first". -- Jamie --
Mar 12, 11:02 am 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
I just tried to get some actual numbers for the size increase by looking at an actual initrd I had lying around. If I just look at some some of the largest files needed for a initrd, they use 800kBytes: ls -l bin/busybox lib/ld-uClibc-0.9.28.so lib/libuClibc-0.9.28.so -rwxr-xr-x 1 root root 499804 2007-01-21 18:17 bin/busybox* -rwxr-xr-x 1 root root 19492 2005-12-27 12:15 lib/ld-uClibc-0.9.28.so* -rw-r--r-- 1 root root 312136 2005-12-27 08:46 lib/libuClibc-0.9.28.so All files are ...
Mar 12, 4:42 pm 2009
Sascha Hauer
Re: [PATCH] dnet: Dave DNET ethernet controller driver
I'm looking forward to the first patches on Linux Arm Kernel. That's gonna be even more fun than this thread ;) Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | --
Mar 12, 1:27 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Or I can keep patching the drivers, that's even easier. No it's not something I expect to see in the official kernel, but who cares, I always have loads of debug patches that won't get into the official kernel either. Keep the status quo. /Christer --
Mar 12, 10:52 am 2009
Neil Horman
Re: [PATCH] dnet: Dave DNET ethernet controller driver
You need to do that yourself. the initramfs is where all your platform specific bits go. You're assuming that some tool is automatically going to do this thing for you that is by definition non-standard. Non-standard stuff needs manually process to implement. --
Mar 12, 12:16 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Alternate answers: a) It wouldn't. But that doesn't stop me from liking the idea of actually having a working initrd/initramfs that people can build on. b) It would. With an easy to use initrd/initramfs infrastructure it would be trivial to add a small script that parses /proc/cmdline and runs "ifconfig eth0 hwaddr $FOO" based on it. c) It would. When the initrd/initramfs runs, it has access to all the normal device driver, so reading the first block of flash and parsing the ...
Mar 12, 12:21 pm 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
Yes, ridiculous in the complexity of the workarounds for not having a Which means that the non-volatile storage must be available through a Linux driver before the MAC address is set. AFAIK there is no guarantee that the MTD layer will be ready to use by that time. And that is assuming that there actually is a MTD driver available, usually when I work on a Linux port for a reference board, the first thing I do is to get a NFS root up and running, then I can put a have a complete Debian ...
Mar 12, 7:21 am 2009
Christer Weinigel
Re: [PATCH] dnet: Dave DNET ethernet controller driver
That would be a very worthwhile project actually. Create a package that uses klibc, does BOOTP/DCHP/NFS and parses the the ip=foo,bar options the same way the kernel does so that we can finally get rid of the in kernel stuff. That, the code that reads an initrd from a floppy disk (nobody can really be using that code anymore, can they?), and the md setup are probably the last obstacles to doing a nice little cleanup of the mount_root code in the kernel. I just wish I had more ...
Mar 12, 11:48 am 2009
David Miller
Re: [PATCH] wimax: fix i2400m printk formats
From: Inaky Perez-Gonzalez <inaky@linux.intel.com> Applied. --
Mar 11, 11:24 pm 2009
David Miller
Re: [PATCH 1/3] be2net: header files
From: Sathya Perla <sathyap@serverengines.com> I've added your driver to the tree, thank you. --
Mar 11, 11:33 pm 2009
Neil Horman
Re: [Patch 3/5] Network Drop Monitor: Adding kfree_skb_c ...
Those are both good ideas. I think I like the former suggestion, since the latter requires that a drop in the stack must occur to detect a stack closer to the hardware. Thank you, I'll keep that in mind for a subsequent enhancement. Regards --
Mar 11, 5:30 pm 2009
Eric Dumazet
Re: Multicast packet loss
Cool I am wondering if we should extend the mechanism and change softirq_delay_exec() to wakeup a workqueue instead of doing the loop from softirq handler, in case a given level of stress / load is hit. This could help machines with several cpus, and one NIC (without multi RX queues) flooded by messages (not necessarly multicast trafic). Imagine a media/chat server receiving XXX.000 frames / second One cpu could be dedicated to pure softirq/network handling, and other cpus could ...
Mar 12, 9:34 am 2009
Brian Bloniarz
Re: Multicast packet loss
This works great in all my tests so far. Thanks, Brian Bloniarz --
Mar 12, 8:47 am 2009
previous daytodaynext day
March 11, 2009March 12, 2009March 13, 2009