Re: VIA velocity skb leak.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Wednesday, March 11, 2009 - 9:20 pm

From: David Miller <davem@davemloft.net>
Date: Wed, 11 Mar 2009 21:17:06 -0700 (PDT)


Actually that won't work since, as you suggest, skb->len
isn't updated by skb_padto().

So the transmit needs something like:

	pktlen = (skb->len > ETH_ZLEN ? : ETH_ZLEN);

velocity_free_tx_buf() needs to make the same calculation
instead of just plain skb->len

This bug probably exists in every other driver using
skb_padto() :-)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
VIA velocity skb leak., Dave Jones, (Wed Mar 11, 9:13 pm)
Re: VIA velocity skb leak., David Miller, (Wed Mar 11, 9:17 pm)
Re: VIA velocity skb leak., David Miller, (Wed Mar 11, 9:20 pm)
Re: VIA velocity skb leak., Dave Jones, (Wed Mar 11, 9:39 pm)
Re: VIA velocity skb leak., Eric Dumazet, (Wed Mar 11, 9:45 pm)
Re: VIA velocity skb leak., Dave Jones, (Wed Mar 11, 9:56 pm)
Re: VIA velocity skb leak., Eric Dumazet, (Wed Mar 11, 10:14 pm)
Re: VIA velocity skb leak., David Miller, (Fri Mar 13, 1:36 pm)
a2065 skb_padto cleanups, Dave Jones, (Fri Mar 13, 1:52 pm)
r8169 skb leak, Dave Jones, (Fri Mar 13, 2:10 pm)
Re: r8169 skb leak, Francois Romieu, (Fri Mar 13, 3:26 pm)
Re: r8169 skb leak, David Miller, (Fri Mar 13, 3:33 pm)
Re: a2065 skb_padto cleanups, David Miller, (Wed Mar 18, 6:18 pm)