>> tatic int ql_configure_rings(struct ql_adapter *qdev)
quoted text
>>  	 * completion handler rx_rings.
>>  	 */
>>  	qdev->rx_ring_count = qdev->tx_ring_count + qdev->rss_ring_count
>>  	+ 1;
>> +	netif_set_gso_max_size(qdev->ndev, 65536);
>>  
>>  	for (i = 0; i < qdev->tx_ring_count; i++) {
>>  		tx_ring = &qdev->tx_ring[i];
>
>65536 (defined by GSO_MAX_SIZE) is the default and it's really a good
>idea to only use this override interface on chips that actaully have
>restrictions and can't use the default.
>
>I also don't see what this change had to do with adding TX
>multiqueue support :-)  It wasn't mentioned in the commit log
>message in any way either.  Please don't slip small things in
>like this.

Dave,

Thanks for clarifying this for me.  I'll drop this line in my next
series. I should have sent it as a separate (rejectable) patch.
I'll be more careful about that.

Ron




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html