Re: BUG: NIU driver: strange issues with multicast "UDP: short packet"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Tuesday, February 3, 2009 - 4:38 pm

From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Tue, 03 Feb 2009 14:38:20 +0100


The UDP header length field is garbage in all of these packets.

In the first two packets here, the source and dest ports are
both zero.  This is also garbage.,


So something corrupts the packet on the way to UDP input.


That could be a good clue.

Do you happen to have multicast routing enabled on this machine?  If
the multicast destination is non-local and IN_DEV_FORWARD is set on
the interface, that puts the packet through ip_mr_input.

ip_mr_input() will clone the SKB if it should be delivered locally
as well as be forwarded.

If the packet does get multicast forwarded, there is all kinds of
funny code that mangles the packet, for example ipmr_cache_report().

Any of this could be corrupting what UDP ends up seeing.

To be honest all of the SKB handling in the ipmr.c file is very scary.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
BUG: NIU driver: strange issues with multicast &quot;UDP: short ..., Jesper Dangaard Brouer, (Tue Feb 3, 6:38 am)
Re: BUG: NIU driver: strange issues with multicast "UDP: s ..., David Miller, (Tue Feb 3, 4:38 pm)
Re: BUG: NIU driver: strange issues with multicast &quot;UDP: s ..., Jesper Dangaard Brouer, (Wed Feb 4, 1:55 am)
Re: BUG: NIU driver: strange issues with multicast &quot;UDP: s ..., Jesper Dangaard Brouer, (Wed Feb 4, 2:32 am)
Re: BUG: NIU driver: strange issues with multicast &quot;UDP: s ..., Jesper Dangaard Brouer, (Thu Feb 5, 5:44 am)
[PATCH] Fix UDP short packet false positive, Jesper Dangaard Brouer, (Thu Feb 5, 5:47 am)
Re: [PATCH] Fix UDP short packet false positive, David Miller, (Thu Feb 5, 4:06 pm)
[RFC] [PATCH] Fix UDP short packet false positive, Jesper Dangaard Brouer, (Fri Feb 6, 2:00 am)
Re: [RFC] [PATCH] Fix UDP short packet false positive, David Miller, (Fri Feb 6, 2:08 am)
[PATCH] udp: Fix potential wrong ip_hdr(skb) pointers, Jesper Dangaard Brouer, (Fri Feb 6, 2:55 am)
Re: [PATCH] udp: Fix potential wrong ip_hdr(skb) pointers, Jesper Dangaard Brouer, (Fri Feb 6, 3:49 am)