From: Jarek Poplawski
Date: Mon, 2 Feb 2009 08:43:58 +0000> On Mon, Feb 02, 2009 at 12:18:54AM -0800, David Miller wrote:
This is a very interesting idea, but it has some drawbacks:
1) Just like any other allocator we'll need to find a way to
handle > PAGE_SIZE allocations, and thus add handling for
compound pages etc.
And exactly the drivers that want such huge SKB data areas
on receive should be converted to use scatter gather page
vectors in order to avoid multi-order pages and thus strains
on the page allocator.
2) Space wastage and poor packing can be an issue.
Even with SLAB/SLUB we get poor packing, look at Evegeniy's
graphs that he made when writing his NTA patches.
Now, when choosing a way to move forward, I'm willing to accept a
little bit of the issues in #2 for the sake of avoiding the
issues in #1 above.
Jarek, note that we can just keep your current splice() copy hacks in
there. And as a result we can have an easier to handle migration
path. We just do the page RX allocation conversions in the drivers
where performance really matters, for hardware a lot of people have.
That's a lot smoother and has less issues that converting the system
wide SKB allocator upside down.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
| Artem Bityutskiy | [PATCH 10/44 take 2] [UBI] debug unit implementation |
| Greg Kroah-Hartman | [PATCH 004/196] Chinese: add translation of SubmittingPatches |
| Trent Piepho | [PATCH] [POWERPC] Improve (in|out)_beXX() asm code |
| Dave Young | Re: Linux v2.6.24-rc1 |
git: | |
| Gerrit Renker | [PATCH 27/37] dccp: Integration of dynamic feature activation - part 2 (server side) |
| Linus Torvalds | Re: [GIT]: Networking |
| David Miller | Re: [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Natalie Protasevich | [BUG] New Kernel Bugs |
