linux-netdev mailing list

FromSubjectsort iconDate
Jeff Kirsher
[net-next PATCH 1/2] ixgbe: Move ring features into an e ...
From: Shannon Nelson <shannon.nelson@intel.com> The ring_feature member of ixgbe_adapter is statically allocated based on the supported features of the device. When a new feature is added, we need to manually update the static allocation. This patch makes the feature list an enum, eliminating the need for multiple updates to the code when adding a new feature. Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by: Jeff Kirsher ...
Feb 24, 4:40 pm 2009
Jeff Kirsher
[net-next PATCH 2/2] ixbge: fix bug when using large pag ...
From: Jesse Brandeburg <jesse.brandeburg@intel.com> it was pointed out on the list that ixgbe was failing when using 64kB pages and large 16kB MTU. since with a 64kB PAGE_SIZE MAX_SKB_FRAGS = 3, the way the driver was configuring page usage was assuming 2kB is half a page, and was only ever dmaing that much data to a half page. (16kB - header size) / 2048 = 7 or 8 pages, which would far exceed 3 adjust the driver to account for these large pages, the hardware can support DMA to up to ...
Feb 24, 4:40 pm 2009
Chuck Ebbert
oops / null deref in __inet6_check_established(), kernel ...
(This doesn't happen on 2.6.27/28) tw is NULL at net/ipv6/inet6_hashtables.c:261: if (twp != NULL) { *twp = tw; ===> NET_INC_STATS_BH(twsk_net(tw), LINUX_MIB_TIMEWAITRECYCLED); } else if (tw != NULL) { I can reproduce this on real hardware on x86_64 too... BUG: unable to handle kernel NULL pointer dereference at 00000024 IP: [<c06d3366>] __inet6_check_established+0x24f/0x2b1 Oops: 0000 [#1] SMP last sysfs file: /sys/devices/virtual/misc/fuse/dev Modules linked in: fuse bridge ...
Feb 24, 4:21 pm 2009
Chuck Ebbert
Re: oops / null deref in __inet6_check_established(), ke ...
On Tue, 24 Feb 2009 15:27:04 -0800 (PST) Oops, forgot to add the bug URL: https://bugzilla.redhat.com/show_bug.cgi?id=486889 Steps to Reproduce: 1. Get minirpc 0.3.2 [http://minirpc.cs.cmu.edu/download/minirpc-0.3.2.tar.gz] 2. Run ./configure ; make ; make check --
Feb 24, 4:35 pm 2009
David Miller
Re: oops / null deref in __inet6_check_established(), ke ...
From: Chuck Ebbert <cebbert@redhat.com> How? :-) --
Feb 24, 4:27 pm 2009
Oliver Zheng
TCP/IP stack interpretation of acceptable packet
I was investigating behaviour of the TCP/IP stacks and noticed that Linux has a peculiarity. When a packet is received with the correct sequence number but incorrect acknowledgement number (in my tests, it was higher than the correct acknowledgement number), the stack accepts the packet as a valid packet and passes the data up to the application (I do not know whether the ack information is accepted). According to the list of tests described here in the TCP RFC 793 [1], accepting a packet ...
Feb 24, 3:59 pm 2009
Andrew Morton
Re: [Bugme-new] [Bug 12753] New: /proc/net/xt_recent/: + ...
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Sun, 22 Feb 2009 15:11:56 -0800 (PST) hm, that function does some pretty ugly things. I wonder if the same bug exists elsewhere (or might do so in the future). A more general fix would be to write a new in6_to_nf_inet_addr() and in4_to_nf_inet_addr() which correctly initialise the whole union. --
Feb 24, 1:58 pm 2009
Tobias Winter
Re: [Bugme-new] [Bug 12772] New: linux is not able to ha ...
Point taken. I just gave it a try with 2.6.29-rc6 and the problem persists. --
Feb 24, 1:07 pm 2009
Andrew Morton
Re: [Bugme-new] [Bug 12772] New: linux is not able to ha ...
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Tue, 24 Feb 2009 11:35:25 -0800 (PST) --
Feb 24, 12:50 pm 2009
Dhananjay Phadke
[patch next 2/4] netxen: advertise wake-on-lan support
Add ethtool wake on lan support. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_ethtool.c | 49 +++++++++++++++++++++++++++++++ drivers/net/netxen/netxen_nic_hdr.h | 3 ++ 2 files changed, 52 insertions(+), 0 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_ethtool.c b/drivers/net/netxen/netxen_nic_ethtool.c index 0894a7b..0012b31 100644 --- a/drivers/net/netxen/netxen_nic_ethtool.c +++ b/drivers/net/netxen/netxen_nic_ethtool.c @@ ...
Feb 24, 12:39 pm 2009
Dhananjay Phadke
[patch next 1/4] netxen: firmware download support
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic.h | 9 ++ drivers/net/netxen/netxen_nic_hdr.h | 3 + drivers/net/netxen/netxen_nic_hw.c | 175 +++++++++++++++++++++++++++++++-- drivers/net/netxen/netxen_nic_main.c | 125 ++++++++++++------------ 4 files changed, 238 insertions(+), 74 deletions(-) diff --git a/drivers/net/netxen/netxen_nic.h b/drivers/net/netxen/netxen_nic.h index f4dd9ac..b726182 100644 --- ...
Feb 24, 12:39 pm 2009
Dhananjay Phadke
[patch next 3/4] netxen: cleanup unused code
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_ethtool.c | 75 ------- drivers/net/netxen/netxen_nic_hw.c | 13 -- drivers/net/netxen/netxen_nic_hw.h | 27 --- drivers/net/netxen/netxen_nic_init.c | 360 ------------------------------- drivers/net/netxen/netxen_nic_niu.c | 219 ------------------- 5 files changed, 0 insertions(+), 694 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_ethtool.c ...
Feb 24, 12:39 pm 2009
Dhananjay Phadke
[patch next 4/4] netxen: refactor pci probe
Split pci probe function into smaller logical blocks. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_main.c | 384 ++++++++++++++++++---------------- 1 files changed, 203 insertions(+), 181 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index 9d6e68f..c2b551f 100644 --- a/drivers/net/netxen/netxen_nic_main.c +++ b/drivers/net/netxen/netxen_nic_main.c @@ -457,6 +457,202 @@ static const struct ...
Feb 24, 12:39 pm 2009
Joe Perches
[PATCH] tcp_scalable: Update malformed & dead url
Signed-off-by: Joe Perches <joe@perches.com> diff --git a/net/ipv4/tcp_scalable.c b/net/ipv4/tcp_scalable.c index 2747ec7..4660b08 100644 --- a/net/ipv4/tcp_scalable.c +++ b/net/ipv4/tcp_scalable.c @@ -1,6 +1,6 @@ /* Tom Kelly's Scalable TCP * - * See htt://www-lce.eng.cam.ac.uk/~ctk21/scalable/ + * See http://www.deneholme.net/tom/scalable/ * * John Heffner <jheffner@sc.edu> */ --
Feb 24, 10:18 am 2009
Randy Dunlap
Re: linux-next: Tree for February 24 (netdev/hp-plus bui ...
ERROR: "__alloc_ei_netdev" [drivers/net/hp-plus.ko] undefined! config attached. -- ~Randy
Feb 24, 9:47 am 2009
Patrick McHardy
netfilter 00/06: netfilter fixes
Hi Dave, the following patches contain netfilter fixes for 2.6.29: - a typo fix in a ICMPv6 conntrack log message from Eric Leblond - a fix for nfnetlink_log per-rule threshold overrides. Currently the rule always wins because of the defaults, which is not intended. Also from Eric. - a fix for the nfnetlink_log default timeout units from Eric. The kernel uses 10ms units, the default is specified in HZ. - a fix to avoid conntrack event delivery for untracked connections - a ...
Feb 24, 7:52 am 2009
Patrick McHardy
netfilter 05/06: make proc/net/ip* print names from fore ...
commit eb132205ca2f7ad44d8c8c482815b6911200b6a0 Author: Jan Engelhardt <jengelh@medozas.de> Date: Wed Feb 18 16:42:19 2009 +0100 netfilter: make proc/net/ip* print names from foreign NFPROTO When extensions were moved to the NFPROTO_UNSPEC wildcard in ab4f21e6fb1c09b13c4c3cb8357babe8223471bd, they disappeared from the procfs files. Signed-off-by: Jan Engelhardt <jengelh@medozas.de> Signed-off-by: Patrick McHardy <kaber@trash.net> diff --git ...
Feb 24, 7:52 am 2009
David Miller
Re: netfilter 00/06: netfilter fixes
From: Patrick McHardy <kaber@trash.net> Pulled, thanks Patrick. --
Feb 24, 2:50 pm 2009
Patrick McHardy
netfilter 03/06: nfnetlink_log: fix timeout handling
commit 2c6764b743f9d25dd0806a417f06920dcbd0f599 Author: Eric Leblond <eric@inl.fr> Date: Wed Feb 18 15:29:49 2009 +0100 netfilter: nfnetlink_log: fix timeout handling NFLOG timeout was computed in timer by doing: flushtimeout*HZ/100 Default value of flushtimeout was HZ (for 1 second delay). This was wrong for non 100HZ computer. This patch modify the default delay by using 100 instead of HZ. Signed-off-by: Eric Leblond <eric@inl.fr> ...
Feb 24, 7:52 am 2009
Patrick McHardy
netfilter 04/06: nf_conntrack: don't try to deliver even ...
commit 5962fc6d5fff09c8e6fb8cadcb18327a0f4277f7 Author: Patrick McHardy <kaber@trash.net> Date: Wed Feb 18 15:30:34 2009 +0100 netfilter: nf_conntrack: don't try to deliver events for untracked connections The untracked conntrack actually does usually have events marked for delivery as its not special-cased in that part of the code. Skip the actual delivery since it impacts performance noticeably. Signed-off-by: Patrick McHardy <kaber@trash.net> diff --git ...
Feb 24, 7:52 am 2009
Patrick McHardy
netfilter 06/06: xt_recent: fix proc-file addition/remov ...
commit 325fb5b4d26038cba665dd0d8ee09555321061f0 Author: Josef Drexler <joe-lk@ttdpatch.net> Date: Tue Feb 24 14:53:12 2009 +0100 netfilter: xt_recent: fix proc-file addition/removal of IPv4 addresses Fix regression introduded by commit 079aa88 (netfilter: xt_recent: IPv6 support): From http://bugzilla.kernel.org/show_bug.cgi?id=12753: Problem Description: An uninitialized buffer causes IPv4 addresses added manually (via the +IP command to the proc ...
Feb 24, 7:52 am 2009
Patrick McHardy
netfilter 02/06: nfnetlink_log: fix per-rule qthreshold ...
commit 5ca431f9ae8db8c6edb9c64bebe6d6521077afd6 Author: Eric Leblond <eric@inl.fr> Date: Wed Feb 18 15:29:23 2009 +0100 netfilter: nfnetlink_log: fix per-rule qthreshold override In NFLOG the per-rule qthreshold should overrides per-instance only it is set. With current code, the per-rule qthreshold is 1 if not set and it overrides the per-instance qthreshold. This patch modifies the default xt_NFLOG threshold from 1 to 0. Thus a value of 0 means there is ...
Feb 24, 7:52 am 2009
Patrick McHardy
netfilter 01/06: nf_conntrack_ipv6: fix nf_log_packet me ...
commit 4aa3b2ee1945ed082430ae1fb988d60eef64ca07 Author: Eric Leblond <eric@inl.fr> Date: Wed Feb 18 15:28:46 2009 +0100 netfilter: nf_conntrack_ipv6: fix nf_log_packet message in icmpv6 conntrack This patch fixes a trivial typo that was adding a new line at end of the nf_log_packet() prefix. It also make the logging conditionnal by adding a LOG_INVALID test. Signed-off-by: Eric Leblond <eric@inl.fr> Signed-off-by: Patrick McHardy <kaber@trash.net> diff ...
Feb 24, 7:52 am 2009
WEBMAIL ACCOUNT UPGRADE
Dear Webmail account User
Dear Webmail account User, This message is from Webmail account update Service team messaging center to all subscribers/webmail users. We are currently upgrading our data base and e-mail center due to an unusual activities identified in our email system. We are deleting all unused Webmail Accounts. to create space for new ones. You are required to verify your webmail account by confirming your Webmail identity. This will prevent your Webmail account from been closed during this exercise.In ...
Feb 24, 6:59 am 2009
Daniel Lezcano
Re: !CONFIG_NET_NS build error, net/core/net_namespace.c
Thanks, this has been fixed with commit ebe47d47b7b7fed72dabcce4717da727b4e2367d Sorry for the inconvenience. -- Daniel --
Feb 24, 6:43 am 2009
Mike Galbraith
!CONFIG_NET_NS build error, net/core/net_namespace.c
CC net/core/net_namespace.o net/core/net_namespace.c: In function ‘net_ns_init’: net/core/net_namespace.c:223: error: implicit declaration of function ‘net_alloc_generic’ net/core/net_namespace.c:223: warning: assignment makes pointer from integer without a cast make[2]: *** [net/core/net_namespace.o] Error 1 make[1]: *** [net/core] Error 2 make: *** [net] Error 2 Impact: fix !CONFIG_NET_NS net/core/net_namespace.c build error Signed-off-by: Mike Galbraith <efault@gmx.de> ...
Feb 24, 6:00 am 2009
Phan Thuy Ngoc
WB/NF/IMF/WA-XX027/N08.
OUR REF: WB/NF/IMF/WA-XX027/N08 Your Ref.................................. It is my pleasure officially to inform you that (ATM Card Number; 280512007660408004) has been accredited in your favor.Your Personal Identification Number is ATM-822. The ATM Card Value is $6.8MILLION USD. You are advice to contact Mrs. Phan Thuy Ngoc Email:(atmcardoffice007@yahoo.com.hk) with the following information; * Full Name: * Delivery Address: * Age: *Sex * Occupation: * Phone Number: * Scan copy ...
Feb 24, 5:33 am 2009
Krzysztof Halasa
Re: ixp4xx_hss modifications for 2x4 HDLC
Hi, Well, I guess it's a bit like a proof of concept rather than an applicable patch? :-) And it's based on "chan" branch. This isn't good, the "chan" isn't yet ready to go upstream, the interface isn't yet stable. It's really experimental, based on undocumented behaviour etc. Do you need the "channelized" feature? If not, perhaps you should stick to HDLC-only David's net-next? Same here. This only needs a tiny change, increasing the number of HDLC devices to 2 or 4 (for each ...
Feb 24, 4:38 pm 2009
Miguel Ángel Álvarez
ixp4xx_hss modifications for 2x4 HDLC
Hi. I have finished my modifications to Krzysztof Halasa's driver for ixp4xx_hss that allow to use four HDLC for each HSS. The modifications are functional, but some effort must be done to allow the configuration in 2x1HDLC (Krzysztof's) or 2x4HDLC (mine) modes. I would appreciate your comments very much, because I think this functionallity is quite usefull and I would like to add it to the main kernel stream. diff -urN ...
Feb 24, 5:47 am 2009
Jan Engelhardt
iproute2: replace linktype number by name for tunnels
ip link currently only shows [65534] for TUN-style tunnels, but 65534 actually maps to a name. $ ip l 6: tun1: <POINTOPOINT,MULTICAST,NOARP> mtu 1500 qdisc noop state DOWN qlen 500 link/[65534] Signed-off-by: Jan Engelhardt <jengelh@medozas.de> --- lib/ll_types.c | 3 +++ 1 file changed, 3 insertions(+) Index: iproute2-2.6.23/lib/ll_types.c =================================================================== --- iproute2-2.6.23.orig/lib/ll_types.c +++ ...
Feb 24, 3:31 am 2009
Jan Engelhardt
iproute2: prints bogus hoplimit
$ ip -6 r fc00::/7 dev rtl0 proto kernel metric 256 mtu 1500 advmss 1440 hoplimit 4294967295 Most likely, "hoplimit -1" would be the right number, though I am not sure if simply changing %u by %d is a correct thing to do, since it would affect all fields. --- ip/iproute.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 6a2ea05..91a8cc0 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -507,7 +507,7 @@ int ...
Feb 24, 3:27 am 2009
Kolbjørn Barmen
PROBLEM: IPv6 autoconf/accept_ra default values
Hello I was tipped by someone at linux-kernel@vger.kernel.org to post this to netdev@vger.kernel.org instead, so here goes... 1. Summary of problem autoconfig and accept_ra is by default on (by the way of forwarning) - this is very problematic in many ways. 2. Full description of the problem/report: * if you want staticly only configured addresses/gateway (which is something you just might want for server machines for example) you need to change the sysctl parameters before the ...
Feb 24, 2:50 am 2009
Daniel Lenders
loan service
I Mr. Daniel Osasu of the Daniel Loan Lending Firm give out loans to serious and minded individuals, I give out loans at 5% interest rate, if interested in applying for a loan from my firm, contact me at dlenders1@live.com. Thanks and God bless you. Management --
Feb 24, 2:09 am 2009
Srivats P
RE: [PATCH] iproute2: Fix no default display of ip4ip6 tunnels
Stephen, Awaiting your response. Regards, Srivats -----Original Message----- From: Srivats P Sent: Friday, February 20, 2009 10:20 AM To: 'Stephen Hemminger' Cc: netdev@vger.kernel.org Subject: RE: [PATCH] iproute2: Fix no default display of ip4ip6 tunnels I guess you meant "mode any" instead of "mode all". And yes, you are right - "mode any" does display all tunnels. However the equivalent INET4 command - "ip tunnel show" displays all tunnels (gre/ipip/sit) irrespective of ...
Feb 24, 1:51 am 2009
Dhananjay Phadke
[PATCH 0/2] netxen: bug fixes
Dave, These are two critical fixes that need to go into net-2.6. Thanks, Dhananjay --
Feb 24, 1:16 am 2009
David Miller
Re: [PATCH 2/2] netxen: handle pci bar 0 mapping failure
From: Dhananjay Phadke <dhananjay@netxen.com> Applied. --
Feb 24, 4:44 am 2009
Dhananjay Phadke
[PATCH 2/2] netxen: handle pci bar 0 mapping failure
PCI bar 0 is used for memory mapped register access. If ioremap fails (returns NULL), register access results in crash. Use pci_ioremap_bar() instead of ioremap(), the latter Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_main.c | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c index f425811..1308778 100644 --- ...
Feb 24, 1:16 am 2009
David Miller
Re: [PATCH 1/2] netxen: fix physical port mapping
From: Dhananjay Phadke <dhananjay@netxen.com> Applied. --
Feb 24, 4:44 am 2009
Dhananjay Phadke
[PATCH 1/2] netxen: fix physical port mapping
The PCI function to physical port mapping is valid only for old firmware. New firmware (4.0.0+) abstracts this. So driver should never try to access phy using invalid mapping. The behavior is unpredictable when PCI functions 4-7 are enabled on the same NIC. Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com> --- drivers/net/netxen/netxen_nic_main.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/netxen/netxen_nic_main.c ...
Feb 24, 1:16 am 2009
Wei Yongjun
[PATCH 2/3] ipip: used time_before for comparing jiffies
The functions time_before is more robust for comparing jiffies against other values. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> --- net/ipv4/ipip.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ipip.c b/net/ipv4/ipip.c index 5079dfb..4b50199 100644 --- a/net/ipv4/ipip.c +++ b/net/ipv4/ipip.c @@ -327,7 +327,7 @@ static int ipip_err(struct sk_buff *skb, u32 info) if (t->parms.iph.ttl == 0 && type == ICMP_TIME_EXCEEDED) goto out; - if ...
Feb 24, 12:54 am 2009
Wei Yongjun
[PATCH 3/3] sit: used time_before for comparing jiffies
The functions time_before is more robust for comparing jiffies against other values. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> --- net/ipv6/sit.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv6/sit.c b/net/ipv6/sit.c index d3467e5..26915ef 100644 --- a/net/ipv6/sit.c +++ b/net/ipv6/sit.c @@ -454,7 +454,7 @@ static int ipip6_err(struct sk_buff *skb, u32 info) if (t->parms.iph.ttl == 0 && type == ICMP_TIME_EXCEEDED) goto out; - if ...
Feb 24, 12:55 am 2009
Wei Yongjun
[PATCH 1/3] gre: used time_before for comparing jiffies
The functions time_before is more robust for comparing jiffies against other values. Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> --- net/ipv4/ip_gre.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/net/ipv4/ip_gre.c b/net/ipv4/ip_gre.c index 0101521..811bef7 100644 --- a/net/ipv4/ip_gre.c +++ b/net/ipv4/ip_gre.c @@ -432,7 +432,7 @@ static void ipgre_err(struct sk_buff *skb, u32 info) if (t->parms.iph.ttl == 0 && type == ICMP_TIME_EXCEEDED) goto ...
Feb 24, 12:54 am 2009
Herbert Xu
Re: [PATCH] ipv6: Remove some pointless conditionals bef ...
Well people will continue to send patches to remove them until they're all gone :) Really this isn't even worth discussing. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 24, 2:55 am 2009
Yang Hongyang Feb 24, 2:54 am 2009
Wei Yongjun
[PATCH] ipv6: Remove some pointless conditionals before ...
Remove some pointless conditionals before kfree_skb(). The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression E; @@ - if (E) - kfree_skb(E); + kfree_skb(E); // </smpl> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com> --- net/ipv6/ipv6_sockglue.c | 3 +-- net/ipv6/tcp_ipv6.c | 6 ++---- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/net/ipv6/ipv6_sockglue.c ...
Feb 24, 12:45 am 2009
Herbert Xu
Re: [PATCH] ipv6: Remove some pointless conditionals bef ...
These checks were specifically added so that callers didn't have to check for NULL. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 24, 2:47 am 2009
Yang Hongyang
Re: [PATCH] ipv6: Remove some pointless conditionals bef ...
I think kfree_skb() suppose that you have handled NULL pointer because it uses `unlikely` to check the pointer. So I don't think these conditions are pointless... 437 void kfree_skb(struct sk_buff *skb) 438 { 439 if (unlikely(!skb)) -- Regards Yang Hongyang --
Feb 24, 2:33 am 2009
David Miller
Re: [PATCH] net: Fix build without CONFIG_NET_NS
From: Benjamin Herrenschmidt <benh@kernel.crashing.org> Yep, sorry about that. commit ebe47d47b7b7fed72dabcce4717da727b4e2367d Author: Clemens Noss <cnoss@gmx.de> Date: Mon Feb 23 15:37:35 2009 -0800 netns: build fix for net_alloc_generic net_alloc_generic was defined in #ifdef CONFIG_NET_NS, but used unconditionally. Move net_alloc_generic out of #ifdef. Signed-off-by: Clemens Noss <cnoss@gmx.de> Signed-off-by: David S. Miller ...
Feb 23, 7:39 pm 2009
Benjamin Herrenschmidt
[PATCH] net: Fix build without CONFIG_NET_NS
Commit 486a87f1e5624096bd1c09e9e716239597d48dca broke build without CONFIG_NET_NS due to calling net_alloc_generic() always while defining it inside an #ifdef CONFIG_NET_NS block. This moves the function definition out of that block. Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- net/core/net_namespace.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux-work.orig/net/core/net_namespace.c 2009-02-24 13:20:42.000000000 +1100 +++ ...
Feb 23, 7:26 pm 2009
Francois Romieu
Re: 2.6.29-rc6: Reported regressions 2.6.27 -> 2.6.28
Rolf Eike Beer <eike-kernel@sf-tec.de> : I am not too hot. #10109 happens with a 8167. We can probably mark as dupe the watchdog timeouts which happen on the same hardware (XID) at boot time though. -- Ueimor --
Feb 24, 4:23 pm 2009
Rolf Eike Beer
Re: 2.6.29-rc6: Reported regressions 2.6.27 -> 2.6.28
=46rancois, would you agree to mark both as dupe of #10109? These problems have been th= ere=20 for a year now, that is nothing new. Eike (shortening CC list)
Feb 24, 9:05 am 2009
Ingo Molnar
Re: 2.6.29-rc6: Reported regressions from 2.6.28
(note, the standalone mail of this bug entry did not make it out for some reason.) Here we came to the conclusion that this is some LILO bug with a too large BSS section - that's one thing that CONFIG_LOCK_STAT causes. Under Grub the same kernel image boots fine. So unless Adam has new data that contradicts this i think we can close this bug. Ingo --
Feb 24, 12:15 am 2009
Greg KH
[PATCH] asix: new device ids
From: Greg Kroah-Hartman <gregkh@suse.de> This patch adds two new device ids to the asix driver. One comes directly from the asix driver on their web site, the other was reported by Armani Liao as needed for the MSI X320 to get the driver to work properly for it. Reported-by: Armani Liao <aliao@novell.com> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> --- drivers/net/usb/asix.c | 8 ++++++++ 1 file changed, 8 insertions(+) --- ...
Feb 23, 5:08 pm 2009
Ira Snyder
[RFC v2] virtio: add virtio-over-PCI driver
This adds support to Linux for using virtio between two computers linked by a PCI interface. This allows the use of virtio_net to create a familiar, fast interface for communication. It should be possible to use other virtio devices in the future, but this has not been tested. I have implemented guest support for the Freescale MPC8349EMDS board, which is capable of running in PCI agent mode (It acts like a PCI card, but is a complete computer system, running Linux). The driver is trivial to port ...
Feb 23, 5:00 pm 2009
Johannes Berg
Re: pull request: wireless-next-2.6 2009-02-23
Hold off on this please, the genetlink patch here introduced a problem with locking and I'm going to rework/fix that. johannes
Feb 23, 11:31 pm 2009
Herbert Xu
Re: VM_BUG_ON triggered with udp6fuzz
It's a weird crash. The stuff that we do with sk_sndmsg_page on the UDP path is nonstandard to say the least. However, it does look kosher. So please let us know if you can reproduce this again. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 24, 12:12 am 2009
Helmut Schaa Feb 24, 12:36 am 2009
Helmut Schaa
Re: [Ipw2100-devel] ipw2100: race between isr_indicate_a ...
Am Dienstag, 24. Februar 2009 schrieb Zhu Yi: Right. But for example when a connection cannot be established by ipw2100 it will call netif_carrier_off on disassociation which in turn leads to a call to dev_deavtivate. Hence, it is possible that a noop_qdisc is Maybe, but I can imagine a similar race when using a wired 802.1x secured network. The switch might send an EAP-request very quickly after the carrier Exactly. [...] Helmut --
Feb 24, 5:15 am 2009
Zhu Yi
Re: [Ipw2100-devel] ipw2100: race between isr_indicate_a ...
[ remove ipw2100-devel and cc linux-wireless ] Thanks for the analysis. Are you sure noop_qdisc is still used when we are about to netif_carrier_on() after receiving the association success response? From dev_open(), dev_activate() is called after netdev->open. So the txq->qdisc_sleeping should be already replaced with pfifo_fast. But the state is still DEACTIVATED. Should the packet from I think making a sync version of netif_carrier_on/activate_dev should be the way to go. This could be a ...
Feb 23, 8:34 pm 2009
Dhananjay Phadke
RE: [PATCH NEXT 1/5] netxen: fix physical port mapping
Dave, Please hold off this 5 patch series. I have two critical bug fixes that take priority and will probably clash the pci probe re-factoring patch. Thanks, -Dhananjay ________________________________________ From: Dhananjay Phadke [dhananjay@netxen.com] Sent: Sunday, February 22, 2009 11:42 PM To: netdev@vger.kernel.org Cc: davem@davemloft.net Subject: [PATCH NEXT 1/5] netxen: fix physical port mapping The PCI function to physical port mapping is valid only for old firmware. New ...
Feb 24, 1:13 am 2009
David Miller
Re: [PATCH NEXT 1/5] netxen: fix physical port mapping
From: Dhananjay Phadke <dhananjay@netxen.com> Ok, I tossed them. I've pulled net-2.6 into net-next-2.6 so you should be able to respin your patches on top of the bug fixes using that. Thanks. --
Feb 24, 5:20 am 2009
Herbert Xu
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
Have you thought by using the rtnl_link_ops interface instead of your own netlink API? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 23, 11:39 pm 2009
James Chapman
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
I did, yes. I decided against it only because I didn't want to cause confusion with what I perhaps wrongly perceive as an API for managing net devices. In the L2TPv3 case, there might not be a netdev directly associated with a newlink API call, for example. I've no problem with switching the code to use it if it is preferred. -- James Chapman Katalix Systems Ltd http://www.katalix.com Catalysts for your Embedded Linux software development --
Feb 24, 2:17 am 2009
Herbert Xu
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
Fair enough, just making sure that it was considered at least :) -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 24, 2:45 am 2009
James Chapman
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
Sure. Userspace needs to create, delete, modify and query L2TP tunnel and session contexts in the kernel. Tunnels are associated with a tunnel socket (UDP or L2TPIP) and can carry multiple sessions. Session contexts differ according to type; they are associated with a pppol2tp socket and implicit ppp netdev in the case of PPP pseudowires, or an ethernet netdev in the case of ethernet pseudowires. Other pseudowires may be added in the future for ATM, Frame Relay etc. In the existing L2TPv2 ...
Feb 24, 2:55 am 2009
Patrick McHardy
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
rtnl_link really doesn't seem to be the best fit for this. It *could* be used for PPP device management, but since a userspace Yes, thanks a lot. --
Feb 24, 3:00 am 2009
Patrick McHardy
Re: [RFC PATCH 0/8] l2tp: introduce L2TPv3 support
From a quick look, it seems you're (also) managing sessions, for which rtnl_link might not be the best choice. Could you give a short overview of the operations you need to be able to perform? --
Feb 24, 2:24 am 2009
David Miller
Re: [PATCH 1/3] Doc: Fix typos in ip-sysctl.txt about rp ...
From: Jesper Dangaard Brouer <jdb@comx.dk> Applied. --
Feb 24, 4:48 am 2009
David Miller
Re: [PATCH 3/3] Doc: Refer to ip-sysctl.txt for strict v ...
From: Jesper Dangaard Brouer <jdb@comx.dk> Also applied, thanks a lot Jesper. --
Feb 24, 4:48 am 2009
David Miller
Re: [PATCH 2/3] Doc: Cleanup whitespaces in ip-sysctl.txt
From: Jesper Dangaard Brouer <jdb@comx.dk> Applied. --
Feb 24, 4:48 am 2009
David Miller
Re: [PATCH 1/3] gre: used time_before for comparing jiffies
From: Herbert Xu <herbert@gondor.apana.org.au> Indeed, I think my original objections have been cleared up after some research. --
Feb 24, 12:41 am 2009
Herbert Xu
Re: [PATCH 1/3] gre: used time_before for comparing jiffies
Please resubmit these patches so that they can be reviewed again. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 24, 12:13 am 2009
Patrick McHardy
Re: [PATCH 3/8] can: CAN Network device driver and SYSFS ...
You could consider triggering the restart automatically, similar to the netdev watchdog. In fact, you could simply use that one. If you really want to trigger this from userspace, setting the device DOWN and UP again seems like the most appropriate way to I don't know the CAN specifics. One goal of the rtnl_link API was to reduce to amount of userspace tools for link configuration though, so please only create a new tool if there's really a good reason. From my POV it would be preferrable to ...
Feb 24, 2:38 am 2009
Wolfgang Grandegger
Re: [PATCH 3/8] can: CAN Network device driver and SYSFS ...
Automatic restart is already support by this patch series but we do not use the watchdog, because it would trigger on normal transmit timeouts as well. But maybe we can suppress them by fiddling with the watchdog's OK, it also depends on what we would like the tool finally to perform, apart from setting and getting device properties. On idea is to move the rather heavy calculation of bit-timing parameters out of the kernel to the user-space configuration tool. Wolfgang. --
Feb 24, 9:29 am 2009
Lennart Sorensen
Re: Why linux keeps connected routes when link goes down
I did run 0.99something on my first linux system, so I remember the transition happening at some point. I remember distribution's network scripts creating routes after assigning the IP to an interface. I don't remember how long ago that was though. Now it had nothing to do with link state, it was simply a matter that setting an ip and netmask on an interface did not create a route the way newer kernels have done (where newer probably covers most years of linux kernels). All route ...
Feb 24, 11:52 am 2009
Patrick McHardy
Re: [PATCH] iptables: xt_hashlimit fix
Indeed. This is unfortunately necessary in some cases to make sure that modules using global state actually use global state instead This seems fine in case of hashlimit since it the match data is read-only. In case of statistic and quota I think we still Applied, thanks. --
Feb 24, 7:31 am 2009
Jeff Chua
Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 brea ...
Uh, I got it wrong. Didn't look into details. Just noticed that tcp_output.c was changed today, so I just assume that was the one ... which turned out to a one-liner comment removed. Anyway, I just tested the Herbert's patch and it looks good. rlogin not hanging. Sorry for the earlier fault report. Thanks Jeff. --
Feb 24, 1:01 am 2009
Herbert Xu
Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 brea ...
Are you sure? It's not in my copy of rc6 :) net-next-2.6 is for the release after the current one so the earliest you're going to see this is in 2.6.30. For now you'll either need to pull net-next-2.6 directly, use linux-next, or apply the patch by hand. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 23, 11:44 pm 2009
David Miller
Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 brea ...
From: Jeff Chua <jeff.chua.linux@gmail.com> Actually, it isn't. Herbert's change is in net-next-2.6 which will show up in linux-next rather than Linus's 2.6.29-rcX tree. --
Feb 23, 11:46 pm 2009
Jeff Chua
Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 brea ...
I see that this is already in linux-2.6.29-rc6. Tested and working fine. Thanks, Jeff. --
Feb 23, 11:40 pm 2009
Paul Moore
xfrm selector generating IKE
Do you know which version of *swan generates xfrm selectors when it does an SA ADD or UPDATE. I downloaded openswan 2.6.19 and it does not -----Original Message----- From: Herbert Xu [mailto:herbert@gondor.apana.org.au] Sent: Thursday, January 29, 2009 10:31 PM To: Paul Moore Cc: kaber@trash.net; davem@davemloft.net; netdev@vger.kernel.org Subject: Re: port bound SAs Either fix racoon to use xfrm or go with a properly maintained key manager like one of the *swans. Cheers, -- ...
Feb 23, 6:31 pm 2009
Herbert Xu
Re: xfrm selector generating IKE
The selector logic doesn't work very well with nested tunnels which is why I didn't use it for the original Openswan port. We rely on the policy selector instead to do the job. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Feb 23, 7:08 pm 2009
Paul Moore
RE: xfrm selector generating IKE
are you sure that works. the xfrm code in the kernel does not look at the policy selector when checking port numbers to see if it should reuse an existing SA. It only looks at the selector on the SA - this is why racoon has a problem. The policy selector has the correct portness in it but the SA does not. I have not tested it but I suspect openswan has the same issue since it passes in an empty SA selector -----Original Message----- From: Herbert Xu [mailto:herbert@gondor.apana.org.au] ...
Feb 24, 10:23 am 2009
previous daytodaynext day
February 23, 2009February 24, 2009February 25, 2009