Re: LRO restructuring?

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: James Huang
Date: Thursday, February 19, 2009 - 3:20 pm

Hi all,
 
    One question about inet_lro.c (linux 2.6.28.6)
In lro_proc_segment(), it does not check the number of available frags entries 
in lro_desc->parent against the number of new fragments to be added before 
calling lro_add_frags().  Is that a bug?  I see that lro_proc_segment() does 
some type of checking at the end, but could that be too late (i.e. overflow 
the frags[])??
 
    Also I think some obvious optimization in lro_get_desc() can be done by 
combining the two for loops into one.
 
-- James Huang




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: LRO restructuring?, James Huang, (Thu Feb 19, 3:20 pm)