Home » Mailing list archives » linux-netdev » 2009 » February » 14

Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: fix signedness

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Cyrill Gorcunov
Subject: Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: fix signedness
Date: Saturday, February 14, 2009 - 2:38 pm

[Cyrill Gorcunov - Sun, Feb 15, 2009 at 12:29:48AM +0300]
| [Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100]
| | Fix this sparse warnings:
| |   drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness)
| |   drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness)
| |   drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness)
| | 
| | Signed-off-by: Hannes Eder <hannes@hanneseder.net>
| ...
| 
| Thanks Hannes,
| 
| Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
| 
| 	- Cyrill -

Btw I think the same fix could be applied on
drivers/net/tun.c (if you have time for :)

	- Cyrill -
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/43] drivers/net: fix (sparse) warnings, Hannes Eder, (Sat Feb 14, 2:11 pm)
[PATCH 01/43] drivers/net/at1700.c: fix sparse warning: sy ..., Hannes Eder, (Sat Feb 14, 2:11 pm)
[PATCH 02/43] drivers/net/e2100.c: fix sparse warning: sym ..., Hannes Eder, (Sat Feb 14, 2:12 pm)
[PATCH 03/43] drivers/net/ni65.c: fix sparse warnings: sym ..., Hannes Eder, (Sat Feb 14, 2:12 pm)
[PATCH 04/43] drivers/net/ns83820.c: fix sparse warnings: ..., Hannes Eder, (Sat Feb 14, 2:12 pm)
[PATCH 05/43] drivers/net/niu.c: fix sparse warning: symbo ..., Hannes Eder, (Sat Feb 14, 2:12 pm)
[PATCH 06/43] drivers/net/lance.c: fix sparse warnings: fi ..., Hannes Eder, (Sat Feb 14, 2:13 pm)
[PATCH 07/43] drivers/net/ni65.c: fix sparse warnings: fix ..., Hannes Eder, (Sat Feb 14, 2:13 pm)
[PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: fix ..., Hannes Eder, (Sat Feb 14, 2:13 pm)
[PATCH 09/43] drivers/net/r6040.c: fix sparse warning: Usi ..., Hannes Eder, (Sat Feb 14, 2:14 pm)
[PATCH 10/43] drivers/net/s2io.c: fix sparse warning: symb ..., Hannes Eder, (Sat Feb 14, 2:14 pm)
[PATCH 11/43] drivers/net/arcnet: fix sparse warning: symb ..., Hannes Eder, (Sat Feb 14, 2:14 pm)
[PATCH 12/43] drivers/net/atl1e: fix sparse warnings: fix ..., Hannes Eder, (Sat Feb 14, 2:14 pm)
[PATCH 13/43] drivers/net/atlx: fix sparse warnings: fix s ..., Hannes Eder, (Sat Feb 14, 2:15 pm)
[PATCH 14/43] drivers/net/bonding: fix sparse warnings: co ..., Hannes Eder, (Sat Feb 14, 2:15 pm)
[PATCH 15/43] drivers/net/bonding: fix sparse warning: sym ..., Hannes Eder, (Sat Feb 14, 2:15 pm)
[PATCH 16/43] drivers/net/cxgb3: fix sparse warning: symbo ..., Hannes Eder, (Sat Feb 14, 2:16 pm)
[PATCH 17/43] drivers/net/cxgb3: fix sparse warnings: fix ..., Hannes Eder, (Sat Feb 14, 2:16 pm)
Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: ..., Cyrill Gorcunov, (Sat Feb 14, 2:29 pm)
[PATCH 18/43] drivers/net/e1000e: fix sparse warning: Shou ..., Hannes Eder, (Sat Feb 14, 2:32 pm)
[PATCH 19/43] drivers/net/hamradio: fix warning: format no ..., Hannes Eder, (Sat Feb 14, 2:33 pm)
[PATCH 20/43] drivers/net/hamradio: fix sparse warning: co ..., Hannes Eder, (Sat Feb 14, 2:34 pm)
[PATCH 21/43] drivers/net/hamradio: fix sparse warning: sy ..., Hannes Eder, (Sat Feb 14, 2:35 pm)
[PATCH 22/43] drivers/net/hamradio: fix sparse warnings: f ..., Hannes Eder, (Sat Feb 14, 2:36 pm)
[PATCH 23/43] drivers/net/igb: fix sparse warning: symbol ..., Hannes Eder, (Sat Feb 14, 2:38 pm)
[PATCH 24/43] drivers/net/ixgbe: fix sparse warning: Shoul ..., Hannes Eder, (Sat Feb 14, 2:38 pm)
Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: ..., Cyrill Gorcunov, (Sat Feb 14, 2:38 pm)
[PATCH 25/43] drivers/net/pcmcia: fix warning: format not ..., Hannes Eder, (Sat Feb 14, 2:39 pm)
[PATCH 26/43] drivers/net/sfc: fix sparse warning: symbol ..., Hannes Eder, (Sat Feb 14, 2:41 pm)
[PATCH 27/43] drivers/net/sfc: fix sparse warnings: Should ..., Hannes Eder, (Sat Feb 14, 2:42 pm)
[PATCH 28/43] drivers/net/skfp: fix sparse warning: Should ..., Hannes Eder, (Sat Feb 14, 2:43 pm)
[PATCH 29/43] drivers/net/tokenring: fix warning: format n ..., Hannes Eder, (Sat Feb 14, 2:44 pm)
[PATCH 30/43] drivers/net/tokenring: fix sparse warning: s ..., Hannes Eder, (Sat Feb 14, 2:44 pm)
[PATCH 31/43] drivers/net/tokenring: fix sparse warning: c ..., Hannes Eder, (Sat Feb 14, 2:46 pm)
[PATCH 32/43] drivers/net/tulip: fix warning: format not a ..., Hannes Eder, (Sat Feb 14, 2:46 pm)
[PATCH 33/43] drivers/net/tulip: fix sparse warning: symbo ..., Hannes Eder, (Sat Feb 14, 2:47 pm)
[PATCH 34/43] drivers/net/usb: fix sparse warnings: Should ..., Hannes Eder, (Sat Feb 14, 2:47 pm)
[PATCH 35/43] drivers/net/wan: fix warning: format not a s ..., Hannes Eder, (Sat Feb 14, 2:48 pm)
[PATCH 36/43] drivers/net/wan: fix sparse warning: symbol ..., Hannes Eder, (Sat Feb 14, 2:48 pm)
[PATCH 37/43] drivers/net/wireless: fix sparse warning: co ..., Hannes Eder, (Sat Feb 14, 2:48 pm)
[PATCH 38/43] drivers/net/wireless: fix sparse warnings: s ..., Hannes Eder, (Sat Feb 14, 2:49 pm)
[PATCH 39/43] drivers/net/wireless: fix sparse warnings: f ..., Hannes Eder, (Sat Feb 14, 2:49 pm)
[PATCH 40/43] drivers/net/wireless/ath9k: fix sparse warni ..., Hannes Eder, (Sat Feb 14, 2:49 pm)
[PATCH 41/43] drivers/net/wireless/b43: fix warning: forma ..., Hannes Eder, (Sat Feb 14, 2:50 pm)
[PATCH 42/43] drivers/net/wireless/ipw2x00: fix sparse war ..., Hannes Eder, (Sat Feb 14, 2:50 pm)
[PATCH 43/43] drivers/net/wireless/prism54: fix sparse war ..., Hannes Eder, (Sat Feb 14, 2:50 pm)
Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: ..., Hannes Eder, (Sat Feb 14, 2:57 pm)
Re: [PATCH 31/43] drivers/net/tokenring: fix sparse warnin ..., Al Viro, (Sat Feb 14, 4:24 pm)
Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: ..., Cyrill Gorcunov, (Sun Feb 15, 1:08 am)
Re: [PATCH 31/43] drivers/net/tokenring: fix sparse warnin ..., Hannes Eder, (Sun Feb 15, 4:47 am)
[PATCH 31/43 v2] drivers/net/tokenring: fix sparse warning ..., Hannes Eder, (Sun Feb 15, 5:13 am)
Re: [PATCH 09/43] drivers/net/r6040.c: fix sparse warning: ..., Florian Fainelli, (Sun Feb 15, 7:00 am)
Re: [PATCH 02/43] drivers/net/e2100.c: fix sparse warning: ..., walter harms, (Sun Feb 15, 7:04 am)
Re: [PATCH 16/43] drivers/net/cxgb3: fix sparse warning: s ..., walter harms, (Sun Feb 15, 7:14 am)
Re: [PATCH 02/43] drivers/net/e2100.c: fix sparse warning: ..., Hannes Eder, (Sun Feb 15, 12:57 pm)
Re: [PATCH 16/43] drivers/net/cxgb3: fix sparse warning: s ..., Hannes Eder, (Sun Feb 15, 1:10 pm)
Re: [PATCH 16/43] drivers/net/cxgb3: fix sparse warning: s ..., Divy Le Ray, (Sun Feb 15, 2:30 pm)
Re: [PATCH 17/43] drivers/net/cxgb3: fix sparse warnings: ..., Divy Le Ray, (Sun Feb 15, 2:32 pm)
Re: [PATCH 27/43] drivers/net/sfc: fix sparse warnings: Sh ..., Ben Hutchings, (Sun Feb 15, 5:37 pm)
Re: [PATCH 26/43] drivers/net/sfc: fix sparse warning: sym ..., Ben Hutchings, (Sun Feb 15, 5:38 pm)
Re: [PATCH 13/43] drivers/net/atlx: fix sparse warnings: f ..., Jay Cliburn, (Sun Feb 15, 7:20 pm)
Re: [PATCH 24/43] drivers/net/ixgbe: fix sparse warning: S ..., Waskiewicz Jr, Peter P, (Sun Feb 15, 11:48 pm)
Re: [PATCH 27/43] drivers/net/sfc: fix sparse warnings: Sh ..., Hannes Eder, (Mon Feb 16, 2:38 am)
[PATCH] drivers/net/sfc: fix sparse warnings: Should it be ..., Hannes Eder, (Mon Feb 16, 2:54 am)
Re: [PATCH 02/43] drivers/net/e2100.c: fix sparse warning: ..., walter harms, (Mon Feb 16, 2:58 am)
Re: [PATCH 31/43 v2] drivers/net/tokenring: fix sparse war ..., Hannes Eder, (Mon Feb 16, 10:29 am)
Re: [PATCH 01/43] drivers/net/at1700.c: fix sparse warning ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 02/43] drivers/net/e2100.c: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 03/43] drivers/net/ni65.c: fix sparse warnings: ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 04/43] drivers/net/ns83820.c: fix sparse warnin ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 05/43] drivers/net/niu.c: fix sparse warning: s ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 06/43] drivers/net/lance.c: fix sparse warnings ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 07/43] drivers/net/ni65.c: fix sparse warnings: ..., David Miller, (Tue Feb 17, 6:21 pm)
Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: ..., David Miller, (Tue Feb 17, 6:22 pm)
Re: [PATCH 09/43] drivers/net/r6040.c: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:22 pm)
Re: [PATCH 10/43] drivers/net/s2io.c: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:22 pm)
Re: [PATCH 10/43] drivers/net/s2io.c: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:26 pm)
Re: [PATCH 11/43] drivers/net/arcnet: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:26 pm)
Re: [PATCH 12/43] drivers/net/atl1e: fix sparse warnings: ..., David Miller, (Tue Feb 17, 6:26 pm)
Re: [PATCH 13/43] drivers/net/atlx: fix sparse warnings: f ..., David Miller, (Tue Feb 17, 6:26 pm)
Re: [PATCH 14/43] drivers/net/bonding: fix sparse warnings ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 15/43] drivers/net/bonding: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 16/43] drivers/net/cxgb3: fix sparse warning: s ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 17/43] drivers/net/cxgb3: fix sparse warnings: ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 18/43] drivers/net/e1000e: fix sparse warning: ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 19/43] drivers/net/hamradio: fix warning: forma ..., David Miller, (Tue Feb 17, 6:27 pm)
Re: [PATCH 20/43] drivers/net/hamradio: fix sparse warning ..., David Miller, (Tue Feb 17, 6:38 pm)
Re: [PATCH 21/43] drivers/net/hamradio: fix sparse warning ..., David Miller, (Tue Feb 17, 6:38 pm)
Re: [PATCH 22/43] drivers/net/hamradio: fix sparse warning ..., David Miller, (Tue Feb 17, 6:38 pm)
Re: [PATCH 23/43] drivers/net/igb: fix sparse warning: sym ..., David Miller, (Tue Feb 17, 6:39 pm)
Re: [PATCH 24/43] drivers/net/ixgbe: fix sparse warning: S ..., David Miller, (Tue Feb 17, 6:39 pm)
Re: [PATCH 25/43] drivers/net/pcmcia: fix warning: format ..., David Miller, (Tue Feb 17, 6:39 pm)
Re: [PATCH 26/43] drivers/net/sfc: fix sparse warning: sym ..., David Miller, (Tue Feb 17, 6:39 pm)
Re: [PATCH 27/43] drivers/net/sfc: fix sparse warnings: Sh ..., David Miller, (Tue Feb 17, 6:39 pm)
Re: [PATCH 28/43] drivers/net/skfp: fix sparse warning: Sh ..., David Miller, (Tue Feb 17, 6:40 pm)
Re: [PATCH 29/43] drivers/net/tokenring: fix warning: form ..., David Miller, (Tue Feb 17, 6:40 pm)
Re: [PATCH 30/43] drivers/net/tokenring: fix sparse warnin ..., David Miller, (Tue Feb 17, 6:41 pm)
Re: [PATCH 32/43] drivers/net/tulip: fix warning: format n ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 33/43] drivers/net/tulip: fix sparse warning: s ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 34/43] drivers/net/usb: fix sparse warnings: Sh ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 35/43] drivers/net/wan: fix warning: format not ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 36/43] drivers/net/wan: fix sparse warning: sym ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 37/43] drivers/net/wireless: fix sparse warning ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 38/43] drivers/net/wireless: fix sparse warning ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 39/43] drivers/net/wireless: fix sparse warning ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 40/43] drivers/net/wireless/ath9k: fix sparse w ..., David Miller, (Tue Feb 17, 8:35 pm)
Re: [PATCH 41/43] drivers/net/wireless/b43: fix warning: f ..., David Miller, (Tue Feb 17, 8:49 pm)
Re: [PATCH 42/43] drivers/net/wireless/ipw2x00: fix sparse ..., David Miller, (Tue Feb 17, 8:49 pm)
Re: [PATCH 43/43] drivers/net/wireless/prism54: fix sparse ..., David Miller, (Tue Feb 17, 8:49 pm)
Re: [PATCH 31/43 v2] drivers/net/tokenring: fix sparse war ..., David Miller, (Tue Feb 17, 8:49 pm)
[PATCH 23/43 v2] drivers/net/igb: fix sparse warning: symb ..., Hannes Eder, (Wed Feb 18, 2:49 pm)
Re: [PATCH] drivers/net/sfc: fix sparse warnings: Should i ..., David Miller, (Wed Feb 18, 6:49 pm)
Re: [PATCH 23/43 v2] drivers/net/igb: fix sparse warning: ..., David Miller, (Wed Feb 18, 8:36 pm)