Re: [net-next-2.6 PATCH v9 2/2] TCPCT part 1i: remove old tcp_optlen() function

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: William Allen Simpson
Date: Thursday, December 3, 2009 - 4:54 pm

In the only two existing files using the old tcp_optlen() function,
clean up confusing and inconsistent mixing of both byte and word
offsets.  Document assumptions.  David Miller's review sayeth:

    This is transmit, and the packets can only come from the Linux
    TCP stack, not some external entity.

Untested.  No response from testers in 6+ weeks.

Signed-off-by: William.Allen.Simpson@gmail.com
CC: Michael Chan <mchan@broadcom.com>
---
  drivers/net/bnx2.c  |   22 +++++++++++++---------
  drivers/net/tg3.c   |   51 +++++++++++++++++++++++----------------------------
  include/linux/tcp.h |    5 -----
  3 files changed, 36 insertions(+), 42 deletions(-)
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[net-next-2.6 PATCH v9 0/2] TCPCT part 1: cleanup, William Allen Simpson, (Thu Dec 3, 4:30 pm)
Re: [net-next-2.6 PATCH v9 0/2] TCPCT part 1h: accept SYNA ..., William Allen Simpson, (Thu Dec 3, 4:40 pm)
Re: [net-next-2.6 PATCH v9 2/2] TCPCT part 1i: remove old ..., William Allen Simpson, (Thu Dec 3, 4:54 pm)
Re: [net-next-2.6 PATCH v9 2/2] TCPCT part 1i: remove old ..., William Allen Simpson, (Fri Dec 4, 5:06 am)