Re: [PATCH 1/1] Defer skb allocation for both mergeable buffers and big packets in virtio_net

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rusty Russell
Date: Tuesday, November 24, 2009 - 5:15 pm

On Wed, 25 Nov 2009 01:06:32 am Anthony Liguori wrote:

Agreed, we can't "fix" it in the guests, but it's a wart.  That's why I
haven't bothered fixing it, but if someone else wants to I'll cheer all the
way.

lguest did it because I knew I could fix lguest any time; it was a bad mistake
and I will now fix lguest :)


I don't think it's worth it.  But the spec does say that the implementation
should not rely on the framing (I think there's a note that current
implementations are buggy tho, so you should frame it separately anyway).

That way future devices can get it right, at least.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Mon Nov 23, 2:43 am)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Tue Nov 24, 4:37 am)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Tue Nov 24, 9:04 am)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Tue Nov 24, 9:04 am)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Rusty Russell, (Tue Nov 24, 5:15 pm)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Wed Nov 25, 2:15 am)
Re: [PATCH 1/1] Defer skb allocation for both mergeable bu ..., Michael S. Tsirkin, (Wed Nov 25, 4:40 am)