Home » Mailing list archives » linux-netdev » 2009 » November » 11

[PATCH 4/6] gianfar: Fix thinko in gfar_set_rx_stash_index()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Anton Vorontsov
Subject: [PATCH 4/6] gianfar: Fix thinko in gfar_set_rx_stash_index()
Date: Tuesday, November 10, 2009 - 5:11 pm

We obviously want to write a modified 'temp' value back to the
register, not the saved IRQ flags.

Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com>
---
 drivers/net/gianfar_sysfs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/gianfar_sysfs.c b/drivers/net/gianfar_sysfs.c
index 3724835..b31c9c8 100644
--- a/drivers/net/gianfar_sysfs.c
+++ b/drivers/net/gianfar_sysfs.c
@@ -186,7 +186,7 @@ static ssize_t gfar_set_rx_stash_index(struct device *dev,
 	temp = gfar_read(&regs->attreli);
 	temp &= ~ATTRELI_EI_MASK;
 	temp |= ATTRELI_EI(index);
-	gfar_write(&regs->attreli, flags);
+	gfar_write(&regs->attreli, temp);
 
 out:
 	unlock_rx_qs(priv);
-- 
1.6.3.3

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 0/6] gianfar: Some fixes, Anton Vorontsov, (Tue Nov 10, 5:10 pm)
[PATCH 1/6] skbuff: Do not allow skb recycling with disabl ..., Anton Vorontsov, (Tue Nov 10, 5:11 pm)
[PATCH 2/6] gianfar: Remove 'Interrupt problem!' warning, Anton Vorontsov, (Tue Nov 10, 5:11 pm)
[PATCH 3/6] gianfar: Fix build with CONFIG_PM=y, Anton Vorontsov, (Tue Nov 10, 5:11 pm)
[PATCH 4/6] gianfar: Fix thinko in gfar_set_rx_stash_index(), Anton Vorontsov, (Tue Nov 10, 5:11 pm)
[PATCH 5/6] gianfar: Fix race between gfar_error() and gfa ..., Anton Vorontsov, (Tue Nov 10, 5:11 pm)
[PATCH 6/6] gianfar: Revive SKB recycling, Anton Vorontsov, (Tue Nov 10, 5:11 pm)
RE: [PATCH 6/6] gianfar: Revive SKB recycling, Kumar Gopalpet-B05799, (Tue Nov 10, 9:20 pm)
RE: [PATCH 3/6] gianfar: Fix build with CONFIG_PM=y, Kumar Gopalpet-B05799, (Tue Nov 10, 9:27 pm)
Re: [PATCH 0/6] gianfar: Some fixes, Kumar Gala, (Wed Nov 11, 8:16 am)
Re: [PATCH 0/6] gianfar: Some fixes, David Miller, (Wed Nov 11, 8:04 pm)