Home » Mailing list archives » linux-netdev » 2009 » November » 10

[PATCH 03/10] net: use rcu for network scheduler API

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Stephen Hemminger
Subject: [PATCH 03/10] net: use rcu for network scheduler API
Date: Tuesday, November 10, 2009 - 10:54 am

Use RCU to walk list of network devices in qdisc dump.
This could be optimized for large number of devices.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/sched/sch_api.c	2009-11-09 22:19:09.002480816 -0800
+++ b/net/sched/sch_api.c	2009-11-10 09:28:38.166439067 -0800
@@ -1279,9 +1279,10 @@ static int tc_dump_qdisc(struct sk_buff 
 
 	s_idx = cb->args[0];
 	s_q_idx = q_idx = cb->args[1];
-	read_lock(&dev_base_lock);
+
+	rcu_read_lock();
 	idx = 0;
-	for_each_netdev(&init_net, dev) {
+	for_each_netdev_rcu(&init_net, dev) {
 		struct netdev_queue *dev_queue;
 
 		if (idx < s_idx)
@@ -1302,7 +1303,7 @@ cont:
 	}
 
 done:
-	read_unlock(&dev_base_lock);
+	rcu_read_unlock();
 
 	cb->args[0] = idx;
 	cb->args[1] = q_idx;

-- 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_lock) ..., Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 01/10] netdev: add netdev_continue_rcu, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 02/10] vlan: eliminate use of dev_base_lock, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 03/10] net: use rcu for network scheduler API, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 05/10] parisc: use RCU to find network device, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 06/10] s390: use RCU to walk list of network devices, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 07/10] decnet: use RCU to find network devices, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 08/10] ipv6: use RCU to walk list of network devices, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 09/10] IPV4: use rcu to walk list of devices in IGMP, Stephen Hemminger, (Tue Nov 10, 10:54 am)
[PATCH 10/10] CAN: use dev_get_by_index_rcu, Stephen Hemminger, (Tue Nov 10, 10:54 am)
Re: [PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_l ..., Eric Dumazet, (Tue Nov 10, 11:18 am)
Re: [PATCH 01/10] netdev: add netdev_continue_rcu, Eric Dumazet, (Tue Nov 10, 11:19 am)
Re: [PATCH 02/10] vlan: eliminate use of dev_base_lock, Eric Dumazet, (Tue Nov 10, 11:20 am)
Re: [PATCH 03/10] net: use rcu for network scheduler API, Eric Dumazet, (Tue Nov 10, 11:20 am)
Re: [PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_l ..., Stephen Hemminger, (Tue Nov 10, 11:22 am)
Re: [PATCH 04/10] AOE: use rcu to find network device, Eric Dumazet, (Tue Nov 10, 11:23 am)
Re: [PATCH 07/10] decnet: use RCU to find network devices, steve, (Tue Nov 10, 11:24 am)
Re: [PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_l ..., Stephen Hemminger, (Tue Nov 10, 11:24 am)
Re: [PATCH 05/10] parisc: use RCU to find network device, Eric Dumazet, (Tue Nov 10, 11:26 am)
Re: [PATCH 06/10] s390: use RCU to walk list of network de ..., Eric Dumazet, (Tue Nov 10, 11:27 am)
Re: [PATCH 06/10] s390: use RCU to walk list of network de ..., Stephen Hemminger, (Tue Nov 10, 11:29 am)
Re: [PATCH 10/10] CAN: use dev_get_by_index_rcu, Eric Dumazet, (Tue Nov 10, 11:34 am)
Re: [PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_l ..., Eric Dumazet, (Tue Nov 10, 11:39 am)
Re: [PATCH 06/10] s390: use RCU to walk list of network de ..., Eric Dumazet, (Tue Nov 10, 11:40 am)
Re: [PATCH 07/10] decnet: use RCU to find network devices, Eric Dumazet, (Tue Nov 10, 11:43 am)
Re: [PATCH 09/10] IPV4: use rcu to walk list of devices in ..., Eric Dumazet, (Tue Nov 10, 11:47 am)
Re: [PATCH 07/10] decnet: use RCU to find network devices, Stephen Hemminger, (Tue Nov 10, 11:50 am)
Re: [PATCH 00/10] netdev: get rid of read_lock(&amp;dev_base_l ..., Stephen Hemminger, (Tue Nov 10, 11:53 am)
Re: [PATCH 07/10] decnet: use RCU to find network devices, Eric Dumazet, (Tue Nov 10, 12:25 pm)
Re: [PATCH 01/10] netdev: add netdev_continue_rcu, Paul E. McKenney, (Tue Nov 10, 12:39 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Tue Nov 10, 1:01 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Tue Nov 10, 4:06 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Tue Nov 10, 4:53 pm)
Re: [PATCH 10/10] CAN: use dev_get_by_index_rcu, Oliver Hartkopp, (Tue Nov 10, 10:54 pm)
Re: [PATCH 01/10] netdev: add netdev_continue_rcu, David Miller, (Tue Nov 10, 11:47 pm)
Re: [PATCH 02/10] vlan: eliminate use of dev_base_lock, David Miller, (Tue Nov 10, 11:47 pm)
Re: [PATCH 03/10] net: use rcu for network scheduler API, David Miller, (Tue Nov 10, 11:47 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, David Miller, (Tue Nov 10, 11:48 pm)
Re: [PATCH 05/10] parisc: use RCU to find network device, David Miller, (Tue Nov 10, 11:48 pm)
Re: [PATCH 06/10] s390: use RCU to walk list of network de ..., David Miller, (Tue Nov 10, 11:49 pm)
Re: [PATCH 07/10] decnet: use RCU to find network devices, David Miller, (Tue Nov 10, 11:49 pm)
Re: [PATCH 08/10] ipv6: use RCU to walk list of network de ..., David Miller, (Tue Nov 10, 11:50 pm)
Re: [PATCH 09/10] IPV4: use rcu to walk list of devices in ..., David Miller, (Tue Nov 10, 11:50 pm)
Re: [PATCH 10/10] CAN: use dev_get_by_index_rcu, David Miller, (Tue Nov 10, 11:50 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Wed Nov 11, 7:22 am)
[PATCH 1/2] decnet: add RTNL lock when reading address list, Stephen Hemminger, (Wed Nov 11, 10:39 am)
[PATCH 2/2] decnet: convert dndev_lock to spinlock, Stephen Hemminger, (Wed Nov 11, 10:40 am)
[PATCH net-next-2.6] ipv6: use RCU to walk list of network ..., Eric Dumazet, (Wed Nov 11, 8:34 pm)
Re: [PATCH 1/2] decnet: add RTNL lock when reading address ..., David Miller, (Wed Nov 11, 8:56 pm)
Re: [PATCH 2/2] decnet: convert dndev_lock to spinlock, David Miller, (Wed Nov 11, 8:56 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Thu Nov 12, 7:33 am)
Re: [PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Thu Nov 12, 10:10 am)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Thu Nov 12, 11:07 am)
Re: [PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Thu Nov 12, 12:09 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Fri Nov 13, 2:39 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Stephen Hemminger, (Fri Nov 13, 3:24 pm)
Re: [PATCH net-next-2.6] ipv6: use RCU to walk list of net ..., David Miller, (Fri Nov 13, 9:39 pm)
Re: [PATCH 04/10] AOE: use rcu to find network device, Ed Cashin, (Wed Nov 18, 9:49 am)