£1,350,000.00 Pounds has been awarded to your E-mail do send us your Name Age Tel Address contery. --

£1,350,000.00 Pounds has been awarded to your E-mail do send us your Name Age Tel Address contery. --

I find it rather disappointing that all my review comments regarding rt2800pci support were just completely ignored and then the initial patch was merged just as it was.. The way rt2800usb and rt2800pci drivers are designed really results in making the task of adding working support for RT28x0 and RT30x0 chipsets to rt2x00 infrastructure more difficult and time consuming than it should be... :( -- Bartlomiej Zolnierkiewicz --

Dave, Here is a collection of fixes (mostly (almost-)one-liners) intended for 2.6.32. There are a couple of fixes relating to behavior when an association failes, as well as spelling fixes, simply endian fixes, a MAINTAINERS change...I don't think there is anything controversial here... Please let me know if there are problems! Thanks, John --- Individual patches are available here: http://www.kernel.org/pub/linux/kernel/people/linville/wireless-2.6/ --- The following ...

Thanks for the inputs. I'll revisit the issue. Steve --

I haven't gone through the entire thread yet, but I should point out that this appears to break regular IP fragmentation for unicast packets. There is no restriction whatsoever that fragments from a remote destination that are actually for the same datagram need to be routed on the same paths and received on the same input interface. For the multicast case, if they are from the same datagram, it doesn't matter how you got them. If it's a different datagram with the same ID, which can happen ...

Fix EEH and firmware mailbox command processor. --

Augment raw_send_hdrinc to correct for incorrect ip header length values A series of oopses was reported to me recently. Apparently when using AF_RAW sockets to send data to peers that were reachable via ipsec encapsulation, people could panic or BUG halt their systems. I've tracked the problem down to user space sending an invalid ip header over an AF_RAW socket with IP_HDRINCL set to 1. Basically what happens is that userspace sends down an ip frame that includes only the header (no ...

Yeah, I had a feeling. Ok, version 2, this time drop the invalid frame and report it to user space, instead of expanding it: Augment raw_send_hdrinc to correct for incorrect ip header length values A series of oopses was reported to me recently. Apparently when using AF_RAW sockets to send data to peers that were reachable via ipsec encapsulation, people could panic or BUG halt their systems. I've tracked the problem down to user space sending an invalid ip ...

This patch adds the PCI IDs for the next generation chip to the PCI_DEVICE_ID table. Signed-off-by: Ajit Khaparde <ajitk@serverengines.com> --- drivers/net/benet/be_main.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c index 4520db7..43180dc 100644 --- a/drivers/net/benet/be_main.c +++ b/drivers/net/benet/be_main.c @@ -31,8 +31,10 @@ MODULE_PARM_DESC(rx_frag_size, "Size of a fragment that holds rcvd ...

Yes your patch does this, so each multicast application receives two copies of the Really ? how so ? I dont see how it can happen, unless you use RPF ? current situation should be : (eth0 frag1) : We create a context, store frag1 in it (eth1 frag1) : We find this context, and drop frag1 since we already have the data (maybe the bug is here, if we cannot cope with a duplicate ?) (eth0 frag2) : We find this context, store frag2 -> complete datagram and deliver it (eth1 ...

Hi, There are some printouts in the phy abstraction library using pr_info(). Personally I would prefer if they used pr_debug() instead. Especially the pr_info("%s: probed\n", bus->name) in mdiobus_register() since in some cases I can't tolerate a console printout while the link is down (we have an ethernet debug link and read the UART output through the link). Of course this is a very specific case but in general in embedded systems (which I think is where the phylib is mainly used) ...

Correction: Thanks - Bhavesh --

Speedup module unloading by factorizing synchronize_rcu() calls Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/ipv4/ipmr.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/net/ipv4/ipmr.c b/net/ipv4/ipmr.c index 6949745..ef4ee45 100644 --- a/net/ipv4/ipmr.c +++ b/net/ipv4/ipmr.c @@ -275,7 +275,8 @@ failure: * @notify: Set to 1, if the caller is a notifier_call */ -static int vif_delete(struct net *net, int vifi, int ...

Speedup module unloading by factorizing synchronize_rcu() calls Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/ipv6/ip6mr.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/net/ipv6/ip6mr.c b/net/ipv6/ip6mr.c index 85849b4..52e0f74 100644 --- a/net/ipv6/ip6mr.c +++ b/net/ipv6/ip6mr.c @@ -477,7 +477,7 @@ failure: * Delete a VIF entry */ -static int mif6_delete(struct net *net, int vifi) +static int mif6_delete(struct net *net, ...

This problem sounds familiar. There are chip bugs in this area, but as far as I know, they should have been worked around. Let me see if this is indeed the same bug resurfacing. --

We have never checked the efx_nic::rx_checksum_enabled flag everywhere we should, and since the switch to GRO we don't check it anywhere. It's simplest to check it in the one place where we initialise the per-packet checksummed flag. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> Cc: stable@kernel.org --- This version really is applicable to net-2.6 and 2.6.31.y, and to 2.6.27.y with fuzz 1. I'm not sure whether this bug is serious enough for a stable update but it is an obvious ...

Implement querying and acting upon the no sack bit in the features field. Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com> Sigend-off-by: Ori Finkelman <ori@comsleep.com> Sigend-off-by: Yony Amit <yony@comsleep.com> --- include/linux/rtnetlink.h | 2 +- net/ipv4/tcp_input.c | 3 ++- net/ipv4/tcp_output.c | 4 +++- 3 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h index adf2068..9c802a6 100644 --- ...

Allow selectively turning off support for specific TCP options on a per route basis. One normally want to disable SACK, DSACK, time stamp or window scale if one got a piece of broken networking equipment somewhere as a stop gap until you can bring a big enough hammer to deal with the broken network equipment. It doesn't make sense to "punish" the entire connections going through the machine to destinations not related to the broken equipment. This is doubly true when one is dealing with ...

We need tcp_parse_options to be aware of dst_entry to take into account per dst_entry TCP options settings Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com> Sigend-off-by: Ori Finkelman <ori@comsleep.com> Sigend-off-by: Yony Amit <yony@comsleep.com> --- include/net/tcp.h | 3 ++- net/ipv4/syncookies.c | 27 ++++++++++++++------------- net/ipv4/tcp_input.c | 9 ++++++--- net/ipv4/tcp_ipv4.c | 21 ++++++++++++--------- net/ipv4/tcp_minisocks.c | 7 ...

Adding an accessor to existing dst_entry feautres field and refactor the only supported feature (allfrag) to use it. Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com> Sigend-off-by: Ori Finkelman <ori@comsleep.com> Sigend-off-by: Yony Amit <yony@comsleep.com> --- include/net/dst.h | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/include/net/dst.h b/include/net/dst.h index 5a900dd..b562be3 100644 --- a/include/net/dst.h +++ b/include/net/dst.h @@ ...

Add and use no DSCAK bit in the features field. Signed-off-by: Gilad Ben-Yossef <gilad@codefidence.com> Sigend-off-by: Ori Finkelman <ori@comsleep.com> Sigend-off-by: Yony Amit <yony@comsleep.com> --- include/linux/rtnetlink.h | 1 + net/ipv4/tcp_input.c | 8 ++++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/include/linux/rtnetlink.h b/include/linux/rtnetlink.h index 6784b34..e78b60c 100644 --- a/include/linux/rtnetlink.h +++ ...

If you're doing a new config interface, I'd suggest netlink like the wireless guys did to replace WEXT with cfg80211. Using netlink makes your interface easily available from programs/libraries without having to screenscrape anything. If you want some advice on netlink API stuff, ask Johannes Berg. --

Add support NAPI Rx API for KS8695NET driver. v2, change the Rx function to NAPI. in <KS8695X Integrated Multi-port Gateway Solution Register Description v1.0>: Interrupt Enable Register (offset 0xE204) Bit29 : WAN MAC Receive Interrupt Enable Bit16 : LAN MAC Receive Interrupt Enable Interrupt Status Register (Offset 0xF208) Bit29: WAN MAC Receive Status Bit16: LAN MAC Receive Status see arch/arm/mach-ks8695/devices.c: ks8695_wan_resources[] and ks8695_lan_resources[] have ...

As of now, udev does not support move events that are generated when network interfaces are renamed. This patch extends udev to support move events. With this patch udev would support rules like ACTION=="move", SUBSYSTEM=="net", PROGRAM="netif_id %k" Signed-off-by: Narendra K <Narendra_K@dell.com> --- udev/udev-event.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/udev/udev-event.c b/udev/udev-event.c index f4d7121..4a77753 100644 --- ...

I'd like to start from your last remark: you r absolutely right, and this is the problem we have in the current net-next driver. More than that, this patch is fixing this problem: it moved liberation of Tx SKBs from hardIRQ context (ISR) to the softIRQ context (tasklet) thereby resolving the problem u've mentioned. So, total agreement with u on this one. I must have named the patch differently to emphasize it. I'd like to summarize the patch I've sent: - Take Tx SKB liberation out of hardIRQ. - ...

All applied to net-next-2.6, but then I had to add the following patch to kill a warning: igb: Fix warnings in igb_set_ringparam() drivers/net/igb/igb_ethtool.c: In function ‘igb_set_ringparam’: drivers/net/igb/igb_ethtool.c:744: warning: comparison of distinct pointer types lacks a cast drivers/net/igb/igb_ethtool.c:748: warning: comparison of distinct pointer types lacks a cast Casts were to u16 on the constant, but the type of new_{r,t}x_count is u32. Cast to u32 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This change moves global_quad_port_a into igb_probe as a static define since it doesn't actually need to be global. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index 62b6876..7f32211 100644 --- ...

From: Alexander Duyck <alexander.h.duyck@intel.com> Going forward the plan is to have the MACs support SCTP checksum offloads so change the check from == to >=. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index 846e64f..1a6c074 100644 --- ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch adds support for a seperate tx-usecs interrupt moderation setting in ethtool which is supported when tx and rx interrupt vectors are sperated. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 5 +++- drivers/net/igb/igb_ethtool.c | 49 +++++++++++++++++++++++++++++++---------- drivers/net/igb/igb_main.c | 22 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> The code for the hw timestamping is a bit bulky and making some of the functions difficult to read. In order to clean things up a bit I am moving the timestamping operations into seperate functions. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/e1000_82575.h | 14 + drivers/net/igb/e1000_defines.h | 33 +++ drivers/net/igb/e1000_regs.h ...

From: Alexander Duyck <alexander.h.duyck@intel.com> In order to support future features it is easiest to replace the clear_to_send boolean with a flag value. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 5 +- drivers/net/igb/igb_main.c | 125 +++++++++++++++++++++++--------------------- 2 files changed, 70 insertions(+), 60 deletions(-) diff --git a/drivers/net/igb/igb.h ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch moves VF initialization into a seperate function to help improve the readability of igb_probe. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 98 +++++++++++++++++++++++++------------------- 1 files changed, 56 insertions(+), 42 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch cleans up some of the ring alloc and free code to better handle exceptions such as attempting to free resources on an already freed ring. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 29 +++++++++++++++++------------ 1 files changed, 17 insertions(+), 12 deletions(-) diff --git a/drivers/net/igb/igb_main.c ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch changes a few things so that instead of firing a link status interrupt directly the get_link_status bit is set and the watchdog is scheduled. In addition the mailbox bit is now only enabled if VFs are enabled. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 31 +++++++++++++++++++++++-------- 1 files changed, 23 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch cleans up the xmit frame path for igb to better handle xmit frame errors and avoid null pointer exceptions. It also cleans up some whitespace issues found in the xmit frame path. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 30 +++++++++++++++--------------- 1 files changed, 15 insertions(+), 15 deletions(-) diff ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch just cleans up some unecessary references to the adapter->hw member when it has already been placed in a local variable named hw. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 26 ++++++++++++-------------- 1 files changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/igb/igb_main.c ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch goes through and cleans up whitespace issues in igb_main.c to help improve readability. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 41 +++++++++++++++++++---------------------- 1 files changed, 19 insertions(+), 22 deletions(-) diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c index ...

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com> Reviewed-by: Roland Dreier <rolandd@cisco.com> Cc: Yevgeny Petrilin <yevgenyp@mellanox.co.il> Cc: netdev@vger.kernel.org --- drivers/net/mlx4/alloc.c | 37 ++++--------------------------------- 1 files changed, 4 insertions(+), 33 deletions(-) diff --git a/drivers/net/mlx4/alloc.c b/drivers/net/mlx4/alloc.c index ad95d5f..8c85156 100644 --- a/drivers/net/mlx4/alloc.c +++ b/drivers/net/mlx4/alloc.c @@ -72,35 +72,6 @@ void ...

From: Sreenivasa Honnur <Sreenivasa.Honnur@neterion.com> Applied, thanks. --

From: <jie.yang@atheros.com> Applied, thanks. --

All 20 patches applied, thanks a lot. --

From: Alexander Duyck <alexander.h.duyck@intel.com> This change makes the tx and rx config a bit cleaner by breaking out the ring specific configuration from the generic rx and tx configuration. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 6 + drivers/net/igb/igb_main.c | 179 ++++++++++++++++++++++++++++---------------- 2 files changed, 117 insertions(+), 68 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> Since we are writting to the head/tail pointers frequently we might as well save ourselves some processing time by converting the head and tail offsets directly to pointers. This will shave a few cycles off the rx/tx path and allows us to move one step closer to the rings being a bit more independant of each other. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch adds a pci device pointer to the ring structure. The main use of this pointer is for memory mapping/unmapping of the rings. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 5 ++- drivers/net/igb/igb_ethtool.c | 4 +- drivers/net/igb/igb_main.c | 72 ++++++++++++++++++++--------------------- 3 files changed, ...

From: Alexander Duyck <alexander.h.duyck@intel.com> The allocation failed and checksum error stats are currently kept as a global stat. If we end up allocating the queues to multiple netdevs then the global counter doesn't make much sense. For this reason I felt it necessary to move the alloc_rx_buff_failed stat into the rx_stats portion of the rx_ring. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This change adds a pointer to the netdev to the ring itself. The idea being at some point in the future it will be possible to support multiple netdevs from a single adapter struct. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 3 ++- drivers/net/igb/igb_main.c | 29 ++++++++++++++--------------- 2 files changed, 16 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This update delays the VF reset notification until after interrupts are enabled. Otherwise there is a chance of having the VF try to reset itself too soon and being ignored by the PF as a result. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_main.c | 33 +++++++++++++++++++++++---------- 1 files changed, 23 insertions(+), 10 ...

From: Alexander Duyck <alexander.h.duyck@intel.com> Since all of the ring code is now specific to the ring instead of the adapter struct it is possible to cut a large section of code out of the ethtool testing configuraiton since we can just use the existing functions to configure the rings. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb.h | 14 +++ drivers/net/igb/igb_ethtool.c | ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This change adds a clean_rx/tx_irq type function call to the ethtool loopback testing which allows us to test the core transmit and receive functionality in the driver. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/igb_ethtool.c | 156 +++++++++++++++++++++++------------------ 1 files changed, 89 insertions(+), 67 deletions(-) diff --git ...

From: Alexander Duyck <alexander.h.duyck@intel.com> This patch moves some defines into the e1000_regs.h file since this is the correct place for register defines and not inside of igb_ethtool.c Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- drivers/net/igb/e1000_regs.h | 7 +++++++ drivers/net/igb/igb_ethtool.c | 11 +---------- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git ...

From: Alexander Duyck <alexander.h.duyck@intel.com> Counting packets with a good checksum can cause a significant amount of cache line bouncing due to the shared counter being written to by all of the queues. In order to avoid this I am removing the counter since we still have the checksum failed counter which will tell us if there are any issues. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- ...

Real fix is to realloc buffer at receive time, no need for user setting. In my testings I saw it reaching 1 Mbyte write(2, "REALLOC buflen 8192\n"..., 20) = 20 write(2, "REALLOC buflen 16384\n"..., 21) = 21 write(2, "REALLOC buflen 32768\n"..., 21) = 21 write(2, "REALLOC buflen 65536\n"..., 21) = 21 write(2, "REALLOC buflen 131072\n"..., 22) = 22 write(2, "REALLOC buflen 262144\n"..., 22) = 22 write(2, "REALLOC buflen 524288\n"..., 22) = 22 [iproute2] realloc buffer in rtnl_listen # ...

Oops, this was wrong, Ben was right, sorry... ENOBUFS errors is a flag to actually report to user that some information was dropped, not that user supplied buffer at recv() time is not big enough. I was surprised that buffer could reach 1Mbytes, while RCVBUF was 32768 or so. --

From: Eric Dumazet <eric.dumazet@gmail.com> This discussion constantly reminds me of: /* * skb should fit one page. This choice is good for headerless malloc. * But we should limit to 8K so that userspace does not have to * use enormous buffer sizes on recvmsg() calls just to avoid * MSG_TRUNC when PAGE_SIZE is very large. */ #if PAGE_SIZE < 8192UL #define NLMSG_GOODSIZE SKB_WITH_OVERHEAD(PAGE_SIZE) #else #define NLMSG_GOODSIZE SKB_WITH_OVERHEAD(8192UL) #endif #define ...

First: This still pretty much guarantees that messages will be lost when the program starts (when messages are coming in too large of chunks for small buffers) If you are debugging something tricky, having lost messages will be very annoying! Second: Why bail on ENOBUFS at all? I don't see how it helps the user since they will probably just have to start it again, and will miss more messages than keeping going would have. And, even 1MB may not be enough for some scenarios. So, probably ...

No, the kernel takes the value as a hint and only uses the maximum allowable value: case SO_RCVBUF: /* Don't error on this BSD doesn't and if you think about it this is right. Otherwise apps have to play 'guess the biggest size' games. RCVBUF/SNDBUF are treated in BSD as hints */ if (val > sysctl_rmem_max) I think it should be fine this way. --

In this case, just dont call setsockopt() at all in "ip" and let system use the standard/default value (/proc/sys/net/core/rmem_default) that an admin can change if he wants to handle one million devices :) --

I sent the specific scenario the patch tries to address to the list in an earlier e-mail. Would it be beneficial if I post the test code somewhere so everyone can have access? Regards, Steve --

If I understand correctly, the idea here is to say that when multiple interfaces receive fragments of copies of the same IP datagram that both copies will "survive" and flow up the stack? Doesn't that rather fly in the face of the weak-end-system model followed by Linux? I can see where scenario one leads to two IP datagrams making it up the stack, but I would have thought that was simply an "accident" of the situation that cannot reasonably be prevented, not justification to cause ...

For scenario 2, the routing code drops the 2nd packet. As a result, no packet make it to the application. If someone is willing to suggest an alternative, I can certainly rework the patch and retest. Regards, Steve --

I actually don't know who Emily Litella is until today. This mailing list is great not just for learning networking stuff :). In the test code I received, one of the step to setup is to configure the IP address of the interface that the application is expecting the packet. It appears to bind on interface based on that casual observation. I'll have to study the code in detail to be able to say for sure. Regards, Steve --

This shouldn't be necessary since the lower device is already in the process of being unregistered. If it was necessary, it could cause crashes since the individual pointers are not set to zero atomically. --

From: Eric Dumazet <eric.dumazet@gmail.com> All applied to net-next-2.6, thanks! --

Have you tested it? ...I doubt this will work like you say and retransmit something when the window is small. ...Besides, you should have built this patch on top of the function rename you submitted earlier as after DaveM applied that this will no longer even compile... -- i. --

The session timeout no longer depends on the actual number of retransmits. Instead its a time interval, which is roughly equivalent to the time a TCP, performing exponential backoff would need to perform 15 retransmits. However, addressing the proposal: I wonder how one can seriously suggest to just skip congestion response during timeout-based loss recovery? I believe that in a heavily congested scenarios, this would lead to a goodput goodput disaster... Not to mention that in a heavily ...

The first part is nowadays done with __tcp_set_rto(tp). -- i. --

This bothers me a bit. Having just looked at your Linux presentation, and not (yet) read your papers, it seems much of your justification was with 1 packet per RTT. Here, you seem to be concentrating on 4, probably because many implementations quickly ramp up to 4. But there's a fair amount of experience showing that ramping to 4 is problematic on congested paths, especially wireless networks. Fast retransmit in that case would be disastrous. Once upon a time, I worked on a fair number of ...

From: Sandeep Gopalpet <sandeep.kumar@freescale.com> This is the third time you've submitted this patch, and for the third time it DOES NOT apply to net-next-2.6 at all when I try to apply this gianfar patch series. You must be patching against another tree that has some changes that conflict with this one. Sort this out before submitting this again. If you submit once more this same series, and it doesn't apply properly to net-next-2.6, I will flat our ignore your submissions for a ...

The register name update in net-next-2.6 changed the context for this patch. I'll send a new patch that will apply to the earlier versions. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. --

On Tue, 27 Oct 2009 16:26:55 +0200 This patch has no changelog, and I'm not seeing any description of what it fixes and how it fixes it up-thread. --

I hate that there's no proper IRQ functions for managing these, as Ben has commented. Although I can understand that writing such is beyond the scope of You still didn't update the module version. This is a pity because you've potentially radically changed behaviour and you definitely have radically You have not added documentation for these fields in the structure's I can't see where you have moved this to. Without it, sometimes the KS8695's This '64' seems quite arbitrary. Is ...

From: Daniel Silverstone <dsilvers@simtec.co.uk> Any such change would need to be relative to what's already in net-next-2.6 --

They explain the "several related concepts" -- indeed the entire scope of This patch series was fairly clearly described in Adam's draft last year. Before writing text, I like to have implementation code.... :-) In fact, it has long been my position that we shouldn't publish IETF RFCs without running code (and I never have). Even PPP over SOnet/SDH had preliminary hardware before publication. Unfortunately, those with standards-bodies-itis have a sad history of the opposite. The Usenix ...

On Tue, 27 Oct 2009 16:41:52 -0700 (PDT) Agreed. Here is the reduced version of the program. To run: find /home -printf '%f\n' 2>/dev/null | ./htest -n 100

On Tue, 27 Oct 2009 17:58:53 -0700 (PDT) Thanks. I wasn't putting huge amount of stock in the micro benchmark, was more interested in how the distribution worked out (which is CPU independent) rather than the time. As long as all usage of name hashing fold properly, there isn't a lot of reason to change. -- --

From: Eric Dumazet <eric.dumazet@gmail.com> Agreed. --

From: Benjamin LaHaise <bcrl@lhnet.ca> Having it in a config option is worse, distributions are going to turn it on so it would be protecting nothing for %99.999 of folks out there. --

From: Randy Dunlap <randy.dunlap@oracle.com> Applied, thanks Randy. --

On Mon, 26 Oct 2009 08:41:32 -0700 Stephen, please retain the bugzilla and reporter email cc's when Twice a day on six separate machines. That ain't no hardware glitch. Vaclav, are you able to say whether this is a regression? Did those machines run 2.6.30 (for example)? --

From: Atsushi Nemoto <anemo@mba.ocn.ne.jp> Applied. --

From: Andy Gospodarek <andy@greyhouse.net> Applied. --

Hi William, Gladly (and suggestions to do it differently are welcome) : For the purpose of the patch tcp_parse_options was changed to consult dst_entry options when parsing non established packets. This means that for any place that we call tcp_parse_options with the established parameter set to false, we need to supply it with a dst_entry. In all other locations in kernel code when tcp_parse_options is called such a dst_entry is easily available already. The time wait mini socket ...

From: Rusty Russell <rusty@rustcorp.com.au> Applied, thanks. --

From: Ben Hutchings <ben@decadent.org.uk> Looks good to me, applied to net-next-2.6 --

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Applied, thanks. --

I found that the current version of drivers/net/usb/dm9601.c can be used to successfully drive a low-power, low-cost network adapter with USB ID 0a46:9000, based on a DM9000E chipset. As no device with this ID is yet present in the kernel, I have created a patch that adds support for the device to the dm9601 driver. Created and tested against linux-2.6.32-rc5. Signed-off-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Acked-by: Peter Korsgaard <jacmet@sunsite.dk> --- I'm not sure if ...

I've tested patches 1+2+3+4 in my normal usage scenario (do some work, suspend, do work, suspend, ...) and it failed today after 4 days (== 4 suspend-resume cycles). I'll test 1-5 now. Thanks. --

From: Sarveshwar Bandi <sarveshwarb@serverengines.com> Applied, thanks. --

What's the point of all this? Why would udev ever need to find the name of a device by the ifindex? The device name is the primary value That all sounds very much like something which will hit us back some day. I'm not sure, if udev should publish such dead text files in /dev, it does not seem to fit the usual APIs/assumptions where /sys and /dev match, and libudev provides access to both. It all sounds more like a database for a possible netdevname library, which does not need to be public ...

I was thinking, if we're not planning on use the chardev/kernel route. There already exists an ifindex file in /sys/class/net/XXX/ifindex. Should udev/helper be creating links to this, or is it better to keep everything under the /dev/ tree? Using this method would require the patch to udev to handle renaming events. --jordan hargrave Dell Enterprise Linux Engineering -----Original Message----- From: dann frazier [mailto:dannf@hp.com] Sent: Wed 10/28/2009 10:09 To: Domsch, Matt Cc: ...

A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top Please never create symlinks out of /dev/ to /sys that doesn't make sense at all and probably violates part of the LSB somewhere... thanks, greg k-h --

Ultimately, udev doesn't care. I just want to use udev to keep track of the pathname to device connections, like it does for all other types of devices. Applications such as net-tools, iproute, ethtool, etc. take a kernel device name. I want to extend them to also take a path, and resolve that path to a kernel device name. libnetdevname currently is _one small function_ which does this. It need not even be in a library. But whatever the mechanism, the path names need to be ...

We don't seem to be supporting changing real_num_tx_queues for registered devices currently (at least I couldn't find it). So I guess it depends on how this would be implemented. Simply changing the dev->real_num_tx_queues value while the device is down would require qdisc operations to operate on all possible queues since the amount of queues in use could be changed after the qdisc is created/configured, but before the device is set up. This approach has more complications like switching ...