From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 23 Oct 2009 18:08:30 +0200

quoted text
> Roel Kluin a écrit :
>> The variables are unsigned so the `< 0' test always fails, the
>> other part of the test catches wrapped values.
>> 
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
> 
> I believe such patches were posted in the past.
> 
> General consensus is that compiler is able to do this optimization for us,
> and reader doesnt have to ask to himself : "Is the test safe enough ?"

Conversely, the reader can say "Wow this can be negative?  There's
tests missing elsewhere! ... oh, nevermind it's unsigned"

That really wastes people's time too.

I suspect I'll apply these patches. :-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html