On Tue, 20 Oct 2009, Gilad Ben-Yossef wrote:
quoted text > Eric Dumazet wrote:
>
> > Gilad Ben-Yossef a écrit :
> >
> > > Turn the global sysctls allowing disabling of TCP SACK, DSCAK,
> > > time stamp and window scale into per route entry feature options,
> > > laying the ground to future removal of the relevant global sysctls.
> > >
> > > ...
> > Interesting... But you should give numbers to your patches so that we know
> > their order
> >
> Will do.
> > You could also do the ECN part for consistency (ie RTAX_FEATURE_ECN ->
> > RTAX_FEATURE_NO_ECN)
> >
> That and sysctl_tcp_mtu_probing are on my todo list, assuming the general
> direction is accepted, of course.
>
> Specifically, I couldn't understand why sysctl_tcp_ecn is documented to be a
> boolean value, but is initialized to 2 and queried with if (sysctl_tcp_ecn ==
> 1) so I decided to let it be until I figure it out... ;-)
Ah, I didn't notice that "- BOOLEAN" there so I modified only the
description (some blindness to caps perhaps :-)), did you perhaps read
it fully?
--
i.
