[PATCH RFC] Per route TCP options

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Gilad Ben-Yossef
Date: Tuesday, October 20, 2009 - 8:22 am

Turn the global sysctls allowing disabling of TCP SACK, DSCAK,
time stamp and window scale into per route entry feature options,
laying the ground to future removal of the relevant global sysctls.

You really only want to disable SACK, DSACK, time stamp or window
scale if you've got a piece of broken networking equipment somewhere 
as a stop gap until you can bring a big enough hammer to deal with
the broken network equipment. It doesn't make sense to "punish" the
entire connections going through the machine to destinations not 
related to the broken equipment.

This is doubly true when you're dealing with network containers
used to isolate several virtual domains.

Per route options implemented in free bits in the features route
entry property, which in some cases were reserved by name for these
options, so this does not inflate any structure and I expect that
when the apropriate global sysctls will be removed the overall code
base will be smaller.

Tested on x86 using Qemu/KVM.  

Will send the matching patch to iproute2 if/when this is ACKed or
if someone wants to test this.

Patchset based on original work by Ori Finkelman and Yoni Amit 
from ComSleep Ltd.

Gilad Ben-Yossef (8):
  Only parse time stamp TCP option in time wait sock
  Allow tcp_parse_options to consult dst entry
  Infrastructure for querying route entry features
  Add the no SACK route option feature
  Allow disabling TCP timestamp options per route
  Allow to turn off TCP window scale opt per route
  Allow disabling of DSACK TCP option per route
  Document future removal of sysctl_tcp_* options

 Documentation/feature-removal-schedule.txt |   12 ++++++++++++
 include/linux/rtnetlink.h                  |    6 ++++--
 include/net/dst.h                          |    8 +++++++-
 include/net/tcp.h                          |    3 ++-
 net/ipv4/syncookies.c                      |   27 ++++++++++++++-------------
 net/ipv4/tcp_input.c                       |   26 ++++++++++++++++++--------
 net/ipv4/tcp_ipv4.c                        |   19 ++++++++++---------
 net/ipv4/tcp_minisocks.c                   |    8 +++++---
 net/ipv4/tcp_output.c                      |   18 +++++++++++++-----
 net/ipv6/syncookies.c                      |   28 +++++++++++++++-------------
 net/ipv6/tcp_ipv6.c                        |    3 ++-
 11 files changed, 102 insertions(+), 56 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Allow tcp_parse_options to consult dst entry, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Add dst_feature to query route entry features, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Add the no SACK route option feature, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Allow disabling TCP timestamp options per route, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Allow to turn off TCP window scale opt per route, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Allow disabling of DSACK TCP option per route, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
[PATCH RFC] Document future removal of sysctl_tcp_* options, Gilad Ben-Yossef, (Tue Oct 20, 8:22 am)
Re: [PATCH RFC] Per route TCP options, Eric Dumazet, (Tue Oct 20, 8:44 am)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Tue Oct 20, 9:11 am)
Re: [PATCH RFC] Per route TCP options, Rick Jones, (Tue Oct 20, 9:26 am)
Re: [PATCH RFC] Per route TCP options, =?ISO-8859-15?Q?Ilpo ..., (Tue Oct 20, 11:53 am)
Re: [PATCH RFC] Per route TCP options, David Miller, (Tue Oct 20, 5:36 pm)
Re: [PATCH RFC] Allow to turn off TCP window scale opt per ..., Stephen Hemminger, (Tue Oct 20, 6:40 pm)
Re: [PATCH RFC] Per route TCP options, Bill Fink, (Tue Oct 20, 7:13 pm)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Wed Oct 21, 1:04 am)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Wed Oct 21, 1:10 am)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Wed Oct 21, 1:15 am)
Re: [PATCH RFC] Per route TCP options, Florian Westphal, (Wed Oct 21, 1:21 am)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Wed Oct 21, 1:27 am)
Re: [PATCH RFC] Per route TCP options, Gilad Ben-Yossef, (Wed Oct 21, 1:40 am)