build test your changes!

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Miller
Date: Monday, October 19, 2009 - 11:22 pm

Krishna, you add:

+static inline void sk_tx_queue_set(struct sock *sk, int tx_queue)
...
+static inline void sk_tx_queue_clear(struct sock *sk)
...
+static inline int sk_tx_queue_get(const struct sock *sk)
...
+static inline bool sk_tx_queue_recorded(const struct sock *sk)

But then in the net/core/dev.c patch you go:

+			if (sk && sk->sk_dst_cache)
+				sk_record_tx_queue(sk, queue_index);

I cannot see how you did a build test of this, it's absolutely impossible.

I'm reverting.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
build test your changes!, David Miller, (Mon Oct 19, 11:22 pm)
Re: build test your changes!, Krishna Kumar2, (Mon Oct 19, 11:52 pm)
Re: build test your changes!, Eric Dumazet, (Tue Oct 20, 12:36 am)