Home » Mailing list archives » linux-netdev » 2009 » October » 20

Re: [PATCH] net: Fix IP_MULTICAST_IF

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: David Miller
Subject: Re: [PATCH] net: Fix IP_MULTICAST_IF
Date: Monday, October 19, 2009 - 8:59 pm

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 19 Oct 2009 18:41:58 +0200


Dubious, how so?

Yes, I know RTNL/dev_base_lock, but it's not using what it gets
back at all.

It's testing existence, a boolean, it doesn't dereference the
'dev' it gets back at all.

This code is intentional and perfectly fine.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] net: Fix IP_MULTICAST_IF, Eric Dumazet, (Mon Oct 19, 9:41 am)
Re: [PATCH] net: Fix IP_MULTICAST_IF, David Miller, (Mon Oct 19, 8:59 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, Eric Dumazet, (Mon Oct 19, 9:07 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, Eric Dumazet, (Mon Oct 19, 9:16 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, David Miller, (Mon Oct 19, 9:20 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, David Miller, (Mon Oct 19, 9:21 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, Eric Dumazet, (Mon Oct 19, 9:23 pm)
Re: [PATCH] net: Fix IP_MULTICAST_IF, David Miller, (Mon Oct 19, 9:28 pm)
[PATCH net-next-2.6] net: Introduce dev_get_by_index_rcu(), Eric Dumazet, (Mon Oct 19, 10:03 pm)
Re: [PATCH net-next-2.6] net: Introduce dev_get_by_index_rcu(), Stephen Hemminger, (Mon Oct 19, 10:06 pm)
Re: [PATCH net-next-2.6] net: Introduce dev_get_by_index_rcu(), Eric Dumazet, (Mon Oct 19, 10:18 pm)
[PATCH] ifb: should not use __dev_get_by_index() without locks, Eric Dumazet, (Tue Oct 20, 5:35 am)
Re: [PATCH] ifb: should not use __dev_get_by_index() witho ..., David Miller, (Thu Oct 22, 9:54 pm)
Re: [PATCH net-next-2.6] net: Introduce dev_get_by_index_rcu(), David Miller, (Thu Oct 29, 1:43 am)