[PATCH 04/16] dma-debug: add allocator code

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Joerg Roedel
Date: Friday, January 9, 2009 - 9:19 am

Impact: add allocator code for struct dma_debug_entry

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 lib/dma-debug.c |   57 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 57 insertions(+), 0 deletions(-)

diff --git a/lib/dma-debug.c b/lib/dma-debug.c
index 74a0f36..c5444d4 100644
--- a/lib/dma-debug.c
+++ b/lib/dma-debug.c
@@ -49,6 +49,16 @@ struct hash_bucket {
 
 /* Hash list to save the allocated dma addresses */
 static struct hash_bucket dma_entry_hash[HASH_SIZE];
+/* List of pre-allocated dma_debug_entry's */
+static LIST_HEAD(free_entries);
+/* Lock for the list above */
+static DEFINE_SPINLOCK(free_entries_lock);
+
+/* Global disable flag - will be set in case of an error */
+static bool global_disable __read_mostly;
+
+static u32 num_free_entries;
+static u32 min_free_entries;
 
 /*
  * Hash related functions
@@ -138,3 +148,50 @@ static void add_dma_entry(struct dma_debug_entry *entry)
 	put_hash_bucket(bucket, &flags);
 }
 
+/* struct dma_entry allocator
+ *
+ * The next two functions implement the allocator for
+ * struct dma_debug_entries.
+ */
+static struct dma_debug_entry *dma_entry_alloc(void)
+{
+	struct dma_debug_entry *entry = NULL;
+	unsigned long flags;
+
+	spin_lock_irqsave(&free_entries_lock, flags);
+
+	if (list_empty(&free_entries)) {
+		printk(KERN_ERR "DMA-API: debugging out of memory "
+				"- disabling\n");
+		global_disable = true;
+		goto out;
+	}
+
+	entry = list_entry(free_entries.next, struct dma_debug_entry, list);
+	list_del(&entry->list);
+	memset(entry, 0, sizeof(*entry));
+
+	num_free_entries -= 1;
+	if (num_free_entries < min_free_entries)
+		min_free_entries = num_free_entries;
+
+out:
+	spin_unlock_irqrestore(&free_entries_lock, flags);
+
+	return entry;
+}
+
+static void dma_entry_free(struct dma_debug_entry *entry)
+{
+	unsigned long flags;
+
+	/*
+	 * add to beginning of the list - this way the entries are
+	 * more likely cache hot when they are reallocated.
+	 */
+	spin_lock_irqsave(&free_entries_lock, flags);
+	list_add(&entry->list, &free_entries);
+	num_free_entries += 1;
+	spin_unlock_irqrestore(&free_entries_lock, flags);
+}
+
-- 
1.5.6.4


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 01/16] dma-debug: add Kconfig entry, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 04/16] dma-debug: add allocator code, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 05/16] dma-debug: add initialization code, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 12/16] dma-debug: add checks for sync_single_*, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 15/16] dma-debug: x86 architecture bindings, Joerg Roedel, (Fri Jan 9, 9:19 am)
[PATCH 16/16] dma-debug: Documentation update, Joerg Roedel, (Fri Jan 9, 9:19 am)
Re: [PATCH 05/16] dma-debug: add initialization code, Evgeniy Polyakov, (Fri Jan 9, 10:58 am)
Re: [PATCH 05/16] dma-debug: add initialization code, Joerg Roedel, (Fri Jan 9, 11:17 am)
Re: [PATCH 01/16] dma-debug: add Kconfig entry, Randy Dunlap, (Fri Jan 9, 1:12 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Michael Chan, (Fri Jan 9, 2:24 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 3:33 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Fri Jan 9, 3:37 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Ingo Molnar, (Sat Jan 10, 4:04 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Ingo Molnar, (Sat Jan 10, 4:08 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Ingo Molnar, (Sat Jan 10, 4:15 pm)
Re: [PATCH 04/16] dma-debug: add allocator code, Ingo Molnar, (Sat Jan 10, 4:43 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Ingo Molnar, (Sat Jan 10, 4:48 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Ingo Molnar, (Sat Jan 10, 4:54 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, FUJITA Tomonori, (Sat Jan 10, 11:25 pm)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, FUJITA Tomonori, (Sat Jan 10, 11:25 pm)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Sun Jan 11, 12:52 am)
Re: [PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Sun Jan 11, 12:54 am)
Re: [PATCH 08/16] dma-debug: add core checking functions, Joerg Roedel, (Sun Jan 11, 12:57 am)
Re: [PATCH 15/16] dma-debug: x86 architecture bindings, Joerg Roedel, (Sun Jan 11, 1:08 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Sun Jan 11, 1:11 am)
Re: [PATCH 07/16] dma-debug: add debugfs interface, Joerg Roedel, (Wed Jan 14, 8:22 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, David Woodhouse, (Thu Feb 5, 3:52 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Thu Feb 5, 7:05 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Thu Feb 5, 7:27 pm)
Re: [PATCH 0/16] DMA-API debugging facility v2, David Woodhouse, (Fri Feb 6, 12:56 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Fri Feb 6, 9:08 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Chris Wright, (Fri Feb 6, 11:20 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Thu Feb 12, 7:48 am)
Re: [PATCH 0/16] DMA-API debugging facility v2, Joerg Roedel, (Thu Feb 12, 8:20 am)