David Miller wrote:
quoted text
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Fri, 9 Jan 2009 15:19:53 +1100
> 
>> Jeff Garzik <jgarzik@pobox.com> wrote:
>>> For generic net stack flags outside the driver's control, that can 
>>> easily be added to ethtool_{get,set}_flags() overriding or ignoring 
>>> whatever the driver may have done.
>> To use the flags interface as is, you'd have to go through every
>> single driver to get them to call ethtool_op_set_flags.  I'm sorry
>> but I'm sticking with the current interface.
> 
> Right, the flags thing is inappropriate without major reworking for
> Herbert's GRO case and therefore his choice was completely
> appropriate.

It took about ten minutes of coding to disprove this...

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html