Home » Mailing list archives » linux-netdev » 2009 » January » 7

Re: [PATCH] dm9601: warn on invalid mac address

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Peter Korsgaard
Subject: Re: [PATCH] dm9601: warn on invalid mac address
Date: Wednesday, January 7, 2009 - 1:24 am

>>>>> "Wu" == Wu Fengguang <wfg@linux.intel.com> writes:

Hi,

 >> Also, it seems like you're not writing the random address to the
 >> hardware registers, so you won't be able to receive any unicast -
 >> You'll need to add a call to dm9601_set_mac_address() or similar.

 Wu> Good catch. I had wanted to ask why it only works with promisc
 Wu> mode ;-)

;)

 Wu> Here is the tested patch.

 Wu> Thanks,
 Wu> Fengguang
 Wu> ---
 Wu> dm9601: tell HW about random generated mac address

 Wu> Otherwise unicast RX will only work in promisc mode.

 Wu> Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>
 Wu> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>

-- 
Bye, Peter Korsgaard
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] dm9601: warn on invalid mac address, Wu Fengguang, (Tue Jan 6, 2:10 am)
Re: [PATCH] dm9601: warn on invalid mac address, Peter Korsgaard, (Tue Jan 6, 2:18 am)
Re: [PATCH] dm9601: warn on invalid mac address, Wu Fengguang, (Tue Jan 6, 2:47 am)
Re: [PATCH] dm9601: warn on invalid mac address, Peter Korsgaard, (Tue Jan 6, 4:17 am)
Re: [PATCH] dm9601: warn on invalid mac address, Ben Hutchings, (Tue Jan 6, 4:52 am)
Re: [PATCH] dm9601: warn on invalid mac address, David Miller, (Tue Jan 6, 11:52 am)
Re: [PATCH] dm9601: warn on invalid mac address, Wu Fengguang, (Tue Jan 6, 9:52 pm)
Re: [PATCH] dm9601: warn on invalid mac address, Wu Fengguang, (Tue Jan 6, 9:55 pm)
Re: [PATCH] dm9601: warn on invalid mac address, Peter Korsgaard, (Wed Jan 7, 1:24 am)
Re: [PATCH] dm9601: warn on invalid mac address, Peter Korsgaard, (Wed Jan 7, 1:25 am)
Re: [PATCH] dm9601: warn on invalid mac address, David Miller, (Thu Jan 8, 11:45 am)
Re: [PATCH] dm9601: warn on invalid mac address, David Miller, (Thu Jan 8, 11:47 am)