linux-netdev mailing list

Fromsort iconSubjectDate
WEBMAIL DESK
Confirm Your Webmail Account
Dear Webmail account User, This message is from Webmail account update Service team messaging center to all subscribers/webmail users. We are currently upgrading our data base and e- mail center due to an unusual activities identified in our email system. We are deleting all unused Webmail Accounts. to create space for new ones. You are required to verify your webmail account by Confirming your Webmail identity. This will prevent your Webmail account from been closed during ...
Jan 30, 2:30 am 2009
Ayaz Abdulla
[PATCH 2/5] forcedeth: msi interrupt fix
This patch fixes an issue with the suspend/resume cycle with msi interrupts. See bugzilla number 10487 for more details. The fix is to re-setup a private msi pci config offset field. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Jan 30, 11:56 am 2009
Ayaz Abdulla
[PATCH 1/5] forcedeth: mgmt unit interface
This patch updates the logic used to communicate with the mgmt unit. It also adds a version check for a newer mgmt unit firmware. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Jan 30, 11:56 am 2009
Ayaz Abdulla
[PATCH 4/5] forcedeth: recover error support
This patch adds another type of recoverable error to the driver. It also modifies the sequence for recovery to include a mac reset and clearing of interrupts. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Jan 30, 11:56 am 2009
Ayaz Abdulla
[PATCH 5/5] forcedeth: bump version to 63
This patch bumps the version up to 63 Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Jan 30, 11:56 am 2009
Ayaz Abdulla
[PATCH 3/5] forcedeth: ethtool tx csum fix
This patch fixes the ethtool tx csum "set" command. A recent patch was submitted to remove HW_CSUM and use IP_CSUM instead. Therefore, the corresponding ethtool command should also be modified. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Jan 30, 11:56 am 2009
Alexey Dobriyan
Re: [PATCH] sky2: fix hard hang with netconsoling and if ...
As for other printks, someone with 8139cp should experience the same bug. --
Jan 30, 4:59 am 2009
Andrew Morton
Re: [PATCH 1/5] forcedeth: mgmt unit interface
On Fri, 30 Jan 2009 13:56:26 -0500 A five second busy-wait still sucks :( Why not do start = jiffies; while (time_before(jiffies, start + 5*HZ)) { ... schedule_timeout_uninterruptible(1); } ? --
Jan 30, 3:35 pm 2009
Andi Kleen
Re: [PATCH] netfilter: unfold two critical loops in ip_p ...
I don't think it will. -funroll-loops is pretty clear defined. -Andi -- ak@linux.intel.com -- Speaking for myself only. --
Jan 30, 10:50 am 2009
Andi Kleen
Re: [PATCH] netfilter: unfold two critical loops in ip_p ...
That's because nobody passed -funroll-loops. Did you try that for That will silently break for IFNAMSIZ >= 4*sizeof(unsigned long) You should add a dummy loop for that or at least a BUILD_BUG_ON -Andi -- ak@linux.intel.com -- Speaking for myself only. --
Jan 30, 8:47 am 2009
Andi Kleen
Re: [PATCH] netfilter: unfold two critical loops in ip_p ...
gcc 4.4 will have a way to do that per function, but earlier you would need to move it to a separate file and specify the option only for that. Doing so would be still a good idea compared to your patch because the code will be cleaner and might be more adaptable to future architectures It cannot do much without profile feedback because Yes I know, sorry for that. -Andi -- ak@linux.intel.com -- Speaking for myself only. --
Jan 30, 10:27 am 2009
Atsushi Nemoto
Re: [PATCH 09/13] atmel-mci: convert to dma_request_chan ...
How dw_dma_slave passed to the dw_dmac driver? I cannot see where dwc->dws is initialized now. Or am I missing something? --- Atsushi Nemoto --
Jan 30, 9:40 am 2009
Atsushi Nemoto
Re: [PATCH 07/13] dmaengine: introduce dma_request_chann ...
I'm writing a new dma driver. My DMAC has multiple channels and only one channel is capable for generic memcpy and other channels have fixed role. Does new framework allow dma driver make only one channel public? Or should I register two dma_device for DMA_MEMCPY and DMA_SLAVE? Could you give me some advice? --- Atsushi Nemoto --
Jan 30, 10:03 am 2009
Benjamin ZORES Jan 30, 1:25 am 2009
Daniel P. Berrange
Re: virt-manager broken by bind(0) in net-next.
The virt-manager console is basically just a plain old boring VNC client. It uses GTK-VNC to establish its VNC network connection, and that doesn't do anything unusual AFAIK. We use getaddrinfo() to resolve the hostname, and then try each of its results in turn, until we succesfully connect to the VNC server. We don't explicitly bind() to the client port, just let the kernel pick it for us. The code in question, is the "gvnc_open_host" method from gvnc.c, which starts at about line ...
Jan 30, 3:27 am 2009
Ben Hutchings
[PATCH 03/11] sfc: SFT9001: Fix speed reporting in 1G PH ...
From: Steve Hodgson <shodgson@solarflare.com> Instead of disabling AN in loopback, just prevent restarting AN and override the speed in sft9001_get_settings(). Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/mdio_10g.c | 4 ++++ drivers/net/sfc/tenxpress.c | 27 +++++++++------------------ drivers/net/sfc/workarounds.h | 5 +++++ 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/net/sfc/mdio_10g.c ...
Jan 29, 8:49 pm 2009
Ben Hutchings
[PATCH 01/11] sfc: SFT9001: Enable robust link training
From: Steve Hodgson <shodgson@solarflare.com> Enable a firmware option that appears to be necessary for reliable operation. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/tenxpress.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/net/sfc/tenxpress.c b/drivers/net/sfc/tenxpress.c index 9ecb77d..19cfc31 100644 --- a/drivers/net/sfc/tenxpress.c +++ b/drivers/net/sfc/tenxpress.c @@ -67,6 +67,8 @@ #define ...
Jan 29, 8:48 pm 2009
Ben Hutchings
[PATCH 05/11] sfc: Fix post-reset MAC selection
From: Steve Hodgson <shodgson@solarflare.com> Modify falcon_switch_mac() to always set NIC_STAT_REG, even if the the MAC is the same as it was before. This ensures that the value is correct after an online reset. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/falcon.c | 15 ++++++++------- 1 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/sfc/falcon.c b/drivers/net/sfc/falcon.c index ae7b0b4..d9412f8 100644 --- ...
Jan 29, 8:49 pm 2009
Ben Hutchings
Re: [PATCH 00/20] sfc: Fixes and new PHY support for 2.6.29
Sorry about that; I should have separated them out more clearly. 1. Patches 3, 6-13 and 20 fix bugs introduced or exposed by the changes already accepted for .29. I regret that I couldn't send these earlier but I simply didn't have near-production hardware or firmware to test against until the last couple of weeks. 2. Patches 16 and 19 add new hardware support without affecting the behaviour on old hardware. 3. Patches 14, 15, 17 and 18 are fairly trivial fixes supporting ...
Jan 29, 6:05 pm 2009
Ben Hutchings
[PATCH 04/11] sfc: SFN4111T: Fix GPIO sharing between I2 ...
Change sfn4111t_reset() to change only GPIO output enables so that it doesn't break subsequent I2C operations. Update comments to explain exactly what we're doing. Add a short sleep to make sure the FLASH_CFG_1 value is latched before any subsequent I2C operations. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/sfe4001.c | 15 +++++++++------ 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/net/sfc/sfe4001.c ...
Jan 29, 8:49 pm 2009
Ben Hutchings
[PATCH 02/11] sfc: SFX7101: Remove workaround for bad li ...
From: Steve Hodgson <shodgson@solarflare.com> Early versions of the SFX7101 firmware could complete link training in a state where it would not adequately cancel noise (Solarflare bug 10750). We previously worked around this by resetting the PHY after seeing many Ethernet CRC errors. This workaround is unsafe since it takes no account of the interval between errors; it also appears to be unnecessary with production firmware. Therefore remove it. Signed-off-by: Ben Hutchings ...
Jan 29, 8:48 pm 2009
Ben Hutchings
[PATCH 11/11] sfc: Replace stats_enabled flag with a dis ...
Currently we use a spin-lock to serialise statistics fetches and also to inhibit them for short periods of time, plus a flag to enable/disable statistics fetches for longer periods of time, during online reset. This was apparently insufficient to deal with the several reasons for stats being disabled. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/efx.c | 33 ++++++++++++++++++++++----------- drivers/net/sfc/efx.h | 2 ++ ...
Jan 29, 9:00 pm 2009
Ben Hutchings
[PATCH 09/11] sfc: SFT9001: Always enable XNP exchange o ...
This workaround is not specific to rev A. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/workarounds.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/sfc/workarounds.h b/drivers/net/sfc/workarounds.h index 420fe15..b810dcd 100644 --- a/drivers/net/sfc/workarounds.h +++ b/drivers/net/sfc/workarounds.h @@ -54,7 +54,7 @@ #define EFX_WORKAROUND_8071 EFX_WORKAROUND_FALCON_A /* Need to send XNP pages for 100BaseT ...
Jan 29, 8:52 pm 2009
Ben Hutchings
[PATCH 06/11] sfc: Reinitialise the PHY completely in ca ...
From: Steve Hodgson <shodgson@solarflare.com> In particular, set pause advertising bits properly. A PHY reset is not necessary to recover from the register self-test, so use a "invisible" reset there instead. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/efx.c | 26 +++++++++++++++++++------- drivers/net/sfc/efx.h | 7 ++++--- drivers/net/sfc/selftest.c | 7 ++++--- drivers/net/sfc/tenxpress.c | 1 + 4 files changed, 28 ...
Jan 29, 8:50 pm 2009
Ben Hutchings
[PATCH 07/11] sfc: Test for PHYXS faults whenever we can ...
From: Steve Hodgson <shodgson@solarflare.com> Depending on the loopback mode, there may be no pertinent link state bits. In this case we test the PHYXS RX fault bit instead. Make sure to do this in all cases where there are no link state bits. Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/mdio_10g.c | 16 +++++++++------- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/net/sfc/mdio_10g.c b/drivers/net/sfc/mdio_10g.c index ...
Jan 29, 8:51 pm 2009
Ben Hutchings
[PATCH 10/11] sfc: SFX7101/SFT9001: Fix AN advertisements
All 10Xpress PHYs require autonegotiation all the time; enforce this in the set_settings() method and do not treat it as a workaround. Remove claimed support for 100M HD mode since it is not supported by current firmware. Do not set speed override bits when AN is enabled, and do not use register 1.49192 for AN configuration as it can override what we set elsewhere. Always set the AN selector bits to 1 (802.3). Fix confusion between Next Page and Extended Next Page. Signed-off-by: Ben ...
Jan 29, 8:59 pm 2009
Ben Hutchings
[PATCH 08/11] sfc: Update board info for hardware monito ...
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com> --- drivers/net/sfc/sfe4001.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/net/sfc/sfe4001.c b/drivers/net/sfc/sfe4001.c index c7c95db..853057e 100644 --- a/drivers/net/sfc/sfe4001.c +++ b/drivers/net/sfc/sfe4001.c @@ -375,17 +375,25 @@ static void sfn4111t_fini(struct efx_nic *efx) i2c_unregister_device(efx->board_info.hwmon_client); } -static struct i2c_board_info ...
Jan 29, 8:51 pm 2009
Bill Fink
Re: How-to use Miltiqueue Rx on SMP ?
You might want to also force disk interrupts to cpus 2 and 3. -Bill --
Jan 30, 12:42 am 2009
Eric Dumazet
Re: virt-manager broken by bind(0) in net-next.
Reviewing commit a9d8f9110d7e953c2f2b521087a4179677843c2a I see use of a hashinfo->bsockets field that : - lacks proper lock/synchronization - suffers from cache line ping pongs on SMP Also there might be a problem at line 175 if (sk->sk_reuse && sk->sk_state != TCP_LISTEN && --attempts >= 0) { spin_unlock(&head->lock); goto again; If we entered inet_csk_get_port() with a non null snum, we can "goto again" while it was not expected. diff --git a/net/ipv4/inet_connection_sock.c ...
Jan 30, 11:41 am 2009
Eric Dumazet
Re: [PATCH 5/5] netfilter: convert x_tables to use RCU
Oops #define SUM_COUNTER(s, c) xt_incr_counter(s, (c).bcnt, (c).pcnt) --
Jan 30, 12:05 am 2009
Eric Dumazet Jan 29, 11:53 pm 2009
Eric Dumazet
Re: Multicast packet loss
Hi Kenny Interesting... You forgot the mcasttest.cc program Any chance you try a recent kernel (2.6.29-rcX) ? Could you post "cat /proc/interrupts" results (one for working setup, another for non working/droping setup) --
Jan 30, 12:04 pm 2009
Eric Dumazet
Re: Multicast packet loss
2.6.29-rc contains UDP receive improvements (lockless) Problem is multicast handling was not yet updated, but could be :) I was asking you "cat /proc/interrupts" because I believe you might have a problem NIC interrupts being handled by one CPU only (when having problems) --
Jan 30, 3:41 pm 2009
Eric Dumazet
Re: [PATCH] netfilter: unfold two critical loops in ip_p ...
So... you suggest me to split file, and use a "-funroll-loops", that might doing strange things on some arches / compilers... This is far too complicated and risky imho. Check compare_ether_addr_64bits() definition in include/linux/etherdevice.h for a truly unreadable code :) --
Jan 30, 10:27 am 2009
Eric Dumazet
Re: virt-manager broken by bind(0) in net-next.
Denying there is a bug is... well... I dont know what to say. Are you kidding ? bsockets is not part of socket structure, but part of "struct inet_hashinfo", shared by all cpus and accessed several thousand times per second on many machines. Please read the comment three lines after 'the free alignemnt slot' you chose.... You just introduced one write on a cache line that is supposed to *not* be written. unsigned int bhash_size; int ...
Jan 30, 3:30 pm 2009
Eric Dumazet
Re: [PATCH] netfilter: unfold two critical loops in ip_p ...
I dont want to unroll all loops, only those two :) I wish gcc (4.3.2 here) was litle bit smarter :( Without using -funroll-loops size ipv4/netfilter/ip_tables.o text data bss dec hex filename 6424 368 16 6808 1a98 net/ipv4/netfilter/ip_tables.o With -funroll-loops : size ipv4/netfilter/ip_tables.o text data bss dec hex filename 7144 368 16 7528 1d68 net/ipv4/netfilter/ip_tables.o With my patch and no ...
Jan 30, 9:54 am 2009
Eric Dumazet
Re: [PATCH 5/5] netfilter: convert x_tables to use RCU
Hum, I just checked and indeed there is a problem... #define SUM_COUNTER(s,c) do { (s).bcnt += (c).bcnt; (s).pcnt += (c).pcnt; } while(0) need to be changed to use #define SUM_COUNTER(s, c) do { xt_incr_counter(s, (c).cnt, (c).pcnt);} while (0) --
Jan 30, 12:02 am 2009
Eric Dumazet
Re: [PATCH 5/6] netfilter: use sequence number synchroni ...
You really want an inline xt_incr_counter() function here to speedup ipt_do_table() --
Jan 30, 1:03 am 2009
Dan Williams
Re: [PATCH 07/13] dmaengine: introduce dma_request_chann ...
Register multiple dma_devices, the public one with a DMA_MEMCPY, and the fixed role devices with DMA_PRIVATE, DMA_MEMCPY, and DMA_SLAVE capabilities. DMA_PRIVATE ensures that a channel is never considered for public consumption. -- Dan --
Jan 30, 4:13 pm 2009
Dan Williams
Re: [PATCH 09/13] atmel-mci: convert to dma_request_chan ...
No, the conversion is incomplete. After finding a channel that meets the slave requirements it is up to the driver to set the slave data. I will send a fix in a separate message. Thanks for the review, Dan --
Jan 30, 4:02 pm 2009
David Miller
Re: [PATCH] net: update documentation ip aliases
From: Stephen Hemminger <shemminger@vyatta.com> Applied, thanks a lot Stephen. --
Jan 29, 5:16 pm 2009
David Miller
Re: [0/4] GRO optimisations
From: Herbert Xu <herbert@gondor.apana.org.au> All applied to net-next-2.6, thanks Herbert! --
Jan 29, 5:54 pm 2009
David Miller
Re: [PATCH 00/20] sfc: Fixes and new PHY support for 2.6.29
From: Ben Hutchings <bhutchings@solarflare.com> Please resend the pure bug fixes. Thank you. --
Jan 29, 6:08 pm 2009
David Miller
Re: [PATCH] netxen: revert jumbo ringsize
From: Dhananjay Phadke <dhananjay@netxen.com> Applied, thanks. --
Jan 29, 5:05 pm 2009
David Miller
Re: [PATCH] drivers/net/skfp: if !capable(CAP_NET_ADMIN) ...
From: Roel Kluin <roel.kluin@gmail.com> Good catch Roel, patch applied. --
Jan 29, 6:32 pm 2009
David Miller
Re: Deadlock with icmpv6fuzz
From: Herbert Xu <herbert@gondor.apana.org.au> I'll try to take a stab at it later tonight. --
Jan 29, 6:49 pm 2009
David Miller
Re: tun new missing ioctl32
From: Michael Tokarev <mjt@tls.msk.ru> I'll take a look at this, thanks for the report. --
Jan 29, 5:06 pm 2009
David Miller
Re: [PATCH] sky2: fix hard hang with netconsoling and if ...
From: David Miller <davem@davemloft.net> Actually, I just read the followup where you indicated that other debugging printk's in this driver might also have the same problem. I'm dropping this until everything is resolved, thanks. --
Jan 29, 6:09 pm 2009
David Miller
Re: [PATCH 1/1] smsc9420: fix interrupt signalling test ...
From: Steve Glendinning <steve.glendinning@smsc.com> Applied, thanks Steve. --
Jan 29, 6:29 pm 2009
David Miller
Re: FEC patches
From: Sascha Hauer <s.hauer@pengutronix.de> I'll look these over and then queue them up for 2.6.30 Thanks! --
Jan 29, 5:04 pm 2009
David Miller
Re: [PATCH] sky2: fix hard hang with netconsoling and if ...
From: Alexey Dobriyan <adobriyan@gmail.com> Then you give me no choice, I have to apply this patch :-) Thanks! --
Jan 30, 2:45 pm 2009
David Miller
Re: [PATCH] ucc_geth: Change uec phy id to the same form ...
From: Kumar Gala <galak@kernel.crashing.org> Applied to net-2.6, thanks. --
Jan 29, 6:28 pm 2009
David Miller
Re: [PATCH] Fix infinite retry loop in IP-Config
From: Benjamin ZORES <benjamin.zores@alcatel-lucent.fr> Patch applied, thank you. --
Jan 29, 5:19 pm 2009
David Miller Jan 29, 6:30 pm 2009
David Miller Jan 29, 5:56 pm 2009
David Miller
Re: [PATCH] tulip : fix 21142 with 10Mbps without negotiation
From: Philippe De Muyter <phdm@macqel.be> Applied, thanks Philippe. --
Jan 30, 2:49 pm 2009
David Miller
Re: [Bugme-new] [Bug 12515] New: possible circular locki ...
From: Herbert Xu <herbert@gondor.apana.org.au> Looks good, applied. I rewrote the commit message as follows so that it actually matches what happens in the fix ;-) -------------------- packet: Avoid lock_sock in mmap handler As the mmap handler gets called under mmap_sem, and we may grab mmap_sem elsewhere under the socket lock to access user data, we should avoid grabbing the socket lock in the mmap handler. Since the only thing we care about in the mmap handler is for pg_vec* to be ...
Jan 30, 3:13 pm 2009
David Miller
Re: [PATCH v2] tcp: splice as many packets as possible at once
From: Jarek Poplawski <jarkao2@gmail.com> Hmmm, Jarek's comments here made me realize that we might be able to do some hack with cooperation with SLAB. Basically the idea is that if the page count of a SLAB page is greater than one, SLAB will not use that page for new allocations. It's cheesy and the SLAB developers will likely barf at the idea, but it would certainly work. Back to real life, I think long term the thing to do is to just do the cached page allocator thing we'll be doing ...
Jan 30, 2:42 pm 2009
David Miller
Re: [PATCH v2] tcp: splice as many packets as possible at once
From: Willy Tarreau <w@1wt.eu> Such a check could have performance ramifications, I wouldn't risk it and already I intend to push Jarek's page allocator Any NIC, even the dumbest ones, can be made to receive into pages. --
Jan 30, 3:03 pm 2009
David Miller
Re: [PANIC] lro + iscsi or lro + skb text search causes panic
From: Herbert Xu <herbert@gondor.apana.org.au> Excellent work everyone. I applied both Herbert's and Shyam's patches, and will queue them up for -stable as well. Thanks again. --
Jan 29, 5:13 pm 2009
David Miller
Re: [ofa-general] NetEffect, iw_nes and kernel warning
From: Roland Dreier <rdreier@cisco.com> local_bh_{enable,disable}() nests, so this is not a problem --
Jan 30, 2:51 pm 2009
David Miller
Re: [PATCH 01/11] sfc: SFT9001: Enable robust link training
From: Ben Hutchings <bhutchings@solarflare.com> I applied all of these patches but: 1) When you get changes written by other people, such as Steve Hodgson here and in the next few patches, you need to get Signed-off-by lines from them too. 2) Outside of the merge window I do not want to see totally irrelevant stuff like PHY loopback fixes. Those kinds of fixes are totally inappropriate at this time. You have been warned :-) --
Jan 30, 3:09 pm 2009
David Miller
Re: [PATCH v2] tcp: splice as many packets as possible at once
From: Willy Tarreau <w@1wt.eu> For a dumb NIC you wouldn't split, you'd receive directly, the entire packet, into part of a page. Then right befire you give it to the stack, you pull the ethernet header from the page into the linear area. --
Jan 30, 3:15 pm 2009
David Miller
Re: [PATCH] sky2: fix hard hang with netconsoling and if ...
From: Alexey Dobriyan <adobriyan@gmail.com> Alexey, can you get this tested by the reporter to make sure it really fixes the hang? Once it's been tested, I'll apply it. Thank you. --
Jan 29, 6:00 pm 2009
David Miller
[GIT]: Networking
More bug fixes, highlights: 1) IP-Config can loop forever retrying due to a bug in how the retry counter is initialized. Fix from Benjamin Zores. 2) iSCSI OOPS fixes from Herbert Xu and Shyam Iyer. 3) Several IPV6 multicast routing bug fixes from Thomas Goff. 4) Wireless bug fixes via John Linville. 5) E1000 shared interrupt handling fix from Jesse Brandeburg. 6) UDP port bind performance regression fix from Eric Dumazet. This came from the port randomization ...
Jan 30, 1:20 am 2009
David Miller
Re: [PATCH] decnet: incorrect optlen size
From: steve@chygwyn.com This code is fine as-is, every single case statement below this code makes an explicit optlen equality check before deferencing any member of the union object we copy into. I'm therefore dropping this patch. --
Jan 29, 6:15 pm 2009
David Miller
Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering
From: Rusty Russell <rusty@rustcorp.com.au> Right, no hurry. --
Jan 30, 12:12 am 2009
David Miller
Re: [Bugme-new] [Bug 12515] New: possible circular locki ...
From: Herbert Xu <herbert@gondor.apana.org.au> I might leave it in there for laughs :-) --
Jan 30, 3:05 pm 2009
David Miller
Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering
From: Alex Williamson <alex.williamson@hp.com> Rusty, are these good? If so, would you like you or I to take them? Thanks. --
Jan 29, 6:49 pm 2009
David Miller
Re: [PATCH] gianfar: Fix Wake-on-LAN support
From: Anton Vorontsov <avorontsov@ru.mvista.com> Applied, thanks Anton. --
Jan 29, 6:31 pm 2009
David Miller
Re: tun new missing ioctl32
From: David Miller <davem@davemloft.net> This should fix it: tun: Add some missing TUN compat ioctl translations. Based upon a report from Michael Tokarev <mjt@tls.msk.ru>: Just saw in dmesg: ioctl32(kvm:4408): Unknown cmd fd(9) cmd(800454cf){t:'T';sz:4} arg(ffc668e4) on /dev/net/tun Signed-off-by: David S. Miller <davem@davemloft.net> --- fs/compat_ioctl.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/fs/compat_ioctl.c ...
Jan 29, 5:53 pm 2009
Denys Fedoryschenko
Re: Multicast packet loss
I didn't work much on multicast, but i have heavy unicast udp streaming (PEP for satellite). First thing to check net.core.wmem_max = 131071 net.core.wmem_default = 124928 net.ipv4.udp_mem = 379008 505344 758016 Usually they are too small by default. next netstat -s Important part Udp: 1263992126 packets received 260196 packets to unknown port received. 627001 packet receive errors 74235906 packets sent RcvbufErrors: 56683 SndbufErrors: ...
Jan 30, 12:17 pm 2009
Divy Le Ray
Re: [0/4] GRO optimisations
Hi Herbert, I'll give these patches a try within a day or two. Please note that the 6Gb/s rate is achieved on a low perf server. Using this server makes it easy to witness the impact of optimizations. Faster boxes reach line rate. Just want to make clear that cxgb3 HW is not limited to 6Gb/s ;) Cheers, Divy --
Jan 29, 5:28 pm 2009
Eilon Greenstein Jan 30, 1:22 am 2009
Erik Slagter
Various strange things with ipv6 local multicast forwarding
Hi All, I am using a very simple setup: a linux server (linux 2.6.28.2, amd64) with 12 nics, almost each connected host has a nic uniquely to itself. On the server a program is running (poc-2250 to be precise) that streams data to multicast address ff05::4242. This data should be forwarded by the kernel to all interfaces that have hosts that are joined to ff05::4242. As it is such a simple setup, I do not want to use PIM nor a router application featuring PIM, I am using MLD messages ...
Jan 30, 6:42 am 2009
Guennadi Liakhovetski
Re: [PATCH 07/13] dmaengine: introduce dma_request_chann ...
Maybe just two dma-devices would suffice: one with the public memcpy channel, and one with the rest private slave channels? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer --
Jan 30, 4:27 pm 2009
Herbert Xu
Re: port bound SAs
Either fix racoon to use xfrm or go with a properly maintained key manager like one of the *swans. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 29, 11:30 pm 2009
Herbert Xu
Re: [PATCH v2] tcp: splice as many packets as possible at once
Yes that sounds like the way to go. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 30, 3:16 pm 2009
Herbert Xu
Re: virt-manager broken by bind(0) in net-next.
Yes, I think a good strace vs. a bad strace would be really helpful in these cases. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 30, 5:53 am 2009
Herbert Xu
[PATCH 2/4] gro: Avoid copying headers of unmerged packets
gro: Avoid copying headers of unmerged packets Unfortunately simplicity isn't always the best. The fraginfo interface turned out to be suboptimal. The problem was quite obvious. For every packet, we have to copy the headers from the frags structure into skb->head, even though for 99% of the packets this part is immediately thrown away after the merge. LRO didn't have this problem because it directly read the headers from the frags structure. This patch attempts to address this by ...
Jan 29, 5:19 pm 2009
Herbert Xu
Re: [ofa-general] NetEffect, iw_nes and kernel warning
I don't know about the rest but bnx2x is certainly OK since it only does so with IRQ enabled. It is legal to call skb_linearize as long as you're sure that IRQs are enabled, which is always the case for hard_start_xmit upon entry. So the only time you can't call it in hard_start_xmit is if you've just disabled IRQs yourself. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: ...
Jan 29, 11:57 pm 2009
Herbert Xu
[0/4] GRO optimisations
Hi Dave: This is a dump of my current patches to optimise GRO in order to get cxgb3 performance back up to the LRO level. I've got some more ideas but I'd like to get this out first so it doesn't rot in my tree. Oh and of course a direct LRO comparison isn't exactly fair because LRO skipped some tests such as checking the IP header checksum (naughty :) so the current 5.7 vs. 6.1 figure isn't all that bad. But I think we should be able to get back to 6Gb/s with cxgb3 at ...
Jan 29, 5:18 pm 2009
Herbert Xu
Re: [PATCH] net: fix setsockopt() locking errors
Well, doing the copy under sk_lock is pretty common through all protocols. So I think it'd be safer to change the other path, which is doing the odd thing here, i.e., ->mmap() grabbing the socket lock while holding mmap_sem. In fact, it would appear that we don't really need the socket lock in ->mmap() since it only needs to ensure that pg_vec* doesn't get yanked or changed. So this patch should work: packet: Avoid lock_sock in mmap handler As the mmap handler gets called under ...
Jan 29, 11:12 pm 2009
Herbert Xu Jan 30, 12:05 am 2009
Herbert Xu
[PATCH 4/4] gro: Open-code memcpy in napi_fraginfo_skb
gro: Open-code memcpy in napi_fraginfo_skb This patch optimises napi_fraginfo_skb to only copy the bits necessary. We also open-code the memcpy so that the alignment information is always available to gcc. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> --- net/core/dev.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c index 3742397..d55f725 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2541,6 +2541,8 @@ ...
Jan 29, 5:19 pm 2009
Herbert Xu
[PATCH 1/4] gro: Move common completion code into helpers
gro: Move common completion code into helpers Currently VLAN still has a bit of common code handling the aftermath of GRO that's shared with the common path. This patch moves them into shared helpers to reduce code duplication. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> --- include/linux/netdevice.h | 3 + net/8021q/vlan_core.c | 39 ++--------------------- net/core/dev.c | 76 +++++++++++++++++++++++++++++++--------------- 3 files changed, 59 ...
Jan 29, 5:19 pm 2009
Herbert Xu
Re: [Bugme-new] [Bug 12515] New: possible circular locki ...
Heh, that sentence should be removed from the description. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 30, 3:01 pm 2009
Herbert Xu
[PATCH 3/4] gro: Do not merge paged packets into frag_list
gro: Do not merge paged packets into frag_list Bigger is not always better :) It was easy to continue to merged packets into frag_list after the page array is full. However, this turns out to be worse than LRO because frag_list is a much less efficient form of storage than the page array. So we're better off stopping the merge and starting a new entry with an empty page array. In future we can optimise this further by doing frag_list merging but making sure that we continue to fill in ...
Jan 29, 5:19 pm 2009
Herbert Xu
Re: [Bugme-new] [Bug 12515] New: possible circular locki ...
Dave pointed out that a spin lock is illegal for this purpose as vm_insert_page can do a GFP_KERNEL allocation. So I've added a mutex for this. I've also widened the critical section in packet_set_ring since we need the mapped check to be within it. packet: Avoid lock_sock in mmap handler As the mmap handler gets called under mmap_sem, and we may grab mmap_sem elsewhere under the socket lock to access user data, we should avoid grabbing the socket lock in the mmap handler. Since the ...
Jan 30, 5:49 am 2009
Herbert Xu
Re: [PATCH 1/1] Return EINVAL if the user provides a ret ...
Why are you resending this patch with no real changes? We had already vetoed it in its current form. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 29, 11:20 pm 2009
Herbert Xu
Re: [0/4] GRO optimisations
It should be the same as the kernel that you did the last test on, i.e., the one that was giving 5.7Gb/s but please reconfirm Of course, any inferences that it was limited wasn't intentional :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt --
Jan 29, 6:29 pm 2009
Inaky Perez-Gonzalez
Re: [PATCH 2/3] wimax: replace uses of __constant_{endian}
Acked-by: Inaky Perez-Gonzalez <inaky@linux.intel.com> Thank you, -- Inaky --
Jan 30, 12:43 am 2009
Peter Korsgaard
Re: [BUG BISECTED] boot hangs while bringing up gianfar ...
>>>>> "Ira" == Ira Snyder <iws@ovro.caltech.edu> writes: Ira> Hello, Ira> I'm working on a Freescale MPC8349EMDS board. I have been Ira> booting it over NFS for a long time now. I try to run the latest Ira> git kernels to find possible problems. Ira> Recently, I haven't been able to boot over NFS anymore. When the machine Ira> tries to bring up the ethernet interface, it just hangs forever. There Ira> are no softlockup warnings, the machine has locked up completely. FYI, I'm ...
Jan 30, 7:57 am 2009
Jarek Poplawski
Re: [PATCH 2/3 net-next] pkt_sched: sch_htb: Warn on too ...
------------------> PATCH 2/3 pkt_sched: sch_htb: Warn on too many events. Let's get some info on possible config problems. This patch brings back an old warning, but is printed only once now. With feedback from Patrick McHardy <kaber@trash.net> Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- diff -Nurp b/net/sched/sch_htb.c c/net/sched/sch_htb.c --- b/net/sched/sch_htb.c 2009-01-29 22:07:42.000000000 +0000 +++ c/net/sched/sch_htb.c 2009-01-30 08:48:41.000000000 +0000 @@ -153,6 ...
Jan 30, 3:17 am 2009
Jarek Poplawski
Re: [PATCH 3/3 net-next] pkt_sched: sch_htb: Warn on too ...
(Changed In-Reply-To) OK, thanks, Jarek P. -------------> PATCH 3/3 pkt_sched: sch_htb: Use workqueue to schedule after too many events. Patrick McHardy <kaber@trash.net> suggested using a workqueue instead of hrtimers to trigger netif_schedule() when there is a problem with setting exact time of this event: 'The differnce - yeah, it shouldn't make much, mainly wake up the qdisc earlier (but not too early) after "too many events" occured _and_ no further enqueue events wake up the qdisc ...
Jan 30, 3:17 am 2009
Jarek Poplawski
Re: [PATCH 1/3 v2 net-next] pkt_sched: sch_htb: Warn on ...
OK, thanks, Jarek P. ------------------> take 2: PATCH 1/3 pkt_sched: sch_hfsc: sch_htb: Add non-work-conserving warning handler. This patch uses qdisc->flags field of "suspected" child qdisc. Signed-off-by: Jarek Poplawski <jarkao2@gmail.com> --- diff -Nurp a/include/net/pkt_sched.h b/include/net/pkt_sched.h --- a/include/net/pkt_sched.h 2009-01-02 21:21:37.000000000 +0100 +++ b/include/net/pkt_sched.h 2009-01-29 22:57:55.000000000 +0100 @@ -85,6 +85,7 @@ extern struct ...
Jan 30, 3:17 am 2009
Jarek Poplawski
Re: [Bugme-new] [Bug 12515] New: possible circular locki ...
On Fri, Jan 30, 2009 at 11:49:47PM +1100, Herbert Xu wrote: So, Dave is stronger than the temptation... Jarek P. --
Jan 30, 6:56 am 2009
Jan Engelhardt
Re: 2.6.28 headers break kbd and net-tools userspace builds
Yeah I just had to notice >:-( IPPROTO_MH is only defined in linux/in6.h, but inclusion of it: /usr/include/linux/in6.h:31: error: redefinition of ■struct in6_addr■ /usr/include/linux/in6.h:52: error: redefinition of ■struct sockaddr_in6■ /usr/include/linux/in6.h:60: error: redefinition of ■struct ipv6_mreq■ Ick. That's even worse than tunnels. --
Jan 29, 9:12 pm 2009
Kenny Chang
Multicast packet loss
Hi all, We've been having some issues with multicast packet loss, we were wondering if anyone knows anything about the behavior we're seeing. Background: we use multicast messaging with lots of messages per sec for our work. We recently transitioned many of our systems from an Ubuntu Dapper Drake ia32 distribution to Ubuntu Hardy Heron x86_64. Since the transition, we've noticed much more multicast packet loss, and we think it's related to the transition. Our particular theory is that it's ...
Jan 30, 10:49 am 2009
Kenny Chang
Re: Multicast packet loss
Ah, sorry, here's the test program attached. We've tried 2.6.28.1, but no, we haven't tried the 2.6.28.2 or the 2.6.29.-rcX. Right now, we are trying to step through the kernel versions until we see where the performance drops significantly. We'll try 2.6.29-rc soon and post the result. Neil Norman wrote: 1) Determine if its a rx or tx packet loss. From your comments above it sounds like this is an rx side issue We're pretty sure it's an rx issue. Other machines receiving at ...
Jan 30, 3:29 pm 2009
Kevin Hilman
Re: [RFC] ARM: Add SMSC911X support to Overo platform
Then here, add: #else static inline void __init overo_init_smsc911x(void) { return; } This allows you to drop the #ifdefs below and have it look a little cleaner. Other than that, looks OK to me. --
Jan 30, 3:18 pm 2009
Matt Carlson
Re: 2.6.29-rc3: tg3 dead after resume
O.K. Let's test some more assumptions. Can you apply the following patch and observe the system logs when the device is first loaded and again after resume. The patch looks at the pci command register to verify that memory space IO is indeed enabled. (It should be.) This is all that should be needed for MMIO to work. If the PCI_COMMAND message doesn't match, then it means that the PCI_COMMAND register isn't getting restored for some reason. If they do match, then something else in the ...
Jan 30, 11:40 am 2009
mcpc100
Powerball..Promo..Award
Contact Mr Francis Scott for the sum of £800,000 pounds GBP. Email: directiveboard24@ymail.com Tel:+44:7045731829 Names:............ Address:.............. Country:................ Phone No:................... Occupation:.................. Age:.......... Fax:.............. Regards Mrs.Caroline Jude --
Jan 30, 7:36 am 2009
Martin MOKREJŠ Jan 30, 10:17 am 2009
Neil Horman
Re: Multicast packet loss
Like Eric mentioned, I'd start with a latest kernel if at all possible. If it doesn't happen there, you're work is half over, you just need to figure out what changed, and tell Canonical to backport it. From there, you can solve this like most packet loss issues are solved: 1) Determine if its a rx or tx packet loss. From your comments above it sounds like this is an rx side issue 2) Look at statistics from the hardware to the application. Use ethtool & /proc/net/dev to get hardware ...
Jan 30, 1:03 pm 2009
Olivier MATZ
[PATCH] sctp: chunkmap size is too large
Hi all, I think that the chunkmap field in struct xt_sctp_info is too large: we have 256 chunk types and it's a bitfield, so the table should be 256 bits (8 uint32_t) instead of 64 uint32_t. I updated the size of the table, and I did some cosmetic changes in SCTP_CHUNKMAP_* macros (use a mask instead of a modulo). netfilter/xt_sctp.h | 30 ++++++++++++++++-------------- netfilter_ipv4/ipt_sctp.h | 30 ++++++++++++++++-------------- 2 files changed, 32 insertions(+), 28 ...
Jan 30, 8:43 am 2009
Parag Warudkar
Re: 2.6.29-rc3: tg3 dead after resume
This time it fails with different error on loading after suspend/resume cycle - 1196.873608] tg3 0000:0e:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16 [ 1196.873620] tg3 0000:0e:00.0: setting latency timer to 64 [ 1196.880017] tg3 0000:0e:00.0: PME# disabled [ 1196.996270] tg3: (0000:0e:00.0) phy probe failed, err -19 [ 1197.508033] tg3: Problem fetching invariants of chip, aborting. [ 1197.508048] tg3 0000:0e:00.0: PCI INT A disabled Parag --
Jan 30, 4:13 pm 2009
Parag Warudkar
Re: 2.6.29-rc3: tg3 dead after resume
Here is the output after applying the patch (fresh boot btw) - [ 29.698877] eth0: PCI_COMMAND reg = 0x406 (bit 1 is on) [ 29.698880] eth0: Reg value at offset 0x0 is 0x167b14e4 [ 29.758169] ADDRCONF(NETDEV_UP): eth0: link is not ready [ 31.295087] tg3: eth0: Link is up at 100 Mbps, full duplex. [ 31.295090] tg3: eth0: Flow control is off for TX and off for RX. [ 31.297574] ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready [ 41.872007] eth0: no IPv6 routers present ^^^ ...
Jan 30, 3:50 pm 2009
Parag Warudkar
Re: 2.6.29-rc3: tg3 dead after resume
Totally worth having this problem from a "getting an opportunity to understand" standpoint. This confirms my long standing suspicion that bugs in Linux kernel are merely a handiwork of few clever people to get more people to understand and contribute :) Any how here is the pre-suspend lspci -vvxxx output followed by diff -u - 00:00.0 Host bridge: Intel Corporation 5400 Chipset Memory Controller Hub (rev 20) Subsystem: Hewlett-Packard Company Device 1307 Control: I/O- Mem- ...
Jan 30, 4:45 pm 2009
Parag Warudkar
Re: 2.6.29-rc3: tg3 dead after resume
No difference - tg3 is still dead after resume. BTW, I applied the patch on top of the one Matt gave earlier. Machine booted with original tg3 which I rmmod'ed and then insmod'ed the new one (with Matt's and Rafael's patch) and then attempted a suspend-resume. Is there a reason to try fresh boot with patched tg3 and without loading old module - I guess I will try that one later as well. Thanks Parag --
Jan 30, 3:31 pm 2009
Paul E. McKenney Jan 29, 6:05 pm 2009
Paweł Staszewski
ixgbe in kernel driver question
I have question about ixgbe in kernel driver compared to ixgbe driver that is on sourceforge http://sourceforge.net/project/showfiles.php?group_id=42302&package_id=247088 What is difference between this drivers ? and does driver in kernel 2.6.28.2 ixgbe: Intel(R) 10 Gigabit PCI Express Network Driver - version 1.3.30-k2 ixgbe: Copyright (c) 1999-2007 Intel Corporation. ixgbe 0000:01:00.0: setting latency timer to 64 is this driver closest version to ...
Jan 30, 9:11 am 2009
Paweł Staszewski
Re: [ SPAM ] ixgbe in kernel driver question
And i use kernel 2.6.28.2 my lspci shows my intel card as: ... 01:00.0 Ethernet controller: Intel Corporation Device 10dd (rev 01) ... My installed card in this machine is: Intel® 82598EB 10 Gigabit Ethernet Controller with CX4 interface --
Jan 30, 9:22 am 2009
Roland Dreier
Re: [ofa-general] NetEffect, iw_nes and kernel warning
> > OK, thanks... what confused me is that several other drivers also do > > skb_linearize() in their hard_start_xmit method... eg bnx2x, > > via-velocity, mv643xx_eth. So there are several other lurking bugs to > > deal with here I guess. > > I don't know about the rest but bnx2x is certainly OK since it > only does so with IRQ enabled. It is legal to call skb_linearize > as long as you're sure that IRQs are enabled, which is always the > case for hard_start_xmit upon entry. I ...
Jan 30, 10:35 am 2009
Rick Jones
Re: [0/4] GRO optimisations
That is what netperf service demand is for :) so you can see the effect of changes even when you are link-bound. rick jones --
Jan 29, 5:37 pm 2009
Rafael J. Wysocki
Re: 2.6.29-rc3: tg3 dead after resume
OK, so it requires more care to be taken. However, suspend-resume seems to work on my test box with this patch applied, although admittedly I haven't tested WoL. If that were the case, it wouldn't work after a resume with the patch applied. Are you sure this actually happens? On my box the chip is in D0 already Anyway, I'd very much prefer to separate the generic PCI operations from the device-specific code. Thanks, Rafael --
Jan 29, 5:10 pm 2009
Rafael J. Wysocki
Re: 2.6.29-rc3: tg3 dead after resume
Thanks for testing. Well, I'm not sure if tg3 is at fault, really. What happens if you unload tg3 before suspend and load it back after the resume? Rafael --
Jan 30, 3:54 pm 2009
Rafael J. Wysocki
Re: 2.6.29-rc3: tg3 dead after resume
[--snip--] and the PCIe port driver may be at fault. Can you try to remove the pci_save_state(dev) from pcie_port_suspend_late() and see if that helps? Rafael --
Jan 30, 4:59 pm 2009
Rafael J. Wysocki
Re: 2.6.29-rc3: tg3 dead after resume
It seems like something between the tg3 chip and the host CPU doesn't work correctly after resume, Linus is right. I wonder if this change makes any difference: --- linux-2.6.orig/drivers/pci/pci-driver.c +++ linux-2.6/drivers/pci/pci-driver.c @@ -501,6 +501,9 @@ static int pci_pm_suspend(struct device if (pci_has_legacy_pm_support(pci_dev)) return pci_legacy_suspend(dev, PMSG_SUSPEND); + if (!drv || !drv->pm) + return 0; + if (drv && drv->pm && drv->pm->suspend) { error ...
Jan 30, 4:31 pm 2009
Rusty Russell
Re: [PATCH 4/5] virtio_net: Add a MAC filter table
The command is simply "set the filter", not "add" and "delete", so the host doesn't have this problem. VLAN has more of an issue: that has add and del. So the host can do a counting hash, or say remember 16 and then a count of overflows, but both will be suboptimal over time. Cheers, Rusty. --
Jan 30, 12:03 am 2009
Rusty Russell
Re: [PATCH v2 1/4] virtio_net: Add a virtqueue for outbo ...
Hmm, I prefer initialize buffer, then set sg to refer to it. Seems to make Or "return status == VIRTIO_NET_OK;" ? See what I mean about nit-picking? Rusty. --
Jan 29, 10:08 pm 2009
Rusty Russell
Re: [PATCH v2 3/4] virtio_net: Add a MAC filter table
It's kind of annoying that we have our virtnet_send_command helper and yet we can't use it here. Hmm, maybe we can kill two birds in one stone? I was a bit nervous about the virtnet_send_command data arg because the pointer must not be vmalloc'ed memory. If we make the arg to virtnet_send_command an sg[] in place of data & len, we force the caller to do the sg_set_buf (which means they *should* be aware of the limitation on what can be put in an sg), and we can make a copy (ideally we could ...
Jan 29, 10:46 pm 2009
Rusty Russell
Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering
Still nitpicking. We'll wrestle a bit more, then I'll ack them to you. These are 2.6.30 material, so no huge hurry AFAICT? Thanks, Rusty. --
Jan 30, 12:05 am 2009
Rusty Russell
Re: [PATCH v2 4/4] virtio_net: Add support for VLAN filt ...
Hmm, I should have mentioned dev_warn() in previous patches. And possibly (since we never expect it to happen), we should move it into virtnet_send_command to save all the callers sweating on it. It'd be We can kill VLAN_ENABLE. We activate it by acking the feature bit. So this becomes: if (virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VLAN)) s/will be dropped/may be filtered out by the host/ ? Cheers, Rusty. --
Jan 29, 11:01 pm 2009
Rusty Russell
Re: [PATCH v2 2/4] virtio_net: Add a set_rx_mode interface
Hmm, this check duplicates the one in virtnet_send_command; after Comment above/beside these two perhaps? /* Supported if VIRTIO_NET_F_CTRL_RX */ Cheers, Rusty. --
Jan 29, 10:30 pm 2009
Rusty Russell
Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering
Yep, now I'll go through the patches more carefully. I know it's a pain to get this kind of nit-picking feedback, but it's an ordeal I force on everyone the first time they make a major contribution; it ensures the code "feels" consistent and means that when I read the code in future I'm not surprised by things which aren't *quite* how I expect. Note that I tend to comment on *everything* where I would have done it differently. So I expect you to argue at least half of ...
Jan 29, 10:03 pm 2009
Steve Sakoman
[RFC] ARM: Add SMSC911X support to Overo platform
Gumstix will soon be shipping a variant of their Summit board that includes an SMSC9221 ethernet interface. This patch is intended to provide support via the smsc911x driver when enabled in defconfig. The final submission of course will also include an updated defconfig. Signed-off-by: Steve Sakoman <steve@sakoman.com> --- diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c index 9995ac2..97d95a4 100644 --- a/arch/arm/mach-omap2/board-overo.c +++ ...
Jan 30, 1:28 pm 2009
Steve Sakoman
Re: [RFC] ARM: Add SMSC911X support to Overo platform
Just to see if anyone was paying attention, I pasted the version with the stupid typos :-) --
Jan 30, 1:43 pm 2009
Stephen Hemminger
virt-manager broken by bind(0) in net-next.
On Thu, 29 Jan 2009 10:35:44 +0000 The problem is only in the net-next tree (not mainline 2.6.29-rcX). Bisected down to this commit is the problem: a9d8f9110d7e953c2f2b521087a4179677843c2a is first bad commit commit a9d8f9110d7e953c2f2b521087a4179677843c2a Author: Evgeniy Polyakov <zbr@ioremap.net> Date: Mon Jan 19 16:46:02 2009 -0800 inet: Allowing more than 64k connections and heavily optimize bind(0) time. With simple extension to the binding mechanism, which allows to ...
Jan 29, 10:35 pm 2009
Stephen Hemminger
[PATCH 5/6] netfilter: use sequence number synchronizati ...
Change how synchronization is done on the iptables counters. Use seqcount wrapper instead of depending on reader/writer lock. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- a/net/netfilter/x_tables.c 2009-01-30 09:15:52.648542116 -0800 +++ b/net/netfilter/x_tables.c 2009-01-30 09:17:03.669061821 -0800 @@ -577,18 +577,36 @@ int xt_compat_target_to_user(struct xt_e EXPORT_SYMBOL_GPL(xt_compat_target_to_user); #endif +static DEFINE_PER_CPU(seqcount_t, ...
Jan 30, 2:57 pm 2009
Stephen Hemminger
[PATCH 0/6] iptables: eliminate read/write lock (v0.4)
More of Eric's suggestions, handle the case of aggregation of counters correctly. Unfortunately, can't easily make xt_add_counter inline because DEFINE_PER_CPU doesn't seem to export to modules correctly. -- --
Jan 30, 2:57 pm 2009
Stephen Hemminger
Re: skge finds PCI error cmd=0x117 status=0x22b0 in 2.6.27.7
On Thu, 29 Jan 2009 17:45:48 -0800 The driver supports >4G of memory (64 bit DMA), but sometimes the motherboard That would imply that a pci quirk should be created. --
Jan 30, 12:15 pm 2009
Stephen Hemminger
Re: [ofa-general] NetEffect, iw_nes and kernel warning
On Fri, 30 Jan 2009 17:57:21 +1100 Or netconsole. netconsole calls start_xmit from IRQ but it is safe since netconsole doesn't send fragmented skb's --
Jan 30, 9:25 am 2009
Stephen Hemminger
Re: virt-manager broken by bind(0) in net-next.
On Fri, 30 Jan 2009 23:53:37 +1100 I have the strace but it comes up no different. What is different is that in the broken case (net-next), I see IPV6 being used: State Recv-Q Send-Q Local Address:Port Peer Address:Port ESTAB 23769 0 ::ffff:127.0.0.1:5900 ::ffff:127.0.0.1:55987 ESTAB 0 0 127.0.0.1:55987 127.0.0.1:5900 and in the working case (2.6.29-rc3), IPV4 is being used State Recv-Q Send-Q Local ...
Jan 30, 10:57 am 2009
Stephen Hemminger
[PATCH 6/6] netfilter: convert x_tables to use RCU
Replace existing reader/writer lock with Read-Copy-Update to elminate the overhead of a read lock on each incoming packet. This should reduce the overhead of iptables especially on SMP systems. The previous code used a reader-writer lock for two purposes. The first was to ensure that the xt_table_info reference was not in process of being changed. Since xt_table_info is only freed via one routine, it was a direct conversion to RCU. The other use of the reader-writer lock was to to block ...
Jan 30, 2:57 pm 2009
Stephen Hemminger
virt-manager broken by bind(0) in net-next.
Resend without screenshot that upsets vger spam filter! The bind(0) optimization in David's net-next breaks virt machine manager when a guest console window is started. virt-machine-manager click local-host (System) Run one of the existing VM's The virtual console window then cause a dialog about allowing remote access to display; (this never happened with earlier kernels), regression #1 Then if I allow it multiple copies of the window start cloning and general chaos ensues. The ...
Jan 29, 11:50 pm 2009
Stephen Hemminger
[PATCH 2/6] netfilter: remove unneeded initializations
Later patches change the locking on xt_table and the initialization of the lock element is not needed since the lock is always initialized in xt_table_register anyway. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- net/ipv4/netfilter/arptable_filter.c | 2 -- net/ipv4/netfilter/iptable_filter.c | 1 - net/ipv4/netfilter/iptable_mangle.c | 1 - net/ipv4/netfilter/iptable_raw.c | 1 - net/ipv4/netfilter/iptable_security.c | 1 - ...
Jan 30, 2:57 pm 2009
Stephen Hemminger
[PATCH 4/6] netfilter: abstract xt_counters
Break out the parts of the x_tables code that manipulates counters so changes to locking are easier. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- include/linux/netfilter/x_tables.h | 6 +++++- net/ipv4/netfilter/arp_tables.c | 9 +++++---- net/ipv4/netfilter/ip_tables.c | 9 +++++---- net/ipv6/netfilter/ip6_tables.c | 21 +++++++++++---------- net/netfilter/x_tables.c | 15 +++++++++++++++ 5 files changed, 41 insertions(+), 19 ...
Jan 30, 2:57 pm 2009
Stephen Hemminger
[PATCH 3/6] ebtables: remove unneeded initializations
The initialization of the lock element is not needed since the lock is always initialized in ebt_register_table. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- net/bridge/netfilter/ebtable_broute.c | 1 - net/bridge/netfilter/ebtable_filter.c | 1 - net/bridge/netfilter/ebtable_nat.c | 1 - 3 files changed, 3 deletions(-) --- a/net/bridge/netfilter/ebtable_broute.c 2009-01-27 17:09:10.313100854 -0800 +++ b/net/bridge/netfilter/ebtable_broute.c 2009-01-27 ...
Jan 30, 2:57 pm 2009
Stephen Hemminger
Re: [PATCH] sky2: fix hard hang with netconsoling and if ...
On Fri, 30 Jan 2009 13:45:50 -0800 (PST) Yes, this is a nice harmless change Acked-by: Stephen Hemminger <shemminger@vyatta.com> --
Jan 30, 3:01 pm 2009
Stephen Hemminger
[PATCH 1/6] netfilter: change elements in x_tables
Change to proper type on private pointer rather than anonymous void. Keep active elements on same cache line. Signed-off-by: Stephen Hemminger <shemminger@vyatta.com> --- include/linux/netfilter/x_tables.h | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) --- a/include/linux/netfilter/x_tables.h 2009-01-26 17:24:43.251543415 -0800 +++ b/include/linux/netfilter/x_tables.h 2009-01-26 17:29:12.510649107 -0800 @@ -349,9 +349,6 @@ struct xt_table { struct list_head ...
Jan 30, 2:57 pm 2009
Thomas Graf
Re: iproute2, meta, flex parser bug?
Try: tc filter ... basic match 'meta(rt_iif eq <NUM>)' classid XX:YY --
Jan 30, 6:20 am 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
I don't think that's right. Now you don't end up calling pci_pm_default_suspend_generic() at all, and this no pci_save_state(). But I think it could easily be the call to pci_disable_enabled_device(). It does that if (atomic_read(&dev->enable_cnt)) do_pci_disable_device(dev); and that ends up disabling PCI_COMMAND_MASTER and then calling pcibios_disable_device(). Any device we have ever done pci_enable_device() on would trigger this, which includes PCIE bridges, for ...
Jan 30, 4:51 pm 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
As long as you didn't suspend/resume with the old module loaded, it really shouldn't matter. Linus --
Jan 30, 3:36 pm 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
It might also be instructive to see the same thing for a working kernel. I assume plain 2.6.28 works for you? Linus --
Jan 30, 4:33 pm 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
We've disabled IO and MEM behind this bridge - the one that bridges to secondary bus 0x0e. And your tg3 device? It's at 0000:0e:00.0. Yeah. Exactly the bus that we've disabled IO and MEM for. In other words, it was never your tg3 suspend/resume that was buggy. It was the suspend/resume for the PCI-E port driver. In fact, I think it's _exactly_ the issue I just emailed out about. I bet Rafael can whip up a patch in a minute. I have too much of a headache right now to look at ...
Jan 30, 4:57 pm 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
Yes, good thing to test. See my previous email - maybe it's a bridge. Linus --
Jan 30, 4:07 pm 2009
Linus Torvalds
Re: 2.6.29-rc3: tg3 dead after resume
One thing strikes me - are there any bridges between the host (CPU) and that tg3 device? Because we obviously have two people who say that their tg3 suspend/resume works fine, so the tg3 driver is obviously not _totally_ broken. So I'm wondering if there is something funny in between the CPU and the tg3, like a hotplug bridge that needs magic to wake up properly. Because clearly the PCI config space addresses are working fine, but the thing is, while PCI config space accesses are ...
Jan 30, 4:06 pm 2009
Willy Tarreau
Re: [PATCH v2] tcp: splice as many packets as possible at once
I thought it was the standard behaviour. That may explain why I Maybe that would be enough as a definitive fix for a stable release, so that we can go on with deeper changes in newer Are there NICs out there able to do that themselves or does the driver need to rely on complex hacks in order to achieve this ? Willy --
Jan 30, 2:59 pm 2009
Willy Tarreau
Re: [PATCH v2] tcp: splice as many packets as possible at once
OK I thought that it was not always easy to split between headers and payload. I know that myri10ge can be configured to receive into either skbs or pages, but I was not sure about the real implications behind that. Thanks Willy --
Jan 30, 3:13 pm 2009
Evgeniy Polyakov
Re: virt-manager broken by bind(0) in net-next.
So it is not explicit bind call, but port autoselection in the connect(). Can you check what errno is returned? Did I understand it right, that connect fails, you try different address, but then suddenly all those sockets become 'alive'? -- Evgeniy Polyakov --
Jan 30, 4:21 am 2009
Evgeniy Polyakov
Re: virt-manager broken by bind(0) in net-next.
It is not a bug. It is not supposed to be precise. At all. I implemented a simple heuristic on when diferent bind port selection algorithm should start: roughly when number of opened sockets equals to some predefined value (sysctl at the moment, but it could be 64k or anything else), so if that number is loosely maintained and does not precisely corresponds to the number of sockets, it is not a problem. You also saw 'again' lavel which has magic 5 number - it is another heuristic - since lock ...
Jan 30, 3:51 pm 2009
Evgeniy Polyakov
Re: virt-manager broken by bind(0) in net-next.
It should contain rough number of sockets, there is no need to be very I used free alignment slot so that socket structure would not be I think it should be smallest_size != -1, since we really want to goto to the again label when hueristic is used, which in turn changes smallest_size. -- Evgeniy Polyakov --
Jan 30, 2:50 pm 2009
Evgeniy Polyakov
Re: virt-manager broken by bind(0) in net-next.
Hi. Any chance to get a bit more information about what this console does? Like how it binds or get a strace? Will you be able to run a debug patch which will dump lots of info into the dmesg and slow things down a bit? -- Evgeniy Polyakov --
Jan 30, 1:16 am 2009
previous daytodaynext day
January 29, 2009January 30, 2009January 31, 2009