Re: [RFC] ARM: Add SMSC911X support to Overo platform

Previous thread: Re: skge finds PCI error cmd=0x117 status=0x22b0 in 2.6.27.7 by Stephen Hemminger on Friday, January 30, 2009 - 12:15 pm. (1 message)

Next thread: [PATCH 0/6] iptables: eliminate read/write lock (v0.4) by Stephen Hemminger on Friday, January 30, 2009 - 2:57 pm. (1 message)
From: Steve Sakoman
Date: Friday, January 30, 2009 - 1:28 pm

Gumstix will soon be shipping a variant of their Summit board that
includes an SMSC9221 ethernet interface.  This patch is intended to
provide support via the smsc911x driver when enabled in defconfig.
The final submission of course will also include an updated defconfig.

Signed-off-by: Steve Sakoman <steve@sakoman.com>
---
diff --git a/arch/arm/mach-omap2/board-overo.c
b/arch/arm/mach-omap2/board-overo.c
index 9995ac2..97d95a4 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -55,6 +55,63 @@
 #define GPMC_CS0_BASE  0x60
 #define GPMC_CS_SIZE   0x30

+#if defined(CONFIG_SMSC911X) || defined(CONFIG_SMSC911X_MODULE)
+
+#include <linux/smsc911x.h>
+
+static struct resource overo_smsc911x_resources[] = {
+	{
+		.name	= "smsc911x-memory",
+		.flags	= IORESOURCE_MEM,
+	},
+	{
+		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
+	},
+};
+
+static struct smsc911x_platform_config overo_smsc911x_config = {
+	.irq_polarity	= SMSC911X_IRQ_POLARITY_ACTIVE_LOW,
+	.irq_type	= SMSC911X_IRQ_TYPE_OPEN_DRAIN,
+	.flags		= SMSC911X_USE_32BIT ,
+	.phy_interface	= PHY_INTERFACE_MODE_MII,
+};
+
+static struct platform_device overo_smsc911x_device = {
+	.name		= "smsc911x",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(overo_smsc911x_resources),
+	.resource	= &overo_smsc911x_resources,
+	.dev		= {
+		.platform_data = &overo_smsc911x_config,
+	},
+};
+
+static inline void __init overo_init_smsc911x(void)
+{
+	unsigned long cs_mem_base;
+
+	if (gpmc_cs_request(OVERO_SMSC911X_CS, SZ_16M, &cs_mem_base) < 0) {
+		printk(KERN_ERR "Failed request for GPMC mem for smsc911x\n");
+		return;
+	}
+
+	overo_smsc911x_resources[0].start = cs_mem_base + 0x0;
+	overo_smsc911x_resources[0].end   = cs_mem_base + 0xff;
+
+	if ((gpio_request(OVERO_SMSC911X_GPIO, "SMSC911X IRQ") == 0) &&
+	    (gpio_direction_input(OVERO_SMSC911X_GPIO) == 0)) {
+		gpio_export(OVERO_SMSC911X_GPIO, 0);
+	} else {
+		printk(KERN_ERR "could not obtain gpio for SMSC911X ...
From: Steve Sakoman
Date: Friday, January 30, 2009 - 1:43 pm

Just to see if anyone was paying attention, I pasted the version with
the stupid typos :-)

--

From: Kevin Hilman
Date: Friday, January 30, 2009 - 3:18 pm

Then here, add:

#else
static inline void __init overo_init_smsc911x(void) { return; }

This allows you to drop the #ifdefs below and have it look a little
cleaner.

Other than that, looks OK to me.

--

Previous thread: Re: skge finds PCI error cmd=0x117 status=0x22b0 in 2.6.27.7 by Stephen Hemminger on Friday, January 30, 2009 - 12:15 pm. (1 message)

Next thread: [PATCH 0/6] iptables: eliminate read/write lock (v0.4) by Stephen Hemminger on Friday, January 30, 2009 - 2:57 pm. (1 message)