Hello list
with current kernels, tulip 21142 ethernet controllers fail to connect
to a 10Mbps only (i.e. without negotiation-partner) network. It used
to work in 2.4 kernels. Fix that. Tested on a 21142 Rev 0x11.
Signed-off-by: Philippe De Muyter <phdm@macqel.be>
diff -r 4e8869c1d518 drivers/net/tulip/21142.c
--- a/drivers/net/tulip/21142.c Sat Jan 17 23:00:27 2009 +0000
+++ b/drivers/net/tulip/21142.c Tue Jan 27 16:44:04 2009 +0100
@@ -9,6 +9,11 @@
Please refer to Documentation/DocBook/tulip-user.{pdf,ps,html}
for more information on this driver.
+
+ DC21143 manual "21143 PCI/CardBus 10/100Mb/s Ethernet LAN Controller
+ Hardware Reference Manual" is currently available at
+ http://developer.intel.com/design/network/manuals/278074.htm
+
Please submit bugs to http://bugzilla.kernel.org/ .
*/
@@ -32,7 +37,11 @@ void t21142_media_task(struct work_struc
int csr12 = ioread32(ioaddr + CSR12);
int next_tick = 60*HZ;
int new_csr6 = 0;
-
+ int csr14 = ioread32(ioaddr + CSR14);
+
+ /* CSR12[LS10,LS100] are not reliable during autonegotiation */
+ if ((csr14 & 0x80) && (csr12 & 0x7000) != 0x5000)
+ csr12 |= 6;
if (tulip_debug > 2)
printk(KERN_INFO"%s: 21143 negotiation status %8.8x, %s.\n",
dev->name, csr12, medianame[dev->if_port]);
@@ -76,7 +85,7 @@ void t21142_media_task(struct work_struc
new_csr6 = 0x83860000;
dev->if_port = 3;
iowrite32(0, ioaddr + CSR13);
- iowrite32(0x0003FF7F, ioaddr + CSR14);
+ iowrite32(0x0003FFFF, ioaddr + CSR14);
iowrite16(8, ioaddr + CSR15);
iowrite32(1, ioaddr + CSR13);
}
@@ -132,10 +141,14 @@ void t21142_lnk_change(struct net_device
struct tulip_private *tp = netdev_priv(dev);
void __iomem *ioaddr = tp->base_addr;
int csr12 = ioread32(ioaddr + CSR12);
-
+ int csr14 = ioread32(ioaddr + CSR14);
+
+ /* CSR12[LS10,LS100] are not reliable during autonegotiation */
+ if ((csr14 & 0x80) && (csr12 & 0x7000) != 0x5000)
+ csr12 |= 6;
if (tulip_debug > 1)
...From: Philippe De Muyter <phdm@macqel.be> Applied, thanks Philippe. --
Hello, I have just installed 2.6.31 (from opensuse 11.2) one a tulip-equipped computer and I get the following error message from the kernel : [ 2495.526390] ------------[ cut here ]------------ [ 2495.526390] kernel BUG at /usr/src/packages/BUILD/kernel-default-2.6.31.5/linux-2.6.31/include/linux/netdevice.h:439! [ 2495.526390] invalid opcode: 0000 [#1] SMP [ 2495.526390] last sysfs file: /sys/devices/pci0000:00/0000:00:07.1/host0/target0:0:0/0:0:0:0/block/sda/uevent [ 2495.526390] Modules linked in: ohci_hcd raw1394 ohci1394 ieee1394 acpi_cpufreq speedstep_lib processor thermal_sys hwmon edd ipv6 af_packet fuse loop dm_mod rtc_cmos rtc_core rtc_lib apm pcspkr sg tulip uhci_hcd ehci_hcd reiserfs ata_piix ahci libata [ 2495.526390] [ 2495.526390] Pid: 339, comm: kapmd Not tainted (2.6.31.5-0.1-default #1) [ 2495.526390] EIP: 0060:[<c3d6045d>] EFLAGS: 00010246 CPU: 0 [ 2495.526390] EIP is at tulip_up+0xa2d/0xa80 [tulip] [ 2495.526390] EAX: 00000000 EBX: c1cd7000 ECX: c022af50 EDX: 0001ec00 [ 2495.526390] ESI: c1cd7340 EDI: 00000000 EBP: c20bde44 ESP: c20bddfc [ 2495.526390] DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068 [ 2495.526390] Process kapmd (pid: 339, ti=c20bc000 task=c25a32c0 task.ti=c20bc000) [ 2495.526390] Stack: [ 2495.526390] 0000000b c20bde44 c02acf76 2caa9a94 c2481800 c20bde38 c043ca4a c20bde27 [ 2495.526390] <0> 069ee44b c20ec120 c087c020 0001ec00 c1cd7000 c3d5c720 2caa9a94 c1cd7000 [ 2495.526390] <0> c2480000 00000000 c20bde68 c3d60555 00000080 c1cd7000 c1cd7000 2caa9a94 [ 2495.526390] Call Trace: [ 2495.526390] [<c3d60555>] tulip_resume+0xa5/0xd0 [tulip] [ 2495.526390] [<c043dd65>] pci_legacy_resume+0x35/0x60 [ 2495.526390] [<c043df2f>] pci_pm_resume+0x7f/0xb0 [ 2495.526390] [<c04d82f2>] pm_op+0xd2/0x180 [ 2495.526390] [<c04d91ee>] device_resume+0x5e/0x1a0 [ 2495.526390] [<c04d93dd>] dpm_resume+0xad/0x140 [ 2495.526390] [<c04d948b>] dpm_resume_end+0x1b/0x40 [ 2495.526390] [<c3db1978>] check_events+0x148/0x240 [apm] [ 2495.526390] [<c3db23a2>] ...
From: Philippe De Muyter <phdm@macqel.be> I took some looks at this bug. I simply can't figure out how this is possible. As both suspend and resume make sure to make the necessary napi_disable() and napi_enable() calls, and therefore they should match up and not trigger this BUG(). I'll try to study the code some more when I get a chance. --
