[PATCH] fix memory leak in drivers/net/netxen_nic_init.c

Previous thread: none

Next thread: [PATCH 00/20] sfc: Fixes and new PHY support for 2.6.29 by Ben Hutchings on Thursday, January 29, 2009 - 12:12 pm. (40 messages)
From: Daniel
Date: Thursday, January 29, 2009 - 11:55 am

From: Daniel Marjamäki <danielm77@spray.se>

For kernel bugzilla #12537:
http://bugzilla.kernel.org/show_bug.cgi?id=12537

Free memory.

Signed-off-by: Daniel Marjamäki <danielm77@spray.se>
Reported-by: Daniel Marjamäki <danielm77@spray.se>
---
diff --git a/drivers/net/netxen/netxen_nic_init.c b/drivers/net/netxen/netxen_nic_init.c
index ca7c8d8..ffd37be 100644
--- a/drivers/net/netxen/netxen_nic_init.c
+++ b/drivers/net/netxen/netxen_nic_init.c
@@ -947,8 +947,10 @@ int netxen_pinit_from_rom(struct netxen_adapter *adapter, int verbose)
 	}
 	for (i = 0; i < n; i++) {
 		if (netxen_rom_fast_read(adapter, 8*i + 4*offset, &val) != 0 ||
-		netxen_rom_fast_read(adapter, 8*i + 4*offset + 4, &addr) != 0)
+		netxen_rom_fast_read(adapter, 8*i + 4*offset + 4, &addr) != 0) {
+			kfree(buf);
 			return -EIO;
+		}

 		buf[i].addr = addr;
 		buf[i].data = val;




--

Previous thread: none

Next thread: [PATCH 00/20] sfc: Fixes and new PHY support for 2.6.29 by Ben Hutchings on Thursday, January 29, 2009 - 12:12 pm. (40 messages)