Home » Mailing list archives » linux-netdev » 2009 » January » 27

Re: [PATCH] ide/net: flip the order of SATA and network init

Previous thread: Re: [Bugme-new] [Bug 12515] New: possible circular locking #0: (sk_lock-AF_PACKET){--..}, at: [<c1279838>] sock_setsockopt+0x12b/0x4a4 by Andrew Morton on Tuesday, January 27, 2009 - 2:43 pm. (9 messages)

Next thread: none
[view original message]
From: Arjan van de Ven
Subject: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 3:19 pm

From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
From: Arjan van de Ven &lt;arjan@linux.intel.com&gt;
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure
other drivers that run after it can execute in parallel. Network drivers do tend
to take some real time talking to the hardware, so running these later is
a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

Signed-off-by: Arjan van de Ven &lt;arjan@linux.intel.com&gt;
---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/Makefile b/drivers/Makefile
index c1bf417..2618a61 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/
-- 
1.6.0.5



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 3:26 pm

From: Arjan van de Ven &lt;arjan@infradead.org&gt;

I have no problem with this:

Acked-by: David S. Miller &lt;davem@davemloft.net&gt;
--


[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 4:35 pm

ACK, ok with me too

--


[ message continues ]
[view original message]
From: Arjan van de Ven
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 5:48 pm

On Tue, 27 Jan 2009 18:35:37 -0500

ok so... which tree should this go via?

I would guess jgarzik's because he deals with both sata and net ;)

Jeff... how do you want to handle this?

-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 6:23 pm

From: Arjan van de Ven &lt;arjan@infradead.org&gt;

Feel free to just submit it directly to Linus, you have both
of our ACKs :-)
--


[ message continues ]
[view original message]
From: Jeff Garzik
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 6:59 pm

ACK :)


--


[ message continues ]
[view original message]
From: Bartlomiej Zolnierkiewicz
Subject: Re: [PATCH] ide/net: flip the order of SATA and network init
Date: Tuesday, January 27, 2009 - 5:22 pm

scsi, ide, macintosh and nubus will be now init-ed after network.

--


[ message continues ]
Previous thread: Re: [Bugme-new] [Bug 12515] New: possible circular locking #0: (sk_lock-AF_PACKET){--..}, at: [<c1279838>] sock_setsockopt+0x12b/0x4a4 by Andrew Morton on Tuesday, January 27, 2009 - 2:43 pm. (9 messages)

Next thread: none