Home » Mailing list archives » linux-netdev » 2009 » January » 27

[net-2.6 PATCH] e1000: fix bug with shared interrupt during reset

Previous thread: Passive OS fingerprint xtables match. by Evgeniy Polyakov on Tuesday, January 27, 2009 - 3:55 pm. (3 messages)

Next thread: Re: [ofa-general] NetEffect, iw_nes and kernel warning by Roland Dreier on Tuesday, January 27, 2009 - 4:53 pm. (16 messages)
[view original message]
From: Jeff Kirsher
Subject: [net-2.6 PATCH] e1000: fix bug with shared interrupt during reset
Date: Tuesday, January 27, 2009 - 4:27 pm

From: Jesse Brandeburg <jesse.brandeburg@intel.com>

A nasty bug was found where an MTU change (or anything else that caused a
reset) could race with the interrupt code.  The interrupt code was entered
by a shared interrupt during the MTU change.

This change prevents the interrupt code from running while the driver is in
the middle of its reset path.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---

 drivers/net/e1000/e1000_main.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
index 26474c9..c986978 100644
--- a/drivers/net/e1000/e1000_main.c
+++ b/drivers/net/e1000/e1000_main.c
@@ -31,7 +31,7 @@
 
 char e1000_driver_name[] = "e1000";
 static char e1000_driver_string[] = "Intel(R) PRO/1000 Network Driver";
-#define DRV_VERSION "7.3.20-k3-NAPI"
+#define DRV_VERSION "7.3.21-k3-NAPI"
 const char e1000_driver_version[] = DRV_VERSION;
 static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel Corporation.";
 
@@ -3712,7 +3712,7 @@ static irqreturn_t e1000_intr(int irq, void *data)
 	struct e1000_hw *hw = &adapter->hw;
 	u32 rctl, icr = er32(ICR);
 
-	if (unlikely(!icr))
+	if (unlikely((!icr) || test_bit(__E1000_RESETTING, &adapter->flags)))
 		return IRQ_NONE;  /* Not our interrupt */
 
 	/* IMS will not auto-mask if INT_ASSERTED is not set, and if it is

--


[ message continues ]
[view original message]
From: David Miller
Subject: Re: [net-2.6 PATCH] e1000: fix bug with shared interrupt during reset
Date: Tuesday, January 27, 2009 - 5:42 pm

From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>

Applied, thanks everyone.
--


[ message continues ]
Previous thread: Passive OS fingerprint xtables match. by Evgeniy Polyakov on Tuesday, January 27, 2009 - 3:55 pm. (3 messages)

Next thread: Re: [ofa-general] NetEffect, iw_nes and kernel warning by Roland Dreier on Tuesday, January 27, 2009 - 4:53 pm. (16 messages)