On Thu, 2009-01-22 at 19:50 +0200, Eilon Greenstein wrote:
quoted text
> On Tue, 2009-01-20 at 21:50 -0800, Harvey Harrison wrote:
> > I believe this exposed an endian bug as the shifting of
> > bytes from the data buffer was done in cpu-order, then
> > masked into a be32 and the combined value was then converted
> > to cpu-order, this does all the masking in be-byteorder and
> > passes a cpu-ordered value to the write routine.
> > 
> > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> 
> This change is breaking the FW upgrade utility which uses this interface
> since it is changing the content. I will need to work with the engineer
> that owns this utility, but this change will probably stay out for a
> while
> 

No worries, can you explain briefly what the code is trying to accomplish?
Maybe it was written assuming a le-machine, because this is going to
work differently on a be-machine.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html