both pdata->mdc and pdata->mdio are unsigned. Notice a negative return value. diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c index a439ebe..9b1dcd6 100644 --- a/drivers/net/phy/mdio-gpio.c +++ b/drivers/net/phy/mdio-gpio.c @@ -200,13 +200,21 @@ static int __devinit mdio_ofgpio_probe(struct of_device *ofdev, { struct device_node *np = NULL; struct mdio_gpio_platform_data *pdata; + int ret; pdata = kzalloc(sizeof(*pdata), GFP_KERNEL); if (!pdata) ...

From: Divy Le Ray <divy@chelsio.com> The driver currently drops to line interrupt mode if it did not get all the msi-x vectors it requested. Allow msi-x settings when a minimal amount of vectors is provided. Signed-off-by: Divy Le Ray <divy@chelsio.com> --- drivers/net/cxgb3/adapter.h | 1 + drivers/net/cxgb3/cxgb3_main.c | 23 +++++++++++++++-------- 2 files changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/net/cxgb3/adapter.h ...

And also disallows any name starting with a dot, while previously it was allowed/valid. I don't think this patch is good. --

On Sun, 18 Jan 2009 09:40:15 -0800 (PST) Thanks Sitsofe. This is what I was looking for. I'll wait for you to try the patch I sent earlier. I'd like to see if the watchdog timeout occurs with the patch applied. Thanks again, Jay --

Dear friend: I sell US iTunes Gift Card $50, $75, $100, $150, $200 with great discount, 60% off you only need pay 40%. This is my new US iTunes Gift Card shop Website link: http://itunesgiftcarddiscount.blogspot.com/ You can buy all US iTunes Gift Card $50, $75, $100, $150, $200 with great discount, you only need pay 40%. This is my shop customer service Email, you can contact me with this Email: goodseller200911@gmail.com Welcome to purchase US iTunes Gift Card! Hope do ...

On Sun, 18 Jan 2009 02:18:33 -0800 (PST) I'd like to see the full dmesg that includes the warning, if you can obtain it next time it occurs. Meanwhile, please see if this patch helps. diff --git a/drivers/net/atlx/atl2.c b/drivers/net/atlx/atl2.c index 8571e8c..376226c 100644 --- a/drivers/net/atlx/atl2.c +++ b/drivers/net/atlx/atl2.c @@ -555,14 +555,18 @@ static void atl2_check_for_link(struct atl2_adapter *adapter) atl2_read_phy_reg(&adapter->hw, MII_BMSR, &phy_data); ...

The second is a trivial error handling bug. gro: Fix error handling on extremely short frags When a frag is shorter than an Ethernet header, we'd return a zeroed packet instead of aborting. This patch fixes that. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/net/core/dev.c b/net/core/dev.c index 4f69a2d..2fb3a00 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2514,6 +2514,7 @@ struct sk_buff *napi_fraginfo_skb(struct napi_struct *napi, if ...

From: Herbert Xu <herbert@gondor.apana.org.au> Applied. --

The third fixes a serious bug in a previous bug fix. gro: Fix merging of paged packets The previous fix to paged packets broke the merging because it reset the skb->len before we added it to the merged packet. This wasn't detected because it simply resulted in the truncation of the packet while the missing bit is subsequently retransmitted. The fix is to store skb->len before we clobber it. Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> diff --git a/net/core/skbuff.c ...

Hi Bert. splice() from the fd to socket behaves exactly the same, since right now sendfile() is implemented as a splice(). Other directions are not affected by this behaviour (like socket-pipe-socket). Userspace memory to socket (aka vmsplice()) iirc behaves exactly like splice(), i.e. it is not allowed to write to the area being transmitted until explicit ack was received. -- Evgeniy Polyakov --

Hello Sam, David, CHECK include/mtd (6 files) /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/mtd/jffs2-user.h:20: extern's make no sense in userspace -- include/mtd/jffs2-user.h: extern int target_endian; #define t16(x) ({ uint16_t __b = (x); (target_endian==__BYTE_ORDER)?__b:bswap_16(__b); }) #define t32(x) ({ uint32_t __b = (x); (target_endian==__BYTE_ORDER)?__b:bswap_32(__b); }) -- In above case extern is OK or not ? Do we have some better ...

Hello David, Here is the list of 33 warnings this patchset solves: CHECK include/linux/can (3 files) /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/can/bcm.h:29: found __[us]{8,16,32,64} type without #include <linux/types.h> CHECK include/linux/dvb (8 files) /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/linux/dvb/audio.h:133: found __[us]{8,16,32,64} type without #include ...

If this file is _ONLY_ for userspace and kernel cannot use it then what is the point of keeping this file in kernel headers. -- JSR --

This file is for userspace only, and it makes sense where it's used (mtd-utils.) In general though, this file doesn't actually depend on the kernel and could be entirely provided from the userspace library. http://lkml.org/lkml/2006/12/1/180 --

From: Jiri Slaby <jirislaby@gmail.com> Applied, thanks. --

Hm, I do believe this _is_ evidence in favour of the theory: top - 09:03:57 up 2:16, 2 users, load average: 129.27, 49.28, 21.57 #define _GNU_SOURCE #include <sys/socket.h> #include <sys/types.h> #include <fcntl.h> #include <errno.h> #include <pthread.h> #include <signal.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <unistd.h> static int sock_fd[2]; static int pipe_fd[2]; #define N 16384 static void *do_write(void *unused) { unsigned int ...

I wonder why this is still up there. Maybe this patch will help? diff --git a/net/core/dev.c b/net/core/dev.c index 3742397..3cc19fa 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -2554,7 +2554,8 @@ struct sk_buff *napi_fraginfo_skb(struct napi_struct *napi, BUG_ON(info->nr_frags > MAX_SKB_FRAGS); skb_shinfo(skb)->nr_frags = info->nr_frags; - memcpy(skb_shinfo(skb)->frags, info->frags, sizeof(info->frags)); + memcpy(skb_shinfo(skb)->frags, info->frags, + ...

From: "Eilon Greenstein" <eilong@broadcom.com> Also applied, thanks. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

From: "Eilon Greenstein" <eilong@broadcom.com> Applied. --

Did you run sparse over the driver to verify you've sorted out all endianess issues? --

From: "Jiri Klimes" <klimes@centrum.cz> Thanks for catching this, I'll revert. --