Re: ixgbe: Replace LRO with GRO

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Herbert Xu
Date: Saturday, January 17, 2009 - 2:52 am

On Sat, Jan 17, 2009 at 01:07:46AM -0700, Tantilov, Emil S wrote:

Thanks, that makes a lot more sense.  Just to confirm, the second
part of the sender dump should be the one showing GRO, right?


OK, although this bug should only manifest itself if aggregation
occurs, which apparently isn't the case according to the dump.


BTW, when you're testing without GRO are you disabling GRO with
ethtool or loading an ixgbe driver without the patch? If the latter
please try it with ethtool (even if you don't have a patched ethtool
that supports GRO you can always disable RX checksums).

Maybe I just stuffed up the ixgbe patch.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[1/2] e1000e: Invoke VLAN GRO handler, Herbert Xu, (Tue Jan 13, 2:26 am)
[2/2] igb: Replace LRO with GRO, Herbert Xu, (Tue Jan 13, 2:28 am)
ixgbe: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 1:44 am)
Re: [2/2] igb: Replace LRO with GRO, Jeff Kirsher, (Wed Jan 14, 4:49 am)
Re: ixgbe: Replace LRO with GRO, Jeff Kirsher, (Wed Jan 14, 4:53 am)
Re: [2/2] igb: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 5:36 am)
Re: [2/2] igb: Replace LRO with GRO, Jeff Kirsher, (Wed Jan 14, 5:03 pm)
Re: [2/2] igb: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 5:32 pm)
Re: [2/2] igb: Replace LRO with GRO, Jeff Kirsher, (Wed Jan 14, 6:35 pm)
Re: [2/2] igb: Replace LRO with GRO, David Miller, (Wed Jan 14, 6:56 pm)
Re: [2/2] igb: Replace LRO with GRO, Jeff Kirsher, (Wed Jan 14, 7:02 pm)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 8:46 pm)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 9:22 pm)
sfc: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 9:24 pm)
Re: [1/2] e1000e: Invoke VLAN GRO handler, David Miller, (Wed Jan 14, 9:38 pm)
Re: [2/2] igb: Replace LRO with GRO, David Miller, (Wed Jan 14, 9:40 pm)
cxgb3: Replace LRO with GRO, Herbert Xu, (Wed Jan 14, 11:59 pm)
Re: ixgbe: Replace LRO with GRO, Jeff Kirsher, (Fri Jan 16, 4:32 pm)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Fri Jan 16, 5:36 pm)
RE: ixgbe: Replace LRO with GRO, Tantilov, Emil S, (Fri Jan 16, 6:06 pm)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Fri Jan 16, 8:45 pm)
RE: ixgbe: Replace LRO with GRO, Tantilov, Emil S, (Sat Jan 17, 1:07 am)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Sat Jan 17, 2:52 am)
Re: ixgbe: Replace LRO with GRO, Herbert Xu, (Sat Jan 17, 6:04 am)
RE: ixgbe: Replace LRO with GRO, Tantilov, Emil S, (Sat Jan 17, 8:44 am)
Re: [2/2] igb: Replace LRO with GRO, David Miller, (Sun Jan 18, 10:47 pm)
Re: ixgbe: Replace LRO with GRO, David Miller, (Sun Jan 18, 10:49 pm)
Re: sfc: Replace LRO with GRO, David Miller, (Sun Jan 18, 10:50 pm)
Re: [2/2] igb: Replace LRO with GRO, Herbert Xu, (Mon Jan 19, 4:16 am)
Re: sfc: Replace LRO with GRO, Ben Hutchings, (Mon Jan 19, 7:40 am)
Re: sfc: Replace LRO with GRO, David Miller, (Mon Jan 19, 2:29 pm)
Re: sfc: Replace LRO with GRO, Harvey Harrison, (Mon Jan 19, 3:12 pm)
Re: [2/2] igb: Replace LRO with GRO, Jeff Kirsher, (Mon Jan 19, 3:34 pm)
Re: [2/2] igb: Replace LRO with GRO, David Miller, (Mon Jan 19, 4:21 pm)
Re: sfc: Replace LRO with GRO, David Miller, (Mon Jan 19, 4:27 pm)
Re: sfc: Replace LRO with GRO, Stephen Rothwell, (Mon Jan 19, 5:57 pm)
RE: ixgbe: Replace LRO with GRO, Tantilov, Emil S, (Tue Jan 20, 4:00 pm)