[PATCH 13/33] netns ct: unregister helper in every netns

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Alexey Dobriyan
Date: Sunday, September 7, 2008 - 8:02 pm

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c
index 920e778..9c06b9f 100644
--- a/net/netfilter/nf_conntrack_helper.c
+++ b/net/netfilter/nf_conntrack_helper.c
@@ -123,29 +123,18 @@ int nf_conntrack_helper_register(struct nf_conntrack_helper *me)
 }
 EXPORT_SYMBOL_GPL(nf_conntrack_helper_register);
 
-void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me)
+static void __nf_conntrack_helper_unregister(struct nf_conntrack_helper *me,
+					     struct net *net)
 {
 	struct nf_conntrack_tuple_hash *h;
 	struct nf_conntrack_expect *exp;
 	const struct hlist_node *n, *next;
 	unsigned int i;
 
-	mutex_lock(&nf_ct_helper_mutex);
-	hlist_del_rcu(&me->hnode);
-	nf_ct_helper_count--;
-	mutex_unlock(&nf_ct_helper_mutex);
-
-	/* Make sure every nothing is still using the helper unless its a
-	 * connection in the hash.
-	 */
-	synchronize_rcu();
-
-	spin_lock_bh(&nf_conntrack_lock);
-
 	/* Get rid of expectations */
 	for (i = 0; i < nf_ct_expect_hsize; i++) {
 		hlist_for_each_entry_safe(exp, n, next,
-					  &init_net.ct.expect_hash[i], hnode) {
+					  &net->ct.expect_hash[i], hnode) {
 			struct nf_conn_help *help = nfct_help(exp->master);
 			if ((help->helper == me || exp->helper == me) &&
 			    del_timer(&exp->timeout)) {
@@ -156,12 +145,31 @@ void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me)
 	}
 
 	/* Get rid of expecteds, set helpers to NULL. */
-	hlist_for_each_entry(h, n, &init_net.ct.unconfirmed, hnode)
+	hlist_for_each_entry(h, n, &net->ct.unconfirmed, hnode)
 		unhelp(h, me);
 	for (i = 0; i < nf_conntrack_htable_size; i++) {
-		hlist_for_each_entry(h, n, &init_net.ct.hash[i], hnode)
+		hlist_for_each_entry(h, n, &net->ct.hash[i], hnode)
 			unhelp(h, me);
 	}
+}
+
+void nf_conntrack_helper_unregister(struct nf_conntrack_helper *me)
+{
+	struct net *net;
+
+	mutex_lock(&nf_ct_helper_mutex);
+	hlist_del_rcu(&me->hnode);
+	nf_ct_helper_count--;
+	mutex_unlock(&nf_ct_helper_mutex);
+
+	/* Make sure every nothing is still using the helper unless its a
+	 * connection in the hash.
+	 */
+	synchronize_rcu();
+
+	spin_lock_bh(&nf_conntrack_lock);
+	for_each_net(net)
+		__nf_conntrack_helper_unregister(me, net);
 	spin_unlock_bh(&nf_conntrack_lock);
 }
 EXPORT_SYMBOL_GPL(nf_conntrack_helper_unregister);
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 10/38] netns ct: per-netns expectations, adobriyan, (Thu Aug 21, 3:00 pm)
Re: [PATCH 10/38] netns ct: per-netns expectations, Patrick McHardy, (Thu Sep 4, 9:43 am)
[PATCH 01/33] nf_conntrack_sip: de-static helper pointers, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 04/33] Fix {ip,6}_route_me_harder() in netns, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 05/33] netns ct: per-netns expectations, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 06/33] netns ct: per-netns unconfirmed list, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 12/33] netns ct: export netns list, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 13/33] netns ct: unregister helper in every netns, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 16/33] netns ct: per-netns event cache, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 17/33] netns ct: final init_net tweaks, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 17/33] netns ct: final init_net tweaks, Alexey Dobriyan, (Sun Sep 7, 8:02 pm)
[PATCH 24/33] netns ct: SIP conntracking in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 25/33] netns ct: H323 conntracking in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 26/33] netns ct: GRE conntracking in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 27/33] netns ct: PPTP conntracking in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 28/33] netns nat: fix ipt_MASQUERADE in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 29/33] netns nat: per-netns NAT table, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 30/33] netns nat: per-netns bysource hash, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 31/33] netns ct: fixup DNAT in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 32/33] netns nat: PPTP NAT in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
[PATCH 33/33] Enable netfilter in netns, Alexey Dobriyan, (Sun Sep 7, 8:03 pm)
Re: [PATCH 04/33] Fix {ip,6}_route_me_harder() in netns, Patrick McHardy, (Mon Sep 8, 10:44 pm)
Re: [PATCH 05/33] netns ct: per-netns expectations, Patrick McHardy, (Mon Sep 8, 10:49 pm)
Re: [PATCH 06/33] netns ct: per-netns unconfirmed list, Patrick McHardy, (Mon Sep 8, 10:50 pm)
Re: [PATCH 12/33] netns ct: export netns list, Patrick McHardy, (Mon Sep 8, 10:59 pm)
Re: [PATCH 13/33] netns ct: unregister helper in every netns, Patrick McHardy, (Mon Sep 8, 11:01 pm)
Re: [PATCH 16/33] netns ct: per-netns event cache, Patrick McHardy, (Mon Sep 8, 11:12 pm)
Re: [PATCH 16/33] netns ct: per-netns event cache, Patrick McHardy, (Tue Sep 9, 12:07 am)
Re: [PATCH 05/33] netns ct: per-netns expectations, Alexey Dobriyan, (Tue Sep 9, 12:07 am)
Re: [PATCH 16/33] netns ct: per-netns event cache, Alexey Dobriyan, (Tue Sep 9, 12:07 am)
Re: [PATCH 05/33] netns ct: per-netns expectations, Patrick McHardy, (Tue Sep 9, 12:10 am)
Re: [PATCH 16/33] netns ct: per-netns event cache, Patrick McHardy, (Tue Sep 9, 12:16 am)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Patrick McHardy, (Tue Sep 9, 12:20 am)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Alexey Dobriyan, (Tue Sep 9, 12:32 am)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Patrick McHardy, (Tue Sep 9, 12:51 am)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Alexey Dobriyan, (Sat Sep 13, 3:45 am)
[PATCH v2 1/6] netns ct: per-netns statistics, Alexey Dobriyan, (Sat Sep 13, 3:48 am)
[PATCH v2 6/6] netns ct: per-netns conntrack accounting, Alexey Dobriyan, (Sat Sep 13, 3:55 am)
[PATCH v2 7/6] netns ct: final netns tweaks, Alexey Dobriyan, (Fri Sep 26, 4:59 pm)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Alexey Dobriyan, (Fri Sep 26, 5:00 pm)
Re: [PATCH 17/33] netns ct: final init_net tweaks, Patrick McHardy, (Sun Sep 28, 3:31 am)
Re: [PATCH v2 1/6] netns ct: per-netns statistics, Patrick McHardy, (Thu Oct 2, 12:58 am)
Re: [PATCH v2 7/6] netns ct: final netns tweaks, Patrick McHardy, (Thu Oct 2, 1:11 am)
Re: [PATCH 24/33] netns ct: SIP conntracking in netns, Patrick McHardy, (Thu Oct 2, 1:52 am)
Re: [PATCH 25/33] netns ct: H323 conntracking in netns, Patrick McHardy, (Thu Oct 2, 1:52 am)
Re: [PATCH 26/33] netns ct: GRE conntracking in netns, Patrick McHardy, (Thu Oct 2, 1:53 am)
Re: [PATCH 27/33] netns ct: PPTP conntracking in netns, Patrick McHardy, (Thu Oct 2, 1:54 am)
Re: [PATCH 28/33] netns nat: fix ipt_MASQUERADE in netns, Patrick McHardy, (Thu Oct 2, 2:06 am)
Re: [PATCH 29/33] netns nat: per-netns NAT table, Patrick McHardy, (Thu Oct 2, 2:08 am)
Re: [PATCH 29/33] netns nat: per-netns NAT table, Patrick McHardy, (Thu Oct 2, 2:09 am)
Re: [PATCH 30/33] netns nat: per-netns bysource hash, Patrick McHardy, (Thu Oct 2, 2:09 am)
Re: [PATCH 31/33] netns ct: fixup DNAT in netns, Patrick McHardy, (Thu Oct 2, 2:10 am)
Re: [PATCH 32/33] netns nat: PPTP NAT in netns, Patrick McHardy, (Thu Oct 2, 2:11 am)
Re: [PATCH 33/33] Enable netfilter in netns, Patrick McHardy, (Thu Oct 2, 2:12 am)
Re: [PATCH 33/33] Enable netfilter in netns, Alexey Dobriyan, (Thu Oct 2, 2:51 am)
Re: [PATCH 33/33] Enable netfilter in netns, Alexey Dobriyan, (Thu Oct 2, 2:53 am)
Re: [PATCH 33/33] Enable netfilter in netns, Patrick McHardy, (Thu Oct 2, 3:00 am)