Em Mon, Sep 22, 2008 at 09:21:54AM +0200, Gerrit Renker escreveu:

quoted text
> A lookup table for feature-negotiation information, extracted from RFC 4340/42,

> is provided by this patch. All currently known features can be found in this

> table, along with their feature location, their default value, and type.

>

> Signed-off-by: Gerrit Renker

> Acked-by: Ian McDonald

> ---

>  include/linux/dccp.h |    9 ++--

>  net/dccp/feat.c      |  115 ++++++++++++++++++++++++++++++++++++++++++++++++++

>  2 files changed, 120 insertions(+), 4 deletions(-)

>

> --- a/include/linux/dccp.h

> +++ b/include/linux/dccp.h

>

> +

> +static int dccp_feat_default_value(u8 feat_num)

> +{

> +	int idx = dccp_feat_index(feat_num);

> +

> +	return idx < 0 ? : dccp_feat_table[idx].default_value;

> +}

[acme@doppio ~]$ cat dd.c

#include 
int main(void)

{

	int idx = -2;
	printf("%d\n", idx < 0 ? : 10);

	printf("%d\n", idx < 0 ? idx : 10);

	return 0;

}

[acme@doppio ~]$ ./dd

1

-2

[acme@doppio ~]$
Which one do you want? The boolean result as the value to be returned or

the index if it is < 0?
I tried to check on the other 4 patches on this series to check if usage

clarified if it was correct, but there is no use of

dccp_feat_default_value() on this 5 patches, perhaps it could be

deferred to when it actually gets used?
- Arnaldo

--

To unsubscribe from this list: send the line "unsubscribe netdev" in

the body of a message to majordomo@vger.kernel.org

More majordomo info at  http://vger.kernel.org/majordomo-info.html