Re: RFC: Nagle latency tuning

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: <csnook@...>
Cc: <andi@...>, <rick.jones2@...>, <netdev@...>
Date: Monday, September 22, 2008 - 7:09 am

From: David Miller <davem@davemloft.net>
Date: Mon, 22 Sep 2008 03:49:33 -0700 (PDT)


Andi's patch uses proc_dointvec_jiffies, which is for sysctl values
stored as seconds, whereas these things are used to record values with
smaller granulatiry, are stored in jiffies, and that's why we get zero
on read and writes have crazy effects.

Also, as Andi stated, this is not the way to deal with this problem.

So we have a broken patch, which even if implemented properly isn't the
way forward, so I consider this discussion dead in the water until we
have some test cases.

Don't you think? :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RFC: Nagle latency tuning, Christopher Snook, (Mon Sep 8, 5:56 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 8, 6:55 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 1:22 am)
Re: RFC: Nagle latency tuning, Rick Jones, (Mon Sep 8, 6:39 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 1:10 am)
Re: RFC: Nagle latency tuning, Rick Jones, (Tue Sep 9, 12:33 pm)
Re: RFC: Nagle latency tuning, Chuck Lever, (Tue Sep 9, 12:54 pm)
Re: RFC: Nagle latency tuning, Rick Jones, (Tue Sep 9, 1:54 pm)
Re: RFC: Nagle latency tuning, Arnaldo Carvalho de Melo, (Tue Sep 9, 1:21 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Tue Sep 9, 10:36 am)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 2:40 pm)
Re: RFC: Nagle latency tuning, David Miller, (Tue Sep 9, 3:59 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 6:49 am)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 7:09 am)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 4:30 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Mon Sep 22, 6:22 pm)
Re: RFC: Nagle latency tuning, Rick Jones, (Mon Sep 22, 6:47 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Mon Sep 22, 6:57 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 6:26 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Mon Sep 22, 7:00 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 7:13 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 7:24 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 7:21 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 8:14 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 9:40 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 10:23 pm)
Re: RFC: Nagle latency tuning, David Miller, (Mon Sep 22, 10:28 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 10:41 pm)
Re: RFC: Nagle latency tuning, Rick Jones, (Mon Sep 22, 8:33 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Mon Sep 22, 10:12 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 4:25 pm)
Re: RFC: Nagle latency tuning, Andi Kleen, (Tue Sep 9, 3:07 pm)
Re: RFC: Nagle latency tuning, Chris Snook, (Thu Sep 11, 12:08 am)
Re: RFC: Nagle latency tuning, Arnaldo Carvalho de Melo, (Tue Sep 9, 3:21 pm)
Re: RFC: Nagle latency tuning, David Miller, (Tue Sep 9, 1:17 am)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 1:56 am)
Re: RFC: Nagle latency tuning, Evgeniy Polyakov, (Tue Sep 9, 2:22 am)
Re: RFC: Nagle latency tuning, Arnaldo Carvalho de Melo, (Tue Sep 9, 9:00 am)
Re: RFC: Nagle latency tuning, Chris Snook, (Tue Sep 9, 2:28 am)
Re: RFC: Nagle latency tuning, David Miller, (Tue Sep 9, 2:02 am)
Re: RFC: Nagle latency tuning, Mark Brown, (Tue Sep 9, 6:31 am)
Re: RFC: Nagle latency tuning, David Miller, (Tue Sep 9, 8:05 am)
Re: RFC: Nagle latency tuning, Mark Brown, (Tue Sep 9, 8:09 am)
Re: RFC: Nagle latency tuning, David Miller, (Tue Sep 9, 8:19 am)