linux-netdev mailing list

FromSubjectsort iconDate
David Miller
[PATCH 1/2]: qlge: Fix warnings in debugging code.
DQpxbGdlOiBGaXggd2FybmluZ3MgaW4gZGVidWdnaW5nIGNvZGUuDQoNCmRyaXZlcnMvbmV0L3Fs Z2UvcWxnZV9kYmcuYzogSW4gZnVuY3Rpb24g4oCYcWxfZHVtcF9xZGV24oCZOg0KZHJpdmVycy9u ZXQvcWxnZS9xbGdlX2RiZy5jOjM2OTogd2FybmluZzogY2FzdCB0byBwb2ludGVyIGZyb20gaW50 ZWdlciBvZiBkaWZmZXJlbnQgc2l6ZQ0KZHJpdmVycy9uZXQvcWxnZS9xbGdlX2RiZy5jOjM3Mzog d2FybmluZzogY2FzdCB0byBwb2ludGVyIGZyb20gaW50ZWdlciBvZiBkaWZmZXJlbnQgc2l6ZQ0K ZHJpdmVycy9uZXQvcWxnZS9xbGdlX2RiZy5jOiBJbiBmdW5jdGlvbiDigJhxbF9kdW1wX3R4X3Jp bmfigJk6DQpkcml2ZXJzL25ldC9xbGdlL3FsZ2VfZGJn...
Sep 19, 7:16 pm 2008
David Miller
[PATCH 2/2]: qlge: Protect qlge_resume() with CONFIG_PM
qlge: Protect qlge_resume() with CONFIG_PM Fixes the following build warning: drivers/net/qlge/qlge_main.c:3897: warning: ‘qlge_resume’ defined but not used Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/qlge/qlge_main.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c index ad878e2..3af822b 100644 --- a/drivers/net/qlge/qlge_main.c +++ b/drivers/net/qlge/qlge_main.c @@ -...
Sep 19, 7:16 pm 2008
David Miller
[PATCH 0/2]: qlge build warning fixes
I just checked the following two build warning fixes to net-next-2.6 Signed-off-by: David S. Miller <davem@davemloft.net> --
Sep 19, 7:16 pm 2008
David Miller
[INFO PATCH]: Use list_head in sk_buff...
I just want folks to know I have this patch against net-next-2.6 It's been running on my workstation for the better part of the last day so basic things work fine. It also passes allmodconfig builds on sparc64. But I want to see if I can find some way to do this change in stages so that the transition is less painful and can be bisected at least partially. The biggest pain areas are TIPC and SCTP. Actually, TIPC gets special marks for implementing it's own SKB queues in a thousand differen...
Sep 19, 6:50 pm 2008
Sven Wegener
[PATCH] ipvs: Restrict sync message to 255 connections
The nr_conns variable in the sync message header is only eight bits wide and will overflow on interfaces with a large MTU. As a result the backup won't parse all connections contained in the sync buffer. On regular ethernet with an MTU of 1500 this isn't a problem, because we can't overflow the value, but consider jumbo frames being used on a cross-over connection between both directors. We now restrict the size of the sync buffer, so that we never put more than 255 connections into a single sync b...
Sep 19, 2:41 pm 2008
Matthew Wilcox
Re: multiqueue interrupts...
Instead of having magic names, how about we put something in /proc/irq/nnn/ that lets us tell which interrupts are connected to which queues? Another idea I've been thinking about is a flag to tell irqbalance to leave stuff alone, and we just set stuff up right the first time. We were discussing various options around multiqueue at first the scsi multiqueue BOF and later at the PCI MSI BOF. There's a general feeling that drivers should be given some guidance about how many queues they should ...
Sep 19, 2:18 pm 2008
Arjan van de Ven
Re: multiqueue interrupts...
On Fri, 19 Sep 2008 12:18:41 -0600 that's not a good answer. There are reasons for moving interrupts that are a sysadmin choice (like power management policy that if the system is seriously idle, that all interrupts go to one of the sockets so that the others can stay in low power mode). Putting the policy in the kernel to prohibit such admin choices sounds like a bad idea to me. There are better ways to do what you want, for example by exposing a "preferred cpu" somewhere so that irqbalance will...
Sep 19, 6:11 pm 2008
Andy Fleming
Re: multiqueue interrupts...
I'm only just now wading into this area, but I thought one of the advantages of multiple hardware queues was that we don't have to worry about multiple cpus trying to access the buffer rings at the same time, thus eliminating locking. If the driver can't rely on that, don't we lose that advantage? Andy --
Sep 19, 6:24 pm 2008
Arjan van de Ven
Re: multiqueue interrupts...
On Fri, 19 Sep 2008 17:24:00 -0500 that's only true if you have at least the amount of queues as you have logical cpus. Ask SGI about how many cpus they have in 3 years, and then ask your NIC vendor how many queues they have planned for ;-) and a per-cpu lock isn't really all THAT expensive. the really big advantage is that you no longer cacheline bounce to hell and back... and that you have either way. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion an...
Sep 19, 6:28 pm 2008
Brandeburg, Jesse
RE: multiqueue interrupts...
There is already this flag called IRQF_NOBALANCING, at least I think that's what we want. irqbalanced's treatment of this flag is another not a bad, idea, but I can appreciate why DaveM thinks this is un-necessary. However all we are left with right now is code changes or module parameters when trying to configure the number of queues. How about some new ethtool options having to do with multiqueue configurations? Here is a proposal. I haven't spent much time thinking about this before but ...
Sep 19, 4:57 pm 2008
David Miller
Re: multiqueue interrupts...
From: "Brandeburg, Jesse" <jesse.brandeburg@intel.com> No way. Let irqbalanced implement the policy. Just configure as many queues as possible and let it figure out what to do. --
Sep 19, 5:09 pm 2008
Matthew Wilcox
Re: multiqueue interrupts...
That isn't a great idea. Some cards consume a significant amount of resources per queue and the cost of each queue may be larger than the benefit. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." --
Sep 19, 5:15 pm 2008
David Miller
Re: multiqueue interrupts...
From: Matthew Wilcox <matthew@wil.cx> More code for irqbalanced to write, to look for the files and directories under there, etc. Harder to make work with simple individual driver backports, which you know dists are going to want to do. That's why. No, this new subdirectory thing isn't a good idea. --
Sep 19, 4:14 pm 2008
Le Rouzic
Full IPv6 client and server support (kernel and user commands)
Hi, I have just posted at http://nfsv4.bullopensource.org/ a full IPV6 client and server NFSV4 support based on linux-2.6.27-rc3 and nfs-utils.1.1.2. It is experimental and not fully tested but it allows to have a IPV6 NFSV4 linux configuration to play with. Let me know if any issues to get this delivery and to run it. Best Regards -- ----------------------------------------------------------------- Company : Bull, Architect of an Open World TM (www.bull.com) Name : Aime Le Rouzic ...
Sep 19, 8:49 am 2008
David Miller
Re: Full IPv6 client and server support (kernel and user com...
From: Le Rouzic <aime.le-rouzic@bull.net> Generally, if you just point people at some web site instead of posting your code as well partitioned patches against the current kernel to this mailing list, people aren't even going to look at your stuff. Myself included. If it doesn't get posted to the mailing list, it might as well not exist. You're making people go through extra effort to see your work. --
Sep 19, 4:26 pm 2008
Ralf Baechle
[PATCH] MIPS checksum fix
Voila. I'm interested in test reports of this on all sorts of configurations - 32-bit, 64-bit, big / little endian, R2 processors and pre-R2. In particular Cavium being the only MIPS64 R2 implementation would be interesting. This definately is stuff which should go upstream for 2.6.27. Ralf Signed-off-by: Ralf Baechle <ralf@linux-mips.org> diff --git a/arch/mips/lib/csum_partial.S b/arch/mips/lib/csum_partial.S index 8d77841..eac0d61 100644 --- a/arch/mips/lib/csum_partial.S ++...
Sep 19, 7:47 am 2008
Ralf Baechle
Re: [PATCH] MIPS checksum fix
There was a trivial bug in the R2 code. From 97ad23f4696a322cb3bc379a25a8c0f6526751d6 Mon Sep 17 00:00:00 2001 From: Ralf Baechle <ralf@linux-mips.org> Date: Fri, 19 Sep 2008 14:05:53 +0200 Subject: [PATCH] [MIPS] Fix 64-bit csum_partial, __csum_partial_copy_user and csum_partial_copy On 64-bit machines it wouldn't handle a possible carry when adding the 32-bit folded checksum and checksum argument. While at it, add a few trivial optimizations, also for R2 processors. Signed-off-by: ...
Sep 19, 8:07 am 2008
Atsushi Nemoto
Re: [PATCH] MIPS checksum fix
I think it would be better splitting bugfix and optimization. This Is this just an optimization? or contain any fixes? --- Atsushi Nemoto --
Sep 19, 10:09 am 2008
Maciej W. Rozycki
Re: [PATCH] MIPS checksum fix
It's probably easier for people to test a single patch now and it can then be split at the commitment time. Of course if something actually breaks, then keeping changes combined won't help tracking down the cause. ;) Maciej --
Sep 19, 11:02 am 2008
Maciej W. Rozycki
Re: [PATCH] MIPS checksum fix
Well, .set reorder to move something from before the branch would have been a little bit better for the common aligned case. ;) There is nothing special about branch delay slots in the whole epilogue, so one from just before the return might simply be relocated here. Maciej --
Sep 19, 8:15 am 2008
frank.blaschka
[patch 0/2] s390: qeth fixes 2.6.27-rc6
Hi Jeff, our internal regression found 2 more qeth bugs. shortlog: Ursula Braun (2) qeth: use firmware MAC-address for layer2 hsi-devices qeth: avoid qeth recovery problems Thanks, Frank -- --
Sep 19, 6:56 am 2008
frank.blaschka
[patch 1/2] qeth: use firmware MAC-address for layer2 hsi-de...
From: Ursula Braun <ursula.braun@de.ibm.com> Real HiperSocket devices in layer2 mode have a firmware-created MAC-address. This change enables the qeth driver to use this firmware MAC-address for layer2 HiperSocket devices. Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_l2_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff -urpN linux-2.6/drivers/s390/net/qeth_l2_...
Sep 19, 6:56 am 2008
frank.blaschka
[patch 2/2] qeth: avoid qeth recovery problems
From: Ursula Braun <ursula.braun@de.ibm.com> Do not touch IFF_UP flag during qeth recovery, but invoke dev_close() in case of failing recovery. Cancel outstanding control commands in case of Data Checks or Channel Checks. Do not invoke qeth_l2_del_all_mc() in case of a hard stop to speed up removal of qeth devices. Signed-off-by: Ursula Braun <ursula.braun@de.ibm.com> Signed-off-by: Frank Blaschka <frank.blaschka@de.ibm.com> --- drivers/s390/net/qeth_core_main.c | 4 +++...
Sep 19, 6:56 am 2008
Julius Volz
[PATCH] IPVS: Move IPVS to net/netfilter/ipvs
Hi Horms, I worked around the unrelated UML build problems for now and did the IPVS move from net/ipv4/ipvs to net/netfilter/ipvs, as discussed. Since the patch is huge (732K), I uploaded it rather than trying to include it in the mail: http://www.mindbasket.com/ipvs/0001-IPVS-Move-IPVS-to-net-netfilter-ipvs.patch The menuconfig option for IPVS is now also in the Netfilter submenu. Everything builds and runs ok here... Julius -- Julius Volz - Corporate Operations - SysOps Google Swit...
Sep 19, 6:45 am 2008
Andrew Morton
Re: NFS root + iptables in 2.6.25
(cc's added) (googles "nfs: RPC call returned error 1") hm, there has been a dribble of reports going back several years, but nothing conclusive afaict. --
Sep 19, 5:00 am 2008
David Miller
multiqueue interrupts...
During kernel summit I was speaking with Arjan van de Ven about irqbalanced and networking card multiqueue interrupts. In order for irqbalanaced to make smart decisions, what needs to happen in drivers is that the individual interrupts need to be named in such a way that he can tell by looking at /proc/interrupts output that these interrupts are related. I would suggest that people use something like: char buf[IFNAMSIZ+6]; sprintf(buf, "%s-%s-%d", netdev->name, (RX_INTERR...
Sep 18, 10:38 pm 2008
Ben Hutchings
Re: multiqueue interrupts...
On Thu, 2008-09-18 at 19:38 -0700, David Miller wrote: What about the case where an interrupt is shared between RX and TX completions? Our hardware is very flexible in this regard, but based on performance testing prior to the introduction of TX multiqueue we currently allocate multiple interrupts for RX completions and share the first with TX completions. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department...
Sep 19, 7:38 am 2008
David Miller
Re: multiqueue interrupts...
From: Ben Hutchings <bhutchings@solarflare.com> Probably it would be sufficient to purely use eth0-N, it's just so that irqbalanced knows that the interrupts are related. --
Sep 19, 4:12 pm 2008
Brice Goglin
Re: multiqueue interrupts...
myri10ge uses the same interrupts for TX and RX. The current name is eth%d:slice-%d but we could change it if there's a consensus. Brice --
Sep 19, 8:29 am 2008
David Miller
Re: multiqueue interrupts...
From: Brice Goglin <brice@myri.com> You might be OK as-is. If we make irqbalanced look for X-%d, you'll likely be fine. --
Sep 19, 4:12 pm 2008
David Miller
[GIT]: Networking
1) bnx2 records MSI vector as 16-bit value, which breaks due to 2.6.27 io_apic.c changes on x86, use 32-bit value instead. From Benjamin Li. 2) Due to missing locking, EEPROM/NVRAM can be corrupted making the card subsequently nearly unusable. Fix from Christopher Li. 3) UDP receive path can try to recursively lock a socket and deadlock, regression from 2.6.26 Reported by lockdep and fixed by Herbert Xu. 4) Three SCTP fixes from Vlad Yasevich: a) OOPS when processing INI...
Sep 18, 10:28 pm 2008
Jeff Garzik
[git patches] regression fixes for .27-rc
This is all the net driver-related regressions AFAICS. Please pull from 'davem-fixes' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git davem-fixes to receive the following updates: drivers/net/e100.c | 4 +--- drivers/net/e1000/e1000_hw.c | 23 +++++++++++++++++++++++ drivers/net/forcedeth.c | 16 +++++++++++++--- 3 files changed, 37 insertions(+), 6 deletions(-) Christopher Li (1): e1000: prevent corruption of EEPROM/NVM Rafael ...
Sep 18, 9:52 pm 2008
David Miller
Re: [git patches] regression fixes for .27-rc
From: Jeff Garzik <jeff@garzik.org> Pulled, thanks a lot Jeff. --
Sep 18, 10:17 pm 2008
Alexander Duyck
[PATCH] netdev: simple_tx_hash shouldn't hash inside fragments
Currently simple_tx_hash is hashing inside of udp fragments. As a result packets are getting getting sent to all queues when they shouldn't be. This causes a serious performance regression which can be seen by sending UDP frames larger than mtu on multiqueue devices. This change will make it so that fragments are hashed only as IP datagrams w/o any protocol information. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> --- net/core/dev.c | 6 ++++-- 1 files changed, 4 ins...
Sep 18, 8:43 pm 2008
Alexander Duyck
[PATCH] multiq: requeue should rewind the current_band
Currently dequeueing a packet and requeueing the same packet will cause a different packet to be pulled on the next dequeue. This change forces requeue to rewind the current_band. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> --- net/sched/sch_multiq.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/net/sched/sch_multiq.c b/net/sched/sch_multiq.c index 5d9cd68..915f314 100644 --- a/net/sched/sch_multiq.c +++ b/net/sched/sch_multiq.c @@ -97,...
Sep 18, 8:43 pm 2008
Randy.Dunlap
Re: patchwork for netdev
Maybe patchwork for wireless would satisfy one of my concerns, but it would be nice if John would ack patches like DaveM and Jeff do... :) Thanks, -- ~Randy --
Sep 18, 8:01 pm 2008
David Miller
Re: patchwork for netdev
From: "Randy.Dunlap" <rdunlap@xenotime.net> It's so much less work for me to click a bunch of buttons on a web page and work in batch mode, than it is to give personalized responses. When you're applying 40, 50 patches in a day, every minute in the workflow starts to count. I was hoping those ACK emails would be one of the things I could stop doing if patchwork is effective. Not immediately, but eventually. --
Sep 18, 8:05 pm 2008
Rick Jones
Re: patchwork for netdev
Can't patchwork do that as those clicks to change state take place? rick jones --
Sep 18, 8:28 pm 2008
David Miller
Re: patchwork for netdev
From: Rick Jones <rick.jones2@hp.com> I honestly don't know, but my guess would be know. We could ask the patchwork author for this feature, as this stuff is actively maintained. --
Sep 18, 10:11 pm 2008
Randy.Dunlap
Re: patchwork for netdev
Well, that's a reasonable goal. OTOH, if everyone wants to know if their patch was applied, then having 50 people look at a web page (or at a git tree) is more total overhead than one person generating an email. IMHO. But maybe it depends on which side is being optimized. Thanks, -- ~Randy --
Sep 18, 8:09 pm 2008
Christoph Hellwig
Re: patchwork for netdev
Could patchworks please generate the ACK mail automatically? --
Sep 19, 3:13 am 2008
David Miller
Re: patchwork for netdev
From: "Randy.Dunlap" <rdunlap@xenotime.net> If the choke point is me, which it is, then... --
Sep 18, 8:12 pm 2008
Randy.Dunlap
Re: patchwork for netdev
then you get to choose, I suppose. Meaning look at the patchwork queue, which I did, and it looks good. -- ~Randy --
Sep 18, 8:13 pm 2008
Vlad Yasevich
Re: [PATCH 1/2] sctp: do not enable peer features if we can'...
It is a major interoperability issue. With the default sysctl settings, we can not establish connection to BSD systems. Yes, there is a workaround of turning on the 2 required sysctl settings, but that is totally suboptimal. I've thought about this fix for a while, and in my opinion, the interoperability problem is large enough to warrant the fix at this time and the backport to table. Of course you are free to not include this in net-2.6, but I hope you will. Thanks -vlad --
Sep 18, 11:01 pm 2008
David Miller
Re: [git patches] new network drivers for net-next
From: Jeff Garzik <jeff@garzik.org> Pulled, thanks Jeff. I'll push this to net-next-2.6 after a quick build sanity test. --
Sep 19, 6:53 pm 2008
David Miller
Re: pull request wireless-next-2.6 2008-09-15
From: "John W. Linville" <linville@tuxdriver.com> Pulled and will push back out to net-next-2.6 after build tests complete. Thanks! --
Sep 19, 7:20 pm 2008
Ivan Vecera
Re: [PATCH] r8169: read MAC address from EEPROM on init
Yes it is, my mistake. The patch below will be better. --- drivers/net/r8169.c | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 73 insertions(+), 1 deletions(-) diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c index befc927..cff8dd6 100644 --- a/drivers/net/r8169.c +++ b/drivers/net/r8169.c @@ -1910,6 +1910,75 @@ static void rtl_disable_msi(struct pci_dev *pdev, struct rtl8169_private *tp) } } +static int rtl_eeprom_read(struct pci_dev *pdev, int cap,...
Sep 19, 9:05 am 2008
Jarek Poplawski
Re: [RFC PATCH] sched: only dequeue if packet can be queued ...
Alexander, I guess you've seen my last messages/patches in this thread and noticed that this __netif_schedule() problem is present both in this RFC patch and sch_multiq: if skb isn't dequeued because of inner tx_queue stopped state check, there is missing __netif_schedule() before exit from qdisc_run(). Jarek P. --
Sep 19, 11:16 am 2008
Jarek Poplawski
Re: [RFC PATCH] sched: only dequeue if packet can be queued ...
On Fri, Sep 19, 2008 at 05:16:32PM +0200, Jarek Poplawski wrote: Hmm... probably false alarm. It seems there have to be same wake_queue after all. Sorry, Jarek P. --
Sep 19, 12:37 pm 2008
Duyck, Alexander H
RE: [RFC PATCH] sched: only dequeue if packet can be queued ...
Actually most of that is handled in the fact that netif_tx_wake_queue will call __netif_schedule when it decides to wake up a queue that has been stopped. Putting it in skb_dequeue is unnecessary, and the way you did it would cause issues because you should be scheduling the root qdisc, not the one currently doing the dequeue. My bigger concern is the fact one queue is back to stopping all queues. By using one global XOFF state, you create head-of-line blocking. I can see the merit in this appr...
Sep 19, 12:26 pm 2008
previous daytodaynext day
September 18, 2008September 19, 2008September 20, 2008