Home » Mailing list archives » linux-netdev » 2008 » September » 19

Re: [RFC PATCH] sched: only dequeue if packet can be queued to hardware queue.

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Jarek Poplawski <jarkao2@...>
To: Alexander Duyck <alexander.h.duyck@...>
Cc: <netdev@...>, <herbert@...>, <davem@...>, <kaber@...>
Subject: Re: [RFC PATCH] sched: only dequeue if packet can be queued to hardware queue.
Date: Friday, September 19, 2008 - 11:16 am

On Thu, Sep 18, 2008 at 09:44:19PM +0200, Jarek Poplawski wrote:

Alexander, I guess you've seen my last messages/patches in this thread
and noticed that this __netif_schedule() problem is present both in
this RFC patch and sch_multiq: if skb isn't dequeued because of inner
tx_queue stopped state check, there is missing __netif_schedule()
before exit from qdisc_run().

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[RFC PATCH] sched: only dequeue if packet can be queued to h..., Alexander Duyck, (Thu Sep 18, 2:43 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Thu Sep 18, 3:44 pm)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Fri Sep 19, 11:16 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Fri Sep 19, 12:37 pm)
RE: [RFC PATCH] sched: only dequeue if packet can be queued ..., Duyck, Alexander H, (Fri Sep 19, 12:26 pm)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Fri Sep 19, 1:35 pm)
RE: [RFC PATCH] sched: only dequeue if packet can be queued ..., Duyck, Alexander H, (Fri Sep 19, 2:01 pm)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Fri Sep 19, 2:51 pm)
RE: [RFC PATCH] sched: only dequeue if packet can be queued ..., Duyck, Alexander H, (Fri Sep 19, 5:43 pm)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Alexander Duyck, (Thu Sep 18, 9:11 pm)
[take 2] Re: [RFC PATCH] sched: only dequeue if packet can b..., Jarek Poplawski, (Fri Sep 19, 6:32 am)
Re: [take 2] Re: [RFC PATCH] sched: only dequeue if packet c..., Jarek Poplawski, (Fri Sep 19, 1:46 pm)
[PATCH take2] pkt_sched: Fix TX state checking in qdisc_run(), Jarek Poplawski, (Fri Sep 19, 10:44 am)
Re: [PATCH take2] pkt_sched: Fix TX state checking in qdisc_..., David Miller, (Sun Sep 21, 1:18 am)
Re: [PATCH take2] pkt_sched: Fix TX state checking in qdisc_..., Jarek Poplawski, (Fri Sep 19, 1:49 pm)
[PATCH] pkt_sched: Fix TX state checking in qdisc_run(), Jarek Poplawski, (Fri Sep 19, 9:07 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Jarek Poplawski, (Fri Sep 19, 5:17 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., David Miller, (Thu Sep 18, 5:46 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Alexander Duyck, (Thu Sep 18, 10:51 am)
Re: [RFC PATCH] sched: only dequeue if packet can be queued ..., Alexander Duyck, (Thu Sep 18, 2:56 am)