Marcel, others, please bring some kind of closure to this regression list entry: Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11442 Subject : btusb hibernation/suspend breakage in current -git Submitter : Rafael J. Wysocki <rjw@sisk.pl> Date : 2008-08-25 11:37 (19 days old) References : http://marc.info/?l=linux-bluetooth&m=121966402012074&w=4 Handled-By : Oliver Neukum <oliver@neukum.org> Patch : http://marc.info/?l=linux-bluetooth&m=121967226027323&w=4 There is a patch, it ...

Jeff please make sure the following makes it's way into your next bug fix pull request to me as it's fixes a regression list entry: http://marc.info/?l=linux-kernel&m=121894416718874&w=4 Bug-Entry : http://bugzilla.kernel.org/show_bug.cgi?id=11358 Subject : net: forcedeth call restore mac addr in nv_shutdown path Submitter : Yinghai Lu <yhlu.kernel@gmail.com> Date : 2008-08-17 3:30 (27 days old) References : http://marc.info/?l=linux-kernel&m=121894389018584&w=4 Handled-By : Yinghai Lu ...

According to the at91rm9200 datasheet, table 36-6, late collisions (AT91_EMAC_LCOL) are already counted in the collision register (in scol, mcol or ecol , depending on the type of error). So don't count them twice in stats.collisions. Signed-off-by: Marc Pignat <marc.pignat@hevs.ch> Signed-off-by: Andrew Victor <linux@maxim.org.za>

This fixes kernel regression for 2.6.27-rc in http://bugzilla.kernel.org/show_bug.cgi?id=11547 The change to split 8390 into old isa and non-isa versions overlooked this driver. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> --- a/drivers/net/hp-plus.c 2008-09-16 12:26:18.000000000 -0700 +++ b/drivers/net/hp-plus.c 2008-09-16 12:28:19.000000000 -0700 @@ -139,7 +139,7 @@ static int __init do_hpp_probe(struct ne #ifndef MODULE struct net_device * __init ...

Hello, After a little investigation (see after), I came to the conclusion there was something strange with the zd1211rw wifi driver (or maybe mac80211-based ones like it happened in the past ?) and ipv6 (at least with autoconfiguration). I am on Archlinux with kernel 2.6.26.5 kernel behind a router connecting me to internet by ipv4 and ipv6. After a little discussion with John W. Linville on irc, he redirected me to this mailing list. The idea is that I connect to a wireless network ...

(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). --

Change __contant_htons() to htons() in the IPVS code when not in an initializer. -Brian Signed-off-by: Brian Haley <brian.haley@hp.com> ---

We are using PhoNet over Bluetooth and IrDA inside the Gnokii project and if we have a common PhoNet stack inside the Linux kernel that is supported by Nokia, I do wanna use that. What are your plans for this? Regards Marcel --

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/linux/if_phonet.h | 2 ++ net/phonet/af_phonet.c | 29 +++++++++++++++++++++++++++++ 2 files changed, 31 insertions(+), 0 deletions(-) diff --git a/include/linux/if_phonet.h b/include/linux/if_phonet.h index 22df25f..94bc59b 100644 --- a/include/linux/if_phonet.h +++ b/include/linux/if_phonet.h @@ -12,3 +12,5 @@ /* 6 bytes header + 65535 bytes payload */ #define PHONET_MAX_MTU 65541 #define ...

[Empty message]

Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- net/Kconfig | 1 + net/Makefile | 1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/Kconfig b/net/Kconfig index d87de48..9103a16 100644 --- a/net/Kconfig +++ b/net/Kconfig @@ -232,6 +232,7 @@ source "net/can/Kconfig" source "net/irda/Kconfig" source "net/bluetooth/Kconfig" source "net/rxrpc/Kconfig" +source "net/phonet/Kconfig" config FIB_RULES bool diff --git a/net/Makefile ...

Phonet endpoints are bound to individual ports. This provides a /proc/sys/net/phonet (or sysctl) interface for selecting the range of automatically allocated ports (much like the ip_local_port_range with IPv4). Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/phonet.h | 3 + net/phonet/Makefile | 1 + net/phonet/af_phonet.c | 3 + net/phonet/socket.c | 3 +- net/phonet/sysctl.c | 113 ...

This is the basis for the Phonet protocol families, and introduces the ETH_P_PHONET packet type and the PF_PHONET socket family. Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/phonet.h | 71 ++++++++++++++ net/phonet/Makefile | 3 +- net/phonet/af_phonet.c | 218 +++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 291 insertions(+), 1 deletions(-) create mode 100644 include/net/phonet/phonet.h create mode 100644 ...

Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/phonet.h | 1 + net/phonet/af_phonet.c | 20 ++++++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/include/net/phonet/phonet.h b/include/net/phonet/phonet.h index 8e7e42d..1131833 100644 --- a/include/net/phonet/phonet.h +++ b/include/net/phonet/phonet.h @@ -81,6 +81,7 @@ void pn_skb_get_dst_sockaddr(struct sk_buff *skb, struct sockaddr_pn *sa) /* Protocols ...

Please look at net/ipv4/tcp_minisocks.c to see how tcp_death_row is initialized, that way you don't have to first initialize it to zeros (BSS as it is static and uninitialized) and then, at phonet_device_init Perhaps a phone_for_each_dev() macro like for_each_netdev() in minor nitpick: if (pna != NULL) INIT_LIST_HEAD(&pna->list); Not symetric, i.e. you have a list_add operation and not a list_del, only one that in addition to removing from the list also destroys the Why not ...

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- Documentation/networking/phonet.txt | 111 +++++++++++++++++++++++++++++++++++ 1 files changed, 111 insertions(+), 0 deletions(-) create mode 100644 Documentation/networking/phonet.txt diff --git a/Documentation/networking/phonet.txt b/Documentation/networking/phonet.txt new file mode 100644 index 0000000..f3c72e0 --- /dev/null +++ b/Documentation/networking/phonet.txt @@ -0,0 +1,111 @@ +Linux Phonet protocol ...

This provides support for configuring Phonet addresses, notifying Phonet configuration changes, and dumping the configuration. Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/phonet.h | 1 + net/phonet/Makefile | 1 + net/phonet/af_phonet.c | 1 + net/phonet/pn_netlink.c | 240 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 243 insertions(+), 0 deletions(-) create mode 100644 net/phonet/pn_netlink.c diff ...

This provides support for adding Phonet addresses to and removing Phonet addresses from network devices. Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/pn_dev.h | 63 ++++++++++++ net/phonet/Makefile | 1 + net/phonet/af_phonet.c | 12 ++ net/phonet/pn_dev.c | 233 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 309 insertions(+), 0 deletions(-) create mode 100644 include/net/phonet/pn_dev.h create mode ...

This provides the basic SOCK_DGRAM transport protocol for Phonet. Signed-off-by: Remi Denis-Courmont <remi.denis-courmont@nokia.com> --- include/net/phonet/phonet.h | 6 ++ net/phonet/Makefile | 1 + net/phonet/af_phonet.c | 108 +++++++++++++++++++++++ net/phonet/datagram.c | 198 +++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 313 insertions(+), 0 deletions(-) create mode 100644 net/phonet/datagram.c diff --git a/include/net/phonet/phonet.h ...

Here you could just use: ph = (struct phonethdr *)skb_network_header(skb); or even just: ph = pn_hdr(skb); No need for __constant_htons(CONSTANT), htons will do the right thing --

Added check for IFF_UP in hso_resume, this should eliminate -EINVAL (-22) errors caused from urb's being submitted twice, once by hso_resume & once in hso_net_open, if suspend/resume USB power saving mode is enabled Signed-off-by: Denis Joseph Barrow <D.Barow@option.com> --- Index: linux-2.6.27-rc6/drivers/net/usb/hso.c =================================================================== --- linux-2.6.27-rc6.orig/drivers/net/usb/hso.c 2008-09-16 16:17:11.000000000 +0200 +++ ...

This patch provides support for including the LSM's secid in addition to the LSM's MLS information in the NetLabel security attributes structure. Signed-off-by: Paul Moore <paul.moore@hp.com> Acked-by: James Morris <jmorris@namei.org> --- include/net/netlabel.h | 2 +- security/selinux/ss/services.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/net/netlabel.h b/include/net/netlabel.h index 074cad4..d56517a 100644 --- ...

This patch accomplishes two minor tasks: add a new tag type for local labeling and rename the CIPSO_V4_MAP_STD define to CIPSO_V4_MAP_TRANS. The first change allows CIPSO to support full LSM labels/contexts, not just MLS attributes. The second change brings the mapping names inline with what userspace is using, compatibility is preserved since we don't actually change the value. Signed-off-by: Paul Moore <paul.moore@hp.com> --- include/net/cipso_ipv4.h | 13 +++-- ...

At some point I think I messed up and dropped the calls to netlbl_skbuff_err() which are necessary for CIPSO to send error notifications to remote systems. This patch re-introduces the error handling calls into the SELinux code. Signed-off-by: Paul Moore <paul.moore@hp.com> Acked-by: James Morris <jmorris@namei.org> --- include/net/netlabel.h | 6 ++++-- net/netlabel/netlabel_kapi.c | 5 +++-- security/selinux/hooks.c | 19 +++++++++++++++---- ...

We were doing a lot of extra work in selinux_netlbl_sock_graft() what wasn't necessary so this patch removes that code. It also removes the redundant second argument to selinux_netlbl_sock_setsid() which allows us to simplify a few other functions. Signed-off-by: Paul Moore <paul.moore@hp.com> --- security/selinux/netlabel.c | 38 ++++++++++---------------------------- 1 files changed, 10 insertions(+), 28 deletions(-) diff --git a/security/selinux/netlabel.c ...

Previous work enabled the use of address based NetLabel selectors, which while highly useful, brought the potential for additional per-packet overhead when used. This patch attempts to solve that by applying NetLabel socket labels when sockets are connect()'d. This should alleviate the per-packet NetLabel labeling for all connected sockets (yes, it even works for connected DGRAM sockets). Signed-off-by: Paul Moore <paul.moore@hp.com> --- include/net/cipso_ipv4.h | 5 + ...

It turns out that checking to see if skb->sk is NULL is not a very good indicator of a forwarded packet as some locally generated packets also have skb->sk set to NULL. Fix this by not only checking the skb->sk field but also the IP[6]CB(skb)->flags field for the IP[6]SKB_FORWARDED flag. While we are at it, we are calling selinux_parse_skb() much earlier than we really should resulting in potentially wasted cycles parsing packets for information we might no use; so shuffle the code around a bit ...

Another revision to the patchset to fix two issues, one trivial, the other not so much. The trivial fix was to add some locking around the connection labeling operations, we're messing with the socket so we should make sure we lock it like we do everywhere else. The second fix was to ensure that we sync up a stream socket's MSS value when we add IP options to the socket. We were doing everything correctly on the client side, but the server side was a bit of a mess; I'm pretty happy with this fix ...

I forgot to add, there is also a small fix to the cipso_v4_sock_delattr() function so that it correctly removes the CIPSO option and either adjust the option padding correctly or removes the options struct entirely from the socket if it is no longer needed. Thanks to Casey Schaufler for finding this bug. -- paul moore linux @ hp --

This patch builds upon the new NetLabel address selector functionality by providing the NetLabel KAPI and CIPSO engine support needed to enable the new packet-based labeling. The only new addition to the NetLabel KAPI at this point is shown below: * int netlbl_skbuff_setattr(skb, family, secattr) ... and is designed to be called from a Netfilter hook after the packet's IP header has been populated such as in the FORWARD or LOCAL_OUT hooks. This patch also provides the necessary SELinux ...

Also, the implementation of sys_paccept() is not "perfect", imho. sys_paccept: ret = do_accept(...); if (ret < 0 && signal_pending()) { set_restore_sigmask(); return ret; } It doesn't check that ret == ERESTARTSYS/EINTR. I can't say this is bug, but let's suppose that do_accept() returns (say) -EINVAL, and then the task is interrupted by the signal. Now, if the signal comes after sys_paccept() checks signal_pending(), we return -EINVAL, and the signal handler runs ...

Jeff, It is more than two months since the benet driver patch was made available as a single file as suggeted by you : ftp://ftp.serverengines.com/0001.benet.patch I have not seen this applied. Is there any reason for not applying this patch ? Do you want a patch against the latest git tree ? Thanks. Subbu -----Original Message----- From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On Behalf Of Subbu Seetharaman Sent: Wednesday, July 09, 2008 7:25 AM To: ...

So you must set max_aggr to I would be interested to see that, anyway. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. --

This teaches sparse that the following are not problems: make C=1 CHECK net/ipv4/ipvs/ip_vs_ctl.c net/ipv4/ipvs/ip_vs_ctl.c:1793:14: warning: context imbalance in 'ip_vs_info_seq_start' - wrong count at exit net/ipv4/ipvs/ip_vs_ctl.c:1842:13: warning: context imbalance in 'ip_vs_info_seq_stop' - unexpected unlock Signed-off-by: Simon Horman <horms@verge.net.au> Index: lvs-2.6/net/ipv4/ipvs/ip_vs_ctl.c =================================================================== --- ...

Could be static and const, to avoid allocation and initialization on the --

Jumping to out unlocks __ip_vs_svc_lock, but that lock is not taken until after code that may jump to out. This problem was detected by sparse. make C=1 CHECK net/ipv4/ipvs/ip_vs_ctl.c net/ipv4/ipvs/ip_vs_ctl.c:1332:2: warning: context imbalance in 'ip_vs_edit_service' - unexpected unlock Signed-off-by: Simon Horman <horms@verge.net.au> Index: lvs-2.6/net/ipv4/ipvs/ip_vs_ctl.c =================================================================== --- ...

Some fixes and annotations for sparse warnings. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en --

From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> Creating a VLAN interface on top of ucc_geth adds 4 bytes to the frame and the HW controller is not prepared to TX a frame bigger than 1518 bytes which is 4 bytes too small for a full VLAN frame. Also add 4 extra bytes for future expansion. Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se> --- drivers/net/ucc_geth.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ucc_geth.c ...

On Mon, Sep 15, 2008 at 03:13:32PM +0200, Sebastien Dugue wrote: There is a known bug in the -rt kernels, the bug causes handlers to lose edge interrupts. See this patch: -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 --

Hi again. Problem is - fib_validate_source() explicitly doesn't allow any local address to be specified as source address. I figured out I'm not the first in need for different behavior. One of the solutions I've found is forward_shared patch [http://www.ssi.bg/~ja/forward_shared-2.6.25-2.diff] which exists for centuries. Actually, it is not working for me but it is addressing the same thing - forwarding packets with local addresses. I've solved my problem (Cisco's GRE keepalive and Linux) ...

Also, I wonder if this should be an unsigned int as both sizeof(struct iphdr) and inet->cork.opt->optlen are unsigned, -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en --

On Mon, Sep 15, 2008 at 02:11:59PM -0700, David Miller wrote: [snip] Hi Dave, can you confirm that the commit message requirement stands even if the SHA1 ID references Linus' tree? I personally think that is reasonable, I just want to confirm that is the requirement. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en --

the pci_disable_device() is done on an enabled device, so your I thought about the solution, but the pci device is completely setup and enabled in the init function so disabling it at that point and enabling it in open() again sounds silly to me. pci_enable_enable/disable is already done in .init/.remove and .suspend/.resume, so it looked more obviuos to not let close() do the pci_disable_device(). Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessary ...

Note that my emails are not meant against David personally - he just seems to have gotten from pushing too much to pushing too few, with such illogical results. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed --

I'm eagerly awaiting to slap this at Linus the next time he dares to directly apply a patch that only fixes a sparse warning outside of a merge window... ;-) More seriously, there's a difference between Linus' "another random improvement" and an "is even suitable for -stable". I'm not reading Linus' (Cc'ed) statement the way that a patch that is appropriate for 2.6.27.1 is not appropriate for -rc now. If I'm misreading Linus on this it might make sense if they'd discuss ...

Among the patches David rejected based on what Linus said was Thomas' patch [1]. It is not a "really important bug" and does not affect "huge number of users". But it passes Documentation/stable_kernel_rules.txt, and can we agree that if it gets submitted for 2.6.27.1 it will likely pass review and get applied? cu Adrian [1] http://article.gmane.org/gmane.linux.network/105810 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. ...

Well, remember that patches that get published for -stable do have to go through an extra review process. It's not true that any "obviously correct" bug fix gets automatically published in -stable. Sometimes bug fixes do get rejected for -stable because they are too risky, or require more time for testing in the -rc series before they are deemed suitable for -stable. Looking at 2.6.26, there is currently about 195 patches queued up, which is certainly not all of the bugs fixed during the ...

On Tue, 16 Sep 2008 09:54:08 -0400 also note that Linus said "regression or on the kerneloops list"; if it has any kind of backtrace, it'll be there if it's a common problem that hits many users. -- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org --

So I did some experiments and removed the ip_vs_post_routing() function that stops further POSTROUTING processing. I added an SNAT rule to POSTROUTING like this: $ iptables –t nat –A POSTROUTING –o eth1 –j SNAT –-to $DIP Amazingly, the first SYN and the SYN/ACK of a TCP connection to the VIP:vport do not traverse the NAT chain in POSTROUTING at all (verified by LOG target), so their source is not rewritten (like in normal LVS/NAT). However, the client's ACK response to the SYN/ACK finally ...

For what it's worth, I'm currently using DNAT alongside LVS-NAT for certain connections. It only serves a secondary purpose and there are other ways (although not as simple) to achieve the purpose, but it has proven useful. -- Jason Stubbs <j.stubbs@linkthink.co.jp> LINKTHINK INC. 東京都渋谷区桜ヶ丘町22-14 N.E.S S棟 3F TEL 03-5728-4772 FAX 03-5728-4773 --

It unfortunately can't. As I already mentioned "it must be assured that no function that modifies the list's content can be called while another list update is in progress". This means that for example ehea_broadcast_reg_helper() may not run during a list update. That's why the locks surround these function calls as well. --

OK, your call, you know the code better than I do. But the locking could at least be pushed into ehea_update_firmware_handles() and ehea_update_bcmc_registrations() instead of being at each call site. Thanks, --

Here is an updated patch without the defconfig changes == cut here == e1000: remove Kconfig option for packet split and e1000 related code From: Jesse Brandeburg <jesse.brandeburg@intel.com> Since the e1000/e1000e split, no hardware supported by e1000 supports packet split, just remove the Kconfig option and associated code from the driver. reposted without the defconfig changes, should apply to net-next Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com> --- ...

On Mon, Sep 15, 2008 at 04:44:08PM -0700, Duyck, Alexander H wrote: Actually, looking at this HFSC now I start to doubt we need to complicate these things so much. If HFSC is OK with its simple hfsc_requeue() I doubt other qdiscs need much more, and we should reconsider David's idea to do the same on top, in dev_requeue_skb(). Qdiscs like multiq would probably never use this, and these above mentioned (not mq-optimized) qdiscs could be used with multiq if needed. Then, it seems, it would be ...

OK. Please also try leaving reset_chip() as it is and see if it still works like that -- I suspect that that part of the patch might have been a debug leftover. --

I guess then we should just wait until the Freescale people submit it. --

I've copied stuff from the other mail to here... Sorry for the delay, I had already looked into it but left it as postponed and I've been busy in other things... On Sat, 13 Sep 2008, D