dead code in tc/m_ematch.c

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Jochen Voss
Date: Saturday, September 13, 2008 - 10:58 am

Hi,

while looking through the source for the Debian package
iproute-20080725, I found the following bit of code (file
tc/m_ematch.c, lines 163-173):

    static struct ematch_util *get_ematch_kind_num(__u16 kind)
    {
	    char name[32];

	    if (lookup_map(kind, name, sizeof(name), EMATCH_MAP) < 0)
		    return NULL;

	    return get_ematch_kind(name);

	    return NULL;
    }

Obviously the second return statement has no effect.  Probably it
should be removed.

I hope this helps,
Jochen
--=20
http://seehuhn.de/
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
dead code in tc/m_ematch.c, Jochen Voss, (Sat Sep 13, 10:58 am)