Home » Mailing list archives » linux-netdev » 2008 » September » 1

[PATCH 48/52] sfc: Stop generating bogus events in tenxpress_check_hw()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Ben Hutchings
Subject: [PATCH 48/52] sfc: Stop generating bogus events in tenxpress_check_hw()
Date: Monday, September 1, 2008 - 4:50 am

mdio_clause45_links_ok() correctly checks efx_phy_mode_disabled(), so
tenxpress_link_ok() doesn't need to.

From: Steve Hodgson <shodgson@solarflare.com>
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
 drivers/net/sfc/tenxpress.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/sfc/tenxpress.c b/drivers/net/sfc/tenxpress.c
index 2ad3d8d..d507c93 100644
--- a/drivers/net/sfc/tenxpress.c
+++ b/drivers/net/sfc/tenxpress.c
@@ -377,8 +377,7 @@ static int tenxpress_phy_check_hw(struct efx_nic *efx)
 	struct tenxpress_phy_data *phy_data = efx->phy_data;
 	bool link_ok;
 
-	link_ok = (phy_data->phy_mode == PHY_MODE_NORMAL &&
-		   tenxpress_link_ok(efx, true));
+	link_ok = tenxpress_link_ok(efx, true);
 
 	if (link_ok != efx->link_up)
 		falcon_xmac_sim_phy_event(efx);
-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH 00/52] sfc: Changes for 2.6.28, Ben Hutchings, (Mon Sep 1, 4:16 am)
[PATCH 01/52] sfc: Replace net_dev-&gt;priv with netdev_priv( ..., Ben Hutchings, (Mon Sep 1, 4:43 am)
[PATCH 02/52] sfc: Change first parameter type of {set,cle ..., Ben Hutchings, (Mon Sep 1, 4:43 am)
[PATCH 03/52] sfc: Remove unused field efx_channel::reset_work, Ben Hutchings, (Mon Sep 1, 4:44 am)
[PATCH 04/52] sfc: Use separate hardware TX queues to sele ..., Ben Hutchings, (Mon Sep 1, 4:44 am)
[PATCH 05/52] sfc: Avoid mangling error codes in efx_test_ ..., Ben Hutchings, (Mon Sep 1, 4:45 am)
[PATCH 06/52] sfc: Reduce delays in SFE4001 initialisation, Ben Hutchings, (Mon Sep 1, 4:45 am)
[PATCH 07/52] sfc: Remove mistaken hardware workaround, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 08/52] sfc: XMAC statistics fix-ups, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 09/52] sfc: Remove inclusion of workarounds.h from ..., Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 10/52] sfc: Reverse the XOFF/XON pause frame contro ..., Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 11/52] sfc: Reduce log level for XGXS lane status, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 12/52] sfc: Self-test reporting cleanup, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 13/52] sfc: Speed up loopback self-test, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 14/52] sfc: Don't leak PCI DMA maps in the TSO code ..., Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 15/52] sfc: Use pci_map_single() to map the skb hea ..., Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 16/52] sfc: Reduce the size of struct efx_tx_buffer, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 17/52] sfc: Use explicit bool for boolean variables ..., Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 18/52] sfc: Set net_device::vlan_features appropriately, Ben Hutchings, (Mon Sep 1, 4:46 am)
[PATCH 19/52] sfc: Cleaned up struct tso_state fields, Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 20/52] sfc: Removed forced inlining of long functions, Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 21/52] sfc: Export boot configuration in EEPROM thr ..., Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 22/52] sfc: Move CPU counting for RSS into a separa ..., Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 23/52] sfc: Remove efx_channel::has_interrupt, Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 24/52] sfc: Cleanup RX queue information, Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 25/52] sfc: Remove initialisation of RX_FILTER_CTL_ ..., Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 26/52] sfc: Make efx_for_each_channel_rx_queue() mo ..., Ben Hutchings, (Mon Sep 1, 4:47 am)
[PATCH 27/52] sfc: Remove efx_channel::evqnum field, Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 28/52] sfc: Cleanup RX event processing, Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 29/52] sfc: Implement get_sset_count, replacing get ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 30/52] sfc: Make PHY flash mode a device attribute, ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 31/52] sfc: Do not call netif_{stop,wake}_queue() b ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 32/52] sfc: Enable TSO for 802.1q VLAN devices, Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 33/52] sfc: Remove efx_nic_dummy_op_int() as redund ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 34/52] sfc: Remove remnants of multi-port abstracti ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 35/52] sfc: Remove some unreachable error paths, Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 36/52] sfc: Cleanup reset code, Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 37/52] sfc: Rework the bitfield header so that we c ..., Ben Hutchings, (Mon Sep 1, 4:48 am)
[PATCH 38/52] sfc: Extend self-tests, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 39/52] sfc: Remove the STATE_RESETTING flag, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 40/52] sfc: Rework efx_set_multicast_hash(), Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 42/52] sfc: Fix memory BAR release call on error path, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 43/52] sfc: Remove workaround for old firmware bug, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 44/52] sfc: Serialise tenxpress_special_reset() wit ..., Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 45/52] sfc: Don't use EFX_OWORD_FIELD on an event ( ..., Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 46/52] sfc: Make queue flushes more reliable, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 47/52] sfc: Don't include net_driver.h from falcon_io.h, Ben Hutchings, (Mon Sep 1, 4:49 am)
[PATCH 48/52] sfc: Stop generating bogus events in tenxpre ..., Ben Hutchings, (Mon Sep 1, 4:50 am)
[PATCH 49/52] sfc: Insert read memory barrier after checki ..., Ben Hutchings, (Mon Sep 1, 4:50 am)
[PATCH 50/52] sfc: Disable interrupts after a fatal interr ..., Ben Hutchings, (Mon Sep 1, 4:50 am)
[PATCH 51/52] sfc: Remove obsolete comment about PCI modes, Ben Hutchings, (Mon Sep 1, 4:50 am)
[PATCH 52/52] sfc: Use CONFIG_HAVE_EFFICIENT_UNALIGNED_ACC ..., Ben Hutchings, (Mon Sep 1, 4:50 am)
Re: [PATCH 40/52] sfc: Rework efx_set_multicast_hash(), Jeff Garzik, (Wed Sep 3, 6:54 am)
[PATCH 41/52] sfc: Add check for memory allocation failure ..., Ben Hutchings, (Wed Sep 3, 7:07 am)
Re: [PATCH 41/52] sfc: Add check for memory allocation fai ..., Jeff Garzik, (Sat Sep 13, 12:29 pm)