Home » Mailing list archives » linux-netdev » 2008 » August » 7

[PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: roel kluin <roel.kluin@...>
To: <jie.yang@...>, <jgarzik@...>
Cc: <netdev@...>, <linux-kernel@...>
Subject: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?
Date: Thursday, August 7, 2008 - 12:24 pm

untested, is it right?
---
WAKE_MCAST bit tested twice, test WAKE_UCAST first.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c
index cdc3b85..619c658 100644
--- a/drivers/net/atl1e/atl1e_ethtool.c
+++ b/drivers/net/atl1e/atl1e_ethtool.c
@@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
 	struct atl1e_adapter *adapter = netdev_priv(netdev);
 
 	if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE |
-			    WAKE_MCAST | WAKE_BCAST | WAKE_MCAST))
+			    WAKE_UCAST | WAKE_MCAST | WAKE_BCAST))
 		return -EOPNOTSUPP;
 	/* these settings will always override what we currently have */
 	adapter->wol = 0;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?, roel kluin, (Thu Aug 7, 12:24 pm)
Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?, Jeff Garzik, (Thu Aug 14, 4:44 am)
RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?, Jie Yang, (Thu Aug 7, 11:12 pm)
RE: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST?, Jie Yang, (Thu Aug 7, 9:25 pm)