linux-netdev mailing list

FromSubjectsort iconDate
Adrian Bunk
[2.6 patch] the overdue eepro100 removal
This patch contains the overdue eepro100 removal. Signed-off-by: Adrian Bunk <bunk@kernel.org> --- This patch has been sent on: - 20 May 2008 Documentation/feature-removal-schedule.txt | 7 MAINTAINERS | 5 drivers/net/Kconfig | 13 drivers/net/Makefile | 1 drivers/net/eepro100.c | 2401 --------------------- 5 files changed, 2427 deletions(-) ceaaa8c3ca68da270944e82b3f...
Aug 6, 5:10 pm 2008
Luis R. Rodriguez
Re: [PATCH 2/4] list.h: add list_cut_position()
Here it is again but this time one which applies cleanly ontop of the list_cut_tail() patch I just reposted. -- list.h: add list_cut_position() This adds list_cut_position() which lets you cut a list into two lists given a pivot in the list. Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com> --- include/linux/list.h | 40 ++++++++++++++++++++++++++++++++++++++++ 1 files changed, 40 insertions(+), 0 deletions(-) diff --git a/include/linux/list.h b/include/linux/list.h ind...
Aug 6, 4:28 pm 2008
Luis R. Rodriguez
Re: [PATCH 2/4] list.h: add list_cut_position()
I meant on top of the list_splice_tail() of course :) Luis --
Aug 6, 4:32 pm 2008
Ayaz Abdulla
[PATCH 4/4] forcedeth: add tx pause limit
This patch adds support for limiting the number of tx pause frames to a default of 8. Previously, hardware would send out continuous stream of pause frames. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Aug 6, 12:16 pm 2008
Ayaz Abdulla
[PATCH 3/4] forcedeth: add jumbo frame support for mcp79
This patch adds jumbo frame support for MCP79 chipsets. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Aug 6, 12:12 pm 2008
Ayaz Abdulla
[PATCH 2/4] forcedeth: add new tx stat counters
This patch adds support for new tx statistic counters in the hardware - unicast, multicast, and broadcast Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Aug 6, 12:11 pm 2008
Ayaz Abdulla
[PATCH 1/4] forcedeth: fix rx error policy
This patch enforces a stricter policy on rx errors. The driver needs to verify whether there are multiple rx errors versus a single error. Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
Aug 6, 12:11 pm 2008
Wolfgang Walter
Re: Kernel oops with 2.6.26, padlock and ipsec: probably pro...
Hello Herbert, I think I finally found the problem. Here a short description again: all our routers with a via C3 using padlock for AES-encryption are crashing with 2.6.26 while they work fine with 2.6.25. Not using padlock (i.e. using the i386 assembler version of AES) they just work fine. After a kernel bisection I found that fa5c4639419668cbb18ca3d20c1253559a3b43ae works fine, 2adee9b30d1382fba97825b9c50e4f50a0117c36 crashes. I did not try to bisect the last 4 commits as they seem to be r...
Aug 6, 1:33 pm 2008
Suresh Siddha
Re: Kernel oops with 2.6.26, padlock and ipsec: probably pro...
Both the padlock version or asm version don't use FP/math registers, right? It is interesting that you don't see the problem with asm version but see the problem with padlock version. Does disabling CONFIG_PREEMPT in 2.6.26 change anything? And also, can you provide the complete kernel log till the point of failure(oops that you sent doesn't have the call trace info) thanks, suresh --
Aug 6, 4:14 pm 2008
Suresh Siddha
Re: Kernel oops with 2.6.26, padlock and ipsec: probably pro...
BTW, in one of your oops, I see: note: cron[1207] exited with preempt_count 268435459 I smell some kind of stack corruption here which is corrupting thread_info (in the above case preempt_count in the thread_info). Similarly, if the status field(in thread_info) gets corrupted(setting TS_USEDFPU) without proper math state allocated(present in thread_struct), we can end up oops in __switch_to. But you seem to say, reverting recent fpu patches make the problem go away. hmm, just wondering if ...
Aug 6, 5:21 pm 2008
Tobias Koeck
hash_list and rcu locking question
Are the hash_list rcu functions avoiding all locking problems (even the one with only one CPU)? Are there some abstract examples for the use of the hash_{head,list} structures? Greetz and thanks t. --
Aug 6, 11:56 am 2008
Evgeniy Polyakov
Re: hash_list and rcu locking question
Hi Tobias. What is hash list? hlist? Or list in a hash bucket? Sorry, my kernel source tree does not know what is 'hash_head'. What data structure exactly do you mean? -- Evgeniy Polyakov --
Aug 6, 4:54 pm 2008
Indan Zupancic
Re: Realtek 8111C transmit timed out
I'm running a git version just before 2.6.27-rc2 and while the card worked fine in 2.6.26, after a resume from suspend to ram I now get: [ 8367.073701] r8169 0000:01:00.0: restoring config space at offset 0x1 (was 0x100007, writing 0x100407) [ 8367.073863] sd 2:0:0:0: [sda] Starting disk [ 8367.077786] r8169: eth0: link up [ 8367.265653] ata4.01: configured for UDMA/100 [ 8371.953804] ata3.00: configured for UDMA/133 [ 8371.964803] sd 2:0:0:0: [sda] 390721968 512-byte hardware sectors (200050 ...
Aug 6, 10:57 am 2008
Francois Romieu
Re: Realtek 8111C transmit timed out
Indan Zupancic <indan@nul.nu> : You cab try to revert the four (4) r8169.c related patches that went in between 2.6.26 and 2.6.27-rc1. I doubt it will make a difference though. Is a git bisect an option ? -- Ueimor --
Aug 6, 2:12 pm 2008
Indan Zupancic
Re: Realtek 8111C transmit timed out
Hello, "git log drivers/net/r8169.c" shows only two commits since May 11: r8169: avoid thrashing PCI conf space above RTL_GIGA_MAC_VER_06 r8169: multicast register update Then at May 11 comes: r8169: remove non-napi code But I think that was in 2.6.26 already. Reverting the first two didn't help, so I guess it's messed up somewhere else. Are two patches missing or didn't they touch r8169.c? I tried manually reverting patch 0004-r8169-new-phy-init-parameters-for-the-8168b.pat...
Aug 6, 3:37 pm 2008
Francois Romieu
Re: Realtek 8111C transmit timed out
Indan Zupancic <indan@nul.nu> : $ git rev-list v2.6.26..v2.6.27-rc1 -- drivers/net/r8169.c 77332894c21165404496c56763d7df6c15c4bb09 f887cce8de019bb32917789379af89ae4c0294ee 865c652d6be9929927cabdc54b137b7541eb6612 No. :o) Ok. -- Ueimor --
Aug 6, 3:50 pm 2008
Indan Zupancic
Re: Realtek 8111C transmit timed out
Oh... I tried 2.6.27-rc2 with that patch reverted and NAPI disabled, but that didn't work either, so it seems it's something a level higher. (No way that that last patch could cause this...) You said off-list that I may want to check if there is any aspm related message in dmesg. Well, I get this: Pre-1.1 PCIe device detected, disable ASPM for 0000:00:1c.1. It can be enabled forcedly with 'pcie_aspm=force' So I guess it's unlikely that it causes any problems, except if the driver assu...
Aug 6, 6:50 pm 2008
Denys Fedoryshchenko
[PATCH] correct pointer assignment in free_opts()
Invalid way of pointer assignment in free_opts causing global opts variable pointingto freed memory. It was possible to trigger this bug only by batching multiple rules with ipt action. Signed-off-by: Denys Fedoryshchenko <denys@visp.net.lb> Acked-by: Jamal Hadi Salim <hadi@cyberus.ca> Tested-by: Denys Fedoryshchenko <denys@visp.net.lb> --- diff -uprN iproute-original/tc/m_ipt.c iproute2-patched2/tc/m_ipt.c --- iproute-original/tc/m_ipt.c 2008-08-05 22:15:56.000000000 +0300 ...
Aug 6, 10:47 am 2008
Brice Goglin
[PATCH 0/2] myri10ge small updates for 2.6.27
Hello Jeff, Here are 2 small updates for myri10ge in 2.6.27. 1) myri10ge: update firmware headers 2) myri10ge: set 64bits consistent DMA mask We are working on multiqueue TX support but I don't know when the patch will be ready, so I am sending everything else now. thanks, Brice --
Aug 6, 10:13 am 2008
Brice Goglin
[PATCH 2/2] myri10ge: set 64bits consistent DMA mask
Set 64bits consistent DMA mask since it improves performance in some cases. No need to check the return value since it is not required for the driver to work. Signed-off-by: Brice Goglin <brice@myri.com> --- drivers/net/myri10ge/myri10ge.c | 1 + 1 file changed, 1 insertion(+) Index: linux-2.6/drivers/net/myri10ge/myri10ge.c =================================================================== --- linux-2.6.orig/drivers/net/myri10ge/myri10ge.c 2008-07-23 09:18:21.000000000 +0200 +++ l...
Aug 6, 10:15 am 2008
Brice Goglin
[PATCH 1/2] myri10ge: update firmware headers
Update myri10ge firmware headers. Signed-off-by: Brice Goglin <brice@myri.com> --- drivers/net/myri10ge/myri10ge_mcp.h | 52 ++++++++++++++++++++++--- drivers/net/myri10ge/myri10ge_mcp_gen_header.h | 2 2 files changed, 48 insertions(+), 6 deletions(-) Index: linux-2.6/drivers/net/myri10ge/myri10ge_mcp.h =================================================================== --- linux-2.6.orig/drivers/net/myri10ge/myri10ge_mcp.h 2008-05-19 18:13:31.000000000 +0200 +++ linux-...
Aug 6, 10:14 am 2008
王晏蓉
您還沒有一個專屬的企業網站嗎?
山鉧科技網頁設計 我們的宗旨:客戶的每ㄧ件小事情,都是山鉧的大事情 我們在推出企業形象網站包含前台網頁美工+後台管理程式 限時限量專案價 只要$29,900 (在送ㄧ年100MB不限流量網站空間) 我們做的不只是網站,而是您企業的入口 ㄧ個好的企業網站資料即時更新的速度是很重要的 企業e化的高品質團隊,打造您的網路門面 選擇山鉧成就您的夢想 ~~~~~~~~~~~~...
Aug 6, 3:10 am 2008
Li Yang
[PATCH] net/fs_enet: remove redundant messages for performance
Currently when we do a packet flood to the Ethernet port, the console reports error every time when a packet is dropped. This is too redundant and cost performance. Remove message for this type of event. Signed-off-by: Li Yang <leoli@freescale.com> --- drivers/net/fs_enet/mac-fcc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/fs_enet/mac-fcc.c b/drivers/net/fs_enet/mac-fcc.c index 0a97fc2..1c7ef81 100644 --- a/drivers/net/fs_enet/mac-fcc.c +++ b...
Aug 6, 3:08 am 2008
Krzysztof Piotr Oledzki
[PATCH] netfilter: fix two recent sysctl problems
netfilter: fix two recent sysctl problems Starting with 9043476f726802f4b00c96d0c4f418dde48d1304 we have two netfilter releated problems: - WARNING: at kernel/sysctl.c:1966 unregister_sysctl_table+0xcc/0x103(), caused by wrong order of ini/fini calls - net.netfilter is duplicated and has truncated set of records Thanks to very useful guidelines from Al Viro, this patch fixes both of them. Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl> diff -Nur linux-2.6.27-rc1-orig/net/n...
Aug 5, 11:08 pm 2008
Al Viro
Re: [PATCH] netfilter: fix two recent sysctl problems
ACKed-by: Al Viro <viro@zeniv.linux.org.uk> --
Aug 5, 11:22 pm 2008
David Miller
Re: [PATCH] netfilter: fix two recent sysctl problems
From: Al Viro <viro@ZenIV.linux.org.uk> Applied, thanks. --
Aug 6, 5:35 am 2008
David Miller
[GIT]: Networking
Here are the pending networking bits. There was going to be the addition of the ath9k wireless driver but there was some fallout that is being worked on right now (linux/list.h changes needed lkml review, ath9k driver triggered some gcc aborts, all kinds of fun stuff :-) so hopefully it will make it in the next pass. I tried to wait an extra day for it to be resolved, but that was optimistic. Highlights: 1) Intel driver guys triggered an OOPS when setting MTU during a busy transmit stre...
Aug 5, 10:00 pm 2008
Linus Torvalds
Re: [GIT]: Networking
Talking about wireless driver updates - has anybody looked at the RaLink wireless driver? It's in the newer EeePC's (901 and 1000), and it actually has a driver from the company which the comments make clear is GPLv2 too, no apparent oddness or anything: http://www.ralinktech.com.tw/data/drivers/2008_0708_RT2860_Linux_STA_v1.7.0.0.tar.bz2 which admittedly apparently has some trivial problems (with a trivial patch as seen at http://fedoraforum.org/forum/showthread.php?t=195429 I'...
Aug 5, 10:57 pm 2008
Ivo van Doorn
Re: [GIT]: Networking
Like the earlier rt2x00 drivers I am rewriting the driver as released by Ralink and have put it in the rt2x00lib/mac80211 framework. Most of the code is currently done, and the last part should be done this week. After that it is a matter of testing and comparing register values with the Ralink driver for the last tweaks. I doubt the driver will be ready/stable for 2.6.28, but it should be ready for 2.6.29. Ivo --
Aug 6, 4:21 am 2008
Marcel Holtmann
Re: [GIT]: Networking
I looked at the driver and got it working. However my 901 seems to have an issue with the antennas. I can do scans, but associating with an access point or even thinking about transmit keeps failing. Even with external antennas this still doesn't work. So either my EeePC is broken or it needs some ACPI magic to enable it. Personally I think mine is broken since the PCIe hotplug stuff works for the wireless card and that seems to be their way of doing the rfkill. The driver itself is p...
Aug 6, 1:59 am 2008
Linus Torvalds
Re: [GIT]: Networking
Yeah, the rfkill literally makes the chip go away from the PCI lists, it seems. But your problems can certainly be somehow driver-related, I haven't actually _tested_ that thing at all, I got the machine just as the Well, it's also trying to support both 2.4.x and 2.6 etc. Yeah, that is horrid. At the same time, I can't say that the "rewrite it entirely" approach of the previous-gen cards has worked very well either, since that seems to have just perpetuated the problems. It would be gre...
Aug 6, 2:18 am 2008
Ivo van Doorn
Re: [GIT]: Networking
I've send a mail to Ralink with a request if they could step away from the "port the windows driver to linux" idea and get the Linux driver "kernel-ready" early on. That won't solve the problem now, but hopefully it does mean the drivers for Well it basically is the Windows driver ported to Linux. ;) Ivo --
Aug 6, 4:22 am 2008
John W. Linville
Re: [GIT]: Networking
The Ralink guys are being educated and AFAICT they are interested in better participation. Time will tell, of course. In the meantime as Ivo indicated he is "on the case" -- I think we will see something before too long. John -- John W. Linville linville@tuxdriver.com --
Aug 6, 9:15 am 2008
Ivo van Doorn
Re: [GIT]: Networking
For the interested, the rt2800pci and rt2800usb code which I am working on can be found in the experimental branch of my repository: http://git.kernel.org/?p=linux/kernel/git/ivd/rt2x00.git;a=shortlog;h=experimental Because the code is incomplete it cannot be tested, but it gives at least an idea on what is already done. ;) Ivo --
Aug 6, 10:35 am 2008
Patrick McHardy
Re: iproute2 proposal
It breaks batches that add links and then configure them. You need to invalidate the link map on "ip link add/del" and "ip tunnel add/del". --
Aug 6, 4:28 am 2008
Denys Fedoryshchenko
Re: iproute2 proposal
Probably for tc batch it doesn't matter, so this optimization can be done only for tc (i exclude also monitor functions, they must renew list of interfaces). Is new patch looks better? (i test it, it compiles and doesn't break tc, and makes still things much faster on systems with many interfaces). --
Aug 6, 6:04 am 2008
Patrick McHardy
Re: iproute2 proposal
I'm not sure I understand you correctly. It matters *only* for No patch attached .. --
Aug 6, 6:09 am 2008
Denys Fedoryshchenko
Re: iproute2 proposal
Sorry :-) Now must be attached
Aug 6, 6:22 am 2008
Patrick McHardy
Re: iproute2 proposal
It would be nicer to avoid the initialization in ll_init_map() as you did in your first patch and add an explicit ll_invalidate_map() and call it when necessary (ip link add/del/change(?), ip tunnel add/del/change(?)). --
Aug 6, 6:25 am 2008
Denys Fedoryshchenko
Re: iproute2 proposal
It is more than that. I must also invalidate in monitor mode, since this is very volatile variable. In monitor mode very possible that interfaces can be changed. Also i guess it is not required and better to invalidate in "printing" functions? If it is ok, i will try to do patch in this way now. --
Aug 6, 6:38 am 2008
Patrick McHardy
Re: iproute2 proposal
Ok I noticed the misunderstanding. Yes, it doesn't matter for tc, only for ip. --
Aug 6, 6:09 am 2008
David Miller
Re: [PATCH] AX.25: Fix sysctl registration if !CONFIG_AX25_D...
From: Ralf Baechle <ralf@linux-mips.org> Applied, and I'll queue it up for -stable too. Thanks Ralf. --
Aug 5, 9:47 pm 2008
Al Viro
Re: [PATCH] AX.25: Fix sysctl registration if !CONFIG_AX25_D...
BTW, here's netfilter sysctl one: Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/net/netfilter/core.c b/net/netfilter/core.c index 292fa28..655d743 100644 --- a/net/netfilter/core.c +++ b/net/netfilter/core.c @@ -264,6 +264,12 @@ EXPORT_SYMBOL(proc_net_netfilter); void __init netfilter_init(void) { int i, h; + +#ifdef CONFIG_SYSCTL + static struct ctl_table empty[1]; + register_sysctl_paths(nf_net_netfilter_sysctl_path, empty); +#endif + for (i = 0; i <...
Aug 5, 9:59 pm 2008
Krzysztof Oledzki
Re: [PATCH] AX.25: Fix sysctl registration if !CONFIG_AX25_D...
I think that instead of adding an empty nf_net_netfilter_sysctl_path=20 registration, it would be better to fix the order of register/unregister: @@ -1032,10 +1032,10 @@ nf_ct_free_hashtable(nf_conntrack_hash, nf_conntrack_vmalloc, nf_conntrack_htable_size); - nf_conntrack_proto_fini(); - nf_conntrack_helper_fini(); - nf_conntrack_expect_fini(); nf_conntrack_acct_fini(); + nf_conntrack_expect_fini(); + nf_con...
Aug 5, 10:35 pm 2008
jamal
Re: few more fixes for iproute2/m_ipt
Denys, Indeed there seems to be an issue here, but: Have you tried in your batch with a few "index"ed parameters to ipt with your fix? I think it will break with your changes. Of course that does not invalidate your concern. If you send me a two liner batch example I think #2 and #3 are leggit. Send two patches - one for #1 when you validate and the other for #2,#3 when you validate. BTW, for the equivalent of the latter - if you feel brave - theres a lot more of that type in the tc code. c...
Aug 6, 6:04 am 2008
Denys Fedoryshchenko
Re: few more fixes for iproute2/m_ipt
not sure about two lines #1 is validated 100%, because i was not able to run tc in batch mode for my tasks(2nd or 3rd ipt rule will crash), till i implement those patches. The batch i gave is short version, full version have around 11k lines. But it crashes usually max on 2rd or 3nd ipt. Well, i can fix what i can sniff&smell in my daily job, and especially if i hit a wall because of some code :-) For me it is difficult to inspect the code, since i am very weak in C, but i will try.
Aug 6, 6:21 am 2008
jamal
Re: few more fixes for iproute2/m_ipt
Ok, thanks - let me take a closer look. Actually i dont doubt that when you batch the optind maybe shaky - I am more worried about other working scenarios that may have depended on it. I understand it could be frustrating sometimes but given your situation you are doing fantastic work. It is highly appreciated. cheers, jamal --
Aug 6, 7:04 am 2008
Denys Fedoryshchenko
Re: few more fixes for iproute2/m_ipt
Is it better like this? Sure optind is up to you, for me it is not clear yet how it works. Just i notice in iptables.c, function do_command where they set optind to zero and in comments /*re-set optind to zero in case do_command gets called second time */
Aug 6, 7:26 am 2008
jamal
Re: few more fixes for iproute2/m_ipt
I have done extensive testing with and with optind=0 and optind=1 and i didnt see any breakage with either. I have a feeling that setting optind to 0 in your case to avoid the crash maybe hiding something else - but i cant find what that something else is since i am just simulating what you are doing. If the iptables folks have changed it to reset to 0, then I dont see any harm in resetting. So ACK to both your patches. cheers, jamal PS:- dont wanna sound anal - and you dont have to do th...
Aug 6, 8:46 am 2008
Denys Fedoryshchenko
Re: few more fixes for iproute2/m_ipt
Yes, i did already Attaching patches
Aug 6, 8:50 am 2008
previous daytodaynext day
August 5, 2008August 6, 2008August 7, 2008