| From | Subject | Date |
|---|---|---|
| Denys Fedoryshchenko | iproute2 proposal
While using iproute2 in batch mode i notice that adding 11362 rules, on system
with 500+ interfaces takes up to 1minute on Xeon 3.0 Ghz.
After "oprofiling" i got result:
CPU: P4 / Xeon with 2 hyper-threads, speed 2992.84 MHz (estimated)
Counted GLOBAL_POWER_EVENTS events (time during which processor is not
stopped) with a unit mask of 0x01 (mandatory) count 100000
samples % image name symbol name
86166 57.3473 tc ll_remember_index
48103 32.0147 ...
| Aug 5, 6:25 pm 2008 |
| Ralf Baechle | [PATCH] AX.25: Fix sysctl registration if !CONFIG_AX25_DAMA_...
Since 49ffcf8f99e8d33ec8afb450956804af518fd788
setting struct ctl_table.procname = NULL does no longer work as it used to
the way the AX.25 code is expecting it to resulting in the AX.25 sysctl
registration code to break if CONFIG_AX25_DAMA_SLAVE was not set as in some
distribution kernels. Kernel releases from 2.6.24 are affected.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/net/ax25/sysctl_net_ax25.c b/net/ax25/sysctl_net_ax25.c
index f597987..f288fc4 100644
--- a/net/...
| Aug 5, 6:37 pm 2008 |
| Denys Fedoryshchenko | few more fixes for iproute2/m_ipt
Comments:
1)optind according iptables sources have to be set to 0. If it is set to 1, in
batch it will mess up things. Also in iptables sources i notice that ->tflags
and ->used need to be reset.
2)Since target->t = fw_calloc(1, size); allocated memory in function build_st,
it have to be freed at the end, or in batch we will have memory leak. TODO:
Probably it must be freed in all "return -1" cases in parse_ipt after
build_st. About this i am not sure, up to Stephen.
3)lname and ne...
| Aug 5, 5:42 pm 2008 |
| Alexander Beregalov | [PATCH] netxen_nic_hw.c: fix warnings
From: Alexander Beregalov <a.beregalov@gmail.com>
netxen_nic_hw.c: fix warnings
drivers/net/netxen/netxen_nic_hw.c:1414: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
drivers/net/netxen/netxen_nic_hw.c:1487: warning: format '%llx' expects type 'long long unsigned int', but argument 3 has type 'u64'
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
drivers/net/netxen/netxen_nic_hw.c | 6 ++++--
1 files changed, 4 inse...
| Aug 5, 4:05 pm 2008 |
| Simon Arlott | forcedeth 10de:0373 doesn't work on resume
My NIC stops working after resuming from standby, it's not receiving any interrupts:
[ 0.618266] pci 0000:00:08.0: supports D1
[ 0.618267] pci 0000:00:08.0: supports D2
[ 0.618269] pci 0000:00:08.0: PME# supported from D0 D1 D2 D3hot D3cold
[ 0.618382] pci 0000:00:08.0: PME# disabled
[ 0.618513] pci 0000:00:09.0: supports D1
[ 0.618523] pci 0000:00:09.0: supports D2
[ 0.618532] pci 0000:00:09.0: PME# supported from D0 D1 D2 D3hot D3cold
[ 0.618632] pci 0000:00:09.0: PME# disa...
| Aug 5, 3:29 pm 2008 |
| Denys Fedoryshchenko | iproute2/m_ipt fix, opts was not set properly
Since opts global variable, if it is set to original_opts, it was done in
local context of function, and global variable in result was pointing to
freed memory. Sure result of that - segfault, it is possible to trigger it
only while processing batch, cause only on next iteration opts was wrong.
There is two ways to fix that, both patches attached.
Please send me note, which way correct (at least i will learn something :-) )
| Aug 5, 3:24 pm 2008 |
| Nicolas Bareil | [BUG] before() integer overflow
Hello!
In include/net/tcp.h, the before() function is defined like this :
241 /*
242 * The next routines deal with comparing 32 bit unsigned ints
243 * and worry about wraparound (automatic with unsigned arithmetic).
244 */
245
246 static inline int before(__u32 seq1, __u32 seq2)
247 {
248 return (__s32)(seq1-seq2) < 0;
249 }
250 #define after(seq2, seq1) before(seq1, seq2)
If seq1 = 0xffffff and seq2 = 0 (so seq1 > seq2), the difference is
equal to 0xf...
| Aug 5, 1:19 pm 2008 |
| David Stevens | Re: [BUG] before() integer overflow
In the sequence space, 0xffffffff is before 0 (by 1), so
before() should return true. In your example, you don't have enough
f's for it to be -1 as a signed number, so I'm assuming you mean
8 of them there. If you mean 6 f's, then the result is not -1, but the
positive number 0xffffff, which returns false.
+-DLS
--
| Aug 5, 1:51 pm 2008 |
| Nicolas Bareil | Re: [BUG] before() integer overflow
Yes I meant 8 f (I should change my too small fonts ;) )
Thanks to Ben for his explanation, I thought the PAWS was handled in a
specific way. Sorry!
--
Nicolas Bareil http://chdir.org/~nico/
OpenPGP=0xAE4F7057 Fingerprint=34DB22091049FB2F33E6B71580F314DAAE4F7057
--
| Aug 5, 2:24 pm 2008 |
| Ben Hutchings | Re: [BUG] before() integer overflow
[...]
That's exactly what we want. The initial sequence number is random (and
TCP streams are not limited to 4GB) so the sequence can wrap around. 0
follows 0xffffffff. If we were to compare sequence numbers from two
packets more than 2GB apart in the stream, this comparison would give
the wrong answer, but currently this is not likely to be a problem.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's...
| Aug 5, 1:40 pm 2008 |
| Subbu Seetharaman | [RESEND][PATCH] benet: BladeEngine 10Gb NIC driver
Jeff,
The benet driver patch with this Kconfig change is available as one file under under :
ftp://ftp.serverengines.com/0001.benet.patch
Thanks.
Subbu
----- Original Message -----
From: Jeff Garzik [mailto:jeff@garzik.org]
To: subbu [mailto:subbus@serverengines.com]
Cc: 'Randy Dunlap' [mailto:randy.dunlap@oracle.com], 'Bill Fink' [mailto:billfink@mindspring.com], netdev@vger.kernel.org
Sent: Mon, 07 Jul 2008 06:57:48 -0700
Subject: Re: [PATCH 8/8] benet: Kconfig, Makefile, MAINTAINERS
...
| Aug 5, 12:22 pm 2008 |
| Alessandro Guido | "e100_probe: Error clearing wake event" when booting 2.6.27-...
[please cc me on replies]
I'm getting this error message when booting my laptop.
The commit that causes this is:
commit eb9d0fe40e313c0a74115ef456a2e43a6c8da72f
Author: Rafael J. Wysocki <rjw@sisk.pl>
Date: Mon Jul 7 03:34:48 2008 +0200
PCI ACPI: Rework PCI handling of wake-up
[very long commit message snipped]
Should I ignore that?
--
| Aug 5, 11:30 am 2008 |
| Rafael J. Wysocki | Re: "e100_probe: Error clearing wake event" when booting 2.6...
The message is harmless, but it exposes the problem that e100_probe() should
not use pci_enable_wake() for this purpose.
The appended patch makes it use pci_pme_active() instead.
Thanks,
Rafael
---
PCI PM: Export pci_pme_active to drivers
Export pci_pme_active() to drivers, so that they can clear the
PME_status bit and disable PME# for the device without involving
ACPI.
Modify the e100 driver to use pci_pme_active() for this purpose.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl&...
| Aug 5, 4:03 pm 2008 |
| Chuck Lever | [RFC] [PATCH 0/2] Set V6ONLY sockopt for kernel RPC services
It has been suggested that I should unconditionally pre-empt the creation
of user space IPv4 listeners on the same port when the kernel sets up an
IPv6 listener for RPC services. This series of patches should implement
that.
I'm interested in comments and review -- it's a pretty simple set of
changes that go on top of 2.6.27-rc1.
---
Chuck Lever (2):
SUNRPC: Set V6ONLY socket option for RPC listener sockets
SUNRPC: Add address family field to svc_serv data structure
fs/lock...
| Aug 5, 11:24 am 2008 |
| Chuck Lever | [PATCH 1/2] SUNRPC: Add address family field to svc_serv dat...
Introduce and initialize an address family field in the svc_serv structure.
This field will determine what family to use for the service's listener
sockets and what families are advertised via the local rpcbind daemon.
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/lockd/svc.c | 2 +-
fs/nfs/callback.c | 3 ++-
fs/nfsd/nfssvc.c | 3 ++-
include/linux/sunrpc/svc.h | 9 +++++----
net/sunrpc/svc.c | 11 ++++++-----
5 file...
| Aug 5, 11:24 am 2008 |
| Jaswinder Singh | BUG: fealnx in 2.6.27-rc1
eth0: no IPv6 routers present
NETDEV WATCHDOG: eth0 (fealnx): transmit timed out
eth0: Transmit timed out, status 00000000, resetting...
Rx ring f7b56000: 80000000 80000000 80000000 80000000 80000000
80000000 80000000 80000000 80000000 80000000 80000000 80000000
Tx ring f7b57000: 0000 80000000 80000000 80000000 80000000 80000000
------------[ cut here ]------------
WARNING: at net/sched/sch_generic.c:221 dev_watchdog+0x109/0x181()
Modules linked in:
Pid: 4, comm: ksoftirqd/0 Not tainted 2.6.2...
| Aug 5, 10:46 am 2008 |
| Ming Lei | BUG:tg3_open() bug
Hi,
kernel : 2.6.27-rc1-00526-g5ede58d
The following message is produced by running "ifconfig eth0 up".
Thanks,
ADDRCONF(NETDEV_UP): eth0: link is not ready
tg3: eth0: Link is up at 100 Mbps, full duplex.
tg3: eth0: Flow control is on for TX and on for RX.
ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
BUG: scheduling while atomic: ifconfig/3345/0x00000102
2 locks held by ifconfig/3345:
#0: (rtnl_mutex){....}, at: [<ffffffff803c0086>] rtnl_lock+0x17/0x19
#1: (&tp->lock)...
| Aug 5, 10:32 am 2008 |
| Michael Chan | Re: BUG:tg3_open() bug
The patch to fix this has been applied to the net-2.6 tree last night:
tg3: Fix 'scheduling while atomic' errors
--
| Aug 5, 9:47 am 2008 |
| Robert Olsson | [PATCH] pktgen multiqueue etc
Sofar far pktgen have had a restriction to only use one device per kernel
thread. With the new multiqueue architecture this is no longer adequate.
The patch below is an effort to remove this by in pktgen configuration
adding a tag to the device name a la eth0@0 etc. The tag is used for
usual device config just as before. Also a new flag is introduced to mirror
queue_map with sending threads smp_processor_id() QUEUE_MAP_CPU.
An example: We use 4 CPU's to send to one 10g interface (eth0)
...
| Aug 5, 10:28 am 2008 |
| Rami Rosen | [PATCH net-2.6 2/2] ipv6: replace dst_metric() with dst_mtu(...
Hi,
This patch replaces dst_metric() with dst_mtu() in net/ipv6/route.c.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
| Aug 5, 9:01 am 2008 |
| Rami Rosen | [PATCH net-2.6 1/2] ipv4: replace dst_metric() with dst_mtu(...
Hi,
This patch replaces dst_metric() with dst_mtu() in net/ipv4/route.c.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
| Aug 5, 9:00 am 2008 |
| Rami Rosen | [PATCH net-2.6 0/2] replace dst_metric() with dst_mtu().
Hi,
This patchset replaces dst_metric() with dst_mtu() in net/ipv4/route.c
and in net/ipv6/route.c.
Regards,
Rami Rosen
--
| Aug 5, 8:59 am 2008 |
| Jarek Poplawski | Re: RES: RES: [Bugme-new] [Bug 11249] New: TC HTB hanging pr...
Not at all... at least until we know if it works!
Jarek P.
--
| Aug 5, 8:29 am 2008 |
| Leandro Oliveira da ... | RES: RES: RES: [Bugme-new] [Bug 11249] New: TC HTB hanging p...
Hi Jarek!
Good news. I downloaded the 2.6.26 version to one of my clients, compiled,
and before the reboot to put this one as active I ran my script and the
server hanged. When they restarted the server the kernel 2.6.26 entered and
I ran the script several times without problem. I guess in my case it was
one of the two bugs, but I'm putting this kernel in other 3 servers and
let's see if they work fine now. I'll send a email on Friday with the
status.
Thanks a lot,
Leandro
-----Mensagem ori...
| Aug 5, 3:46 pm 2008 |
| Neil Horman | [PATCH] catch up device stats when multicast > total frames
Hey-
REcently observed a problem wherein, if a BMC or other IPMI device is
attached to a NIC, multicast frames can be consumed by the aformentioned device
without ever being seen by the driver. Since multicast frames are counted in
the hardware and the total frame counter is counted in the driver napi routine,
its possible to have a condition in which the number of received multicast
frames exceeds the total number of frames. This patch re-aligns those values on
receive, so that the total frame co...
| Aug 5, 7:50 am 2008 |
| Ben Hutchings | Re: [PATCH] catch up device stats when multicast > total ...
I'd be surprised if the hardware does not also maintain a total frame
counter. If not, you can possibly calculate the total as good + bad
packets, or unicast + multicast + broadcast + bad, or something like that.
[...]
This is a botch - it means the numbers can't be so obviously wrong, but
doesn't make them correct.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that S...
| Aug 5, 8:15 am 2008 |
| Neil Horman | Re: [PATCH] catch up device stats when multicast > total ...
It does, however, for whatever reason the drriver relies on a software
computed total packets counter rather than the hardware based on (possibly for
the same reason, in that it counts frames the driver never actually sees). I
asked John R. in the origional bug report why e1000 might do this, and while
I agree, but as it stands currently the numbers are obviously wrong, and I don't
see a way to make them undenyably correct. We could use the hardware counter
instead, but then we would be counting ...
| Aug 5, 9:16 am 2008 |
| Ronciak, John | RE: [PATCH] catch up device stats when multicast > total ...
The total packet count in the driver was done so that the count is always right even in between stats updates. Believe it or not there are some people that think this is an important thing for some reason. We don't understand that but agreed to do this to correct what they were seeing with the stats being updated every 2 seconds.
The problem that seems to be happening here is that the BMC is consuming frames that the driver never sees. This I think is what is messing up the counts. The problem we hav...
| Aug 5, 12:52 pm 2008 |
| Neil Horman | Re: [PATCH] catch up device stats when multicast > total ...
Yuk. I can't imagine why anyone would want that, but if thats what were stuck
We went back and forth on this point several times in the bugzilla, please re-read
(specifically see comment #93). I have no problem
with e1000 recording total frame recieved count from hardware directly. In fact
it seems to make much more sense to me to do just that. However, e1000 doesn't
do that currently, opting instead to use this software counter. Why that is I
don't know, but I was hoping that one of you might....
| Aug 5, 2:03 pm 2008 |
| Brandeburg, Jesse | RE: [E1000-devel] [PATCH] catch up device stats when multica...
We changed the driver to do real time updates based on user feedback
that updating the stats every two seconds was not fast enough. It was
There are counters at the end of the ethtool -S output called
tx_smbus: 0
rx_smbus: 0
dropped_smbus: 0
that are indicating when the SMBUS is active. (SMBUS is used to tx / rx
There doesn't seem to be much of a middle ground, you either count in
I guess this comes down to a question of "how big a problem is this" as
we can really do it either ...
| Aug 5, 12:43 pm 2008 |
| Neil Horman | Re: [E1000-devel] [PATCH] catch up device stats when multica...
I didn't see those, I'll need to look again. Still though, knowing this still
leaves us with the possibility that multicast packets > total_rx_packets (where
I can't really answer how big a problem this is. What I can tell you is that it
was reported to me origionally as a net-snmp issue. net-snmp was getting some
very odd counter values because it was computing unicast rx frames from a given
interface as unicast = total - multicast, as read from /proc/net/dev. The
assumption here being that tot...
| Aug 5, 12:53 pm 2008 |
| Ingo Oeser | Re: [E1000-devel] [PATCH] catch up device stats when multica...
Hi all,
There maybe:
1. store software counters counted in software in stat_soft_last
2. store software counters counted in hardware in stat_hard_last
3. diff them after getting the fresh counters from hardware and software
4. wait for any "get statistic" request as done with hardware counters today
5. store the combination, taking "unseen packets" into account,
as the real netstat
6. goto 1.
What do you think?
Best Regards
Ingo Oeser
--
| Aug 5, 1:12 pm 2008 |
| Robert Olsson | [PATCH] pktgen random flow
Hello,
Random flow generation has not worked. This fixes it.
Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Cheers.
--ro
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 3284605..755d08f 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2085,15 +2085,19 @@ static inline int f_pick(struct pktgen_dev *pkt_dev)
if (pkt_dev->flows[flow].count >= pkt_dev->lflow) {
/* reset time */
pkt_dev->flows[flow].count = 0;
+ pkt_dev->...
| Aug 5, 7:20 am 2008 |
| Robert Olsson | [PATCH] pktgen mac count
One more...
dst_mac_count and src_mac_count patch from Eneas Hunguana
We have sent one mac address to much.
Signed-off-by: Robert Olsson <robert.olsson@its.uu.se>
Cheers.
--ro
--- a/net/core/pktgen.c 2008-06-09 20:27:19.000000000 +0200
+++ b/net/core/pktgen.c 2008-07-06 03:06:00.000000000 +0200
@@ -2143,7 +2143,7 @@
mc = random32() % pkt_dev->src_mac_count;
else {
mc = pkt_dev->cur_src_mac_offset++;
- if (pkt_dev->cur_src_mac_offset >
+ if (...
| Aug 5, 7:27 am 2008 |
| Subrata Modak | Re: [LTP] [PATCH 0/0] Traffic control cgroups subsystem
Ranjit,
Would you like to tell us something on the test cases for this ?
Regards--
--
| Aug 5, 7:00 am 2008 |
| Ranjit Manomohan | Re: [LTP] [PATCH 0/0] Traffic control cgroups subsystem
On Tue, Aug 5, 2008 at 4:00 AM, Subrata Modak
Subrata,
We have some internal test cases but not under LTP. Let me take a
look at the existing LTP infrastructure and see if these can be ported
over.
-Thanks,
--
| Aug 5, 2:06 pm 2008 |
| Joakim Koskela | [PATCH 2/2] (revised) Interfamily IPSec BEET
Here's a revised version, based on Herbert's comments, of a fix for
the ipv4-inner, ipv6-outer interfamily ipsec beet mode. It fixes the
network header adjustment during interfamily, as well as makes sure
that we reserve enough room for the new ipv6 header if we might have
something else as the inner family. Also, the ipv4 pseudo header
construction was added.
Signed-off-by: Joakim Koskela <jookos@gmail.com>
---
net/ipv6/esp6.c | 4 ++++
net/ipv6/xfrm6_mode_beet.c | 27 ...
| Aug 5, 5:35 am 2008 |
| Herbert Xu | Re: [PATCH 2/2] (revised) Interfamily IPSec BEET
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
A future improvement would be to divide the output processing
for BEET based on the inner/outer family. Then the option code
would only be needed on the IPv4 side.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Aug 5, 6:54 am 2008 |
| Joakim Koskela | [PATCH 1/2] (revised) Interfamily IPSec BEET
Here's a revised version, based on Herbert's comments, of a fix for
the ipv6-inner, ipv4-outer interfamily ipsec beet mode. It fixes the
network header adjustment in interfamily, and doesn't reserve space
for the pseudo header anymore when we have ipv6 as the inner family.
Signed-off-by: Joakim Koskela <jookos@gmail.com>
---
net/ipv4/esp4.c | 2 +-
net/ipv4/xfrm4_mode_beet.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/esp4.c b/n...
| Aug 5, 5:35 am 2008 |
| Herbert Xu | Re: [PATCH 1/2] (revised) Interfamily IPSec BEET
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
| Aug 5, 6:51 am 2008 |
| Gui Jianfeng | [PATCH 3/3] Prevent from passing NULL pointer to tcp_v6_md5_...
If skb->sk == NULL when calling tcp_v6_md5_do_lookup(), kernel
will panic. Don't let this thing happen.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
net/ipv6/tcp_ipv6.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/ipv6/tcp_ipv6.c b/net/ipv6/tcp_ipv6.c
index 78185a4..5b90b36 100644
--- a/net/ipv6/tcp_ipv6.c
+++ b/net/ipv6/tcp_ipv6.c
@@ -69,7 +69,8 @@
#include <linux/scatterlist.h>
static void tcp_v6_send_reset(struct s...
| Aug 5, 5:24 am 2008 |
| Gui Jianfeng | [PATCH 2/3] Prevent from passing NULL pointer to tcp_v4_md5_...
If skb->sk == NULL when calling tcp_v4_md5_do_lookup(), kernel
will panic. Don't let this thing happen.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
net/ipv4/tcp_ipv4.c | 4 ++--
net/ipv4/tcp_minisocks.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 91a8cfd..44c1e93 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -687,14 +687,14 @@ static void tcp_v4_timewait_ack(struct s...
| Aug 5, 5:23 am 2008 |
| Gui Jianfeng | [PATCH 1/3] Add (struct sock*) sk parameter for send_ack()
Add (struct sock*) sk parameter for send_ack.
Signed-off-by: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
---
include/net/request_sock.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/net/request_sock.h b/include/net/request_sock.h
index 8d6e991..cac811e 100644
--- a/include/net/request_sock.h
+++ b/include/net/request_sock.h
@@ -33,7 +33,7 @@ struct request_sock_ops {
struct kmem_cache *slab;
int (*rtx_syn_ack)(struct sock *sk,
struct r...
| Aug 5, 5:22 am 2008 |
| Gui Jianfeng | [PATCH 0/3] Fix kernel panic when calling tcp_(v4/v6)_md5_do...
If the following packet flow happen, kernel will panic.
MathineA MathineB
SYN
---------------------->
SYN+ACK
<----------------------
ACK(bad seq)
---------------------->
When a bad seq ACK is received, tcp_v4_md5_do_lookup(skb->sk, ip_hdr(skb)->daddr))
is finally called by tcp_v4_reqsk_send_ack(), but the first parameter(skb->sk) is
NULL at that moment, so kernel panic happens.
This patch set fix this issue.
Below is the OOPS output:
[ 302.812793] ...
| Aug 5, 5:22 am 2008 |
| Rami Rosen | [PATCH net-2.6] ipv4: remove unused field in struct flowi (i...
Hi,
This patch removes an unused field (flags) from struct flowi;
it seems that this "flags" field was used once in the past for
multipath routing with
FLOWI_FLAG_MULTIPATHOLDROUTE flag (which does no longer exist);
however, the "flags"
field of struct flowi is not used anymore.
Regards,
Rami Rosen
Signed-off-by: Rami Rosen <ramirose@gmail.com>
| Aug 5, 4:14 am 2008 |
| David Miller | Re: [PATCH net-2.6] ipv4: remove unused field in struct flow...
From: "Rami Rosen" <ramirose@gmail.com>
Applied, thanks a lot Rami.
--
| Aug 5, 4:20 am 2008 |
| Daniel Lezcano | Re: SYSFS support together with NET_NS status?
Definitely agree :)
I think the patches should be first in the Greg-KH tree.
Eric asked Greg-KH about this patchset 2 days ago, perhaps I missed it
but I didn't see any answer yet.
-- Daniel
--
| Aug 5, 4:01 am 2008 |
| Denys Fedoryshchenko | thousands of classes, e1000 TX unit hang
I did script, that looks something like this (to simulate SFQ by flow
classifier):
$2 (is ppp interface)
echo "qdisc del dev $2 root ">>${TEMP}
echo "qdisc add dev $2 root handle 1: htb ">>${TEMP}
echo "filter add dev $2 protocol ip pref 16 parent 1: u32 \
match ip dst 0.0.0.0/0 police rate 8kbit burst 2048kb \
peakrate 1024Kbit mtu 10000 \
conform-exceed continue/ok">>${TEMP}
echo "filter add dev $2 protocol ip pref 32 parent 1: handle 1 \
flow hash keys nfct divisor 1...
| Aug 5, 3:47 am 2008 |
| Denys Fedoryshchenko | Re: thousands of classes, e1000 TX unit hang
A little bit more info:
On oprofile i run on another machine (which doesn't suffer much, but i can
notice also drops on eth0 after adding around 100 interfaces). On first
machine clocksources is TSC, on machine where i read stats acpi_pm.
CPU: P4 / Xeon with 2 hyper-threads, speed 3200.53 MHz (estimated)
Counted GLOBAL_POWER_EVENTS events (time during which processor is not
stopped) with a unit mask of 0x01 (mandatory) count 100000
GLOBAL_POWER_E...|
samples| %|
------------------
...
| Aug 5, 4:06 am 2008 |
| Denys Fedoryshchenko | Re: thousands of classes, e1000 TX unit hang
I found, that packetloss happening when i am deleting/adding classes.
I attach result of oprofile as file.
| Aug 5, 6:05 am 2008 |
| previous day | today | next day |
|---|---|---|
| August 4, 2008 | August 5, 2008 | August 6, 2008 |
| Bart Van Assche | Integration of SCST in the mainstream Linux kernel |
| Kamalesh Babulal | [BUG] Linux 2.6.25-rc2 - Kernel Ooops while running dbench |
| Greg Kroah-Hartman | [PATCH 005/196] Chinese: add translation of SubmittingDrivers |
| Paul Jackson | Re: cpuset-remove-sched-domain-hooks-from-cpusets |
git: | |
| Gerrit Renker | [PATCH 0/37] dccp: Feature negotiation - last call for comments |
| Jarek Poplawski | [PATCH] pkt_sched: Destroy gen estimators under rtnl_lock(). |
| Steven Rostedt | Re: -rt scheduling: wakeup bug? |
| David Miller | Re: [GIT]: Networking |
