few more fixes for iproute2/m_ipt

!MAILaRCHIVE_VOTE_RePLACE
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
To: Stephen Hemminger <shemminger@...>
Cc: <netdev@...>
Date: Tuesday, August 5, 2008 - 5:42 pm

Comments:
1)optind according iptables sources have to be set to 0. If it is set to 1, in 
batch it will mess up things. Also in iptables sources i notice that ->tflags 
and ->used need to be reset.

2)Since target->t = fw_calloc(1, size); allocated memory in function build_st, 
it have to be freed at the end, or in batch we will have memory leak. TODO: 
Probably it must be freed in all "return -1" cases in parse_ipt after 
build_st. About this i am not sure, up to Stephen.

3)lname and new_name was malloc'ed, but not freed

Point 1 fix is critical, since without it m_ipt crashing iproute2 in batch 
mode.
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Tue Aug 5, 5:42 pm)
Re: few more fixes for iproute2/m_ipt, Stephen Hemminger, (Tue Jan 6, 11:43 pm)
Re: few more fixes for iproute2/m_ipt, jamal, (Wed Aug 6, 6:04 am)
Re: few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Wed Aug 6, 6:21 am)
Re: few more fixes for iproute2/m_ipt, jamal, (Wed Aug 6, 7:04 am)
Re: few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Wed Aug 6, 7:26 am)
Re: few more fixes for iproute2/m_ipt, jamal, (Wed Aug 6, 8:46 am)
Re: few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Wed Aug 6, 8:50 am)
Re: few more fixes for iproute2/m_ipt, jamal, (Wed Aug 6, 8:55 am)
Re: few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Wed Aug 6, 8:59 am)
Re: few more fixes for iproute2/m_ipt, jamal, (Wed Aug 6, 9:17 am)
Re: few more fixes for iproute2/m_ipt, Denys Fedoryshchenko, (Wed Aug 6, 8:56 am)